16395825001

Committed 19 Jul 2025 11:30PM UTC coverage: 90.635% (-0.07%) from 90.708%

Build # 16395825001

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #4998 from randombit/jack/fix-clang-tidy-readability-isolate-declaration

Enable and fix clang-tidy warning readability-isolate-declaration

Run Details

99940 of 110266 relevant lines covered (90.64%)

12341110.13 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.38

/src/lib/filters/hex_filt.cpp

/*
* Hex Encoder/Decoder
* (C) 1999-2007 Jack Lloyd
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include <botan/filters.h>

#include <botan/exceptn.h>
#include <botan/hex.h>
#include <botan/mem_ops.h>
#include <algorithm>

namespace Botan {

/**
* Size used for internal buffer in hex encoder/decoder
*/
const size_t HEX_CODEC_BUFFER_SIZE = 256;

/*
* Hex_Encoder Constructor
*/
Hex_Encoder::Hex_Encoder(bool breaks, size_t length, Case c) : m_casing(c), m_line_length(breaks ? length : 0) {
   m_in.resize(HEX_CODEC_BUFFER_SIZE);
   m_out.resize(2 * m_in.size());
}

/*
* Hex_Encoder Constructor
*/
Hex_Encoder::Hex_Encoder(Case c) : m_casing(c), m_line_length(0) {
   m_in.resize(HEX_CODEC_BUFFER_SIZE);
   m_out.resize(2 * m_in.size());
}

/*
* Encode and send a block
*/
void Hex_Encoder::encode_and_send(const uint8_t block[], size_t length) {
   hex_encode(cast_uint8_ptr_to_char(m_out.data()), block, length, m_casing == Uppercase);

   if(m_line_length == 0) {
      send(m_out, 2 * length);
   } else {
      size_t remaining = 2 * length;
      size_t offset = 0;
      while(remaining > 0) {
         size_t sent = std::min(m_line_length - m_counter, remaining);
         send(&m_out[offset], sent);
         m_counter += sent;
         remaining -= sent;
         offset += sent;
         if(m_counter == m_line_length) {
            send('\n');
            m_counter = 0;
         }
      }
   }
}

/*
* Convert some data into hex format
*/
void Hex_Encoder::write(const uint8_t input[], size_t length) {
   const size_t initial_fill = std::min(m_in.size() - m_position, length);
   copy_mem(&m_in[m_position], input, initial_fill);

   if(m_position + length >= m_in.size()) {
      encode_and_send(m_in.data(), m_in.size());
      input += (m_in.size() - m_position);
      length -= (m_in.size() - m_position);
      while(length >= m_in.size()) {
         encode_and_send(input, m_in.size());
         input += m_in.size();
         length -= m_in.size();
      }
      copy_mem(m_in.data(), input, length);
      m_position = 0;
   }
   m_position += length;
}

/*
* Flush buffers
*/
void Hex_Encoder::end_msg() {
   encode_and_send(m_in.data(), m_position);
   if(m_counter > 0 && m_line_length > 0) {
      send('\n');
   }
   m_counter = m_position = 0;
}

/*
* Hex_Decoder Constructor
*/
Hex_Decoder::Hex_Decoder(Decoder_Checking c) : m_checking(c) {
   m_in.resize(HEX_CODEC_BUFFER_SIZE);
   m_out.resize(m_in.size() / 2);
}

/*
* Convert some data from hex format
*/
void Hex_Decoder::write(const uint8_t input[], size_t length) {
   while(length > 0) {
      size_t to_copy = std::min<size_t>(length, m_in.size() - m_position);
      copy_mem(&m_in[m_position], input, to_copy);
      m_position += to_copy;

      size_t consumed = 0;
      size_t written =
         hex_decode(m_out.data(), cast_uint8_ptr_to_char(m_in.data()), m_position, consumed, m_checking != FULL_CHECK);

      send(m_out, written);

      if(consumed != m_position) {
         copy_mem(m_in.data(), m_in.data() + consumed, m_position - consumed);
         m_position = m_position - consumed;
      } else {
         m_position = 0;
      }

      length -= to_copy;
      input += to_copy;
   }
}

/*
* Flush buffers
*/
void Hex_Decoder::end_msg() {
   size_t consumed = 0;
   size_t written =
      hex_decode(m_out.data(), cast_uint8_ptr_to_char(m_in.data()), m_position, consumed, m_checking != FULL_CHECK);

   send(m_out, written);

   const bool not_full_bytes = consumed != m_position;

   m_position = 0;

   if(not_full_bytes) {
      throw Invalid_Argument("Hex_Decoder: Input not full bytes");
   }
}

}  // namespace Botan

1	/*
2	* Hex Encoder/Decoder
3	* (C) 1999-2007 Jack Lloyd
4	*
5	* Botan is released under the Simplified BSD License (see license.txt)
6	*/
7
8	#include <botan/filters.h>
9
10	#include <botan/exceptn.h>
11	#include <botan/hex.h>
12	#include <botan/mem_ops.h>
13	#include <algorithm>
14
15	namespace Botan {
16
17	/**
18	* Size used for internal buffer in hex encoder/decoder
19	*/
20	const size_t HEX_CODEC_BUFFER_SIZE = 256;
21
22	/*
23	* Hex_Encoder Constructor
24	*/
25	Hex_Encoder::Hex_Encoder(bool breaks, size_t length, Case c) : m_casing(c), m_line_length(breaks ? length : 0) {	18✔
26	m_in.resize(HEX_CODEC_BUFFER_SIZE);	10✔
27	m_out.resize(2 * m_in.size());	10✔
28	}	10✔
29
30	/*
31	* Hex_Encoder Constructor
32	*/
33	Hex_Encoder::Hex_Encoder(Case c) : m_casing(c), m_line_length(0) {	×
34	m_in.resize(HEX_CODEC_BUFFER_SIZE);	×
35	m_out.resize(2 * m_in.size());	×
36	}	×
37
38	/*
39	* Encode and send a block
40	*/
41	void Hex_Encoder::encode_and_send(const uint8_t block[], size_t length) {	37✔
42	hex_encode(cast_uint8_ptr_to_char(m_out.data()), block, length, m_casing == Uppercase);	37✔
43
44	if(m_line_length == 0) {	37✔
45	send(m_out, 2 * length);	35✔
46	} else {
47	size_t remaining = 2 * length;	2✔
48	size_t offset = 0;	2✔
49	while(remaining > 0) {	9✔
50	size_t sent = std::min(m_line_length - m_counter, remaining);	7✔
51	send(&m_out[offset], sent);	7✔
52	m_counter += sent;	7✔
53	remaining -= sent;	7✔
54	offset += sent;	7✔
55	if(m_counter == m_line_length) {	7✔
56	send('\n');	6✔
57	m_counter = 0;	6✔
58	}
59	}
60	}
61	}	37✔
62
63	/*
64	* Convert some data into hex format
65	*/
66	void Hex_Encoder::write(const uint8_t input[], size_t length) {	37✔
67	const size_t initial_fill = std::min(m_in.size() - m_position, length);	37✔
68	copy_mem(&m_in[m_position], input, initial_fill);	37✔
69
70	if(m_position + length >= m_in.size()) {	37✔
71	encode_and_send(m_in.data(), m_in.size());	×
72	input += (m_in.size() - m_position);	×
73	length -= (m_in.size() - m_position);	×
74	while(length >= m_in.size()) {	×
75	encode_and_send(input, m_in.size());	×
76	input += m_in.size();	×
77	length -= m_in.size();	×
78	}
79	copy_mem(m_in.data(), input, length);	×
80	m_position = 0;	×
81	}
82	m_position += length;	37✔
83	}	37✔
84
85	/*
86	* Flush buffers
87	*/
88	void Hex_Encoder::end_msg() {	37✔
89	encode_and_send(m_in.data(), m_position);	37✔
90	if(m_counter > 0 && m_line_length > 0) {	37✔
91	send('\n');	1✔
92	}
93	m_counter = m_position = 0;	37✔
94	}	37✔
95
96	/*
97	* Hex_Decoder Constructor
98	*/
99	Hex_Decoder::Hex_Decoder(Decoder_Checking c) : m_checking(c) {	7✔
100	m_in.resize(HEX_CODEC_BUFFER_SIZE);
101	m_out.resize(m_in.size() / 2);	7✔
102	}	7✔
103
104	/*
105	* Convert some data from hex format
106	*/
107	void Hex_Decoder::write(const uint8_t input[], size_t length) {	23✔
108	while(length > 0) {	46✔
109	size_t to_copy = std::min<size_t>(length, m_in.size() - m_position);	23✔
110	copy_mem(&m_in[m_position], input, to_copy);	23✔
111	m_position += to_copy;	23✔
112
113	size_t consumed = 0;	23✔
114	size_t written =	23✔
115	hex_decode(m_out.data(), cast_uint8_ptr_to_char(m_in.data()), m_position, consumed, m_checking != FULL_CHECK);	23✔
116
117	send(m_out, written);	23✔
118
119	if(consumed != m_position) {	23✔
120	copy_mem(m_in.data(), m_in.data() + consumed, m_position - consumed);	×
121	m_position = m_position - consumed;	×
122	} else {
123	m_position = 0;	23✔
124	}
125
126	length -= to_copy;	23✔
127	input += to_copy;	23✔
128	}
129	}	23✔
130
131	/*
132	* Flush buffers
133	*/
134	void Hex_Decoder::end_msg() {	23✔
135	size_t consumed = 0;	23✔
136	size_t written =	23✔
137	hex_decode(m_out.data(), cast_uint8_ptr_to_char(m_in.data()), m_position, consumed, m_checking != FULL_CHECK);	23✔
138
139	send(m_out, written);	23✔
140
141	const bool not_full_bytes = consumed != m_position;	23✔
142
143	m_position = 0;	23✔
144
145	if(not_full_bytes) {	23✔
146	throw Invalid_Argument("Hex_Decoder: Input not full bytes");	×
147	}
148	}	23✔
149
150	} // namespace Botan

randombit / botan / 16395825001

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous