7a49a98cbd16987b328dd1c28937c031e489ec8c

Committed 18 Jul 2025 12:56AM UTC coverage: 59.469% (+0.2%) from 59.248%

Build # 7a49a98cbd16987b328dd1c28937c031e489ec8c

Build Type

Pull #52

github

Committed by

camatcode

Commit Message

perf: Image Previews are now relationships

Pull Request Pull Request #52: perf: Image Previews are now relationships

Run Details

16 of 17 new or added lines in 4 files covered. (94.12%)

1 existing line in 1 file now uncovered.

986 of 1658 relevant lines covered (59.47%)

362.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

82.61

/lib/basenji_web/controllers/api/comics_controller.ex

defmodule BasenjiWeb.ComicsController do
  @moduledoc false
  use BasenjiWeb, :controller

  alias Basenji.Comics
  alias Basenji.ImageProcessor
  alias BasenjiWeb.API.Utils
  alias BasenjiWeb.PredictiveCache

  def get_page(conn, params) do
    id = params["id"]
    page = params["page"]

    with {:ok, page_num} <- Utils.safe_to_int(page),
         {:ok, comic} <- Comics.get_comic(id) do
      PredictiveCache.get_comic_page_from_cache(comic, page_num)
    end
    |> case do
      {:ok, binary, mime} ->
        length = byte_size(binary)

        conn
        |> merge_resp_headers([{"access-control-allow-origin", "*"}])
        |> merge_resp_headers([{"content-type", mime}])
        |> merge_resp_headers([{"content-length", "#{length}"}])
        |> send_resp(200, binary)

      error ->
        Utils.bad_request_handler(conn, error)
    end
  end

  def get_preview(conn, params) do
    id = params["id"]

    get_comic_preview(id)
    |> case do
      {:ok, binary} ->
        length = byte_size(binary)

        conn
        |> merge_resp_headers([{"access-control-allow-origin", "*"}])
        |> merge_resp_headers([{"content-type", "image/jpeg"}])
        |> merge_resp_headers([{"content-length", "#{length}"}])
        |> send_resp(200, binary)

      error ->
        Utils.bad_request_handler(conn, error)
    end
  end

  defp get_comic_preview(id) do
    with {:ok, comic} <- Comics.get_comic(id) do
      Comics.get_image_preview(comic)
      |> case do
        {:ok, bytes} -> {:ok, bytes}
        _ -> make_preview(comic)
      end
    end
  end

  defp make_preview(comic) do
    {:ok, bytes, _mime} = PredictiveCache.get_comic_page_from_cache(comic, 1)
    {:ok, preview_bytes} = ImageProcessor.get_image_preview(bytes, 600, 600)
    Comics.associate_image_preview(comic, preview_bytes, width: 600, height: 600)
    {:ok, preview_bytes}
  end
end

1	defmodule BasenjiWeb.ComicsController do
2	@moduledoc false
3	use BasenjiWeb, :controller
4
5	alias Basenji.Comics
6	alias Basenji.ImageProcessor
7	alias BasenjiWeb.API.Utils
8	alias BasenjiWeb.PredictiveCache
9
10	def get_page(conn, params) do
11	id = params["id"]	4✔
12	page = params["page"]	4✔
13
14	with {:ok, page_num} <- Utils.safe_to_int(page),	×
15	{:ok, comic} <- Comics.get_comic(id) do	4✔
16	PredictiveCache.get_comic_page_from_cache(comic, page_num)	4✔
17	end
18	\|> case do	4✔
19	{:ok, binary, mime} ->
20	length = byte_size(binary)	4✔
21
22	conn
23	\|> merge_resp_headers([{"access-control-allow-origin", "*"}])
24	\|> merge_resp_headers([{"content-type", mime}])
25	\|> merge_resp_headers([{"content-length", "#{length}"}])	4✔
26	\|> send_resp(200, binary)	4✔
27
28	error ->
29	Utils.bad_request_handler(conn, error)	×
30	end
31	end
32
33	def get_preview(conn, params) do
34	id = params["id"]	1✔
35
36	get_comic_preview(id)
37	\|> case do	1✔
38	{:ok, binary} ->
39	length = byte_size(binary)	1✔
40
41	conn
42	\|> merge_resp_headers([{"access-control-allow-origin", "*"}])
43	\|> merge_resp_headers([{"content-type", "image/jpeg"}])
44	\|> merge_resp_headers([{"content-length", "#{length}"}])	1✔
45	\|> send_resp(200, binary)	1✔
46
47	error ->
48	Utils.bad_request_handler(conn, error)	×
49	end
50	end
51
52	defp get_comic_preview(id) do
53	with {:ok, comic} <- Comics.get_comic(id) do	1✔
54	Comics.get_image_preview(comic)
55	\|> case do	1✔
NEW 56	{:ok, bytes} -> {:ok, bytes}	×
57	_ -> make_preview(comic)	1✔
58	end
59	end
60	end
61
62	defp make_preview(comic) do
63	{:ok, bytes, _mime} = PredictiveCache.get_comic_page_from_cache(comic, 1)	1✔
64	{:ok, preview_bytes} = ImageProcessor.get_image_preview(bytes, 600, 600)	1✔
65	Comics.associate_image_preview(comic, preview_bytes, width: 600, height: 600)	1✔
66	{:ok, preview_bytes}
67	end
68	end

camatcode / basenji / 7a49a98cbd16987b328dd1c28937c031e489ec8c

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous