16304548909

Committed 15 Jul 2025 09:08PM UTC coverage: 59.36% (+0.2%) from 59.189%

Build # 16304548909

Build Type

Pull #75

github

Committed by

Abo-Omar-74

Commit Message

chore: format code using go fmt

Pull Request Pull Request #75: Encapsulate Config Access with Internal Locking and Thread-Safe Getters

Run Details

74 of 199 new or added lines in 10 files covered. (37.19%)

12 existing lines in 1 file now uncovered.

723 of 1218 relevant lines covered (59.36%)

0.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

41.18

/internal/server/server.go

package server

import (
        "sync"

        "watchdog.onebusaway.org/internal/models"
)

// Config Holds all the configuration settings for our application
type Config struct {
        Port    int
        Env     string
        Mu      sync.RWMutex
        Servers []models.ObaServer
}

// NewConfig creates a new instance of a Config struct.
func NewConfig(port int, env string, servers []models.ObaServer) *Config {
        return &Config{
                Port:    port,
                Env:     env,
                Servers: servers,
        }
}

// updateConfig safely updates the config servers.
func (cfg *Config) UpdateConfig(newServers []models.ObaServer) {
        cfg.Mu.Lock()
        defer cfg.Mu.Unlock()
        cfg.Servers = newServers
}

// GetServers safely returns a copy of the servers slice to avoid
// concurrent modification issues.
// This method should be used to access the servers from other parts of the application.
// It returns a copy of the servers slice to ensure thread safety.
func (cfg *Config) GetServers() []models.ObaServer {
        cfg.Mu.RLock()
        defer cfg.Mu.RUnlock()
        return append([]models.ObaServer(nil), cfg.Servers...)
}

1	package server
2
3	import (
4	"sync"
5
6	"watchdog.onebusaway.org/internal/models"
7	)
8
9	// Config Holds all the configuration settings for our application
10	type Config struct {
11	Port int
12	Env string
13	Mu sync.RWMutex
14	Servers []models.ObaServer
15	}
16
17	// NewConfig creates a new instance of a Config struct.
18	func NewConfig(port int, env string, servers []models.ObaServer) *Config {	1✔
19	return &Config{	1✔
20	Port: port,	1✔
21	Env: env,	1✔
22	Servers: servers,	1✔
23	}	1✔
24	}	1✔
25
26	// updateConfig safely updates the config servers.
NEW 27	func (cfg *Config) UpdateConfig(newServers []models.ObaServer) {	×
NEW 28	cfg.Mu.Lock()	×
NEW 29	defer cfg.Mu.Unlock()	×
NEW 30	cfg.Servers = newServers	×
NEW 31	}	×
32
33	// GetServers safely returns a copy of the servers slice to avoid
34	// concurrent modification issues.
35	// This method should be used to access the servers from other parts of the application.
36	// It returns a copy of the servers slice to ensure thread safety.
NEW 37	func (cfg *Config) GetServers() []models.ObaServer {	×
NEW 38	cfg.Mu.RLock()	×
NEW 39	defer cfg.Mu.RUnlock()	×
NEW 40	return append([]models.ObaServer(nil), cfg.Servers...)	×
NEW 41	}	×

OneBusAway / watchdog / 16304548909

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous