16248620128

Committed 13 Jul 2025 11:27AM UTC coverage: 90.565% (-0.01%) from 90.575%

Build # 16248620128

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #4983 from randombit/jack/clang-tidy-cppcoreguidelines-owning-memory

Enable and fix clang-tidy warning cppcoreguidelines-owning-memory

Coverage Stats

99026 of 109342 relevant lines covered (90.57%)

12444574.04 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

94.59

/src/lib/tls/tls13/msg_encrypted_extensions.cpp

/*
* TLS Hello Request and Client Hello Messages
* (C) 2022 Jack Lloyd
*     2022 René Meusel, Hannes Rantzsch - neXenio GmbH
*
* Botan is released under the Simplified BSD License (see license.txt)
*/

#include <botan/tls_messages.h>

#include <botan/tls_callbacks.h>
#include <botan/tls_exceptn.h>
#include <botan/internal/tls_reader.h>

namespace Botan::TLS {

Encrypted_Extensions::Encrypted_Extensions(const Client_Hello_13& client_hello, const Policy& policy, Callbacks& cb) {
   const auto& exts = client_hello.extensions();

   // NOLINTBEGIN(*-owning-memory)

   // RFC 8446 4.2.7
   //    As of TLS 1.3, servers are permitted to send the "supported_groups"
   //    extension to the client.  Clients [...] MAY use the information
   //    learned from a successfully completed handshake to change what groups
   //    they use in their "key_share" extension in subsequent connections.
   if(exts.has<Supported_Groups>()) {
      m_extensions.add(new Supported_Groups(policy.key_exchange_groups()));
   }

   const auto record_size_limit = policy.record_size_limit();
   const auto max_record_size = MAX_PLAINTEXT_SIZE + 1 /* encrypted content type byte */;
   if(exts.has<Record_Size_Limit>()) {
      // RFC 8449 4
      //    Endpoints SHOULD advertise the "record_size_limit" extension, even
      //    if they have no need to limit the size of records. [...]  For
      //    servers, this allows clients to know that their limit will be
      //    respected.
      m_extensions.add(new Record_Size_Limit(record_size_limit.value_or(max_record_size)));
   } else if(record_size_limit.has_value() && record_size_limit.value() < max_record_size) {
      // RFC 8449 4
      //    Endpoints SHOULD advertise the "record_size_limit" extension, even if
      //    they have no need to limit the size of records. For clients, this
      //    allows servers to advertise a limit at their discretion.
      throw TLS_Exception(Alert::MissingExtension,
                          "Server cannot enforce record size limit without the client supporting it");
   }

   // RFC 7250 4.2
   //    If the TLS server wants to request a certificate from the client
   //    (via the certificate_request message), it MUST include the
   //    client_certificate_type extension in the server hello.
   //    [...]
   //    If the server does not send a certificate_request payload [...],
   //    then the client_certificate_type payload in the server hello MUST be
   //    omitted.
   if(auto* ch_client_cert_types = exts.get<Client_Certificate_Type>();
      ch_client_cert_types && policy.request_client_certificate_authentication()) {
      m_extensions.add(new Client_Certificate_Type(*ch_client_cert_types, policy));
   }

   // RFC 7250 4.2
   //    The server_certificate_type extension in the client hello indicates the
   //    types of certificates the client is able to process when provided by
   //    the server in a subsequent certificate payload. [...] With the
   //    server_certificate_type extension in the server hello, the TLS server
   //    indicates the certificate type carried in the Certificate payload.
   if(auto* ch_server_cert_types = exts.get<Server_Certificate_Type>()) {
      m_extensions.add(new Server_Certificate_Type(*ch_server_cert_types, policy));
   }

   // RFC 6066 3
   //    A server that receives a client hello containing the "server_name"
   //    extension [...] SHALL include an extension of type "server_name" in the
   //    (extended) server hello. The "extension_data" field of this extension
   //    SHALL be empty.
   if(exts.has<Server_Name_Indicator>()) {
      m_extensions.add(new Server_Name_Indicator(""));
   }

   if(auto* alpn_ext = exts.get<Application_Layer_Protocol_Notification>()) {
      const auto next_protocol = cb.tls_server_choose_app_protocol(alpn_ext->protocols());
      if(!next_protocol.empty()) {
         m_extensions.add(new Application_Layer_Protocol_Notification(next_protocol));
      }
   }

   // NOLINTEND(*-owning-memory)

   // TODO: Implement handling for (at least)
   //       * SRTP

   cb.tls_modify_extensions(m_extensions, Connection_Side::Server, type());
}

Encrypted_Extensions::Encrypted_Extensions(const std::vector<uint8_t>& buf) {
   TLS_Data_Reader reader("encrypted extensions reader", buf);

   // Encrypted Extensions contains a list of extensions. This list may legally
   // be empty. However, in that case we should at least see a two-byte length
   // field that reads 0x00 0x00.
   if(buf.size() < 2) {
      throw TLS_Exception(Alert::DecodeError, "Server sent an empty Encrypted Extensions message");
   }

   m_extensions.deserialize(reader, Connection_Side::Server, type());

   // RFC 8446 4.2
   //    If an implementation receives an extension which it recognizes and
   //    which is not specified for the message in which it appears, it MUST
   //    abort the handshake with an "illegal_parameter" alert.
   //
   // Note that we cannot encounter any extensions that we don't recognize here,
   // since only extensions we previously offered are allowed in EE.
   const auto allowed_exts = std::set<Extension_Code>{
      // Allowed extensions listed in RFC 8446 and implemented in Botan
      Extension_Code::ServerNameIndication,
      // MAX_FRAGMENT_LENGTH
      Extension_Code::SupportedGroups,
      Extension_Code::UseSrtp,
      // HEARTBEAT
      Extension_Code::ApplicationLayerProtocolNegotiation,
      // RFC 7250
      Extension_Code::ClientCertificateType,
      Extension_Code::ServerCertificateType,
      // EARLY_DATA

      // Allowed extensions not listed in RFC 8446 but acceptable as Botan implements them
      Extension_Code::RecordSizeLimit,
   };
   if(m_extensions.contains_implemented_extensions_other_than(allowed_exts)) {
      throw TLS_Exception(Alert::IllegalParameter, "Encrypted Extensions contained an extension that is not allowed");
   }
}

std::vector<uint8_t> Encrypted_Extensions::serialize() const {
   return m_extensions.serialize(Connection_Side::Server);
}

}  // namespace Botan::TLS

1	/*
2	* TLS Hello Request and Client Hello Messages
3	* (C) 2022 Jack Lloyd
4	* 2022 René Meusel, Hannes Rantzsch - neXenio GmbH
5	*
6	* Botan is released under the Simplified BSD License (see license.txt)
7	*/
8
9	#include <botan/tls_messages.h>
10
11	#include <botan/tls_callbacks.h>
12	#include <botan/tls_exceptn.h>
13	#include <botan/internal/tls_reader.h>
14
15	namespace Botan::TLS {
16
17	Encrypted_Extensions::Encrypted_Extensions(const Client_Hello_13& client_hello, const Policy& policy, Callbacks& cb) {	363✔
18	const auto& exts = client_hello.extensions();	363✔
19
20	// NOLINTBEGIN(*-owning-memory)
21
22	// RFC 8446 4.2.7
23	// As of TLS 1.3, servers are permitted to send the "supported_groups"
24	// extension to the client. Clients [...] MAY use the information
25	// learned from a successfully completed handshake to change what groups
26	// they use in their "key_share" extension in subsequent connections.
27	if(exts.has<Supported_Groups>()) {	363✔
28	m_extensions.add(new Supported_Groups(policy.key_exchange_groups()));	726✔
29	}
30
31	const auto record_size_limit = policy.record_size_limit();	363✔
32	const auto max_record_size = MAX_PLAINTEXT_SIZE + 1 /* encrypted content type byte */;	363✔
33	if(exts.has<Record_Size_Limit>()) {	363✔
34	// RFC 8449 4
35	// Endpoints SHOULD advertise the "record_size_limit" extension, even
36	// if they have no need to limit the size of records. [...] For
37	// servers, this allows clients to know that their limit will be
38	// respected.
39	m_extensions.add(new Record_Size_Limit(record_size_limit.value_or(max_record_size)));	15✔
40	} else if(record_size_limit.has_value() && record_size_limit.value() < max_record_size) {	355✔
41	// RFC 8449 4
42	// Endpoints SHOULD advertise the "record_size_limit" extension, even if
43	// they have no need to limit the size of records. For clients, this
44	// allows servers to advertise a limit at their discretion.
45	throw TLS_Exception(Alert::MissingExtension,	×
46	"Server cannot enforce record size limit without the client supporting it");	×
47	}
48
49	// RFC 7250 4.2
50	// If the TLS server wants to request a certificate from the client
51	// (via the certificate_request message), it MUST include the
52	// client_certificate_type extension in the server hello.
53	// [...]
54	// If the server does not send a certificate_request payload [...],
55	// then the client_certificate_type payload in the server hello MUST be
56	// omitted.
57	if(auto* ch_client_cert_types = exts.get<Client_Certificate_Type>();	363✔
58	ch_client_cert_types && policy.request_client_certificate_authentication()) {	363✔
59	m_extensions.add(new Client_Certificate_Type(*ch_client_cert_types, policy));	1✔
60	}
61
62	// RFC 7250 4.2
63	// The server_certificate_type extension in the client hello indicates the
64	// types of certificates the client is able to process when provided by
65	// the server in a subsequent certificate payload. [...] With the
66	// server_certificate_type extension in the server hello, the TLS server
67	// indicates the certificate type carried in the Certificate payload.
68	if(auto* ch_server_cert_types = exts.get<Server_Certificate_Type>()) {	363✔
69	m_extensions.add(new Server_Certificate_Type(*ch_server_cert_types, policy));	1✔
70	}
71
72	// RFC 6066 3
73	// A server that receives a client hello containing the "server_name"
74	// extension [...] SHALL include an extension of type "server_name" in the
75	// (extended) server hello. The "extension_data" field of this extension
76	// SHALL be empty.
77	if(exts.has<Server_Name_Indicator>()) {	363✔
78	m_extensions.add(new Server_Name_Indicator(""));	354✔
79	}
80
81	if(auto* alpn_ext = exts.get<Application_Layer_Protocol_Notification>()) {	363✔
82	const auto next_protocol = cb.tls_server_choose_app_protocol(alpn_ext->protocols());	7✔
83	if(!next_protocol.empty()) {	6✔
84	m_extensions.add(new Application_Layer_Protocol_Notification(next_protocol));	4✔
85	}
86	}	6✔
87
88	// NOLINTEND(*-owning-memory)
89
90	// TODO: Implement handling for (at least)
91	// * SRTP
92
93	cb.tls_modify_extensions(m_extensions, Connection_Side::Server, type());	362✔
94	}	363✔
95
96	Encrypted_Extensions::Encrypted_Extensions(const std::vector<uint8_t>& buf) {	431✔
97	TLS_Data_Reader reader("encrypted extensions reader", buf);	431✔
98
99	// Encrypted Extensions contains a list of extensions. This list may legally
100	// be empty. However, in that case we should at least see a two-byte length
101	// field that reads 0x00 0x00.
102	if(buf.size() < 2) {	431✔
103	throw TLS_Exception(Alert::DecodeError, "Server sent an empty Encrypted Extensions message");	1✔
104	}
105
106	m_extensions.deserialize(reader, Connection_Side::Server, type());	430✔
107
108	// RFC 8446 4.2
109	// If an implementation receives an extension which it recognizes and
110	// which is not specified for the message in which it appears, it MUST
111	// abort the handshake with an "illegal_parameter" alert.
112	//
113	// Note that we cannot encounter any extensions that we don't recognize here,
114	// since only extensions we previously offered are allowed in EE.
115	const auto allowed_exts = std::set<Extension_Code>{	426✔
116	// Allowed extensions listed in RFC 8446 and implemented in Botan
117	Extension_Code::ServerNameIndication,
118	// MAX_FRAGMENT_LENGTH
119	Extension_Code::SupportedGroups,
120	Extension_Code::UseSrtp,
121	// HEARTBEAT
122	Extension_Code::ApplicationLayerProtocolNegotiation,
123	// RFC 7250
124	Extension_Code::ClientCertificateType,
125	Extension_Code::ServerCertificateType,
126	// EARLY_DATA
127
128	// Allowed extensions not listed in RFC 8446 but acceptable as Botan implements them
129	Extension_Code::RecordSizeLimit,
130	};	426✔
131	if(m_extensions.contains_implemented_extensions_other_than(allowed_exts)) {	426✔
132	throw TLS_Exception(Alert::IllegalParameter, "Encrypted Extensions contained an extension that is not allowed");	5✔
133	}
134	}	431✔
135
136	std::vector<uint8_t> Encrypted_Extensions::serialize() const {	375✔
137	return m_extensions.serialize(Connection_Side::Server);	375✔
138	}
139
140	} // namespace Botan::TLS

randombit / botan / 16248620128

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous