• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4469

08 Jul 2025 09:38AM UTC coverage: 62.22% (-1.2%) from 63.381%
#4469

push

travis-ci

web-flow
Merge pull request #31712 from taosdata/merge/mainto3.0

merge: from main to 3.0 branch

153678 of 316510 branches covered (48.55%)

Branch coverage included in aggregate %.

56 of 60 new or added lines in 13 files covered. (93.33%)

5035 existing lines in 221 files now uncovered.

238955 of 314529 relevant lines covered (75.97%)

6273248.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.55
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "tmsg.h"
21
#include "ttypes.h"
22

23
#include "executorInt.h"
24
#include "tcommon.h"
25
#include "thash.h"
26
#include "ttime.h"
27

28
#include "function.h"
29
#include "operator.h"
30
#include "querynodes.h"
31
#include "querytask.h"
32
#include "tdatablock.h"
33
#include "tfill.h"
34

35
typedef struct STimeRange {
36
  TSKEY    skey;
37
  TSKEY    ekey;
38
  uint64_t groupId;
39
} STimeRange;
40

41
typedef struct SFillOperatorInfo {
42
  struct SFillInfo* pFillInfo;
43
  SSDataBlock*      pRes;
44
  SSDataBlock*      pFinalRes;
45
  int64_t           totalInputRows;
46
  void**            p;
47
  SSDataBlock*      existNewGroupBlock;
48
  STimeWindow       win;
49
  SColMatchInfo     matchInfo;
50
  int32_t           primaryTsCol;
51
  int32_t           primarySrcSlotId;
52
  uint64_t          curGroupId;  // current handled group id
53
  SExprInfo*        pExprInfo;
54
  int32_t           numOfExpr;
55
  SExprSupp         noFillExprSupp;
56
  SExprSupp         fillNullExprSupp;
57
  SList*            pFillSavedBlockList;
58
} SFillOperatorInfo;
59

60
static void destroyFillOperatorInfo(void* param);
61
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
62
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
63
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
64

65
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
8,588✔
66
                                               SResultInfo* pResultInfo, int32_t order) {
67
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
8,588✔
68
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
8,588✔
69
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
8,588✔
70

71
  //  int32_t order = TSDB_ORDER_ASC;
72
  int32_t scanFlag = MAIN_SCAN;
8,588✔
73
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
74
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
8,588✔
75

76
  blockDataCleanup(pInfo->pRes);
8,588✔
77
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
8,588✔
78

79
  reviseFillStartAndEndKey(pOperator->info, order);
8,588✔
80

81
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
17,176✔
82
                                         : pInfo->existNewGroupBlock->info.window.skey;
8,588!
83
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
8,588✔
84

85
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
8,588✔
86
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
8,588✔
87
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
893✔
88
    if (code != TSDB_CODE_SUCCESS) {
893!
89
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
90
      T_LONG_JMP(pTaskInfo->env, code);
×
91
    }
92
  }
93

94
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
8,588✔
95
  int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, NULL);
8,588✔
96
  if (code != TSDB_CODE_SUCCESS) {
8,588!
97
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
98
    T_LONG_JMP(pTaskInfo->env, code);
×
99
  }
100

101
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
8,588✔
102
  pInfo->existNewGroupBlock = NULL;
8,588✔
103
}
8,588✔
104

105
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
41,913✔
106
                                            SResultInfo* pResultInfo, int32_t order) {
107
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
41,913✔
108
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
41,913✔
109
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
7,032✔
110
    int32_t code = taosFillResultDataBlock2(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows, NULL);
7,032✔
111
    if (code != TSDB_CODE_SUCCESS) {
7,032!
112
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
113
      T_LONG_JMP(pTaskInfo->env, code);
×
114
    }
115
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
7,032✔
116
    return;
7,032✔
117
  }
118

119
  // handle the cached new group data block
120
  if (pInfo->existNewGroupBlock) {
34,878✔
121
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
8,588✔
122
  }
123
}
124

125
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
36,429✔
126
  int32_t            code = TSDB_CODE_SUCCESS;
36,429✔
127
  int32_t            lino = 0;
36,429✔
128
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
36,429✔
129
  SFillOperatorInfo* pInfo = pOperator->info;
36,429✔
130
  SExprSupp*         pSup = &pOperator->exprSupp;
36,429✔
131
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
36,429✔
132
  QUERY_CHECK_CODE(code, lino, _end);
36,428!
133
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL);
36,428✔
134
  QUERY_CHECK_CODE(code, lino, _end);
36,427!
135

136
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
137
  pInfo->pRes->info.rows = 0;
36,427✔
138
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
36,427✔
139
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
36,427✔
140
  QUERY_CHECK_CODE(code, lino, _end);
36,429!
141

142
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
36,429✔
143
                               NULL);
144
  QUERY_CHECK_CODE(code, lino, _end);
36,428!
145

146
  if (pInfo->fillNullExprSupp.pExprInfo) {
36,428✔
147
    pInfo->pRes->info.rows = 0;
118✔
148
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
118✔
149
    QUERY_CHECK_CODE(code, lino, _end);
118!
150
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
118✔
151
        pInfo->fillNullExprSupp.numOfExprs, NULL);
152
  }
153

154
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
36,428✔
155

156
_end:
36,428✔
157
  if (code != TSDB_CODE_SUCCESS) {
36,428!
158
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
159
    T_LONG_JMP(pTaskInfo->env, code);
×
160
  }
161
}
36,428✔
162

163
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
893✔
164
  int32_t code = TSDB_CODE_SUCCESS;
893✔
165
  int32_t lino = 0;
893✔
166
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
7,124✔
167
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
6,231✔
168
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
4,506✔
169
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
4,506!
170
      key->isNull = true;
4,506✔
171
    }
172
  }
173

174
_end:
893✔
175
  if (code != TSDB_CODE_SUCCESS) {
893!
176
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
177
  }
178
  return code;
893✔
179
}
180

181
static SSDataBlock* doFillImpl2(SOperatorInfo* pOperator) {
41,911✔
182
  int32_t            code = TSDB_CODE_SUCCESS;
41,911✔
183
  int32_t            lino = 0;
41,911✔
184
  SFillOperatorInfo* pInfo = pOperator->info;
41,911✔
185
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
41,911✔
186
  if (pInfo == NULL || pTaskInfo == NULL) {
41,911!
187
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
188
    return NULL;
×
189
  }
190

191
  SResultInfo* pResultInfo = &pOperator->resultInfo;
41,921✔
192
  SSDataBlock* pResBlock = pInfo->pFinalRes;
41,921✔
193
  if (pResBlock == NULL) {
41,921!
194
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
195
    return NULL;
×
196
  }
197
  blockDataCleanup(pResBlock);
41,921✔
198
  int32_t        order = pInfo->pFillInfo->order;
41,922✔
199
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
41,922✔
200

201
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
41,922✔
202
  if (pResBlock->info.rows > 0) {
41,911✔
203
    pResBlock->info.id.groupId = pInfo->curGroupId;
5,043✔
204
    return pResBlock;
5,043✔
205
  }
206

207
  while (1) {
17,175✔
208
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
54,043✔
209
    if (pBlock == NULL) {
54,051✔
210
      if (pInfo->totalInputRows == 0 &&
26,214✔
211
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
10,546✔
212
        setOperatorCompleted(pOperator);
9,986✔
213
        return NULL;
36,880✔
214
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
16,228✔
215
        reviseFillStartAndEndKey(pInfo, order);
280✔
216
      }
217

218
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
16,228✔
219
    } else {
220
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
27,837✔
221
      pBlock->info.dataLoad = 1;
27,837✔
222
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
27,837✔
223
      QUERY_CHECK_CODE(code, lino, _end);
27,839!
224

225
      blockDataCleanup(pInfo->pRes);
27,839✔
226
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
27,841✔
227
      QUERY_CHECK_CODE(code, lino, _end);
27,841!
228
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
27,841✔
229
      QUERY_CHECK_CODE(code, lino, _end);
27,841!
230
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
27,841✔
231

232
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
47,093✔
233
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
19,252✔
234
          reviseFillStartAndEndKey(pInfo, order);
7,933✔
235
        }
236

237
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
19,253✔
238
        pInfo->totalInputRows += pInfo->pRes->info.rows;
19,253✔
239

240
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
19,253✔
241
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
19,253✔
242
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
19,253✔
243
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
8,588!
244
        pInfo->existNewGroupBlock = pBlock;
8,588✔
245

246
        // Fill the previous group data block, before handle the data block of new group.
247
        // Close the fill operation for previous group data block
248
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
8,588✔
249
        pInfo->pFillInfo->prev.key = 0;
8,588✔
250
      }
251
    }
252

253
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
44,069✔
254
    bool wantMoreBlock = false;
44,069✔
255
    code = taosFillResultDataBlock2(pInfo->pFillInfo, pResBlock, numOfResultRows, &wantMoreBlock);
44,069✔
256
    QUERY_CHECK_CODE(code, lino, _end);
44,067!
257

258
    // current group has no more result to return
259
    if (pResBlock->info.rows > 0) {
44,067✔
260
      // 1. The result in current group not reach the threshold of output result, continue
261
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
262
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
18,793!
263
        pResBlock->info.id.groupId = pInfo->curGroupId;
18,793✔
264
        return pResBlock;
18,793✔
265
      }
266

267
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
268
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
269
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
270
        return pResBlock;
×
271
      }
272
    } else if (pInfo->existNewGroupBlock) {  // try next group
25,274!
273
      blockDataCleanup(pResBlock);
×
274

275
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
276
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
277
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
278
        return pResBlock;
×
279
      }
280
    } else {
281
      if (wantMoreBlock) continue;
25,274✔
282
      return NULL;
8,099✔
283
    }
284
  }
285

286
_end:
×
287
  if (code != TSDB_CODE_SUCCESS) {
×
288
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
289
    T_LONG_JMP(pTaskInfo->env, code);
×
290
  }
291
  return NULL;
×
292
}
293

294
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
×
295
  int32_t            code = TSDB_CODE_SUCCESS;
×
296
  int32_t            lino = 0;
×
297
  SFillOperatorInfo* pInfo = pOperator->info;
×
298
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
×
299
  if (pInfo == NULL || pTaskInfo == NULL) {
×
300
    qError("%s failed at line %d since pInfo or pTaskInfo is NULL.", __func__, __LINE__);
×
301
    return NULL;
×
302
  }
303

304
  SResultInfo* pResultInfo = &pOperator->resultInfo;
×
305
  SSDataBlock* pResBlock = pInfo->pFinalRes;
×
306
  if (pResBlock == NULL) {
×
307
    qError("%s failed at line %d since pResBlock is NULL.", __func__, __LINE__);
×
308
    return NULL;
×
309
  }
310

311
  blockDataCleanup(pResBlock);
×
312

313
  int32_t order = pInfo->pFillInfo->order;
×
314

315
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
×
316
#if 0
317
  // the scan order may be different from the output result order for agg interval operator.
318
  if (pDownstream->operatorType == QUERY_NODE_PHYSICAL_PLAN_HASH_INTERVAL) {
319
    order = ((SIntervalAggOperatorInfo*) pDownstream->info)->resultTsOrder;
320
  } else {
321
    order = pInfo->pFillInfo->order;
322
  }
323
#endif
324

325
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
326
  if (pResBlock->info.rows > 0) {
×
327
    pResBlock->info.id.groupId = pInfo->curGroupId;
×
328
    return pResBlock;
×
329
  }
330

331
  while (1) {
×
332
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
×
333
    if (pBlock == NULL) {
×
334
      if (pInfo->totalInputRows == 0 &&
×
335
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
×
336
        setOperatorCompleted(pOperator);
×
337
        return NULL;
×
338
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
339
        reviseFillStartAndEndKey(pInfo, order);
×
340
      }
341

342
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
343
    } else {
344
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
×
345
      pBlock->info.dataLoad = 1;
×
346
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
×
347
      QUERY_CHECK_CODE(code, lino, _end);
×
348

349
      blockDataCleanup(pInfo->pRes);
×
350
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
×
351
      QUERY_CHECK_CODE(code, lino, _end);
×
352
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
×
353
      QUERY_CHECK_CODE(code, lino, _end);
×
354
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
×
355

356
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
×
357
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
×
358
          reviseFillStartAndEndKey(pInfo, order);
×
359
        }
360

361
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
×
362
        pInfo->totalInputRows += pInfo->pRes->info.rows;
×
363

364
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
×
365
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
×
366
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
×
367
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
×
368
        pInfo->existNewGroupBlock = pBlock;
×
369

370
        // Fill the previous group data block, before handle the data block of new group.
371
        // Close the fill operation for previous group data block
372
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
×
373
        pInfo->pFillInfo->prev.key = 0;
×
374
      }
375
    }
376

377
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
×
378
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
×
379
    QUERY_CHECK_CODE(code, lino, _end);
×
380

381
    // current group has no more result to return
382
    if (pResBlock->info.rows > 0) {
×
383
      // 1. The result in current group not reach the threshold of output result, continue
384
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
385
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
×
386
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
387
        return pResBlock;
×
388
      }
389

390
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
×
391
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
×
392
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
393
        return pResBlock;
×
394
      }
395
    } else if (pInfo->existNewGroupBlock) {  // try next group
×
396
      blockDataCleanup(pResBlock);
×
397

398
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
×
399
      if (pResBlock->info.rows > pResultInfo->threshold) {
×
400
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
401
        return pResBlock;
×
402
      }
403
    } else {
404
      return NULL;
×
405
    }
406
  }
407

408
_end:
×
409
  if (code != TSDB_CODE_SUCCESS) {
×
410
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
411
    T_LONG_JMP(pTaskInfo->env, code);
×
412
  }
413
  return NULL;
×
414
}
415

416
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
41,911✔
417
  int32_t            code = TSDB_CODE_SUCCESS;
41,911✔
418
  SFillOperatorInfo* pInfo = pOperator->info;
41,911✔
419
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
41,911✔
420

421
  if (pOperator->status == OP_EXEC_DONE) {
41,911!
422
    (*ppRes) = NULL;
×
423
    return code;
×
424
  }
425

426
  SSDataBlock* fillResult = NULL;
41,911✔
427
  while (true) {
428
    fillResult = doFillImpl2(pOperator);
41,911✔
429
    if (fillResult == NULL) {
41,923✔
430
      setOperatorCompleted(pOperator);
18,086✔
431
      break;
18,085✔
432
    }
433

434
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo);
23,837✔
435
    if (code != TSDB_CODE_SUCCESS) {
23,836!
UNCOV
436
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
UNCOV
437
      pTaskInfo->code = code;
×
UNCOV
438
      T_LONG_JMP(pTaskInfo->env, code);
×
439
    }
440
    if (fillResult->info.rows > 0) {
23,836!
441
      break;
23,836✔
442
    }
443
  }
444

445
  if (fillResult != NULL) {
41,921✔
446
    pOperator->resultInfo.totalRows += fillResult->info.rows;
23,836✔
447
  }
448

449
  (*ppRes) = fillResult;
41,921✔
450
  return code;
41,921✔
451
}
452

453
void destroyFillOperatorInfo(void* param) {
18,197✔
454
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
18,197✔
455
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
18,197✔
456
  blockDataDestroy(pInfo->pRes);
18,201✔
457
  pInfo->pRes = NULL;
18,201✔
458
  blockDataDestroy(pInfo->pFinalRes);
18,201✔
459
  pInfo->pFinalRes = NULL;
18,201✔
460

461
  cleanupExprSupp(&pInfo->noFillExprSupp);
18,201✔
462
  cleanupExprSupp(&pInfo->fillNullExprSupp);
18,201✔
463

464
  taosMemoryFreeClear(pInfo->p);
18,201!
465
  taosArrayDestroy(pInfo->matchInfo.pList);
18,202✔
466
  taosMemoryFreeClear(param);
18,202!
467
}
18,202✔
468

469
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr, int32_t numOfCols, SExprInfo* pNotFillExpr,
18,194✔
470
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr, int32_t numOfFillNullExprs,
471
                            SNodeListNode* pValNode, STimeWindow win, int32_t capacity, const char* id,
472
                            SInterval* pInterval, int32_t fillType, int32_t order, SExecTaskInfo* pTaskInfo) {
473
  SFillColInfo* pColInfo =
474
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols, pFillNullExpr, numOfFillNullExprs, pValNode);
18,194✔
475
  if (!pColInfo) {
18,198✔
476
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
5!
477
    return terrno;
5✔
478
  }
479

480
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
18,193✔
481

482
  //  STimeWindow w = {0};
483
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
484
  pInfo->pFillInfo = NULL;
18,193✔
485
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols, numOfFillNullExprs, capacity, pInterval,
18,193✔
486
                                    fillType, pColInfo, pInfo->primaryTsCol, order, id, pTaskInfo, &pInfo->pFillInfo);
18,193✔
487
  if (code != TSDB_CODE_SUCCESS) {
18,198✔
488
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
1!
489
    return code;
×
490
  }
491

492
  if (order == TSDB_ORDER_ASC) {
18,197✔
493
    pInfo->win.skey = win.skey;
15,684✔
494
    pInfo->win.ekey = win.ekey;
15,684✔
495
  } else {
496
    pInfo->win.skey = win.ekey;
2,513✔
497
    pInfo->win.ekey = win.skey;
2,513✔
498
  }
499
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
18,197✔
500
  if (!pInfo->p) {
18,201!
501
    return terrno;
×
502
  }
503

504
  if (pInfo->pFillInfo == NULL) {
18,201!
505
    taosMemoryFree(pInfo->pFillInfo);
×
506
    taosMemoryFree(pInfo->p);
×
507
    return TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
508
  } else {
509
    return TSDB_CODE_SUCCESS;
18,201✔
510
  }
511
}
512

513
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
18,195✔
514
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
18,195✔
515
    return false;
311✔
516
  }
517

518
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
26,407✔
519
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
26,312✔
520
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
26,312✔
521
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
26,308✔
522
      return true;
17,789✔
523
    }
524
  }
525
  return false;
95✔
526
}
527

528
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
18,197✔
529
                                           const char* idStr) {
530
  bool wstartExist = isWstartColumnExist(pInfo);
18,197✔
531

532
  if (wstartExist == false) {
18,199✔
533
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
410!
534
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
535
      return TSDB_CODE_QRY_SYS_ERROR;
×
536
    }
537

538
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
410!
539
    if (pExpr == NULL) {
410!
540
      return terrno;
×
541
    }
542

543
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
410✔
544
    if (code != TSDB_CODE_SUCCESS) {
410!
545
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
546
      pExprSupp->numOfExprs += 1;
×
547
      pExprSupp->pExprInfo = pExpr;
×
548
      return code;
×
549
    }
550

551
    pExprSupp->numOfExprs += 1;
410✔
552
    pExprSupp->pExprInfo = pExpr;
410✔
553
  }
554

555
  return TSDB_CODE_SUCCESS;
18,199✔
556
}
557

558
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
18,186✔
559
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
560
  QRY_PARAM_CHECK(pOptrInfo);
18,186!
561
  int32_t code = 0;
18,186✔
562
  int32_t lino = 0;
18,186✔
563

564
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
18,186!
565
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
18,191!
566
  if (pInfo == NULL || pOperator == NULL) {
18,198!
567
    code = terrno;
×
568
    goto _error;
×
569
  }
570

571
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
18,198✔
572
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
18,200!
573
  SExprInfo* pExprInfo = NULL;
18,200✔
574

575
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
18,200✔
576
  QUERY_CHECK_CODE(code, lino, _error);
18,197!
577

578
  pOperator->exprSupp.pExprInfo = pExprInfo;
18,197✔
579
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
18,197✔
580

581
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
18,197✔
582
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
18,197✔
583
  QUERY_CHECK_CODE(code, lino, _error);
18,198!
584

585
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
18,198✔
586
  QUERY_CHECK_CODE(code, lino, _error);
18,199!
587

588
  code =
589
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
18,199✔
590
  QUERY_CHECK_CODE(code, lino, _error);
18,200!
591

592
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
18,200✔
593
                        &pInfo->fillNullExprSupp.numOfExprs);
594
  QUERY_CHECK_CODE(code, lino, _error);
18,199!
595
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
18,199✔
596
                      &pTaskInfo->storageAPI.functionStore);
597
  QUERY_CHECK_CODE(code, lino, _error);
18,199!
598

599
  SInterval* pInterval =
18,199✔
600
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
18,199✔
601
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
6,063✔
602
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
18,199✔
603

604
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
18,199✔
605
  int32_t type = convertFillType(pPhyFillNode->mode);
18,199✔
606

607
  SResultInfo* pResultInfo = &pOperator->resultInfo;
18,197✔
608

609
  initResultSizeInfo(&pOperator->resultInfo, 4096);
18,197✔
610
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
18,195✔
611
  if (code != TSDB_CODE_SUCCESS) {
18,201!
612
    goto _error;
×
613
  }
614
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
18,201✔
615
  if (code != TSDB_CODE_SUCCESS) {
18,200!
616
    goto _error;
×
617
  }
618

619
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
18,200✔
620
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
18,200✔
621

622
  int32_t numOfOutputCols = 0;
18,200✔
623
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
18,200✔
624
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
625

626
  QUERY_CHECK_CODE(code, lino, _error);
18,200!
627
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
18,200✔
628
                      pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
629
                      (SNodeListNode*)pPhyFillNode->pValues, pPhyFillNode->timeRange, pResultInfo->capacity,
18,200✔
630
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo);
18,200✔
631
  if (code != TSDB_CODE_SUCCESS) {
18,200!
632
    goto _error;
×
633
  }
634

635
  pInfo->pFinalRes = NULL;
18,200✔
636

637
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
18,200✔
638
  if (code) {
18,191!
639
    goto _error;
×
640
  }
641

642
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
18,191✔
643
  if (code != TSDB_CODE_SUCCESS) {
18,201!
644
    goto _error;
×
645
  }
646

647
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0);
18,201✔
648
  if (code != TSDB_CODE_SUCCESS) {
18,200!
649
    goto _error;
×
650
  }
651

652
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
18,200✔
653
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
18,201✔
654
                                         optrDefaultGetNextExtFn, NULL);
655

656
  code = appendDownstream(pOperator, &downstream, 1);
18,199✔
657
  if (code != TSDB_CODE_SUCCESS) {
18,200!
658
    goto _error;
×
659
  }
660

661
  *pOptrInfo = pOperator;
18,200✔
662
  return TSDB_CODE_SUCCESS;
18,200✔
663

664
_error:
×
665
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
666

667
  if (pInfo != NULL) {
×
668
    destroyFillOperatorInfo(pInfo);
×
669
  }
670
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
671
  pTaskInfo->code = code;
×
672
  return code;
×
673
}
674

675
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
16,801✔
676
  int64_t skey, ekey, next;
677
  if (order == TSDB_ORDER_ASC) {
16,801✔
678
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
15,477✔
679
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
15,478✔
680

681
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
15,478✔
682
    next = ekey;
15,478✔
683
    while (next < pInfo->win.ekey) {
85,278✔
684
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
69,800✔
685
                         pInfo->pFillInfo->interval.precision, NULL);
69,800✔
686
      ekey = next > pInfo->win.ekey ? ekey : next;
69,800✔
687
    }
688
    pInfo->win.ekey = ekey;
15,478✔
689
  } else {
690
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
1,324✔
691
    next = skey;
1,324✔
692
    while (next < pInfo->win.skey) {
7,986✔
693
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
6,662✔
694
                         pInfo->pFillInfo->interval.precision, NULL);
6,662✔
695
      skey = next > pInfo->win.skey ? skey : next;
6,662✔
696
    }
697
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
1,324✔
698
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
1,324✔
699
  }
700
}
16,802✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc