8a834057-0af3-474c-9eeb-1e8ae473d305

Committed 09 Jul 2025 07:26PM UTC coverage: 92.025% (-0.04%) from 92.068%

Build # 8a834057-0af3-474c-9eeb-1e8ae473d305

Build Type

Pull #2795

circleci

Committed by

christinach

Commit Message

following review: remove version form gem flipflop

Pull Request Pull Request #2795: Add flipper

Run Details

4 of 6 new or added lines in 2 files covered. (66.67%)

3485 of 3787 relevant lines covered (92.03%)

844.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/app/controllers/application_controller.rb

class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
  include ApplicationHelper

  def after_sign_out_path_for(_resource_or_scope)
    request.referer
  end

  def handle_alma_exception(exception:, message:)
    if exception.is_a?(Alma::PerSecondThresholdError)
      Rails.logger.error "HTTP 429. #{message} #{exception}"
      head :too_many_requests
    elsif exception.is_a?(Alma::NotFoundError)
      Rails.logger.error "HTTP 404. #{message} #{exception}"
      head :not_found
    elsif exception.is_a?(Alma::StandardError)
      Rails.logger.error "HTTP 400. #{message} #{exception}"
      head :bad_request
    elsif exception.is_a?(Net::ReadTimeout)
      Rails.logger.error "HTTP 504. #{message} #{exception}"
      head :gateway_timeout
    else
      Rails.logger.error "HTTP 500. #{message} #{exception}"
      head :internal_server_error
    end
  end

  private

    def verify_admin!
      authenticate_user!
      head :forbidden unless current_user.catalog_admin?
    end
end

1	class ApplicationController < ActionController::Base	1✔
2	# Prevent CSRF attacks by raising an exception.
3	# For APIs, you may want to use :null_session instead.
4	protect_from_forgery with: :exception	1✔
5	include ApplicationHelper	1✔
6
7	def after_sign_out_path_for(_resource_or_scope)	1✔
8	request.referer	×
9	end
10
11	def handle_alma_exception(exception:, message:)	1✔
12	if exception.is_a?(Alma::PerSecondThresholdError)	14✔
13	Rails.logger.error "HTTP 429. #{message} #{exception}"	9✔
14	head :too_many_requests	9✔
15	elsif exception.is_a?(Alma::NotFoundError)	5✔
16	Rails.logger.error "HTTP 404. #{message} #{exception}"	2✔
17	head :not_found	2✔
18	elsif exception.is_a?(Alma::StandardError)	3✔
19	Rails.logger.error "HTTP 400. #{message} #{exception}"	1✔
20	head :bad_request	1✔
21	elsif exception.is_a?(Net::ReadTimeout)	2✔
22	Rails.logger.error "HTTP 504. #{message} #{exception}"	1✔
23	head :gateway_timeout	1✔
24	else
25	Rails.logger.error "HTTP 500. #{message} #{exception}"	1✔
26	head :internal_server_error	1✔
27	end
28	end
29
30	private	1✔
31
32	def verify_admin!	1✔
NEW 33	authenticate_user!	×
NEW 34	head :forbidden unless current_user.catalog_admin?	×
35	end
36	end

pulibrary / bibdata / 8a834057-0af3-474c-9eeb-1e8ae473d305

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous