ensdomains / namechain / 16114489818

push

github

BET-397: Counting assignees for a role (#68)

* feat: counting assignees for a role

* fix: from uint128 to uint64

* Update contracts/src/common/EnhancedAccessControl.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* Update contracts/src/common/EnhancedAccessControl.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* Update contracts/src/common/EnhancedAccessControl.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* refactor: minor updates to clarify the changes

* refactor: update all roles to be nybbles

* fix: tests working again

* test: added tests for assignee counts

* docs: make method usage clearer

* fix: role constants in ts tests

* Update contracts/src/L2/ETHRegistrar.sol

Co-authored-by: Nick Johnson <arachnid@notdot.net>

* refactor: cleaner admin role definitions

* fix: type check error

* refactor: undo test changes

* fix: incorrect role value

* refactor: define roles in an easier-to-understand format

* refactor: ensure granted/revoked role bitmaps are sanitized

* refactor: add sanitization call to mask method

---------

Co-authored-by: Nick Johnson <arachnid@notdot.net>

92 of 194 branches covered (47.42%)

Branch coverage included in aggregate %.

26 of 27 new or added lines in 1 file covered. (96.3%)

874 of 1248 relevant lines covered (70.03%)

4305.75 hits per line