• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4440

04 Jul 2025 02:10AM UTC coverage: 63.29% (-0.4%) from 63.643%
#4440

push

travis-ci

web-flow
fix:(stmt2) heap buffer overflow (#31607)

159782 of 321690 branches covered (49.67%)

Branch coverage included in aggregate %.

19 of 22 new or added lines in 3 files covered. (86.36%)

5735 existing lines in 195 files now uncovered.

246739 of 320626 relevant lines covered (76.96%)

6757056.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.72
/source/dnode/mnode/impl/src/mndBnode.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "mndBnode.h"
18
#include "mndDnode.h"
19
#include "mndPrivilege.h"
20
#include "mndShow.h"
21
#include "mndTrans.h"
22
#include "mndUser.h"
23

24
#define BNODE_VER_NUMBER   1
25
#define BNODE_RESERVE_SIZE 64
26

27
static SSdbRaw *mndBnodeActionEncode(SBnodeObj *pObj) {
416✔
28
  int32_t code = 0;
416✔
29
  int32_t lino = 0;
416✔
30

31
  terrno = TSDB_CODE_OUT_OF_MEMORY;
416✔
32

33
  SSdbRaw *pRaw = sdbAllocRaw(SDB_BNODE, BNODE_VER_NUMBER, sizeof(SBnodeObj) + BNODE_RESERVE_SIZE);
416✔
34
  if (pRaw == NULL) goto _OVER;
416!
35

36
  int32_t dataPos = 0;
416✔
37
  SDB_SET_INT32(pRaw, dataPos, pObj->id, _OVER)
416!
38
  SDB_SET_INT32(pRaw, dataPos, pObj->proto, _OVER)
416!
39
  SDB_SET_INT64(pRaw, dataPos, pObj->createdTime, _OVER)
416!
40
  SDB_SET_INT64(pRaw, dataPos, pObj->updateTime, _OVER)
416!
41
  SDB_SET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
416!
42

43
  terrno = 0;
416✔
44

45
_OVER:
416✔
46
  if (terrno != 0) {
416!
47
    mError("bnode:%d, failed to encode to raw:%p since %s", pObj->id, pRaw, terrstr());
×
48
    sdbFreeRaw(pRaw);
×
49
    return NULL;
×
50
  }
51

52
  mTrace("bnode:%d, encode to raw:%p, row:%p", pObj->id, pRaw, pObj);
416!
53
  return pRaw;
416✔
54
}
55

56
static SSdbRow *mndBnodeActionDecode(SSdbRaw *pRaw) {
327✔
57
  int32_t    code = 0;
327✔
58
  int32_t    lino = 0;
327✔
59
  SSdbRow   *pRow = NULL;
327✔
60
  SBnodeObj *pObj = NULL;
327✔
61
  int8_t     sver = 0;
327✔
62

63
  terrno = TSDB_CODE_OUT_OF_MEMORY;
327✔
64

65
  if (sdbGetRawSoftVer(pRaw, &sver) != 0) goto _OVER;
327!
66

67
  if (sver != BNODE_VER_NUMBER) {
327!
68
    terrno = TSDB_CODE_SDB_INVALID_DATA_VER;
×
69
    goto _OVER;
×
70
  }
71

72
  pRow = sdbAllocRow(sizeof(SBnodeObj));
327✔
73
  if (pRow == NULL) goto _OVER;
327!
74

75
  pObj = sdbGetRowObj(pRow);
327✔
76
  if (pObj == NULL) goto _OVER;
327!
77

78
  int32_t dataPos = 0;
327✔
79
  SDB_GET_INT32(pRaw, dataPos, &pObj->id, _OVER)
327!
80
  SDB_GET_INT32(pRaw, dataPos, &pObj->proto, _OVER)
327!
81
  SDB_GET_INT64(pRaw, dataPos, &pObj->createdTime, _OVER)
327!
82
  SDB_GET_INT64(pRaw, dataPos, &pObj->updateTime, _OVER)
327!
83
  SDB_GET_RESERVE(pRaw, dataPos, BNODE_RESERVE_SIZE, _OVER)
327!
84

85
  terrno = 0;
327✔
86

87
_OVER:
327✔
88
  if (terrno != 0) {
327!
89
    mError("bnode:%d, failed to decode from raw:%p since %s", pObj == NULL ? 0 : pObj->id, pRaw, terrstr());
×
90
    taosMemoryFreeClear(pRow);
×
91
    return NULL;
×
92
  }
93

94
  mTrace("bnode:%d, decode from raw:%p, row:%p", pObj->id, pRaw, pObj);
327!
95
  return pRow;
327✔
96
}
97

98
static int32_t mndBnodeActionInsert(SSdb *pSdb, SBnodeObj *pObj) {
84✔
99
  mTrace("bnode:%d, perform insert action, row:%p", pObj->id, pObj);
84!
100
  pObj->pDnode = sdbAcquire(pSdb, SDB_DNODE, &pObj->id);
84✔
101
  if (pObj->pDnode == NULL) {
84!
102
    terrno = TSDB_CODE_MND_DNODE_NOT_EXIST;
×
103
    mError("bnode:%d, failed to perform insert action since %s", pObj->id, terrstr());
×
104
    return -1;
×
105
  }
106

107
  return 0;
84✔
108
}
109

110
static int32_t mndBnodeActionDelete(SSdb *pSdb, SBnodeObj *pObj) {
327✔
111
  mTrace("bnode:%d, perform delete action, row:%p", pObj->id, pObj);
327!
112
  if (pObj->pDnode != NULL) {
327✔
113
    sdbRelease(pSdb, pObj->pDnode);
84✔
114
    pObj->pDnode = NULL;
84✔
115
  }
116

117
  return 0;
327✔
118
}
119

120
static int32_t mndBnodeActionUpdate(SSdb *pSdb, SBnodeObj *pOld, SBnodeObj *pNew) {
162✔
121
  mTrace("bnode:%d, perform update action, old row:%p new row:%p", pOld->id, pOld, pNew);
162!
122
  pOld->updateTime = pNew->updateTime;
162✔
123
  return 0;
162✔
124
}
125

126
static int32_t mndSetCreateBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
81✔
127
  int32_t  code = 0;
81✔
128
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
81✔
129
  if (pRedoRaw == NULL) {
81!
130
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
131
    if (terrno != 0) code = terrno;
×
132
    TAOS_RETURN(code);
×
133
  }
134
  TAOS_CHECK_RETURN(mndTransAppendRedolog(pTrans, pRedoRaw));
81!
135
  TAOS_CHECK_RETURN(sdbSetRawStatus(pRedoRaw, SDB_STATUS_CREATING));
81!
136
  TAOS_RETURN(code);
81✔
137
}
138

139
static int32_t mndSetCreateBnodeUndoLogs(STrans *pTrans, SBnodeObj *pObj) {
81✔
140
  int32_t  code = 0;
81✔
141
  SSdbRaw *pUndoRaw = mndBnodeActionEncode(pObj);
81✔
142
  if (pUndoRaw == NULL) {
81!
143
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
144
    if (terrno != 0) code = terrno;
×
145
    TAOS_RETURN(code);
×
146
  }
147
  TAOS_CHECK_RETURN(mndTransAppendUndolog(pTrans, pUndoRaw));
81!
148
  TAOS_CHECK_RETURN(sdbSetRawStatus(pUndoRaw, SDB_STATUS_DROPPED));
81!
149
  TAOS_RETURN(code);
81✔
150
}
151

152
static int32_t mndSetCreateBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
81✔
153
  int32_t  code = 0;
81✔
154
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
81✔
155
  if (pCommitRaw == NULL) {
81!
156
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
157
    if (terrno != 0) code = terrno;
×
158
    TAOS_RETURN(code);
×
159
  }
160
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
81!
161
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_READY));
81!
162
  TAOS_RETURN(code);
81✔
163
}
164

165
static int32_t mndSetCreateBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
81✔
166
  int32_t          code = 0;
81✔
167
  SDCreateBnodeReq createReq = {0};
81✔
168
  createReq.dnodeId = pDnode->id;
81✔
169
  createReq.bnodeProto = pObj->proto;
81✔
170

171
  int32_t contLen = tSerializeSMCreateBnodeReq(NULL, 0, &createReq);
81✔
172
  void   *pReq = taosMemoryMalloc(contLen);
81!
173
  if (pReq == NULL) {
81!
174
    code = terrno;
×
175
    TAOS_RETURN(code);
×
176
  }
177
  code = tSerializeSMCreateBnodeReq(pReq, contLen, &createReq);
81✔
178
  if (code < 0) {
81!
179
    mError("bnode:%d, failed to serialize create drop bnode request since %s", createReq.dnodeId, terrstr());
×
180

181
    taosMemoryFree(pReq);
×
182
    TAOS_RETURN(code);
×
183
  }
184

185
  STransAction action = {0};
81✔
186
  action.epSet = mndGetDnodeEpset(pDnode);
81✔
187
  action.pCont = pReq;
81✔
188
  action.contLen = contLen;
81✔
189
  action.msgType = TDMT_DND_CREATE_BNODE;
81✔
190
  action.acceptableCode = TSDB_CODE_BNODE_ALREADY_DEPLOYED;
81✔
191

192
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
81!
193
    taosMemoryFree(pReq);
×
194
    TAOS_RETURN(code);
×
195
  }
196

197
  TAOS_RETURN(code);
81✔
198
}
199

200
static int32_t mndSetCreateBnodeUndoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
81✔
201
  int32_t        code = 0;
81✔
202
  SDDropBnodeReq dropReq = {0};
81✔
203
  dropReq.dnodeId = pDnode->id;
81✔
204

205
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
81✔
206
  void   *pReq = taosMemoryMalloc(contLen);
81!
207
  if (pReq == NULL) {
81!
208
    code = terrno;
×
209
    TAOS_RETURN(code);
×
210
  }
211
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
81✔
212
  if (code < 0) {
81!
213
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
214
  }
215

216
  STransAction action = {0};
81✔
217
  action.epSet = mndGetDnodeEpset(pDnode);
81✔
218
  action.pCont = pReq;
81✔
219
  action.contLen = contLen;
81✔
220
  action.msgType = TDMT_DND_DROP_BNODE;
81✔
221
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
81✔
222

223
  if ((code = mndTransAppendUndoAction(pTrans, &action)) != 0) {
81!
224
    taosMemoryFree(pReq);
×
225
    TAOS_RETURN(code);
×
226
  }
227

228
  TAOS_RETURN(code);
81✔
229
}
230

231
static int32_t mndCreateBnode(SMnode *pMnode, SRpcMsg *pReq, SDnodeObj *pDnode, SMCreateBnodeReq *pCreate) {
81✔
232
  int32_t code = -1;
81✔
233

234
  SBnodeObj bnodeObj = {0};
81✔
235
  bnodeObj.id = pDnode->id;
81✔
236
  bnodeObj.proto = pCreate->bnodeProto;
81✔
237
  bnodeObj.createdTime = taosGetTimestampMs();
81✔
238
  bnodeObj.updateTime = bnodeObj.createdTime;
81✔
239

240
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_ROLLBACK, TRN_CONFLICT_NOTHING, pReq, "create-bnode");
81✔
241
  if (pTrans == NULL) {
81!
242
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
243
    if (terrno != 0) code = terrno;
×
244
    goto _OVER;
×
245
  }
246
  mndTransSetSerial(pTrans);
81✔
247

248
  mInfo("trans:%d, to create bnode:%d %d", pTrans->id, pCreate->dnodeId, pCreate->bnodeProto);
81!
249

250
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoLogs(pTrans, &bnodeObj), NULL, _OVER);
81!
251
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoLogs(pTrans, &bnodeObj), NULL, _OVER);
81!
252
  TAOS_CHECK_GOTO(mndSetCreateBnodeCommitLogs(pTrans, &bnodeObj), NULL, _OVER);
81!
253
  TAOS_CHECK_GOTO(mndSetCreateBnodeRedoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
81!
254
  TAOS_CHECK_GOTO(mndSetCreateBnodeUndoActions(pTrans, pDnode, &bnodeObj), NULL, _OVER);
81!
255
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
81!
256

257
  code = 0;
81✔
258

259
_OVER:
81✔
260
  mndTransDrop(pTrans);
81✔
261
  TAOS_RETURN(code);
81✔
262
}
263

264
static int32_t mndProcessCreateBnodeReq(SRpcMsg *pReq) {
90✔
265
  SMnode          *pMnode = pReq->info.node;
90✔
266
  int32_t          code = -1;
90✔
267
  SBnodeObj       *pObj = NULL;
90✔
268
  SDnodeObj       *pDnode = NULL;
90✔
269
  SMCreateBnodeReq createReq = {0};
90✔
270

271
  TAOS_CHECK_GOTO(tDeserializeSMCreateBnodeReq(pReq->pCont, pReq->contLen, &createReq), NULL, _OVER);
90!
272

273
  mInfo("bnode:%d, start to create", createReq.dnodeId);
90!
274
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_CREATE_BNODE), NULL, _OVER);
90!
275

276
  pObj = mndAcquireBnode(pMnode, createReq.dnodeId);
90✔
277
  if (pObj != NULL) {
90!
278
    code = terrno = TSDB_CODE_MND_BNODE_ALREADY_EXIST;
×
279
    goto _OVER;
×
280
  } else if (terrno != TSDB_CODE_MND_BNODE_NOT_EXIST) {
90!
281
    code = terrno;
×
282
    goto _OVER;
×
283
  }
284

285
  pDnode = mndAcquireDnode(pMnode, createReq.dnodeId);
90✔
286
  if (pDnode == NULL) {
90✔
287
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
9✔
288
    goto _OVER;
9✔
289
  }
290

291
  code = mndCreateBnode(pMnode, pReq, pDnode, &createReq);
81✔
292
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
81!
293

294
_OVER:
×
295
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
90!
296
    mError("bnode:%d, failed to create since %s", createReq.dnodeId, tstrerror(code));
9!
297
    TAOS_RETURN(code);
9✔
298
  }
299

300
  //  mndReleaseBnode(pMnode, pObj);
301
  mndReleaseDnode(pMnode, pDnode);
81✔
302
  tFreeSMCreateBnodeReq(&createReq);
81✔
303
  TAOS_RETURN(code);
81✔
304
}
305

306
static int32_t mndSetDropBnodeRedoLogs(STrans *pTrans, SBnodeObj *pObj) {
84✔
307
  int32_t code = 0, lino = 0;
84✔
308

309
  SSdbRaw *pRedoRaw = mndBnodeActionEncode(pObj);
84✔
310
  if (pRedoRaw == NULL) {
84!
311
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
312
    if (terrno != 0) code = terrno;
×
UNCOV
313
    TAOS_RETURN(code);
×
314
  }
315
  TAOS_CHECK_GOTO(mndTransAppendGroupRedolog(pTrans, pRedoRaw, -1), &lino, _OVER);
84!
316
  TAOS_CHECK_GOTO(sdbSetRawStatus(pRedoRaw, SDB_STATUS_DROPPING), &lino, _OVER);
84!
317

318
_OVER:
84✔
319
  if (code != 0) {
84!
UNCOV
320
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
×
321
  }
322

323
  TAOS_RETURN(code);
84✔
324
}
325

326
static int32_t mndSetDropBnodeCommitLogs(STrans *pTrans, SBnodeObj *pObj) {
84✔
327
  int32_t  code = 0;
84✔
328
  SSdbRaw *pCommitRaw = mndBnodeActionEncode(pObj);
84✔
329
  if (pCommitRaw == NULL) {
84!
UNCOV
330
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
331
    if (terrno != 0) code = terrno;
×
UNCOV
332
    TAOS_RETURN(code);
×
333
  }
334
  TAOS_CHECK_RETURN(mndTransAppendCommitlog(pTrans, pCommitRaw));
84!
335
  TAOS_CHECK_RETURN(sdbSetRawStatus(pCommitRaw, SDB_STATUS_DROPPED));
84!
336
  TAOS_RETURN(code);
84✔
337
}
338

339
static int32_t mndSetDropBnodeRedoActions(STrans *pTrans, SDnodeObj *pDnode, SBnodeObj *pObj) {
84✔
340
  int32_t        code = 0;
84✔
341
  SDDropBnodeReq dropReq = {0};
84✔
342
  dropReq.dnodeId = pDnode->id;
84✔
343

344
  int32_t contLen = tSerializeSMDropBnodeReq(NULL, 0, &dropReq);
84✔
345
  void   *pReq = taosMemoryMalloc(contLen);
84!
346
  if (pReq == NULL) {
84!
UNCOV
347
    code = terrno;
×
UNCOV
348
    TAOS_RETURN(code);
×
349
  }
350
  code = tSerializeSMDropBnodeReq(pReq, contLen, &dropReq);
84✔
351
  if (code < 0) {
84!
UNCOV
352
    mError("bnode:%d, failed to serialize create drop bnode request since %s", dropReq.dnodeId, terrstr());
×
353
  }
354

355
  STransAction action = {0};
84✔
356
  action.epSet = mndGetDnodeEpset(pDnode);
84✔
357
  action.pCont = pReq;
84✔
358
  action.contLen = contLen;
84✔
359
  action.msgType = TDMT_DND_DROP_BNODE;
84✔
360
  action.acceptableCode = TSDB_CODE_BNODE_NOT_DEPLOYED;
84✔
361

362
  if ((code = mndTransAppendRedoAction(pTrans, &action)) != 0) {
84✔
363
    taosMemoryFree(pReq);
3!
364
    TAOS_RETURN(code);
3✔
365
  }
366

367
  TAOS_RETURN(code);
81✔
368
}
369

370
int32_t mndSetDropBnodeInfoToTrans(SMnode *pMnode, STrans *pTrans, SBnodeObj *pObj, bool force) {
84✔
371
  int32_t code = -1, lino = 0;
84✔
372

373
  if (pObj == NULL) return 0;
84!
374
  TAOS_CHECK_GOTO(mndSetDropBnodeRedoLogs(pTrans, pObj), &lino, _OVER);
84!
375
  TAOS_CHECK_GOTO(mndSetDropBnodeCommitLogs(pTrans, pObj), &lino, _OVER);
84!
376
  if (!force) {
84!
377
    TAOS_CHECK_GOTO(mndSetDropBnodeRedoActions(pTrans, pObj->pDnode, pObj), &lino, _OVER);
84✔
378
  }
379

380
_OVER:
81✔
381
  if (code != 0) {
84✔
382
    mError("bnode:%d, failed to drop bnode at line:%d since %s", pObj->id, lino, tstrerror(code));
3!
383
  }
384

385
  return code;
84✔
386
}
387

388
static int32_t mndDropBnode(SMnode *pMnode, SRpcMsg *pReq, SBnodeObj *pObj) {
81✔
389
  int32_t code = -1;
81✔
390

391
  STrans *pTrans = mndTransCreate(pMnode, TRN_POLICY_RETRY, TRN_CONFLICT_NOTHING, pReq, "drop-bnode");
81✔
392
  if (pTrans == NULL) {
81!
UNCOV
393
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
×
UNCOV
394
    if (terrno != 0) code = terrno;
×
UNCOV
395
    goto _OVER;
×
396
  }
397
  mndTransSetSerial(pTrans);
81✔
398

399
  mInfo("trans:%d, used to drop bnode:%d", pTrans->id, pObj->id);
81!
400
  TAOS_CHECK_GOTO(mndSetDropBnodeInfoToTrans(pMnode, pTrans, pObj, false), NULL, _OVER);
81!
401
  TAOS_CHECK_GOTO(mndTransPrepare(pMnode, pTrans), NULL, _OVER);
81!
402

403
  code = 0;
81✔
404

405
_OVER:
81✔
406
  mndTransDrop(pTrans);
81✔
407
  TAOS_RETURN(code);
81✔
408
}
409

410
static int32_t mndProcessDropBnodeReq(SRpcMsg *pReq) {
110✔
411
  SMnode        *pMnode = pReq->info.node;
110✔
412
  int32_t        code = -1;
110✔
413
  SBnodeObj     *pObj = NULL;
110✔
414
  SDnodeObj     *pDnode = NULL;
110✔
415
  SMDropBnodeReq dropReq = {0};
110✔
416

417
  TAOS_CHECK_GOTO(tDeserializeSMDropBnodeReq(pReq->pCont, pReq->contLen, &dropReq), NULL, _OVER);
110!
418

419
  mInfo("bnode:%d, start to drop", dropReq.dnodeId);
110!
420
  TAOS_CHECK_GOTO(mndCheckOperPrivilege(pMnode, pReq->info.conn.user, MND_OPER_DROP_BNODE), NULL, _OVER);
110!
421

422
  if (dropReq.dnodeId <= 0) {
110✔
423
    code = TSDB_CODE_INVALID_MSG;
6✔
424
    goto _OVER;
6✔
425
  }
426

427
  pDnode = mndAcquireDnode(pMnode, dropReq.dnodeId);
104✔
428
  if (pDnode == NULL) {
104✔
429
    code = TSDB_CODE_MND_DNODE_NOT_EXIST;
8✔
430
    goto _OVER;
8✔
431
  }
432

433
  if (!mndIsDnodeOnline(pDnode, taosGetTimestampMs())) {
96✔
434
    code = TSDB_CODE_DNODE_OFFLINE;
7✔
435
    goto _OVER;
7✔
436
  }
437

438
  pObj = mndAcquireBnode(pMnode, dropReq.dnodeId);
89✔
439
  if (pObj == NULL) {
89✔
440
    code = TSDB_CODE_MND_RETURN_VALUE_NULL;
8✔
441
    if (terrno != 0) code = terrno;
8!
442
    goto _OVER;
8✔
443
  }
444

445
  // check deletable
446
  code = mndDropBnode(pMnode, pReq, pObj);
81✔
447
  if (code == 0) code = TSDB_CODE_ACTION_IN_PROGRESS;
81!
448

449
_OVER:
×
450
  if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) {
110!
451
    mError("bnode:%d, failed to drop since %s", dropReq.dnodeId, tstrerror(code));
29!
452
  }
453

454
  mndReleaseBnode(pMnode, pObj);
110✔
455
  mndReleaseDnode(pMnode, pDnode);
110✔
456
  tFreeSMDropBnodeReq(&dropReq);
110✔
457
  TAOS_RETURN(code);
110✔
458
}
459

460
static const char *mndBnodeProtoStr(int32_t proto) {
528✔
461
  switch (proto) {
528!
462
    case TSDB_BNODE_OPT_PROTO_MQTT:
528✔
463
      return TSDB_BNODE_OPT_PROTO_STR_MQTT;
528✔
UNCOV
464
    default:
×
UNCOV
465
      break;
×
466
  }
UNCOV
467
  return "unknown";
×
468
}
469

470
static int32_t mndRetrieveBnodes(SRpcMsg *pReq, SShowObj *pShow, SSDataBlock *pBlock, int32_t rows) {
276✔
471
  SMnode    *pMnode = pReq->info.node;
276✔
472
  SSdb      *pSdb = pMnode->pSdb;
276✔
473
  int32_t    numOfRows = 0;
276✔
474
  int32_t    cols = 0;
276✔
475
  SBnodeObj *pObj = NULL;
276✔
476
  char       buf[TSDB_EP_LEN + VARSTR_HEADER_SIZE];
477

478
  while (numOfRows < rows) {
540!
479
    pShow->pIter = sdbFetch(pSdb, SDB_BNODE, pShow->pIter, (void **)&pObj);
540✔
480
    if (pShow->pIter == NULL) break;
540✔
481

482
    cols = 0;
264✔
483
    SColumnInfoData *pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
264✔
484
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->id, false), pSdb, pObj);
264!
485

486
    char mqtt_ep[TSDB_EP_LEN] = {0};
264✔
487
    char ep[TSDB_EP_LEN + VARSTR_HEADER_SIZE] = {0};
264✔
488

489
    TAOS_UNUSED(tsnprintf(mqtt_ep, TSDB_EP_LEN - 1, "%s:%hu", pObj->pDnode->fqdn, tsMqttPort));
264✔
490
    STR_WITH_MAXSIZE_TO_VARSTR(ep, mqtt_ep, pShow->pMeta->pSchemas[cols].bytes);
264✔
491

492
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
264✔
493
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)ep, false), pSdb, pObj);
264!
494

495
    STR_TO_VARSTR(buf, mndBnodeProtoStr(pObj->proto));
264✔
496
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
264✔
497
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)buf, false), pSdb, pObj);
264!
498

499
    pColInfo = taosArrayGet(pBlock->pDataBlock, cols++);
264✔
500
    TAOS_CHECK_RETURN_WITH_RELEASE(colDataSetVal(pColInfo, numOfRows, (const char *)&pObj->createdTime, false), pSdb,
264!
501
                                   pObj);
502

503
    numOfRows++;
264✔
504
    sdbRelease(pSdb, pObj);
264✔
505
  }
506

507
  pShow->numOfRows += numOfRows;
276✔
508

509
  return numOfRows;
276✔
510
}
511

UNCOV
512
static void mndCancelGetNextBnode(SMnode *pMnode, void *pIter) {
×
UNCOV
513
  SSdb *pSdb = pMnode->pSdb;
×
UNCOV
514
  sdbCancelFetchByType(pSdb, pIter, SDB_BNODE);
×
UNCOV
515
}
×
516

UNCOV
517
SEpSet mndAcquireEpFromBnode(SMnode *pMnode, const SBnodeObj *pBnode) {
×
UNCOV
518
  SEpSet epSet = {.numOfEps = 1, .inUse = 0};
×
UNCOV
519
  memcpy(epSet.eps[0].fqdn, pBnode->pDnode->fqdn, TSDB_FQDN_LEN);
×
UNCOV
520
  epSet.eps[0].port = pBnode->pDnode->port;
×
UNCOV
521
  return epSet;
×
522
}
523

524
SBnodeObj *mndAcquireBnode(SMnode *pMnode, int32_t dnodeId) {
230✔
525
  SBnodeObj *pObj = sdbAcquire(pMnode->pSdb, SDB_BNODE, &dnodeId);
230✔
526
  if (pObj == NULL && terrno == TSDB_CODE_SDB_OBJ_NOT_THERE) {
230!
527
    terrno = TSDB_CODE_MND_BNODE_NOT_EXIST;
146✔
528
  }
529
  return pObj;
230✔
530
}
531

532
void mndReleaseBnode(SMnode *pMnode, SBnodeObj *pObj) {
163✔
533
  SSdb *pSdb = pMnode->pSdb;
163✔
534
  sdbRelease(pSdb, pObj);
163✔
535
}
163✔
536

537
int32_t mndInitBnode(SMnode *pMnode) {
2,560✔
538
  SSdbTable table = {
2,560✔
539
      .sdbType = SDB_BNODE,
540
      .keyType = SDB_KEY_INT32,
541
      .encodeFp = (SdbEncodeFp)mndBnodeActionEncode,
542
      .decodeFp = (SdbDecodeFp)mndBnodeActionDecode,
543
      .insertFp = (SdbInsertFp)mndBnodeActionInsert,
544
      .updateFp = (SdbUpdateFp)mndBnodeActionUpdate,
545
      .deleteFp = (SdbDeleteFp)mndBnodeActionDelete,
546
  };
547

548
  mndSetMsgHandle(pMnode, TDMT_MND_CREATE_BNODE, mndProcessCreateBnodeReq);
2,560✔
549
  mndSetMsgHandle(pMnode, TDMT_MND_DROP_BNODE, mndProcessDropBnodeReq);
2,560✔
550
  mndSetMsgHandle(pMnode, TDMT_DND_CREATE_BNODE_RSP, mndTransProcessRsp);
2,560✔
551
  mndSetMsgHandle(pMnode, TDMT_DND_DROP_BNODE_RSP, mndTransProcessRsp);
2,560✔
552

553
  mndAddShowRetrieveHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndRetrieveBnodes);
2,560✔
554
  mndAddShowFreeIterHandle(pMnode, TSDB_MGMT_TABLE_BNODE, mndCancelGetNextBnode);
2,560✔
555

556
  return sdbSetTable(pMnode->pSdb, table);
2,560✔
557
}
558

559
void mndCleanupBnode(SMnode *pMnode) {}
2,557✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc