• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 16047898469

03 Jul 2025 10:22AM UTC coverage: 21.529% (-0.02%) from 21.545%
16047898469

Pull #5426

github

zhangzujian
fix setting LR option always_learn_from_arp_request

Signed-off-by: zhangzujian <zhangzujian.7@gmail.com>
Pull Request #5426: fix setting LR option always_learn_from_arp_request

1 of 26 new or added lines in 2 files covered. (3.85%)

5 existing lines in 3 files now uncovered.

10511 of 48823 relevant lines covered (21.53%)

0.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/pkg/controller/vpc.go
1
package controller
2

3
import (
4
        "context"
5
        "encoding/json"
6
        "errors"
7
        "fmt"
8
        "maps"
9
        "math"
10
        "net"
11
        "reflect"
12
        "slices"
13
        "sort"
14
        "strings"
15
        "time"
16

17
        v1 "k8s.io/api/core/v1"
18
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
19
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
20
        "k8s.io/apimachinery/pkg/labels"
21
        "k8s.io/apimachinery/pkg/types"
22
        "k8s.io/client-go/tools/cache"
23
        "k8s.io/klog/v2"
24
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
25

26
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
27
        "github.com/kubeovn/kube-ovn/pkg/ovsdb/ovnnb"
28
        "github.com/kubeovn/kube-ovn/pkg/util"
29
)
30

31
func (c *Controller) enqueueAddVpc(obj any) {
×
32
        vpc := obj.(*kubeovnv1.Vpc)
×
33
        key := cache.MetaObjectToName(vpc).String()
×
34
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !ok {
×
35
                klog.V(3).Infof("enqueue add vpc %s", key)
×
36
                c.addOrUpdateVpcQueue.Add(key)
×
37
        }
×
38
}
39

40
func vpcBFDPortChanged(oldObj, newObj *kubeovnv1.BFDPort) bool {
×
41
        if oldObj == nil && newObj == nil {
×
42
                return false
×
43
        }
×
44
        if oldObj == nil || newObj == nil {
×
45
                return true
×
46
        }
×
47
        return oldObj.Enabled != newObj.Enabled || oldObj.IP != newObj.IP || !reflect.DeepEqual(oldObj.NodeSelector, newObj.NodeSelector)
×
48
}
49

50
func (c *Controller) enqueueUpdateVpc(oldObj, newObj any) {
×
51
        oldVpc := oldObj.(*kubeovnv1.Vpc)
×
52
        newVpc := newObj.(*kubeovnv1.Vpc)
×
53

×
54
        if !newVpc.DeletionTimestamp.IsZero() ||
×
55
                !slices.Equal(oldVpc.Spec.Namespaces, newVpc.Spec.Namespaces) ||
×
56
                !reflect.DeepEqual(oldVpc.Spec.StaticRoutes, newVpc.Spec.StaticRoutes) ||
×
57
                !reflect.DeepEqual(oldVpc.Spec.PolicyRoutes, newVpc.Spec.PolicyRoutes) ||
×
58
                !reflect.DeepEqual(oldVpc.Spec.VpcPeerings, newVpc.Spec.VpcPeerings) ||
×
59
                !maps.Equal(oldVpc.Annotations, newVpc.Annotations) ||
×
60
                !slices.Equal(oldVpc.Spec.ExtraExternalSubnets, newVpc.Spec.ExtraExternalSubnets) ||
×
61
                oldVpc.Spec.EnableExternal != newVpc.Spec.EnableExternal ||
×
62
                oldVpc.Spec.EnableBfd != newVpc.Spec.EnableBfd ||
×
63
                vpcBFDPortChanged(oldVpc.Spec.BFDPort, newVpc.Spec.BFDPort) ||
×
NEW
64
                oldVpc.Labels[util.VpcExternalLabel] != newVpc.Labels[util.VpcExternalLabel] ||
×
NEW
65
                !slices.Equal(oldVpc.Status.Subnets, newVpc.Status.Subnets) {
×
66
                // TODO:// label VpcExternalLabel replace with spec enable external
×
67

×
68
                if newVpc.Annotations == nil {
×
69
                        newVpc.Annotations = make(map[string]string)
×
70
                }
×
71
                newVpc.Annotations[util.VpcLastPolicies] = convertPolicies(oldVpc.Spec.PolicyRoutes)
×
72

×
73
                key := cache.MetaObjectToName(newVpc).String()
×
74
                klog.Infof("enqueue update vpc %s", key)
×
75
                c.addOrUpdateVpcQueue.Add(key)
×
76
        }
77
}
78

79
func (c *Controller) enqueueDelVpc(obj any) {
×
80
        vpc := obj.(*kubeovnv1.Vpc)
×
81
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !vpc.Status.Default || !ok {
×
82
                klog.V(3).Infof("enqueue delete vpc %s", vpc.Name)
×
83
                c.delVpcQueue.Add(vpc)
×
84
        }
×
85
}
86

87
func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {
×
88
        c.vpcKeyMutex.LockKey(vpc.Name)
×
89
        defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()
×
90
        klog.Infof("handle delete vpc %s", vpc.Name)
×
91

×
92
        // should delete vpc subnets first
×
93
        var err error
×
94
        for _, subnet := range vpc.Status.Subnets {
×
95
                if _, err = c.subnetsLister.Get(subnet); err != nil {
×
96
                        if k8serrors.IsNotFound(err) {
×
97
                                continue
×
98
                        }
99
                        err = fmt.Errorf("failed to get subnet %s for vpc %s: %w", subnet, vpc.Name, err)
×
100
                } else {
×
101
                        err = fmt.Errorf("failed to delete vpc %s, please delete subnet %s first", vpc.Name, subnet)
×
102
                }
×
103
                klog.Error(err)
×
104
                return err
×
105
        }
106

107
        if err := c.deleteVpcLb(vpc); err != nil {
×
108
                klog.Error(err)
×
109
                return err
×
110
        }
×
111

112
        if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
113
                klog.Errorf("failed to delete external connection for vpc %s, error %v", vpc.Name, err)
×
114
                return err
×
115
        }
×
116

117
        for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
118
                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
119
                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
120
                        klog.Error(err)
×
121
                        return err
×
122
                }
×
123
        }
124

125
        if err := c.deleteVpcRouter(vpc.Status.Router); err != nil {
×
126
                klog.Error(err)
×
127
                return err
×
128
        }
×
129

130
        return nil
×
131
}
132

133
func (c *Controller) handleUpdateVpcStatus(key string) error {
×
134
        c.vpcKeyMutex.LockKey(key)
×
135
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
136
        klog.Infof("handle status update for vpc %s", key)
×
137

×
138
        cachedVpc, err := c.vpcsLister.Get(key)
×
139
        if err != nil {
×
140
                if k8serrors.IsNotFound(err) {
×
141
                        return nil
×
142
                }
×
143
                klog.Error(err)
×
144
                return err
×
145
        }
146
        vpc := cachedVpc.DeepCopy()
×
147

×
148
        subnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
149
        if err != nil {
×
150
                klog.Error(err)
×
151
                return err
×
152
        }
×
153

154
        change := vpc.Status.DefaultLogicalSwitch != defaultSubnet
×
155

×
156
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
157
        vpc.Status.Subnets = subnets
×
158

×
159
        if !vpc.Spec.BFDPort.IsEnabled() && !vpc.Status.BFDPort.IsEmpty() {
×
160
                vpc.Status.BFDPort.Clear()
×
161
        }
×
162
        bytes, err := vpc.Status.Bytes()
×
163
        if err != nil {
×
164
                klog.Error(err)
×
165
                return err
×
166
        }
×
167

168
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
169
        if err != nil {
×
170
                klog.Error(err)
×
171
                return err
×
172
        }
×
173

174
        if len(vpc.Status.Subnets) == 0 {
×
175
                klog.Infof("vpc %s has no subnets, add to queue", vpc.Name)
×
176
                c.addOrUpdateVpcQueue.AddAfter(vpc.Name, 5*time.Second)
×
177
        }
×
178

179
        if change {
×
180
                for _, ns := range vpc.Spec.Namespaces {
×
181
                        c.addNamespaceQueue.Add(ns)
×
182
                }
×
183
        }
184

185
        natGws, err := c.vpcNatGatewayLister.List(labels.Everything())
×
186
        if err != nil {
×
187
                klog.Error(err)
×
188
                return err
×
189
        }
×
190
        for _, gw := range natGws {
×
191
                if key == gw.Spec.Vpc {
×
192
                        c.updateVpcSubnetQueue.Add(gw.Name)
×
193
                }
×
194
        }
195
        return nil
×
196
}
197

198
type VpcLoadBalancer struct {
199
        TCPLoadBalancer      string
200
        TCPSessLoadBalancer  string
201
        UDPLoadBalancer      string
202
        UDPSessLoadBalancer  string
203
        SctpLoadBalancer     string
204
        SctpSessLoadBalancer string
205
}
206

207
func (c *Controller) GenVpcLoadBalancer(vpcKey string) *VpcLoadBalancer {
×
208
        if vpcKey == c.config.ClusterRouter || vpcKey == "" {
×
209
                return &VpcLoadBalancer{
×
210
                        TCPLoadBalancer:      c.config.ClusterTCPLoadBalancer,
×
211
                        TCPSessLoadBalancer:  c.config.ClusterTCPSessionLoadBalancer,
×
212
                        UDPLoadBalancer:      c.config.ClusterUDPLoadBalancer,
×
213
                        UDPSessLoadBalancer:  c.config.ClusterUDPSessionLoadBalancer,
×
214
                        SctpLoadBalancer:     c.config.ClusterSctpLoadBalancer,
×
215
                        SctpSessLoadBalancer: c.config.ClusterSctpSessionLoadBalancer,
×
216
                }
×
217
        }
×
218
        return &VpcLoadBalancer{
×
219
                TCPLoadBalancer:      fmt.Sprintf("vpc-%s-tcp-load", vpcKey),
×
220
                TCPSessLoadBalancer:  fmt.Sprintf("vpc-%s-tcp-sess-load", vpcKey),
×
221
                UDPLoadBalancer:      fmt.Sprintf("vpc-%s-udp-load", vpcKey),
×
222
                UDPSessLoadBalancer:  fmt.Sprintf("vpc-%s-udp-sess-load", vpcKey),
×
223
                SctpLoadBalancer:     fmt.Sprintf("vpc-%s-sctp-load", vpcKey),
×
224
                SctpSessLoadBalancer: fmt.Sprintf("vpc-%s-sctp-sess-load", vpcKey),
×
225
        }
×
226
}
227

228
func (c *Controller) addLoadBalancer(vpc string) (*VpcLoadBalancer, error) {
×
229
        vpcLbConfig := c.GenVpcLoadBalancer(vpc)
×
230
        if err := c.initLB(vpcLbConfig.TCPLoadBalancer, string(v1.ProtocolTCP), false); err != nil {
×
231
                return nil, err
×
232
        }
×
233
        if err := c.initLB(vpcLbConfig.TCPSessLoadBalancer, string(v1.ProtocolTCP), true); err != nil {
×
234
                return nil, err
×
235
        }
×
236
        if err := c.initLB(vpcLbConfig.UDPLoadBalancer, string(v1.ProtocolUDP), false); err != nil {
×
237
                return nil, err
×
238
        }
×
239
        if err := c.initLB(vpcLbConfig.UDPSessLoadBalancer, string(v1.ProtocolUDP), true); err != nil {
×
240
                return nil, err
×
241
        }
×
242
        if err := c.initLB(vpcLbConfig.SctpLoadBalancer, string(v1.ProtocolSCTP), false); err != nil {
×
243
                return nil, err
×
244
        }
×
245
        if err := c.initLB(vpcLbConfig.SctpSessLoadBalancer, string(v1.ProtocolSCTP), true); err != nil {
×
246
                return nil, err
×
247
        }
×
248

249
        return vpcLbConfig, nil
×
250
}
251

252
func (c *Controller) handleAddOrUpdateVpc(key string) error {
×
253
        c.vpcKeyMutex.LockKey(key)
×
254
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
255
        klog.Infof("handle add/update vpc %s", key)
×
256

×
257
        cachedVpc, err := c.vpcsLister.Get(key)
×
258
        if err != nil {
×
259
                if k8serrors.IsNotFound(err) {
×
260
                        return nil
×
261
                }
×
262
                klog.Error(err)
×
263
                return err
×
264
        }
265

266
        vpc, err := c.formatVpc(cachedVpc.DeepCopy())
×
267
        if err != nil {
×
268
                klog.Errorf("failed to format vpc %s: %v", key, err)
×
269
                return err
×
270
        }
×
271

NEW
272
        learnFromARPRequest := vpc.Spec.EnableExternal
×
NEW
273
        if !learnFromARPRequest {
×
NEW
274
                for _, subnetName := range vpc.Status.Subnets {
×
NEW
275
                        subnet, err := c.subnetsLister.Get(subnetName)
×
NEW
276
                        if err != nil {
×
NEW
277
                                if k8serrors.IsNotFound(err) {
×
NEW
278
                                        continue
×
279
                                }
NEW
280
                                klog.Errorf("failed to get subnet %s for vpc %s: %v", subnetName, key, err)
×
NEW
281
                                return err
×
282
                        }
NEW
283
                        if subnet.Spec.Vlan != "" && subnet.Spec.U2OInterconnection {
×
NEW
284
                                learnFromARPRequest = true
×
NEW
285
                                break
×
286
                        }
287
                }
288
        }
289

NEW
290
        if err = c.createVpcRouter(key, learnFromARPRequest); err != nil {
×
291
                klog.Errorf("failed to create vpc router for vpc %s: %v", key, err)
×
292
                return err
×
293
        }
×
294

295
        var newPeers []string
×
296
        for _, peering := range vpc.Spec.VpcPeerings {
×
297
                if err = util.CheckCidrs(peering.LocalConnectIP); err != nil {
×
298
                        klog.Errorf("invalid cidr %s", peering.LocalConnectIP)
×
299
                        return err
×
300
                }
×
301

302
                newPeers = append(newPeers, peering.RemoteVpc)
×
303
                if err := c.OVNNbClient.CreatePeerRouterPort(vpc.Name, peering.RemoteVpc, peering.LocalConnectIP); err != nil {
×
304
                        klog.Errorf("create peer router port for vpc %s, %v", vpc.Name, err)
×
305
                        return err
×
306
                }
×
307
        }
308
        for _, oldPeer := range vpc.Status.VpcPeerings {
×
309
                if !slices.Contains(newPeers, oldPeer) {
×
310
                        if err = c.OVNNbClient.DeleteLogicalRouterPort(fmt.Sprintf("%s-%s", vpc.Name, oldPeer)); err != nil {
×
311
                                klog.Errorf("delete peer router port for vpc %s, %v", vpc.Name, err)
×
312
                                return err
×
313
                        }
×
314
                }
315
        }
316

317
        // handle static route
318
        var (
×
319
                staticExistedRoutes []*ovnnb.LogicalRouterStaticRoute
×
320
                staticTargetRoutes  []*kubeovnv1.StaticRoute
×
321
                staticRouteMapping  map[string][]*kubeovnv1.StaticRoute
×
322
        )
×
323

×
324
        staticExistedRoutes, err = c.OVNNbClient.ListLogicalRouterStaticRoutes(vpc.Name, nil, nil, "", nil)
×
325
        if err != nil {
×
326
                klog.Errorf("failed to get vpc %s static route list, %v", vpc.Name, err)
×
327
                return err
×
328
        }
×
329

330
        var externalSubnet *kubeovnv1.Subnet
×
331
        externalSubnetExist := false
×
332
        externalSubnetGW := ""
×
333
        if c.config.EnableEipSnat {
×
334
                externalSubnet, err = c.subnetsLister.Get(c.config.ExternalGatewaySwitch)
×
335
                if err != nil {
×
336
                        klog.Warningf("enable-eip-snat need external subnet %s to be exist: %v", c.config.ExternalGatewaySwitch, err)
×
337
                } else {
×
338
                        if !externalSubnet.Spec.LogicalGateway {
×
339
                                // logical gw external subnet can not access external
×
340
                                externalSubnetExist = true
×
341
                                externalSubnetGW = externalSubnet.Spec.Gateway
×
342
                        } else {
×
343
                                klog.Infof("default external subnet %s using logical gw", c.config.ExternalGatewaySwitch)
×
344
                        }
×
345
                }
346
        }
347

348
        staticRouteMapping = c.getRouteTablesByVpc(vpc)
×
349
        staticTargetRoutes = vpc.Spec.StaticRoutes
×
350
        if vpc.Name == c.config.ClusterRouter {
×
351
                if _, ok := staticRouteMapping[util.MainRouteTable]; !ok {
×
352
                        staticRouteMapping[util.MainRouteTable] = nil
×
353
                }
×
354

355
                joinSubnet, err := c.subnetsLister.Get(c.config.NodeSwitch)
×
356
                if err != nil {
×
357
                        if !k8serrors.IsNotFound(err) {
×
358
                                klog.Errorf("failed to get node switch subnet %s: %v", c.config.NodeSwitch, err)
×
359
                                return err
×
360
                        }
×
361
                        c.addOrUpdateVpcQueue.Add(vpc.Name)
×
362
                        return nil
×
363
                }
364
                gatewayV4, gatewayV6 := util.SplitStringIP(joinSubnet.Spec.Gateway)
×
365
                if gatewayV4 != "" {
×
366
                        for table := range staticRouteMapping {
×
367
                                staticTargetRoutes = append(
×
368
                                        staticTargetRoutes,
×
369
                                        &kubeovnv1.StaticRoute{
×
370
                                                Policy:     kubeovnv1.PolicyDst,
×
371
                                                CIDR:       "0.0.0.0/0",
×
372
                                                NextHopIP:  gatewayV4,
×
373
                                                RouteTable: table,
×
374
                                        },
×
375
                                )
×
376
                        }
×
377
                }
378
                if gatewayV6 != "" {
×
379
                        for table := range staticRouteMapping {
×
380
                                staticTargetRoutes = append(
×
381
                                        staticTargetRoutes,
×
382
                                        &kubeovnv1.StaticRoute{
×
383
                                                Policy:     kubeovnv1.PolicyDst,
×
384
                                                CIDR:       "::/0",
×
385
                                                NextHopIP:  gatewayV6,
×
386
                                                RouteTable: table,
×
387
                                        },
×
388
                                )
×
389
                        }
×
390
                }
391
                if c.config.EnableEipSnat {
×
392
                        cm, err := c.configMapsLister.ConfigMaps(c.config.ExternalGatewayConfigNS).Get(util.ExternalGatewayConfig)
×
393
                        if err == nil {
×
394
                                nextHop := cm.Data["external-gw-addr"]
×
395
                                if nextHop == "" {
×
396
                                        if !externalSubnetExist {
×
397
                                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
398
                                                klog.Error(err)
×
399
                                                return err
×
400
                                        }
×
401
                                        nextHop = externalSubnet.Spec.Gateway
×
402
                                        if nextHop == "" {
×
403
                                                err := fmt.Errorf("subnet %s has no gateway configuration", externalSubnet.Name)
×
404
                                                klog.Error(err)
×
405
                                                return err
×
406
                                        }
×
407
                                }
408
                                if strings.Contains(nextHop, "/") {
×
409
                                        nextHop = strings.Split(nextHop, "/")[0]
×
410
                                }
×
411

412
                                lr, err := c.OVNNbClient.GetLogicalRouter(vpc.Name, false)
×
413
                                if err != nil {
×
414
                                        klog.Errorf("failed to get logical router %s: %v", vpc.Name, err)
×
415
                                        return err
×
416
                                }
×
417

418
                                for _, nat := range lr.Nat {
×
419
                                        info, err := c.OVNNbClient.GetNATByUUID(nat)
×
420
                                        if err != nil {
×
421
                                                klog.Errorf("failed to get nat ip info for vpc %s, %v", vpc.Name, err)
×
422
                                                return err
×
423
                                        }
×
424
                                        if info.LogicalIP != "" {
×
425
                                                for table := range staticRouteMapping {
×
426
                                                        staticTargetRoutes = append(
×
427
                                                                staticTargetRoutes,
×
428
                                                                &kubeovnv1.StaticRoute{
×
429
                                                                        Policy:     kubeovnv1.PolicySrc,
×
430
                                                                        CIDR:       info.LogicalIP,
×
431
                                                                        NextHopIP:  nextHop,
×
432
                                                                        RouteTable: table,
×
433
                                                                },
×
434
                                                        )
×
435
                                                }
×
436
                                        }
437
                                }
438
                        }
439
                }
440
        }
441

442
        routeNeedDel, routeNeedAdd, err := diffStaticRoute(staticExistedRoutes, staticTargetRoutes)
×
443
        if err != nil {
×
444
                klog.Errorf("failed to diff vpc %s static route, %v", vpc.Name, err)
×
445
                return err
×
446
        }
×
447

448
        for _, item := range routeNeedDel {
×
449
                klog.Infof("vpc %s del static route: %+v", vpc.Name, item)
×
450
                policy := convertPolicy(item.Policy)
×
451
                if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(vpc.Name, &item.RouteTable, &policy, item.CIDR, item.NextHopIP); err != nil {
×
452
                        klog.Errorf("del vpc %s static route failed, %v", vpc.Name, err)
×
453
                        return err
×
454
                }
×
455
        }
456

457
        for _, item := range routeNeedAdd {
×
458
                if item.BfdID != "" {
×
459
                        klog.Infof("vpc %s add static ecmp route: %+v", vpc.Name, item)
×
460
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
461
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, &item.BfdID, nil, item.NextHopIP,
×
462
                        ); err != nil {
×
463
                                klog.Errorf("failed to add bfd static route to vpc %s , %v", vpc.Name, err)
×
464
                                return err
×
465
                        }
×
466
                } else {
×
467
                        klog.Infof("vpc %s add static route: %+v", vpc.Name, item)
×
468
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
469
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, nil, nil, item.NextHopIP,
×
470
                        ); err != nil {
×
471
                                klog.Errorf("failed to add normal static route to vpc %s , %v", vpc.Name, err)
×
472
                                return err
×
473
                        }
×
474
                }
475
        }
476

477
        // handle policy route
478
        var (
×
479
                policyRouteExisted, policyRouteNeedDel, policyRouteNeedAdd []*kubeovnv1.PolicyRoute
×
480
                policyRouteLogical                                         []*ovnnb.LogicalRouterPolicy
×
481
                externalIDs                                                = map[string]string{"vendor": util.CniTypeName}
×
482
        )
×
483

×
484
        if vpc.Name == c.config.ClusterRouter {
×
485
                policyRouteExisted = reversePolicies(vpc.Annotations[util.VpcLastPolicies])
×
486
                // diff list
×
487
                policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithExisted(policyRouteExisted, vpc.Spec.PolicyRoutes)
×
488
        } else {
×
489
                if vpc.Spec.PolicyRoutes == nil {
×
490
                        // do not clean default vpc policy routes
×
491
                        if err = c.OVNNbClient.ClearLogicalRouterPolicy(vpc.Name); err != nil {
×
492
                                klog.Errorf("clean all vpc %s policy route failed, %v", vpc.Name, err)
×
493
                                return err
×
494
                        }
×
495
                } else {
×
496
                        policyRouteLogical, err = c.OVNNbClient.ListLogicalRouterPolicies(vpc.Name, -1, nil, true)
×
497
                        if err != nil {
×
498
                                klog.Errorf("failed to get vpc %s policy route list, %v", vpc.Name, err)
×
499
                                return err
×
500
                        }
×
501
                        // diff vpc policy route
502
                        policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithLogical(policyRouteLogical, vpc.Spec.PolicyRoutes)
×
503
                }
504
        }
505
        // delete policies non-exist
506
        for _, item := range policyRouteNeedDel {
×
507
                klog.Infof("delete policy route for router: %s, priority: %d, match %s", vpc.Name, item.Priority, item.Match)
×
508
                if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpc.Name, item.Priority, item.Match); err != nil {
×
509
                        klog.Errorf("del vpc %s policy route failed, %v", vpc.Name, err)
×
510
                        return err
×
511
                }
×
512
        }
513
        // add new policies
514
        for _, item := range policyRouteNeedAdd {
×
515
                klog.Infof("add policy route for router: %s, match %s, action %s, nexthop %s, externalID %v", c.config.ClusterRouter, item.Match, string(item.Action), item.NextHopIP, externalIDs)
×
516
                if err = c.OVNNbClient.AddLogicalRouterPolicy(vpc.Name, item.Priority, item.Match, string(item.Action), []string{item.NextHopIP}, nil, externalIDs); err != nil {
×
517
                        klog.Errorf("add policy route to vpc %s failed, %v", vpc.Name, err)
×
518
                        return err
×
519
                }
×
520
        }
521

522
        vpcSubnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
523
        if err != nil {
×
524
                klog.Error(err)
×
525
                return err
×
526
        }
×
527

528
        vpc.Status.Subnets = vpcSubnets
×
529
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
530
        vpc.Status.Router = key
×
531
        vpc.Status.Standby = true
×
532
        vpc.Status.VpcPeerings = newPeers
×
533
        if c.config.EnableLb {
×
534
                vpcLb, err := c.addLoadBalancer(key)
×
535
                if err != nil {
×
536
                        klog.Error(err)
×
537
                        return err
×
538
                }
×
539
                vpc.Status.TCPLoadBalancer = vpcLb.TCPLoadBalancer
×
540
                vpc.Status.TCPSessionLoadBalancer = vpcLb.TCPSessLoadBalancer
×
541
                vpc.Status.UDPLoadBalancer = vpcLb.UDPLoadBalancer
×
542
                vpc.Status.UDPSessionLoadBalancer = vpcLb.UDPSessLoadBalancer
×
543
                vpc.Status.SctpLoadBalancer = vpcLb.SctpLoadBalancer
×
544
                vpc.Status.SctpSessionLoadBalancer = vpcLb.SctpSessLoadBalancer
×
545
        }
546
        bytes, err := vpc.Status.Bytes()
×
547
        if err != nil {
×
548
                klog.Error(err)
×
549
                return err
×
550
        }
×
551
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
552
        if err != nil {
×
553
                klog.Error(err)
×
554
                return err
×
555
        }
×
556

557
        if len(vpc.Annotations) != 0 && strings.ToLower(vpc.Annotations[util.VpcLbAnnotation]) == "on" {
×
558
                if err = c.createVpcLb(vpc); err != nil {
×
559
                        klog.Error(err)
×
560
                        return err
×
561
                }
×
562
        } else if err = c.deleteVpcLb(vpc); err != nil {
×
563
                klog.Error(err)
×
564
                return err
×
565
        }
×
566

567
        subnets, err := c.subnetsLister.List(labels.Everything())
×
568
        if err != nil {
×
569
                klog.Error(err)
×
570
                return err
×
571
        }
×
572
        custVpcEnableExternalEcmp := false
×
573
        for _, subnet := range subnets {
×
574
                if subnet.Spec.Vpc == key {
×
575
                        c.addOrUpdateSubnetQueue.Add(subnet.Name)
×
576
                        if vpc.Name != util.DefaultVpc && vpc.Spec.EnableBfd && subnet.Spec.EnableEcmp {
×
577
                                custVpcEnableExternalEcmp = true
×
578
                        }
×
579
                }
580
        }
581

582
        if vpc.Spec.EnableExternal || vpc.Status.EnableExternal {
×
583
                if err = c.handleUpdateVpcExternal(cachedVpc, custVpcEnableExternalEcmp, externalSubnetExist, externalSubnetGW); err != nil {
×
584
                        klog.Errorf("failed to handle update external subnet for vpc %s, %v", key, err)
×
585
                        return err
×
586
                }
×
587
        }
588

589
        bfdPortName, bfdPortNodes, err := c.reconcileVpcBfdLRP(vpc)
×
590
        if err != nil {
×
591
                klog.Error(err)
×
592
                return err
×
593
        }
×
594
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
595
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{}
×
596
        } else {
×
597
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{
×
598
                        Name:  bfdPortName,
×
599
                        IP:    vpc.Spec.BFDPort.IP,
×
600
                        Nodes: bfdPortNodes,
×
601
                }
×
602
        }
×
603
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().
×
604
                UpdateStatus(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
605
                klog.Error(err)
×
606
                return err
×
607
        }
×
608

609
        return nil
×
610
}
611

612
func (c *Controller) handleUpdateVpcExternal(vpc *kubeovnv1.Vpc, custVpcEnableExternalEcmp, defaultExternalSubnetExist bool, externalSubnetGW string) error {
×
613
        if c.config.EnableEipSnat && vpc.Name == util.DefaultVpc {
×
614
                klog.Infof("external_gw handle ovn default external gw %s", vpc.Name)
×
615
                return nil
×
616
        }
×
617

618
        if !vpc.Spec.EnableExternal && !vpc.Status.EnableExternal {
×
619
                // no need to handle external connection
×
620
                return nil
×
621
        }
×
622

623
        // handle any vpc external
624
        if vpc.Spec.EnableExternal && !defaultExternalSubnetExist && vpc.Spec.ExtraExternalSubnets == nil {
×
625
                // at least have a external subnet
×
626
                err := fmt.Errorf("failed to get external subnet for enable external vpc %s", vpc.Name)
×
627
                klog.Error(err)
×
628
                return err
×
629
        }
×
630

631
        if !vpc.Spec.EnableExternal && vpc.Status.EnableExternal {
×
632
                // just del all external subnets connection
×
633
                klog.Infof("disconnect default external subnet %s to vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)
×
634
                if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
635
                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)
×
636
                        return err
×
637
                }
×
638
                for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
639
                        klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)
×
640
                        if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
641
                                klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
642
                                return err
×
643
                        }
×
644
                }
645
        }
646

647
        if vpc.Spec.EnableExternal {
×
648
                if !vpc.Status.EnableExternal {
×
649
                        // just add external connection
×
650
                        if vpc.Spec.ExtraExternalSubnets == nil && defaultExternalSubnetExist {
×
651
                                // only connect default external subnet
×
652
                                klog.Infof("connect default external subnet %s with vpc %s", c.config.ExternalGatewaySwitch, vpc.Name)
×
653
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
654
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", c.config.ExternalGatewaySwitch, vpc.Name, err)
×
655
                                        return err
×
656
                                }
×
657
                        }
658

659
                        // only connect provider network vlan external subnet
660
                        for _, subnet := range vpc.Spec.ExtraExternalSubnets {
×
661
                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)
×
662
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
663
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
664
                                        return err
×
665
                                }
×
666
                        }
667
                }
668

669
                // diff to add
670
                for _, subnet := range vpc.Spec.ExtraExternalSubnets {
×
671
                        if !slices.Contains(vpc.Status.ExtraExternalSubnets, subnet) {
×
672
                                klog.Infof("connect external subnet %s with vpc %s", subnet, vpc.Name)
×
673
                                if err := c.handleAddVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
674
                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
675
                                        return err
×
676
                                }
×
677
                        }
678
                }
679

680
                // diff to del
681
                for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
682
                        if !slices.Contains(vpc.Spec.ExtraExternalSubnets, subnet) {
×
683
                                klog.Infof("disconnect external subnet %s to vpc %s", subnet, vpc.Name)
×
684
                                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
685
                                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnet, vpc.Name, err)
×
686
                                        return err
×
687
                                }
×
688
                        }
689
                }
690
        }
691

692
        // custom vpc enable bfd
693
        if vpc.Spec.EnableBfd && vpc.Name != util.DefaultVpc && defaultExternalSubnetExist {
×
694
                // create bfd between lrp and physical switch gw
×
695
                // bfd status down means current lrp binding chassis node external nic lost external network connectivity
×
696
                // should switch lrp to another node
×
697
                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)
×
698
                v4ExtGw, _ := util.SplitStringIP(externalSubnetGW)
×
699
                // TODO: dualstack
×
700
                if _, err := c.OVNNbClient.CreateBFD(lrpEipName, v4ExtGw, c.config.BfdMinRx, c.config.BfdMinTx, c.config.BfdDetectMult, nil); err != nil {
×
701
                        klog.Error(err)
×
702
                        return err
×
703
                }
×
704
                // TODO: support multi external nic
705
                if custVpcEnableExternalEcmp {
×
706
                        klog.Infof("remove normal static ecmp route for vpc %s", vpc.Name)
×
707
                        // auto remove normal type static route, if using ecmp based bfd
×
708
                        if err := c.reconcileCustomVpcDelNormalStaticRoute(vpc.Name); err != nil {
×
709
                                klog.Errorf("failed to reconcile del vpc %q normal static route", vpc.Name)
×
710
                                return err
×
711
                        }
×
712
                }
713
        }
714

715
        if !vpc.Spec.EnableBfd && vpc.Status.EnableBfd {
×
716
                lrpEipName := fmt.Sprintf("%s-%s", vpc.Name, c.config.ExternalGatewaySwitch)
×
717
                if err := c.OVNNbClient.DeleteBFDByDstIP(lrpEipName, ""); err != nil {
×
718
                        klog.Error(err)
×
719
                        return err
×
720
                }
×
721
                if err := c.handleDeleteVpcStaticRoute(vpc.Name); err != nil {
×
722
                        klog.Errorf("failed to delete bfd route for vpc %s, error %v", vpc.Name, err)
×
723
                        return err
×
724
                }
×
725
        }
726

727
        if err := c.updateVpcExternalStatus(vpc.Name, vpc.Spec.EnableExternal); err != nil {
×
728
                klog.Errorf("failed to update vpc external subnets status, %v", err)
×
729
                return err
×
730
        }
×
731
        return nil
×
732
}
733

734
func (c *Controller) reconcileVpcBfdLRP(vpc *kubeovnv1.Vpc) (string, []string, error) {
×
735
        portName := "bfd@" + vpc.Name
×
736
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
737
                if err := c.OVNNbClient.DeleteLogicalRouterPort(portName); err != nil {
×
738
                        err = fmt.Errorf("failed to delete BFD LRP %s: %w", portName, err)
×
739
                        klog.Error(err)
×
740
                        return portName, nil, err
×
741
                }
×
742
                if err := c.OVNNbClient.DeleteHAChassisGroup(portName); err != nil {
×
743
                        err = fmt.Errorf("failed to delete HA chassis group %s: %w", portName, err)
×
744
                        klog.Error(err)
×
745
                        return portName, nil, err
×
746
                }
×
747
                return portName, nil, nil
×
748
        }
749

750
        var err error
×
751
        chassisCount := 3
×
752
        selector := labels.Everything()
×
753
        if vpc.Spec.BFDPort.NodeSelector != nil {
×
754
                chassisCount = math.MaxInt
×
755
                if selector, err = metav1.LabelSelectorAsSelector(vpc.Spec.BFDPort.NodeSelector); err != nil {
×
756
                        err = fmt.Errorf("failed to parse node selector %q: %w", vpc.Spec.BFDPort.NodeSelector.String(), err)
×
757
                        klog.Error(err)
×
758
                        return portName, nil, err
×
759
                }
×
760
        }
761

762
        nodes, err := c.nodesLister.List(selector)
×
763
        if err != nil {
×
764
                err = fmt.Errorf("failed to list nodes with selector %q: %w", vpc.Spec.BFDPort.NodeSelector, err)
×
765
                klog.Error(err)
×
766
                return portName, nil, err
×
767
        }
×
768
        if len(nodes) == 0 {
×
769
                err = fmt.Errorf("no nodes found by selector %q", selector.String())
×
770
                klog.Error(err)
×
771
                return portName, nil, err
×
772
        }
×
773

774
        nodeNames := make([]string, 0, len(nodes))
×
775
        chassisCount = min(chassisCount, len(nodes))
×
776
        chassisNames := make([]string, 0, chassisCount)
×
777
        for _, nodes := range nodes[:chassisCount] {
×
778
                chassis, err := c.OVNSbClient.GetChassisByHost(nodes.Name)
×
779
                if err != nil {
×
780
                        err = fmt.Errorf("failed to get chassis of node %s: %w", nodes.Name, err)
×
781
                        klog.Error(err)
×
782
                        return portName, nil, err
×
783
                }
×
784
                chassisNames = append(chassisNames, chassis.Name)
×
785
                nodeNames = append(nodeNames, nodes.Name)
×
786
        }
787

788
        networks := strings.Split(vpc.Spec.BFDPort.IP, ",")
×
789
        if err = c.OVNNbClient.CreateLogicalRouterPort(vpc.Name, portName, "", networks); err != nil {
×
790
                klog.Error(err)
×
791
                return portName, nil, err
×
792
        }
×
793
        if err = c.OVNNbClient.UpdateLogicalRouterPortNetworks(portName, networks); err != nil {
×
794
                klog.Error(err)
×
795
                return portName, nil, err
×
796
        }
×
797
        if err = c.OVNNbClient.UpdateLogicalRouterPortOptions(portName, map[string]string{"bfd-only": "true"}); err != nil {
×
798
                klog.Error(err)
×
799
                return portName, nil, err
×
800
        }
×
801
        if err = c.OVNNbClient.CreateHAChassisGroup(portName, chassisNames, map[string]string{"lrp": portName}); err != nil {
×
802
                klog.Error(err)
×
803
                return portName, nil, err
×
804
        }
×
805
        if err = c.OVNNbClient.SetLogicalRouterPortHAChassisGroup(portName, portName); err != nil {
×
806
                klog.Error(err)
×
807
                return portName, nil, err
×
808
        }
×
809

810
        return portName, nodeNames, nil
×
811
}
812

813
func (c *Controller) addPolicyRouteToVpc(vpcName string, policy *kubeovnv1.PolicyRoute, externalIDs map[string]string) error {
×
814
        var (
×
815
                nextHops []string
×
816
                err      error
×
817
        )
×
818

×
819
        if policy.NextHopIP != "" {
×
820
                nextHops = strings.Split(policy.NextHopIP, ",")
×
821
        }
×
822

823
        if err = c.OVNNbClient.AddLogicalRouterPolicy(vpcName, policy.Priority, policy.Match, string(policy.Action), nextHops, nil, externalIDs); err != nil {
×
824
                klog.Errorf("add policy route to vpc %s failed, %v", vpcName, err)
×
825
                return err
×
826
        }
×
827
        return nil
×
828
}
829

830
func buildExternalIDsMapKey(match, action string, priority int) string {
×
831
        return fmt.Sprintf("%s-%s-%d", match, action, priority)
×
832
}
×
833

834
func (c *Controller) batchAddPolicyRouteToVpc(name string, policies []*kubeovnv1.PolicyRoute, externalIDs map[string]map[string]string) error {
×
835
        if len(policies) == 0 {
×
836
                return nil
×
837
        }
×
838
        start := time.Now()
×
839
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
840
        for _, policy := range policies {
×
841
                var nextHops []string
×
842
                if policy.NextHopIP != "" {
×
843
                        nextHops = strings.Split(policy.NextHopIP, ",")
×
844
                }
×
845
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
846
                        Priority:    policy.Priority,
×
847
                        Nexthops:    nextHops,
×
848
                        Action:      string(policy.Action),
×
849
                        Match:       policy.Match,
×
850
                        ExternalIDs: externalIDs[buildExternalIDsMapKey(policy.Match, string(policy.Action), policy.Priority)],
×
851
                })
×
852
        }
853

854
        if err := c.OVNNbClient.BatchAddLogicalRouterPolicy(name, routerPolicies...); err != nil {
×
855
                klog.Errorf("batch add policy route to vpc %s failed, %v", name, err)
×
856
                return err
×
857
        }
×
858
        klog.Infof("take to %v batch add policy route to vpc %s policies %d", time.Since(start), name, len(policies))
×
859
        return nil
×
860
}
861

862
func (c *Controller) deletePolicyRouteFromVpc(vpcName string, priority int, match string) error {
×
863
        var (
×
864
                vpc, cachedVpc *kubeovnv1.Vpc
×
865
                err            error
×
866
        )
×
867

×
868
        if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpcName, priority, match); err != nil {
×
869
                klog.Error(err)
×
870
                return err
×
871
        }
×
872

873
        cachedVpc, err = c.vpcsLister.Get(vpcName)
×
874
        if err != nil {
×
875
                if k8serrors.IsNotFound(err) {
×
876
                        return nil
×
877
                }
×
878
                klog.Error(err)
×
879
                return err
×
880
        }
881
        vpc = cachedVpc.DeepCopy()
×
882
        // make sure custom policies not be deleted
×
883
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
884
        if err != nil {
×
885
                klog.Error(err)
×
886
                return err
×
887
        }
×
888
        return nil
×
889
}
890

891
func (c *Controller) batchDeletePolicyRouteFromVpc(name string, policies []*kubeovnv1.PolicyRoute) error {
×
892
        var (
×
893
                vpc, cachedVpc *kubeovnv1.Vpc
×
894
                err            error
×
895
        )
×
896

×
897
        start := time.Now()
×
898
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
899
        for _, policy := range policies {
×
900
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
901
                        Priority: policy.Priority,
×
902
                        Match:    policy.Match,
×
903
                })
×
904
        }
×
905

906
        if err = c.OVNNbClient.BatchDeleteLogicalRouterPolicy(name, routerPolicies); err != nil {
×
907
                return err
×
908
        }
×
909
        klog.V(3).Infof("take to %v batch delete policy route from vpc %s policies %d", time.Since(start), name, len(policies))
×
910

×
911
        cachedVpc, err = c.vpcsLister.Get(name)
×
912
        if err != nil {
×
913
                if k8serrors.IsNotFound(err) {
×
914
                        return nil
×
915
                }
×
916
                klog.Error(err)
×
917
                return err
×
918
        }
919
        vpc = cachedVpc.DeepCopy()
×
920
        // make sure custom policies not be deleted
×
921
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
922
        if err != nil {
×
923
                klog.Error(err)
×
924
                return err
×
925
        }
×
926
        return nil
×
927
}
928

929
func (c *Controller) addStaticRouteToVpc(name string, route *kubeovnv1.StaticRoute) error {
×
930
        if route.BfdID != "" {
×
931
                klog.Infof("vpc %s add static ecmp route: %+v", name, route)
×
932
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
933
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, &route.BfdID, nil, route.NextHopIP,
×
934
                ); err != nil {
×
935
                        klog.Errorf("failed to add bfd static route to vpc %s , %v", name, err)
×
936
                        return err
×
937
                }
×
938
        } else {
×
939
                klog.Infof("vpc %s add static route: %+v", name, route)
×
940
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
941
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, nil, nil, route.NextHopIP,
×
942
                ); err != nil {
×
943
                        klog.Errorf("failed to add normal static route to vpc %s , %v", name, err)
×
944
                        return err
×
945
                }
×
946
        }
947
        return nil
×
948
}
949

950
func (c *Controller) deleteStaticRouteFromVpc(name, table, cidr, nextHop string, policy kubeovnv1.RoutePolicy) error {
×
951
        var (
×
952
                policyStr string
×
953
                err       error
×
954
        )
×
955

×
956
        policyStr = convertPolicy(policy)
×
957
        if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(name, &table, &policyStr, cidr, nextHop); err != nil {
×
958
                klog.Errorf("del vpc %s static route failed, %v", name, err)
×
959
                return err
×
960
        }
×
961

962
        return nil
×
963
}
964

965
func (c *Controller) batchDeleteStaticRouteFromVpc(name string, staticRoutes []*kubeovnv1.StaticRoute) error {
×
966
        var (
×
967
                vpc, cachedVpc *kubeovnv1.Vpc
×
968
                err            error
×
969
        )
×
970
        start := time.Now()
×
971
        routeCount := len(staticRoutes)
×
972
        delRoutes := make([]*ovnnb.LogicalRouterStaticRoute, 0, routeCount)
×
973
        for _, sr := range staticRoutes {
×
974
                policyStr := convertPolicy(sr.Policy)
×
975
                newRoute := &ovnnb.LogicalRouterStaticRoute{
×
976
                        RouteTable: sr.RouteTable,
×
977
                        Nexthop:    sr.NextHopIP,
×
978
                        Policy:     &policyStr,
×
979
                        IPPrefix:   sr.CIDR,
×
980
                }
×
981
                delRoutes = append(delRoutes, newRoute)
×
982
        }
×
983
        if err = c.OVNNbClient.BatchDeleteLogicalRouterStaticRoute(name, delRoutes); err != nil {
×
984
                klog.Errorf("batch del vpc %s static route %d failed, %v", name, routeCount, err)
×
985
                return err
×
986
        }
×
987
        klog.V(3).Infof("take to %v batch delete static route from vpc %s static routes %d", time.Since(start), name, len(delRoutes))
×
988

×
989
        cachedVpc, err = c.vpcsLister.Get(name)
×
990
        if err != nil {
×
991
                if k8serrors.IsNotFound(err) {
×
992
                        return nil
×
993
                }
×
994
                klog.Error(err)
×
995
                return err
×
996
        }
997
        vpc = cachedVpc.DeepCopy()
×
998
        // make sure custom policies not be deleted
×
999
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1000
        if err != nil {
×
1001
                klog.Error(err)
×
1002
                return err
×
1003
        }
×
1004
        return nil
×
1005
}
1006

1007
func diffPolicyRouteWithExisted(exists, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
1008
        var (
×
1009
                dels, adds []*kubeovnv1.PolicyRoute
×
1010
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
1011
                key        string
×
1012
                ok         bool
×
1013
        )
×
1014

×
1015
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
1016
        for _, item := range exists {
×
1017
                existsMap[getPolicyRouteItemKey(item)] = item
×
1018
        }
×
1019
        // load policies to add
1020
        for _, item := range target {
×
1021
                key = getPolicyRouteItemKey(item)
×
1022

×
1023
                if _, ok = existsMap[key]; ok {
×
1024
                        delete(existsMap, key)
×
1025
                } else {
×
1026
                        adds = append(adds, item)
×
1027
                }
×
1028
        }
1029
        // load policies to delete
1030
        for _, item := range existsMap {
×
1031
                dels = append(dels, item)
×
1032
        }
×
1033
        return dels, adds
×
1034
}
1035

1036
func diffPolicyRouteWithLogical(exists []*ovnnb.LogicalRouterPolicy, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
1037
        var (
×
1038
                dels, adds []*kubeovnv1.PolicyRoute
×
1039
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
1040
                key        string
×
1041
                ok         bool
×
1042
        )
×
1043
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
1044

×
1045
        for _, item := range exists {
×
1046
                policy := &kubeovnv1.PolicyRoute{
×
1047
                        Priority: item.Priority,
×
1048
                        Match:    item.Match,
×
1049
                        Action:   kubeovnv1.PolicyRouteAction(item.Action),
×
1050
                }
×
1051
                existsMap[getPolicyRouteItemKey(policy)] = policy
×
1052
        }
×
1053

1054
        for _, item := range target {
×
1055
                key = getPolicyRouteItemKey(item)
×
1056

×
1057
                if _, ok = existsMap[key]; ok {
×
1058
                        delete(existsMap, key)
×
1059
                } else {
×
1060
                        adds = append(adds, item)
×
1061
                }
×
1062
        }
1063

1064
        for _, item := range existsMap {
×
1065
                dels = append(dels, item)
×
1066
        }
×
1067
        return dels, adds
×
1068
}
1069

1070
func getPolicyRouteItemKey(item *kubeovnv1.PolicyRoute) (key string) {
×
1071
        return fmt.Sprintf("%d:%s:%s:%s", item.Priority, item.Match, item.Action, item.NextHopIP)
×
1072
}
×
1073

1074
func diffStaticRoute(exist []*ovnnb.LogicalRouterStaticRoute, target []*kubeovnv1.StaticRoute) (routeNeedDel, routeNeedAdd []*kubeovnv1.StaticRoute, err error) {
×
1075
        existRouteMap := make(map[string]*kubeovnv1.StaticRoute, len(exist))
×
1076
        for _, item := range exist {
×
1077
                policy := kubeovnv1.PolicyDst
×
1078
                if item.Policy != nil && *item.Policy == ovnnb.LogicalRouterStaticRoutePolicySrcIP {
×
1079
                        policy = kubeovnv1.PolicySrc
×
1080
                }
×
1081
                route := &kubeovnv1.StaticRoute{
×
1082
                        Policy:     policy,
×
1083
                        CIDR:       item.IPPrefix,
×
1084
                        NextHopIP:  item.Nexthop,
×
1085
                        RouteTable: item.RouteTable,
×
1086
                        ECMPMode:   util.StaticRouteBfdEcmp,
×
1087
                }
×
1088
                if item.BFD != nil {
×
1089
                        route.BfdID = *item.BFD
×
1090
                }
×
1091
                existRouteMap[getStaticRouteItemKey(route)] = route
×
1092
        }
1093

1094
        for _, item := range target {
×
1095
                key := getStaticRouteItemKey(item)
×
1096
                if _, ok := existRouteMap[key]; ok {
×
1097
                        delete(existRouteMap, key)
×
1098
                } else {
×
1099
                        routeNeedAdd = append(routeNeedAdd, item)
×
1100
                }
×
1101
        }
1102
        for _, item := range existRouteMap {
×
1103
                routeNeedDel = append(routeNeedDel, item)
×
1104
        }
×
1105
        return
×
1106
}
1107

1108
func getStaticRouteItemKey(item *kubeovnv1.StaticRoute) string {
×
1109
        var key string
×
1110
        if item.Policy == kubeovnv1.PolicyDst {
×
1111
                key = fmt.Sprintf("%s:dst:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1112
        } else {
×
1113
                key = fmt.Sprintf("%s:src:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1114
        }
×
1115
        return key
×
1116
}
1117

1118
func (c *Controller) formatVpc(vpc *kubeovnv1.Vpc) (*kubeovnv1.Vpc, error) {
×
1119
        var changed bool
×
1120
        for _, item := range vpc.Spec.StaticRoutes {
×
1121
                // check policy
×
1122
                if item.Policy == "" {
×
1123
                        item.Policy = kubeovnv1.PolicyDst
×
1124
                        changed = true
×
1125
                }
×
1126
                if item.Policy != kubeovnv1.PolicyDst && item.Policy != kubeovnv1.PolicySrc {
×
1127
                        return nil, fmt.Errorf("unknown policy type: %q", item.Policy)
×
1128
                }
×
1129
                // check cidr
1130
                if strings.Contains(item.CIDR, "/") {
×
1131
                        if _, _, err := net.ParseCIDR(item.CIDR); err != nil {
×
1132
                                return nil, fmt.Errorf("invalid cidr %q: %w", item.CIDR, err)
×
1133
                        }
×
1134
                } else if ip := net.ParseIP(item.CIDR); ip == nil {
×
1135
                        return nil, fmt.Errorf("invalid ip %q", item.CIDR)
×
1136
                }
×
1137
                // check next hop ip
1138
                if ip := net.ParseIP(item.NextHopIP); ip == nil {
×
1139
                        return nil, fmt.Errorf("invalid next hop ip %q", item.NextHopIP)
×
1140
                }
×
1141
        }
1142

1143
        for _, route := range vpc.Spec.PolicyRoutes {
×
1144
                if route.Action != kubeovnv1.PolicyRouteActionReroute {
×
1145
                        if route.NextHopIP != "" {
×
1146
                                route.NextHopIP = ""
×
1147
                                changed = true
×
1148
                        }
×
1149
                } else {
×
1150
                        // ecmp policy route may reroute to multiple next hop ips
×
1151
                        for ipStr := range strings.SplitSeq(route.NextHopIP, ",") {
×
1152
                                if ip := net.ParseIP(ipStr); ip == nil {
×
1153
                                        err := fmt.Errorf("invalid next hop ips: %s", route.NextHopIP)
×
1154
                                        klog.Error(err)
×
1155
                                        return nil, err
×
1156
                                }
×
1157
                        }
1158
                }
1159
        }
1160

1161
        if vpc.DeletionTimestamp.IsZero() && !slices.Contains(vpc.GetFinalizers(), util.KubeOVNControllerFinalizer) {
×
1162
                controllerutil.AddFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1163
                changed = true
×
1164
        }
×
1165

1166
        if !vpc.DeletionTimestamp.IsZero() && len(vpc.Status.Subnets) == 0 {
×
1167
                controllerutil.RemoveFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1168
                changed = true
×
1169
        }
×
1170

1171
        if changed {
×
1172
                newVpc, err := c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1173
                if err != nil {
×
1174
                        klog.Errorf("failed to update vpc %s: %v", vpc.Name, err)
×
1175
                        return nil, err
×
1176
                }
×
1177
                return newVpc, nil
×
1178
        }
1179

1180
        return vpc, nil
×
1181
}
1182

1183
func convertPolicies(list []*kubeovnv1.PolicyRoute) string {
×
1184
        if list == nil {
×
1185
                return ""
×
1186
        }
×
1187

1188
        var (
×
1189
                res []byte
×
1190
                err error
×
1191
        )
×
1192

×
1193
        if res, err = json.Marshal(list); err != nil {
×
1194
                klog.Errorf("failed to serialize policy routes %v , reason : %v", list, err)
×
1195
                return ""
×
1196
        }
×
1197
        return string(res)
×
1198
}
1199

1200
func reversePolicies(origin string) []*kubeovnv1.PolicyRoute {
×
1201
        if origin == "" {
×
1202
                return nil
×
1203
        }
×
1204

1205
        var (
×
1206
                list []*kubeovnv1.PolicyRoute
×
1207
                err  error
×
1208
        )
×
1209

×
1210
        if err = json.Unmarshal([]byte(origin), &list); err != nil {
×
1211
                klog.Errorf("failed to deserialize policy routes %v , reason : %v", list, err)
×
1212
                return nil
×
1213
        }
×
1214
        return list
×
1215
}
1216

1217
func convertPolicy(origin kubeovnv1.RoutePolicy) string {
×
1218
        if origin == kubeovnv1.PolicyDst {
×
1219
                return ovnnb.LogicalRouterStaticRoutePolicyDstIP
×
1220
        }
×
1221
        return ovnnb.LogicalRouterStaticRoutePolicySrcIP
×
1222
}
1223

1224
func reversePolicy(origin ovnnb.LogicalRouterStaticRoutePolicy) kubeovnv1.RoutePolicy {
×
1225
        if origin == ovnnb.LogicalRouterStaticRoutePolicyDstIP {
×
1226
                return kubeovnv1.PolicyDst
×
1227
        }
×
1228
        return kubeovnv1.PolicySrc
×
1229
}
1230

1231
func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaultSubnet string, err error) {
×
1232
        subnets = []string{}
×
1233
        allSubnets, err := c.subnetsLister.List(labels.Everything())
×
1234
        if err != nil {
×
1235
                klog.Error(err)
×
1236
                return nil, "", err
×
1237
        }
×
1238

1239
        for _, subnet := range allSubnets {
×
1240
                if subnet.Spec.Vpc != vpc.Name || !subnet.DeletionTimestamp.IsZero() || !isOvnSubnet(subnet) {
×
1241
                        continue
×
1242
                }
1243

1244
                subnets = append(subnets, subnet.Name)
×
1245
                if subnet.Spec.Default {
×
1246
                        defaultSubnet = subnet.Name
×
1247
                }
×
1248

1249
                if vpc.Name != util.DefaultVpc && vpc.Spec.DefaultSubnet != "" && vpc.Spec.DefaultSubnet == subnet.Name {
×
1250
                        defaultSubnet = vpc.Spec.DefaultSubnet
×
1251
                }
×
1252
        }
NEW
1253
        sort.Strings(subnets)
×
UNCOV
1254
        return
×
1255
}
1256

1257
// createVpcRouter create router to connect logical switches in vpc
NEW
1258
func (c *Controller) createVpcRouter(lr string, learnFromARPRequest bool) error {
×
1259
        if err := c.OVNNbClient.CreateLogicalRouter(lr); err != nil {
×
1260
                klog.Errorf("create logical router %s failed: %v", lr, err)
×
1261
                return err
×
1262
        }
×
1263

1264
        vpcRouter, err := c.OVNNbClient.GetLogicalRouter(lr, false)
×
1265
        if err != nil {
×
1266
                klog.Errorf("get logical router %s failed: %v", lr, err)
×
1267
                return err
×
1268
        }
×
1269

1270
        lrOptions := map[string]string{
×
1271
                "mac_binding_age_threshold": "300",
×
1272
                "dynamic_neigh_routers":     "true",
×
1273
        }
×
NEW
1274
        if !learnFromARPRequest {
×
1275
                lrOptions["always_learn_from_arp_request"] = "false"
×
1276
        }
×
1277
        if !maps.Equal(vpcRouter.Options, lrOptions) {
×
1278
                vpcRouter.Options = lrOptions
×
1279
                if err = c.OVNNbClient.UpdateLogicalRouter(vpcRouter, &vpcRouter.Options); err != nil {
×
1280
                        klog.Errorf("failed to update options of logical router %s: %v", lr, err)
×
1281
                        return err
×
1282
                }
×
1283
        }
1284

1285
        return nil
×
1286
}
1287

1288
// deleteVpcRouter delete router to connect logical switches in vpc
1289
func (c *Controller) deleteVpcRouter(lr string) error {
×
1290
        return c.OVNNbClient.DeleteLogicalRouter(lr)
×
1291
}
×
1292

1293
func (c *Controller) handleAddVpcExternalSubnet(key, subnet string) error {
×
1294
        cachedSubnet, err := c.subnetsLister.Get(subnet)
×
1295
        if err != nil {
×
1296
                klog.Error(err)
×
1297
                return err
×
1298
        }
×
1299
        lrpEipName := fmt.Sprintf("%s-%s", key, subnet)
×
1300
        cachedEip, err := c.ovnEipsLister.Get(lrpEipName)
×
1301
        var needCreateEip bool
×
1302
        if err != nil {
×
1303
                if !k8serrors.IsNotFound(err) {
×
1304
                        klog.Error(err)
×
1305
                        return err
×
1306
                }
×
1307
                needCreateEip = true
×
1308
        }
1309
        var v4ip, v6ip, mac string
×
1310
        klog.V(3).Infof("create vpc lrp eip %s", lrpEipName)
×
1311
        if needCreateEip {
×
1312
                if v4ip, v6ip, mac, err = c.acquireIPAddress(subnet, lrpEipName, lrpEipName); err != nil {
×
1313
                        klog.Errorf("failed to acquire ip address for lrp eip %s, %v", lrpEipName, err)
×
1314
                        return err
×
1315
                }
×
1316
                if err := c.createOrUpdateOvnEipCR(lrpEipName, subnet, v4ip, v6ip, mac, util.OvnEipTypeLRP); err != nil {
×
1317
                        klog.Errorf("failed to create ovn eip for lrp %s: %v", lrpEipName, err)
×
1318
                        return err
×
1319
                }
×
1320
        } else {
×
1321
                v4ip = cachedEip.Spec.V4Ip
×
1322
                mac = cachedEip.Spec.MacAddress
×
1323
        }
×
1324
        if v4ip == "" || mac == "" {
×
1325
                err := fmt.Errorf("lrp '%s' ip or mac should not be empty", lrpEipName)
×
1326
                klog.Error(err)
×
1327
                return err
×
1328
        }
×
1329
        // init lrp gw chassis group
1330
        chassises := []string{}
×
1331
        sel, _ := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{util.ExGatewayLabel: "true"}})
×
1332
        gwNodes, err := c.nodesLister.List(sel)
×
1333
        if err != nil {
×
1334
                klog.Errorf("failed to list external gw nodes, %v", err)
×
1335
                return err
×
1336
        }
×
1337
        for _, gwNode := range gwNodes {
×
1338
                annoChassisName := gwNode.Annotations[util.ChassisAnnotation]
×
1339
                if annoChassisName == "" {
×
1340
                        err := fmt.Errorf("node %s has no chassis annotation, kube-ovn-cni not ready", gwNode.Name)
×
1341
                        klog.Error(err)
×
1342
                        return err
×
1343
                }
×
1344
                klog.Infof("get node %s chassis: %s", gwNode.Name, annoChassisName)
×
1345
                chassis, err := c.OVNSbClient.GetChassis(annoChassisName, false)
×
1346
                if err != nil {
×
1347
                        klog.Errorf("failed to get node %s chassis: %s, %v", gwNode.Name, annoChassisName, err)
×
1348
                        return err
×
1349
                }
×
1350
                chassises = append(chassises, chassis.Name)
×
1351
        }
1352

1353
        if len(chassises) == 0 {
×
1354
                err := errors.New("no external gw nodes")
×
1355
                klog.Error(err)
×
1356
                return err
×
1357
        }
×
1358

1359
        v4ipCidr, err := util.GetIPAddrWithMask(v4ip, cachedSubnet.Spec.CIDRBlock)
×
1360
        if err != nil {
×
1361
                klog.Error(err)
×
1362
                return err
×
1363
        }
×
1364
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1365
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1366

×
1367
        if err := c.OVNNbClient.CreateLogicalPatchPort(subnet, key, lspName, lrpName, v4ipCidr, mac, chassises...); err != nil {
×
1368
                klog.Errorf("failed to connect router '%s' to external: %v", key, err)
×
1369
                return err
×
1370
        }
×
1371
        return nil
×
1372
}
1373

1374
func (c *Controller) handleDeleteVpcStaticRoute(key string) error {
×
1375
        vpc, err := c.vpcsLister.Get(key)
×
1376
        if err != nil {
×
1377
                if k8serrors.IsNotFound(err) {
×
1378
                        return nil
×
1379
                }
×
1380
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1381
                return err
×
1382
        }
1383
        needUpdate := false
×
1384
        newStaticRoutes := make([]*kubeovnv1.StaticRoute, 0, len(vpc.Spec.StaticRoutes))
×
1385
        for _, route := range vpc.Spec.StaticRoutes {
×
1386
                if route.ECMPMode != util.StaticRouteBfdEcmp {
×
1387
                        newStaticRoutes = append(newStaticRoutes, route)
×
1388
                        needUpdate = true
×
1389
                }
×
1390
        }
1391
        // keep non ecmp bfd routes
1392
        vpc.Spec.StaticRoutes = newStaticRoutes
×
1393
        if needUpdate {
×
1394
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
1395
                        klog.Errorf("failed to update vpc spec static route %s, %v", vpc.Name, err)
×
1396
                        return err
×
1397
                }
×
1398
        }
1399
        if err = c.patchVpcBfdStatus(vpc.Name); err != nil {
×
1400
                klog.Errorf("failed to patch vpc %s, %v", vpc.Name, err)
×
1401
                return err
×
1402
        }
×
1403
        return nil
×
1404
}
1405

1406
func (c *Controller) handleDelVpcExternalSubnet(key, subnet string) error {
×
1407
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1408
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1409
        klog.Infof("delete vpc lrp %s", lrpName)
×
1410
        if err := c.OVNNbClient.RemoveLogicalPatchPort(lspName, lrpName); err != nil {
×
1411
                klog.Errorf("failed to disconnect router '%s' to external, %v", key, err)
×
1412
                return err
×
1413
        }
×
1414
        if err := c.config.KubeOvnClient.KubeovnV1().OvnEips().Delete(context.Background(), lrpName, metav1.DeleteOptions{}); err != nil {
×
1415
                if !k8serrors.IsNotFound(err) {
×
1416
                        klog.Errorf("failed to delete ovn eip %s, %v", lrpName, err)
×
1417
                        return err
×
1418
                }
×
1419
        }
1420
        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpName, ""); err != nil {
×
1421
                klog.Error(err)
×
1422
                return err
×
1423
        }
×
1424
        return nil
×
1425
}
1426

1427
func (c *Controller) patchVpcBfdStatus(key string) error {
×
1428
        cachedVpc, err := c.vpcsLister.Get(key)
×
1429
        if err != nil {
×
1430
                if k8serrors.IsNotFound(err) {
×
1431
                        return nil
×
1432
                }
×
1433
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1434
                return err
×
1435
        }
1436

1437
        if cachedVpc.Status.EnableBfd != cachedVpc.Spec.EnableBfd {
×
1438
                status := cachedVpc.Status.DeepCopy()
×
1439
                status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1440
                status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1441
                bytes, err := status.Bytes()
×
1442
                if err != nil {
×
1443
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1444
                        return err
×
1445
                }
×
1446
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1447
                        cachedVpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1448
                        klog.Error(err)
×
1449
                        return err
×
1450
                }
×
1451
        }
1452
        return nil
×
1453
}
1454

1455
func (c *Controller) getRouteTablesByVpc(vpc *kubeovnv1.Vpc) map[string][]*kubeovnv1.StaticRoute {
×
1456
        rtbs := make(map[string][]*kubeovnv1.StaticRoute)
×
1457
        for _, route := range vpc.Spec.StaticRoutes {
×
1458
                rtbs[route.RouteTable] = append(rtbs[route.RouteTable], route)
×
1459
        }
×
1460
        return rtbs
×
1461
}
1462

1463
func (c *Controller) updateVpcExternalStatus(key string, enableExternal bool) error {
×
1464
        cachedVpc, err := c.vpcsLister.Get(key)
×
1465
        if err != nil {
×
1466
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1467
                return err
×
1468
        }
×
1469
        vpc := cachedVpc.DeepCopy()
×
1470
        vpc.Status.EnableExternal = vpc.Spec.EnableExternal
×
1471
        vpc.Status.EnableBfd = vpc.Spec.EnableBfd
×
1472

×
1473
        if enableExternal {
×
1474
                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
1475
                vpc.Status.ExtraExternalSubnets = vpc.Spec.ExtraExternalSubnets
×
1476
        } else {
×
1477
                vpc.Status.ExtraExternalSubnets = nil
×
1478
        }
×
1479

1480
        bytes, err := vpc.Status.Bytes()
×
1481
        if err != nil {
×
1482
                klog.Errorf("failed to get vpc bytes, %v", err)
×
1483
                return err
×
1484
        }
×
1485
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1486
                vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1487
                klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1488
                return err
×
1489
        }
×
1490

1491
        return nil
×
1492
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc