16021153021

Committed 02 Jul 2025 09:16AM UTC coverage: 65.61% (+0.003%) from 65.607%

Build # 16021153021

Build Type

Pull #15766

github

Committed by

web-flow

Commit Message

Merge 18f9411df into ed2445371

Pull Request Pull Request #15766: rec: fix two Coverity reported resource leaks and add release() to FDWrapper

Run Details

41566 of 92020 branches covered (45.17%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 3 files covered. (100.0%)

34 existing lines in 11 files now uncovered.

126953 of 164828 relevant lines covered (77.02%)

5615123.01 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.18

/modules/gpgsqlbackend/spgsql.cc

/*
 * This file is part of PowerDNS or dnsdist.
 * Copyright -- PowerDNS.COM B.V. and its contributors
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * In addition, for the avoidance of any doubt, permission is granted to
 * link this program with OpenSSL and to (re)distribute the binaries
 * produced as the result of such linking.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */

#ifdef HAVE_CONFIG_H
#include "config.h"
#endif
#include <string>
#include "spgsql.hh"
#include <sys/time.h>
#include <iostream>
#include "pdns/logger.hh"
#include "pdns/dns.hh"
#include "pdns/namespaces.hh"
#include <algorithm>

class SPgSQLStatement : public SSqlStatement
{
public:
  SPgSQLStatement(const string& query, bool dolog, int nparams, SPgSQL* db, unsigned int nstatement)
  {
    d_query = query;
    d_dolog = dolog;
    d_parent = db;
    d_nparams = nparams;
    d_nstatement = nstatement;
  }

  SSqlStatement* bind(const string& name, bool value) override { return bind(name, string(value ? "t" : "f")); }
  SSqlStatement* bind(const string& name, int value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& name, uint32_t value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& name, long value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& name, unsigned long value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& name, long long value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& name, unsigned long long value) override { return bind(name, std::to_string(value)); }
  SSqlStatement* bind(const string& /* name */, const std::string& value) override
  {
    prepareStatement();
    allocate();
    if (d_paridx >= d_nparams) {
      releaseStatement();
      throw SSqlException("Attempt to bind more parameters than query has: " + d_query);
    }
    paramValues[d_paridx] = new char[value.size() + 1];
    memset(paramValues[d_paridx], 0, sizeof(char) * (value.size() + 1));
    value.copy(paramValues[d_paridx], value.size());
    paramLengths[d_paridx] = value.size();
    d_paridx++;
    return this;
  }
  SSqlStatement* bindNull(const string& /* name */) override
  {
    prepareStatement();
    d_paridx++;
    return this;
  } // these are set null in allocate()
  SSqlStatement* execute() override
  {
    prepareStatement();
    if (d_dolog) {
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": Statement: " << d_query << endl;
      if (d_paridx) {
        // Log message is similar, but not exactly the same as the postgres server log.
        std::stringstream log_message;
        log_message << "Query " << ((long)(void*)this) << ": Parameters: ";
        for (int i = 0; i < d_paridx; i++) {
          if (i != 0) {
            log_message << ", ";
          }
          log_message << "$" << (i + 1) << " = ";
          if (paramValues[i] == nullptr) {
            log_message << "NULL";
          }
          else {
            log_message << "'" << paramValues[i] << "'";
          }
        }
        g_log << Logger::Warning << log_message.str() << endl;
      }
      d_dtime.set();
    }
    if (!d_stmt.empty()) {
      d_res_set = PQexecPrepared(d_db(), d_stmt.c_str(), d_nparams, paramValues, paramLengths, nullptr, 0);
    }
    else {
      d_res_set = PQexecParams(d_db(), d_query.c_str(), d_nparams, nullptr, paramValues, paramLengths, nullptr, 0);
    }
    ExecStatusType status = PQresultStatus(d_res_set);
    if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
      string errmsg(PQresultErrorMessage(d_res_set));
      releaseStatement();
      throw SSqlException("Fatal error during query: " + d_query + string(": ") + errmsg);
    }
    d_cur_set = 0;
    if (d_dolog) {
      auto diff = d_dtime.udiffNoReset();
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << diff << " us to execute" << endl;
    }

    nextResult();
    return this;
  }

  void nextResult()
  {
    if (d_res_set == nullptr)
      return;
    if (d_cur_set >= PQntuples(d_res_set)) {
      PQclear(d_res_set);
      d_res_set = nullptr;
      return;
    }
    if (PQftype(d_res_set, 0) == 1790) { // REFCURSOR
      g_log << Logger::Error << "Postgres query returned a REFCURSOR and we do not support those - see https://github.com/PowerDNS/pdns/pull/10259" << endl;
      PQclear(d_res_set);
      d_res_set = nullptr;
    }
    else {
      d_res = d_res_set;
      d_res_set = nullptr;
      d_resnum = PQntuples(d_res);
    }
  }

  bool hasNextRow() override
  {
    if (d_dolog && d_residx == d_resnum) {
      g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << d_dtime.udiff() << " us total to last row" << endl;
    }

    return d_residx < d_resnum;
  }

  SSqlStatement* nextRow(row_t& row) override
  {
    int i;
    row.clear();
    if (d_residx >= d_resnum || !d_res)
      return this;
    row.reserve(PQnfields(d_res));
    for (i = 0; i < PQnfields(d_res); i++) {
      if (PQgetisnull(d_res, d_residx, i)) {
        row.emplace_back("");
      }
      else if (PQftype(d_res, i) == 16) { // BOOLEAN
        char* val = PQgetvalue(d_res, d_residx, i);
        row.emplace_back(val[0] == 't' ? "1" : "0");
      }
      else {
        row.emplace_back(PQgetvalue(d_res, d_residx, i));
      }
    }
    d_residx++;
    if (d_residx >= d_resnum) {
      PQclear(d_res);
      d_res = nullptr;
      nextResult();
    }
    return this;
  }

  SSqlStatement* getResult(result_t& result) override
  {
    result.clear();
    if (d_res == nullptr)
      return this;
    result.reserve(d_resnum);
    row_t row;
    while (hasNextRow()) {
      nextRow(row);
      result.push_back(std::move(row));
    }
    return this;
  }

  SSqlStatement* reset() override
  {
    int i;
    if (d_res) {
      PQclear(d_res);
    }
    if (d_res_set) {
      PQclear(d_res_set);
    }
    d_res_set = nullptr;
    d_res = nullptr;
    d_paridx = d_residx = d_resnum = 0;
    if (paramValues) {
      for (i = 0; i < d_nparams; i++) {
        if (paramValues[i]) {
          delete[] paramValues[i];
        }
      }
    }
    delete[] paramValues;
    paramValues = nullptr;
    delete[] paramLengths;
    paramLengths = nullptr;
    return this;
  }

  const std::string& getQuery() override { return d_query; }

  ~SPgSQLStatement() override
  {
    releaseStatement();
  }

private:
  PGconn* d_db()
  {
    return d_parent->db();
  }

  void releaseStatement()
  {
    d_prepared = false;
    reset();
    if (!d_stmt.empty()) {
      string cmd = string("DEALLOCATE " + d_stmt);
      PGresult* res = PQexec(d_db(), cmd.c_str());
      PQclear(res);
      d_stmt.clear();
    }
  }

  void prepareStatement()
  {
    if (d_prepared)
      return;
    if (d_parent->usePrepared()) {
      // prepare a statement; name must be unique per session (using d_nstatement to ensure this).
      this->d_stmt = string("stmt") + std::to_string(d_nstatement);
      PGresult* res = PQprepare(d_db(), d_stmt.c_str(), d_query.c_str(), d_nparams, nullptr);
      ExecStatusType status = PQresultStatus(res);
      string errmsg(PQresultErrorMessage(res));
      PQclear(res);
      if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
        releaseStatement();
        throw SSqlException("Fatal error during prePQpreparepare: " + d_query + string(": ") + errmsg);
      }
    }
    paramValues = nullptr;
    paramLengths = nullptr;
    d_cur_set = d_paridx = d_residx = d_resnum = 0;
    d_res = nullptr;
    d_res_set = nullptr;
    d_prepared = true;
  }

  void allocate()
  {
    if (paramValues != nullptr)
      return;
    paramValues = new char*[d_nparams];
    paramLengths = new int[d_nparams];
    memset(paramValues, 0, sizeof(char*) * d_nparams);
    memset(paramLengths, 0, sizeof(int) * d_nparams);
  }

  string d_query;
  string d_stmt;
  SPgSQL* d_parent;
  PGresult* d_res_set{nullptr};
  PGresult* d_res{nullptr};
  bool d_dolog;
  DTime d_dtime; // only used if d_dolog is set
  bool d_prepared{false};
  int d_nparams;
  int d_paridx{0};
  char** paramValues{nullptr};
  int* paramLengths{nullptr};
  int d_residx{0};
  int d_resnum{0};
  int d_cur_set{0};
  unsigned int d_nstatement;
};

bool SPgSQL::s_dolog;

static string escapeForPQparam(const string& v)
{
  string ret = v;
  boost::replace_all(ret, "\\", "\\\\");
  boost::replace_all(ret, "'", "\\'");

  return string("'") + ret + string("'");
}

SPgSQL::SPgSQL(const string& database, const string& host, const string& port, const string& user,
               const string& password, const string& extra_connection_parameters, const bool use_prepared)
{
  d_db = nullptr;
  d_in_trx = false;
  d_connectstr = "";
  d_nstatements = 0;

  if (!database.empty())
    d_connectstr += "dbname=" + escapeForPQparam(database);

  if (!user.empty())
    d_connectstr += " user=" + escapeForPQparam(user);

  if (!host.empty())
    d_connectstr += " host=" + escapeForPQparam(host);

  if (!port.empty())
    d_connectstr += " port=" + escapeForPQparam(port);

  if (!extra_connection_parameters.empty())
    d_connectstr += " " + extra_connection_parameters;

  d_connectlogstr = d_connectstr;

  if (!password.empty()) {
    d_connectlogstr += " password=<HIDDEN>";
    d_connectstr += " password=" + escapeForPQparam(password);
  }

  d_use_prepared = use_prepared;

  d_db = PQconnectdb(d_connectstr.c_str());

  if (!d_db || PQstatus(d_db) == CONNECTION_BAD) {
    try {
      throw sPerrorException("Unable to connect to database, connect string: " + d_connectlogstr);
    }
    catch (...) {
      if (d_db)
        PQfinish(d_db);
      d_db = 0;
      throw;
    }
  }
}

void SPgSQL::setLog(bool state)
{
  s_dolog = state;
}

SPgSQL::~SPgSQL()
{
  PQfinish(d_db);
}

SSqlException SPgSQL::sPerrorException(const string& reason)
{
  return SSqlException(reason + string(": ") + (d_db ? PQerrorMessage(d_db) : "no connection"));
}

void SPgSQL::execute(const string& query)
{
  PGresult* res = PQexec(d_db, query.c_str());
  ExecStatusType status = PQresultStatus(res);
  string errmsg(PQresultErrorMessage(res));
  PQclear(res);
  if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {
    throw sPerrorException("Fatal error during query: " + errmsg);
  }
}

std::unique_ptr<SSqlStatement> SPgSQL::prepare(const string& query, int nparams)
{
  d_nstatements++;
  return std::make_unique<SPgSQLStatement>(query, s_dolog, nparams, this, d_nstatements);
}

void SPgSQL::startTransaction()
{
  execute("begin");
  d_in_trx = true;
}

void SPgSQL::commit()
{
  execute("commit");
  d_in_trx = false;
}

void SPgSQL::rollback()
{
  execute("rollback");
  d_in_trx = false;
}

bool SPgSQL::isConnectionUsable()
{
  if (PQstatus(d_db) != CONNECTION_OK) {
    return false;
  }

  bool usable = false;
  int sd = PQsocket(d_db);
  bool wasNonBlocking = isNonBlocking(sd);

  if (!wasNonBlocking) {
    if (!setNonBlocking(sd)) {
      return usable;
    }
  }

  usable = isTCPSocketUsable(sd);

  if (!wasNonBlocking) {
    if (!setBlocking(sd)) {
      usable = false;
    }
  }

  return usable;
}

void SPgSQL::reconnect()
{
  PQreset(d_db);
}

1	/*
2	* This file is part of PowerDNS or dnsdist.
3	* Copyright -- PowerDNS.COM B.V. and its contributors
4	*
5	* This program is free software; you can redistribute it and/or modify
6	* it under the terms of version 2 of the GNU General Public License as
7	* published by the Free Software Foundation.
8	*
9	* In addition, for the avoidance of any doubt, permission is granted to
10	* link this program with OpenSSL and to (re)distribute the binaries
11	* produced as the result of such linking.
12	*
13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.
17	*
18	* You should have received a copy of the GNU General Public License
19	* along with this program; if not, write to the Free Software
20	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21	*/
22
23	#ifdef HAVE_CONFIG_H
24	#include "config.h"
25	#endif
26	#include <string>
27	#include "spgsql.hh"
28	#include <sys/time.h>
29	#include <iostream>
30	#include "pdns/logger.hh"
31	#include "pdns/dns.hh"
32	#include "pdns/namespaces.hh"
33	#include <algorithm>
34
35	class SPgSQLStatement : public SSqlStatement
36	{
37	public:
38	SPgSQLStatement(const string& query, bool dolog, int nparams, SPgSQL* db, unsigned int nstatement)
39	{	127,718✔
40	d_query = query;	127,718✔
41	d_dolog = dolog;	127,718✔
42	d_parent = db;	127,718✔
43	d_nparams = nparams;	127,718✔
44	d_nstatement = nstatement;	127,718✔
45	}	127,718✔
46
47	SSqlStatement* bind(const string& name, bool value) override { return bind(name, string(value ? "t" : "f")); }	529,346✔
48	SSqlStatement* bind(const string& name, int value) override { return bind(name, std::to_string(value)); }	547,458✔
49	SSqlStatement* bind(const string& name, uint32_t value) override { return bind(name, std::to_string(value)); }	223,778✔
50	SSqlStatement* bind(const string& name, long value) override { return bind(name, std::to_string(value)); }	81✔
51	SSqlStatement* bind(const string& name, unsigned long value) override { return bind(name, std::to_string(value)); }	11✔
52	SSqlStatement* bind(const string& name, long long value) override { return bind(name, std::to_string(value)); }	×
53	SSqlStatement* bind(const string& name, unsigned long long value) override { return bind(name, std::to_string(value)); }	×
54	SSqlStatement* bind(const string& /* name */, const std::string& value) override
55	{	2,225,938✔
56	prepareStatement();	2,225,938✔
57	allocate();	2,225,938✔
58	if (d_paridx >= d_nparams) {	2,225,938!
59	releaseStatement();	×
60	throw SSqlException("Attempt to bind more parameters than query has: " + d_query);	×
61	}	×
62	paramValues[d_paridx] = new char[value.size() + 1];	2,225,938✔
63	memset(paramValues[d_paridx], 0, sizeof(char) * (value.size() + 1));	2,225,938✔
64	value.copy(paramValues[d_paridx], value.size());	2,225,938✔
65	paramLengths[d_paridx] = value.size();	2,225,938✔
66	d_paridx++;	2,225,938✔
67	return this;	2,225,938✔
68	}	2,225,938✔
69	SSqlStatement* bindNull(const string& /* name */) override
70	{	162,870✔
71	prepareStatement();	162,870✔
72	d_paridx++;	162,870✔
73	return this;	162,870✔
74	} // these are set null in allocate()	162,870✔
75	SSqlStatement* execute() override
76	{	331,053✔
77	prepareStatement();	331,053✔
78	if (d_dolog) {	331,053!
79	g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": Statement: " << d_query << endl;	×
80	if (d_paridx) {	×
81	// Log message is similar, but not exactly the same as the postgres server log.
82	std::stringstream log_message;	×
83	log_message << "Query " << ((long)(void*)this) << ": Parameters: ";	×
84	for (int i = 0; i < d_paridx; i++) {	×
85	if (i != 0) {	×
86	log_message << ", ";	×
87	}	×
88	log_message << "$" << (i + 1) << " = ";	×
89	if (paramValues[i] == nullptr) {	×
90	log_message << "NULL";	×
91	}	×
92	else {	×
93	log_message << "'" << paramValues[i] << "'";	×
94	}	×
95	}	×
96	g_log << Logger::Warning << log_message.str() << endl;	×
97	}	×
98	d_dtime.set();	×
99	}	×
100	if (!d_stmt.empty()) {	331,053!
101	d_res_set = PQexecPrepared(d_db(), d_stmt.c_str(), d_nparams, paramValues, paramLengths, nullptr, 0);	331,053✔
102	}	331,053✔
UNCOV 103	else {	×
UNCOV 104	d_res_set = PQexecParams(d_db(), d_query.c_str(), d_nparams, nullptr, paramValues, paramLengths, nullptr, 0);	×
UNCOV 105	}	×
106	ExecStatusType status = PQresultStatus(d_res_set);	331,053✔
107	if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {	331,053!
108	string errmsg(PQresultErrorMessage(d_res_set));	×
109	releaseStatement();	×
110	throw SSqlException("Fatal error during query: " + d_query + string(": ") + errmsg);	×
111	}	×
112	d_cur_set = 0;	331,053✔
113	if (d_dolog) {	331,053!
114	auto diff = d_dtime.udiffNoReset();	×
115	g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << diff << " us to execute" << endl;	×
116	}	×
117
118	nextResult();	331,053✔
119	return this;	331,053✔
120	}	331,053✔
121
122	void nextResult()
123	{	349,112✔
124	if (d_res_set == nullptr)	349,112✔
125	return;	18,059✔
126	if (d_cur_set >= PQntuples(d_res_set)) {	331,053✔
127	PQclear(d_res_set);	312,992✔
128	d_res_set = nullptr;	312,992✔
129	return;	312,992✔
130	}	312,992✔
131	if (PQftype(d_res_set, 0) == 1790) { // REFCURSOR	18,061!
132	g_log << Logger::Error << "Postgres query returned a REFCURSOR and we do not support those - see https://github.com/PowerDNS/pdns/pull/10259" << endl;	×
133	PQclear(d_res_set);	×
134	d_res_set = nullptr;	×
135	}	×
136	else {	18,061✔
137	d_res = d_res_set;	18,061✔
138	d_res_set = nullptr;	18,061✔
139	d_resnum = PQntuples(d_res);	18,061✔
140	}	18,061✔
141	}	18,061✔
142
143	bool hasNextRow() override
144	{	294,907✔
145	if (d_dolog && d_residx == d_resnum) {	294,907!
146	g_log << Logger::Warning << "Query " << ((long)(void*)this) << ": " << d_dtime.udiff() << " us total to last row" << endl;	×
147	}	×
148
149	return d_residx < d_resnum;	294,907✔
150	}	294,907✔
151
152	SSqlStatement* nextRow(row_t& row) override
153	{	271,446✔
154	int i;	271,446✔
155	row.clear();	271,446✔
156	if (d_residx >= d_resnum \|\| !d_res)	271,446!
157	return this;	×
158	row.reserve(PQnfields(d_res));	271,446✔
159	for (i = 0; i < PQnfields(d_res); i++) {	2,609,200✔
160	if (PQgetisnull(d_res, d_residx, i)) {	2,337,754✔
161	row.emplace_back("");	198,143✔
162	}	198,143✔
163	else if (PQftype(d_res, i) == 16) { // BOOLEAN	2,139,611✔
164	char* val = PQgetvalue(d_res, d_residx, i);	166✔
165	row.emplace_back(val[0] == 't' ? "1" : "0");	166✔
166	}	166✔
167	else {	2,139,445✔
168	row.emplace_back(PQgetvalue(d_res, d_residx, i));	2,139,445✔
169	}	2,139,445✔
170	}	2,337,754✔
171	d_residx++;	271,446✔
172	if (d_residx >= d_resnum) {	271,446✔
173	PQclear(d_res);	18,059✔
174	d_res = nullptr;	18,059✔
175	nextResult();	18,059✔
176	}	18,059✔
177	return this;	271,446✔
178	}	271,446✔
179
180	SSqlStatement* getResult(result_t& result) override
181	{	1,183✔
182	result.clear();	1,183✔
183	if (d_res == nullptr)	1,183✔
184	return this;	161✔
185	result.reserve(d_resnum);	1,022✔
186	row_t row;	1,022✔
187	while (hasNextRow()) {	2,109✔
188	nextRow(row);	1,087✔
189	result.push_back(std::move(row));	1,087✔
190	}	1,087✔
191	return this;	1,022✔
192	}	1,183✔
193
194	SSqlStatement* reset() override
195	{	451,441✔
196	int i;	451,441✔
197	if (d_res) {	451,441!
198	PQclear(d_res);	×
199	}	×
200	if (d_res_set) {	451,441!
201	PQclear(d_res_set);	×
202	}	×
203	d_res_set = nullptr;	451,441✔
204	d_res = nullptr;	451,441✔
205	d_paridx = d_residx = d_resnum = 0;	451,441✔
206	if (paramValues) {	451,441✔
207	for (i = 0; i < d_nparams; i++) {	2,719,837✔
208	if (paramValues[i]) {	2,388,809✔
209	delete[] paramValues[i];	2,225,939✔
210	}	2,225,939✔
211	}	2,388,809✔
212	}	331,028✔
213	delete[] paramValues;	451,441✔
214	paramValues = nullptr;	451,441✔
215	delete[] paramLengths;	451,441✔
216	paramLengths = nullptr;	451,441✔
217	return this;	451,441✔
218	}	451,441✔
219
220	const std::string& getQuery() override { return d_query; }	×
221
222	~SPgSQLStatement() override
223	{	119,961✔
224	releaseStatement();	119,961✔
225	}	119,961✔
226
227	private:
228	PGconn* d_db()
229	{	344,518✔
230	return d_parent->db();	344,518✔
231	}	344,518✔
232
233	void releaseStatement()
234	{	120,254✔
235	d_prepared = false;	120,254✔
236	reset();	120,254✔
237	if (!d_stmt.empty()) {	120,254✔
238	string cmd = string("DEALLOCATE " + d_stmt);	6,530✔
239	PGresult* res = PQexec(d_db(), cmd.c_str());	6,530✔
240	PQclear(res);	6,530✔
241	d_stmt.clear();	6,530✔
242	}	6,530✔
243	}	120,254✔
244
245	void prepareStatement()
246	{	2,719,859✔
247	if (d_prepared)	2,719,859✔
248	return;	2,712,926✔
249	if (d_parent->usePrepared()) {	6,935✔
250	// prepare a statement; name must be unique per session (using d_nstatement to ensure this).
251	this->d_stmt = string("stmt") + std::to_string(d_nstatement);	6,935✔
252	PGresult* res = PQprepare(d_db(), d_stmt.c_str(), d_query.c_str(), d_nparams, nullptr);	6,935✔
253	ExecStatusType status = PQresultStatus(res);	6,935✔
254	string errmsg(PQresultErrorMessage(res));	6,935✔
255	PQclear(res);	6,935✔
256	if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {	6,935!
257	releaseStatement();	×
258	throw SSqlException("Fatal error during prePQpreparepare: " + d_query + string(": ") + errmsg);	×
259	}	×
260	}	6,935✔
261	paramValues = nullptr;	6,933✔
262	paramLengths = nullptr;	6,933✔
263	d_cur_set = d_paridx = d_residx = d_resnum = 0;	6,933✔
264	d_res = nullptr;	6,933✔
265	d_res_set = nullptr;	6,933✔
266	d_prepared = true;	6,933✔
267	}	6,933✔
268
269	void allocate()
270	{	2,225,936✔
271	if (paramValues != nullptr)	2,225,936✔
272	return;	1,894,911✔
273	paramValues = new char*[d_nparams];	331,025✔
274	paramLengths = new int[d_nparams];	331,025✔
275	memset(paramValues, 0, sizeof(char) d_nparams);	331,025✔
276	memset(paramLengths, 0, sizeof(int) * d_nparams);	331,025✔
277	}	331,025✔
278
279	string d_query;
280	string d_stmt;
281	SPgSQL* d_parent;
282	PGresult* d_res_set{nullptr};
283	PGresult* d_res{nullptr};
284	bool d_dolog;
285	DTime d_dtime; // only used if d_dolog is set
286	bool d_prepared{false};
287	int d_nparams;
288	int d_paridx{0};
289	char** paramValues{nullptr};
290	int* paramLengths{nullptr};
291	int d_residx{0};
292	int d_resnum{0};
293	int d_cur_set{0};
294	unsigned int d_nstatement;
295	};
296
297	bool SPgSQL::s_dolog;
298
299	static string escapeForPQparam(const string& v)
300	{	3,292✔
301	string ret = v;	3,292✔
302	boost::replace_all(ret, "\\", "\\\\");	3,292✔
303	boost::replace_all(ret, "'", "\\'");	3,292✔
304
305	return string("'") + ret + string("'");	3,292✔
306	}	3,292✔
307
308	SPgSQL::SPgSQL(const string& database, const string& host, const string& port, const string& user,
309	const string& password, const string& extra_connection_parameters, const bool use_prepared)
310	{	1,879✔
311	d_db = nullptr;	1,879✔
312	d_in_trx = false;	1,879✔
313	d_connectstr = "";	1,879✔
314	d_nstatements = 0;	1,879✔
315
316	if (!database.empty())	1,879✔
317	d_connectstr += "dbname=" + escapeForPQparam(database);	1,877✔
318
319	if (!user.empty())	1,879✔
320	d_connectstr += " user=" + escapeForPQparam(user);	1,413✔
321
322	if (!host.empty())	1,879!
323	d_connectstr += " host=" + escapeForPQparam(host);	×
324
325	if (!port.empty())	1,879!
326	d_connectstr += " port=" + escapeForPQparam(port);	×
327
328	if (!extra_connection_parameters.empty())	1,879!
329	d_connectstr += " " + extra_connection_parameters;	×
330
331	d_connectlogstr = d_connectstr;	1,879✔
332
333	if (!password.empty()) {	1,879!
334	d_connectlogstr += " password=<HIDDEN>";	×
335	d_connectstr += " password=" + escapeForPQparam(password);	×
336	}	×
337
338	d_use_prepared = use_prepared;	1,879✔
339
340	d_db = PQconnectdb(d_connectstr.c_str());	1,879✔
341
342	if (!d_db \|\| PQstatus(d_db) == CONNECTION_BAD) {	1,879!
343	try {	×
344	throw sPerrorException("Unable to connect to database, connect string: " + d_connectlogstr);	×
345	}	×
346	catch (...) {	×
347	if (d_db)	×
348	PQfinish(d_db);	×
349	d_db = 0;	×
350	throw;	×
351	}	×
352	}	×
353	}	1,879✔
354
355	void SPgSQL::setLog(bool state)
356	{	1,879✔
357	s_dolog = state;	1,879✔
358	}	1,879✔
359
360	SPgSQL::~SPgSQL()
361	{	1,775✔
362	PQfinish(d_db);	1,775✔
363	}	1,775✔
364
365	SSqlException SPgSQL::sPerrorException(const string& reason)
366	{	×
367	return SSqlException(reason + string(": ") + (d_db ? PQerrorMessage(d_db) : "no connection"));	×
368	}	×
369
370	void SPgSQL::execute(const string& query)
371	{	1,075✔
372	PGresult* res = PQexec(d_db, query.c_str());	1,075✔
373	ExecStatusType status = PQresultStatus(res);	1,075✔
374	string errmsg(PQresultErrorMessage(res));	1,075✔
375	PQclear(res);	1,075✔
376	if (status != PGRES_COMMAND_OK && status != PGRES_TUPLES_OK && status != PGRES_NONFATAL_ERROR) {	1,075!
377	throw sPerrorException("Fatal error during query: " + errmsg);	×
378	}	×
379	}	1,075✔
380
381	std::unique_ptr<SSqlStatement> SPgSQL::prepare(const string& query, int nparams)
382	{	127,761✔
383	d_nstatements++;	127,761✔
384	return std::make_unique<SPgSQLStatement>(query, s_dolog, nparams, this, d_nstatements);	127,761✔
385	}	127,761✔
386
387	void SPgSQL::startTransaction()
388	{	545✔
389	execute("begin");	545✔
390	d_in_trx = true;	545✔
391	}	545✔
392
393	void SPgSQL::commit()
394	{	513✔
395	execute("commit");	513✔
396	d_in_trx = false;	513✔
397	}	513✔
398
399	void SPgSQL::rollback()
400	{	17✔
401	execute("rollback");	17✔
402	d_in_trx = false;	17✔
403	}	17✔
404
405	bool SPgSQL::isConnectionUsable()
406	{	22,779✔
407	if (PQstatus(d_db) != CONNECTION_OK) {	22,779!
408	return false;	×
409	}	×
410
411	bool usable = false;	22,779✔
412	int sd = PQsocket(d_db);	22,779✔
413	bool wasNonBlocking = isNonBlocking(sd);	22,779✔
414
415	if (!wasNonBlocking) {	22,779!
416	if (!setNonBlocking(sd)) {	×
417	return usable;	×
418	}	×
419	}	×
420
421	usable = isTCPSocketUsable(sd);	22,779✔
422
423	if (!wasNonBlocking) {	22,779!
424	if (!setBlocking(sd)) {	×
425	usable = false;	×
426	}	×
427	}	×
428
429	return usable;	22,779✔
430	}	22,779✔
431
432	void SPgSQL::reconnect()
433	{	×
434	PQreset(d_db);	×
435	}	×

PowerDNS / pdns / 16021153021

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous