3d3af85f-d15e-4a16-9ec1-f834b564ac67

Committed 01 Jul 2025 05:48PM UTC coverage: 97.424%. Remained the same

Build # 3d3af85f-d15e-4a16-9ec1-f834b564ac67

Build Type

push

circleci

Committed by

mark-dce

Commit Message

Fix redlock deprecation warnings

**ISSUE**
After the `Redis.current` fix, we are now seeing significant numbers
of deprecations warnings like:
```
Passing 'call' command to redis as is; blind passthrough has been
  deprecated and will be removed in redis-namespace 2.0
  (at /Users/mark/.rbenv/versions/2.7.4/lib/ruby/gems/2.7.0/gems/
   redlock-2.0.6/lib/redlock/client.rb:214:in `block (2 levels) in unlock')
```

**DIAGNOSIS**
We were passing a RedisNamespace object to Redlock instead of a
plain Redis connection specifier. RedisNamespace was complaining
any time an admin (not-namespace-able) command was received.

**RESOLUTION**
Pass a Redis URI to RedLock instead of a RedisNamespace object.

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

286 existing lines in 34 files now uncovered.

2837 of 2912 relevant lines covered (97.42%)

52.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/validators/my_program_validator.rb

class MyProgramValidator < ActiveModel::Validator
  def validate(record)
    return unless current_tab?(record)
    fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]
    fields_to_validate.each do |field|
      # TODO: confirm whether subfields are never required by Emory
      next if field == :subfield
      record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?
    end
  end

  def parsed_data(record)
    return {} unless record.data
    JSON.parse(record.data)
  end

  def current_tab?(record)
    parsed_data(record)['currentTab'] == "My Program"
  end
end

1	class MyProgramValidator < ActiveModel::Validator	4✔
2	def validate(record)	4✔
3	return unless current_tab?(record)	91✔
UNCOV 4	fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]	3✔
UNCOV 5	fields_to_validate.each do \|field\|	3✔
6	# TODO: confirm whether subfields are never required by Emory
UNCOV 7	next if field == :subfield	12✔
UNCOV 8	record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?	9✔
9	end
10	end
11
12	def parsed_data(record)	4✔
13	return {} unless record.data	100✔
14	JSON.parse(record.data)	74✔
15	end
16
17	def current_tab?(record)	4✔
18	parsed_data(record)['currentTab'] == "My Program"	91✔
19	end
20	end

curationexperts / laevigata / 3d3af85f-d15e-4a16-9ec1-f834b564ac67

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous