Qiskit / qiskit / 15999970202

push

github

Fix future clippy issues (#14461)

* Fix future clippy issues

This commit fixes some issues the clippy on nightly has identified as
issues in the code. These will all become CI failures at some future
date (after we raise the MSRV to match the current rules nightly is
adding). However, most of the changes are good improvements and in this
case most are code style issues that make things a bit more concise. The
bulk of the changes here are just moving to use captured identifiers in
format strings.

* Update new qasm3 code too

* Fix new issues introduced in new commits

* Remove unneeded return statements

* Make lifetime syntaxes consistent

A new nightly rule was added to ensure that lifetime syntaxes are
matched in function signatures. In many cases we were excluding the
elided anonymous lifetime parameter being returned in the source which
clippy asserts is potentially confusing. This commit adds the explicit
anonymous paramter to these places to fix the warning.

* Fix rust tests too

129 of 244 new or added lines in 46 files covered. (52.87%)

80982 of 92302 relevant lines covered (87.74%)

506230.69 hits per line