tylerb / graceful / 63

pending completion

Build # 63

Build Type

Pull #86

travis-ci

Committed by

web-flow

Commit Message

ISSUE #85: TCP Keep Alive cannot wrap TLS

Order matters when enabling TCP Keep Alives. Keep alives need to
be configured before wrapping them with a TLS Listener. In the current
implementation the TCP Keep Alive listener wraps after TLS is enabled
and TLS Listener doesn't have methods to access the lower layer TCP
behavior.

1. remove the TCP Keep Alive Listener from Serve
2. re-add TCP Keep Alive after creating a tcp Listener but before wrapping in TLS
3. update TLS unit tests to always specify TCPKeepAlive values to catch
   regressions.

Pull Request Pull Request #86: ISSUE #85: TCP Keep Alive cannot wrap TLS

Run Details

11 of 11 new or added lines in 1 file covered. (100.0%)

219 of 300 relevant lines covered (73.0%)

41.13 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

73.56

/graceful.go

Build SHA Not Found

The commit SHA "842120ca9ab2636a4fad3d68f28fb763008d0d1c" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

tylerb / graceful / 63

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous