9d67cb69-aa25-40dd-9aea-e25d2b427348

Committed 18 Jun 2025 03:04AM UTC coverage: 91.874% (-5.5%) from 97.411%

Build # 9d67cb69-aa25-40dd-9aea-e25d2b427348

Build Type

Pull #2464

circleci

Committed by

mark-dce

Commit Message

Disable embargo expiration notifications

Per discussions with SCO, they wish to reduce administrative overhead
by eliminating embargo expiration notifications.

We still need to process actual embargo expirations to change the
corresponding ETDs from a restricted to open status.

Therefore, this change leaves the schedule and service code in place
and simply comments out the calls to notification processing so that
we still get nightly expiration processing.

Pull Request Pull Request #2464: Disable embargo expiration notifications

Run Details

2544 of 2769 relevant lines covered (91.87%)

40.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/validators/my_program_validator.rb

class MyProgramValidator < ActiveModel::Validator
  def validate(record)
    return unless current_tab?(record)
    fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]
    fields_to_validate.each do |field|
      # TODO: confirm whether subfields are never required by Emory
      next if field == :subfield
      record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?
    end
  end

  def parsed_data(record)
    return {} unless record.data
    JSON.parse(record.data)
  end

  def current_tab?(record)
    parsed_data(record)['currentTab'] == "My Program"
  end
end

1	class MyProgramValidator < ActiveModel::Validator	3✔
2	def validate(record)	3✔
3	return unless current_tab?(record)	79✔
4	fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]	2✔
5	fields_to_validate.each do \|field\|	2✔
6	# TODO: confirm whether subfields are never required by Emory
7	next if field == :subfield	8✔
8	record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?	6✔
9	end
10	end
11
12	def parsed_data(record)	3✔
13	return {} unless record.data	85✔
14	JSON.parse(record.data)	61✔
15	end
16
17	def current_tab?(record)	3✔
18	parsed_data(record)['currentTab'] == "My Program"	79✔
19	end
20	end

curationexperts / laevigata / 9d67cb69-aa25-40dd-9aea-e25d2b427348

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous