#4308

Committed 14 Jun 2025 02:06PM UTC coverage: 62.454% (-0.3%) from 62.777%

Build # #4308

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix: taosdump windows pthread_mutex_unlock crash(3.0) (#31357)

* fix: windows pthread_mutex_unlock crash

* enh: sync from main fix taosdump crash windows

* fix: restore .github action branch to main

Run Details

153985 of 315105 branches covered (48.87%)

Branch coverage included in aggregate %.

238120 of 312727 relevant lines covered (76.14%)

6462519.65 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

57.89

/source/dnode/vnode/src/tq/tqPush.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "tq.h"
#include "vnd.h"

int32_t tqProcessSubmitReqForSubscribe(STQ* pTq) {
  if (pTq == NULL) {
    return TSDB_CODE_INVALID_MSG;
  }
  if (taosHashGetSize(pTq->pPushMgr) <= 0) {
    return 0;
  }
  SRpcMsg msg = {.msgType = TDMT_VND_TMQ_CONSUME_PUSH};
  msg.pCont = rpcMallocCont(sizeof(SMsgHead));
  if (msg.pCont == NULL) {
    return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);
  }
  msg.contLen = sizeof(SMsgHead);
  SMsgHead *pHead = msg.pCont;
  pHead->vgId = TD_VID(pTq->pVnode);
  pHead->contLen = msg.contLen;
  int32_t code = tmsgPutToQueue(&pTq->pVnode->msgCb, QUERY_QUEUE, &msg);
  if (code != 0){
    tqError("vgId:%d failed to push msg to queue, code:%d", TD_VID(pTq->pVnode), code);
    rpcFreeCont(msg.pCont);
  }
  return code;
}

int32_t tqPushMsg(STQ* pTq, tmsg_t msgType) {
  int32_t code = 0;
  if (msgType == TDMT_VND_SUBMIT) {
    code = tqProcessSubmitReqForSubscribe(pTq);
    if (code != 0){
      tqError("vgId:%d failed to process submit request for subscribe, code:%d", TD_VID(pTq->pVnode), code);
    }
  }

  return code;
}

int32_t tqRegisterPushHandle(STQ* pTq, void* handle, SRpcMsg* pMsg) {
  if (pTq == NULL || handle == NULL || pMsg == NULL) {
    return TSDB_CODE_INVALID_MSG;
  }
  int32_t    vgId = TD_VID(pTq->pVnode);
  STqHandle* pHandle = (STqHandle*)handle;

  if (pHandle->msg == NULL) {
    pHandle->msg = taosMemoryCalloc(1, sizeof(SRpcMsg));
    if (pHandle->msg == NULL) {
      return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);
    }
    (void)memcpy(pHandle->msg, pMsg, sizeof(SRpcMsg));
    pHandle->msg->pCont = rpcMallocCont(pMsg->contLen);
    if (pHandle->msg->pCont == NULL) {
      taosMemoryFree(pHandle->msg);
      pHandle->msg = NULL;
      return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);
    }
  } else {
    tqPushEmptyDataRsp(pHandle, vgId);

    void* tmp = pHandle->msg->pCont;
    (void)memcpy(pHandle->msg, pMsg, sizeof(SRpcMsg));
    pHandle->msg->pCont = tmp;
  }

  (void)memcpy(pHandle->msg->pCont, pMsg->pCont, pMsg->contLen);
  pHandle->msg->contLen = pMsg->contLen;
  int32_t ret = taosHashPut(pTq->pPushMgr, pHandle->subKey, strlen(pHandle->subKey), &pHandle, POINTER_BYTES);
  tqDebug("vgId:%d data is over, ret:%d, consumerId:0x%" PRIx64 ", register to pHandle:%p, pCont:%p, len:%d", vgId, ret,
          pHandle->consumerId, pHandle, pHandle->msg->pCont, pHandle->msg->contLen);
  if (ret != 0) {
    rpcFreeCont(pHandle->msg->pCont);
    taosMemoryFree(pHandle->msg);
    pHandle->msg = NULL;
  }
  return ret;
}

void tqUnregisterPushHandle(STQ* pTq, void *handle) {
  if (pTq == NULL || handle == NULL) {
    return;
  }
  STqHandle *pHandle = (STqHandle*)handle;
  int32_t    vgId = TD_VID(pTq->pVnode);

  if(taosHashGetSize(pTq->pPushMgr) <= 0) {
    return;
  }
  int32_t ret = taosHashRemove(pTq->pPushMgr, pHandle->subKey, strlen(pHandle->subKey));
  tqInfo("vgId:%d remove pHandle:%p,ret:%d consumer Id:0x%" PRIx64, vgId, pHandle, ret, pHandle->consumerId);

  if(ret == 0 && pHandle->msg != NULL) {
    tqPushEmptyDataRsp(pHandle, vgId);

    rpcFreeCont(pHandle->msg->pCont);
    taosMemoryFree(pHandle->msg);
    pHandle->msg = NULL;
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "tq.h"
17	#include "vnd.h"
18
19	int32_t tqProcessSubmitReqForSubscribe(STQ* pTq) {	2,887,667✔
20	if (pTq == NULL) {	2,887,667!
21	return TSDB_CODE_INVALID_MSG;	×
22	}
23	if (taosHashGetSize(pTq->pPushMgr) <= 0) {	2,887,667✔
24	return 0;	2,872,279✔
25	}
26	SRpcMsg msg = {.msgType = TDMT_VND_TMQ_CONSUME_PUSH};	15,661✔
27	msg.pCont = rpcMallocCont(sizeof(SMsgHead));	15,661✔
28	if (msg.pCont == NULL) {	15,662!
29	return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);	×
30	}
31	msg.contLen = sizeof(SMsgHead);	15,662✔
32	SMsgHead *pHead = msg.pCont;	15,662✔
33	pHead->vgId = TD_VID(pTq->pVnode);	15,662✔
34	pHead->contLen = msg.contLen;	15,662✔
35	int32_t code = tmsgPutToQueue(&pTq->pVnode->msgCb, QUERY_QUEUE, &msg);	15,662✔
36	if (code != 0){	15,662!
37	tqError("vgId:%d failed to push msg to queue, code:%d", TD_VID(pTq->pVnode), code);	×
38	rpcFreeCont(msg.pCont);	×
39	}
40	return code;	15,662✔
41	}
42
43	int32_t tqPushMsg(STQ* pTq, tmsg_t msgType) {	3,100,631✔
44	int32_t code = 0;	3,100,631✔
45	if (msgType == TDMT_VND_SUBMIT) {	3,100,631✔
46	code = tqProcessSubmitReqForSubscribe(pTq);	2,887,698✔
47	if (code != 0){	2,887,940!
48	tqError("vgId:%d failed to process submit request for subscribe, code:%d", TD_VID(pTq->pVnode), code);	×
49	}
50	}
51
52	return code;	3,101,566✔
53	}
54
55	int32_t tqRegisterPushHandle(STQ* pTq, void* handle, SRpcMsg* pMsg) {	16,543✔
56	if (pTq == NULL \|\| handle == NULL \|\| pMsg == NULL) {	16,543!
57	return TSDB_CODE_INVALID_MSG;	×
58	}
59	int32_t vgId = TD_VID(pTq->pVnode);	16,543✔
60	STqHandle* pHandle = (STqHandle*)handle;	16,543✔
61
62	if (pHandle->msg == NULL) {	16,543!
63	pHandle->msg = taosMemoryCalloc(1, sizeof(SRpcMsg));	16,543!
64	if (pHandle->msg == NULL) {	16,543!
65	return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);	×
66	}
67	(void)memcpy(pHandle->msg, pMsg, sizeof(SRpcMsg));	16,543✔
68	pHandle->msg->pCont = rpcMallocCont(pMsg->contLen);	16,543✔
69	if (pHandle->msg->pCont == NULL) {	16,543!
70	taosMemoryFree(pHandle->msg);	×
71	pHandle->msg = NULL;	×
72	return TAOS_GET_TERRNO(TSDB_CODE_OUT_OF_MEMORY);	×
73	}
74	} else {
75	tqPushEmptyDataRsp(pHandle, vgId);	×
76
77	void* tmp = pHandle->msg->pCont;	×
78	(void)memcpy(pHandle->msg, pMsg, sizeof(SRpcMsg));	×
79	pHandle->msg->pCont = tmp;	×
80	}
81
82	(void)memcpy(pHandle->msg->pCont, pMsg->pCont, pMsg->contLen);	16,543✔
83	pHandle->msg->contLen = pMsg->contLen;	16,543✔
84	int32_t ret = taosHashPut(pTq->pPushMgr, pHandle->subKey, strlen(pHandle->subKey), &pHandle, POINTER_BYTES);	16,543✔
85	tqDebug("vgId:%d data is over, ret:%d, consumerId:0x%" PRIx64 ", register to pHandle:%p, pCont:%p, len:%d", vgId, ret,	16,543!
86	pHandle->consumerId, pHandle, pHandle->msg->pCont, pHandle->msg->contLen);
87	if (ret != 0) {	16,543!
88	rpcFreeCont(pHandle->msg->pCont);	×
89	taosMemoryFree(pHandle->msg);	×
90	pHandle->msg = NULL;	×
91	}
92	return ret;	16,543✔
93	}
94
95	void tqUnregisterPushHandle(STQ* pTq, void *handle) {	3,653✔
96	if (pTq == NULL \|\| handle == NULL) {	3,653!
97	return;	×
98	}
99	STqHandle pHandle = (STqHandle)handle;	3,653✔
100	int32_t vgId = TD_VID(pTq->pVnode);	3,653✔
101
102	if(taosHashGetSize(pTq->pPushMgr) <= 0) {	3,653✔
103	return;	3,021✔
104	}
105	int32_t ret = taosHashRemove(pTq->pPushMgr, pHandle->subKey, strlen(pHandle->subKey));	631✔
106	tqInfo("vgId:%d remove pHandle:%p,ret:%d consumer Id:0x%" PRIx64, vgId, pHandle, ret, pHandle->consumerId);	631!
107
108	if(ret == 0 && pHandle->msg != NULL) {	631!
109	tqPushEmptyDataRsp(pHandle, vgId);	617✔
110
111	rpcFreeCont(pHandle->msg->pCont);	617✔
112	taosMemoryFree(pHandle->msg);	617!
113	pHandle->msg = NULL;	617✔
114	}
115	}

taosdata / TDengine / #4308

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous