15651574485

Committed 14 Jun 2025 11:29AM UTC coverage: 50.476% (-0.01%) from 50.488%

Build # 15651574485

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1771 from ottml/fix_clang_tidy_on_ci

Fix clang tidy on ci

Run Details

42 of 53 new or added lines in 22 files covered. (79.25%)

5 existing lines in 2 files now uncovered.

22464 of 44504 relevant lines covered (50.48%)

35471.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

39.29

/libs/s25main/network/NetworkPlayer.cpp

// Copyright (C) 2005 - 2021 Settlers Freaks (sf-team at siedler25.org)
//
// SPDX-License-Identifier: GPL-2.0-or-later

#include "NetworkPlayer.h"
#include "GameMessage.h"

NetworkPlayer::NetworkPlayer(unsigned playerId)
    : playerId(playerId), recvQueue(GameMessage::create_game), sendQueue(GameMessage::create_game)
{}

void NetworkPlayer::closeConnection()
{
    // Close socket and clear queues
    socket.Close();
    sendQueue.clear();
    recvQueue.clear();
}

bool NetworkPlayer::receiveMsgs()
{
    return recvQueue.recvAll(socket) >= 0;
}

bool NetworkPlayer::sendMsgs(int maxNumMsgs)
{
    return sendQueue.send(socket, maxNumMsgs);
}

void NetworkPlayer::sendMsgAsync(Message* msg)
{
    sendQueue.push(msg);
}

void NetworkPlayer::sendMsg(const Message& msg)
{
    MessageQueue::sendMessage(socket, msg);
}

void NetworkPlayer::executeMsgs(MessageInterface& msgHandler)
{
    while(!recvQueue.empty())
        recvQueue.pop()->run(&msgHandler, playerId);
}

void swap(NetworkPlayer& lhs, NetworkPlayer& rhs) noexcept
{
    using std::swap;
    swap(lhs.playerId, rhs.playerId);
    swap(lhs.recvQueue, rhs.recvQueue);
    swap(lhs.sendQueue, rhs.sendQueue);
    swap(lhs.socket, rhs.socket);
}

1	// Copyright (C) 2005 - 2021 Settlers Freaks (sf-team at siedler25.org)
2	//
3	// SPDX-License-Identifier: GPL-2.0-or-later
4
5	#include "NetworkPlayer.h"
6	#include "GameMessage.h"
7
8	NetworkPlayer::NetworkPlayer(unsigned playerId)	7✔
9	: playerId(playerId), recvQueue(GameMessage::create_game), sendQueue(GameMessage::create_game)	7✔
10	{}	7✔
11
12	void NetworkPlayer::closeConnection()	5✔
13	{
14	// Close socket and clear queues
15	socket.Close();	5✔
16	sendQueue.clear();	5✔
17	recvQueue.clear();	5✔
18	}	5✔
19
20	bool NetworkPlayer::receiveMsgs()	×
21	{
22	return recvQueue.recvAll(socket) >= 0;	×
23	}
24
25	bool NetworkPlayer::sendMsgs(int maxNumMsgs)	×
26	{
27	return sendQueue.send(socket, maxNumMsgs);	×
28	}
29
30	void NetworkPlayer::sendMsgAsync(Message* msg)	28✔
31	{
32	sendQueue.push(msg);	28✔
33	}	28✔
34
35	void NetworkPlayer::sendMsg(const Message& msg)	×
36	{
37	MessageQueue::sendMessage(socket, msg);	×
38	}	×
39
40	void NetworkPlayer::executeMsgs(MessageInterface& msgHandler)	×
41	{
42	while(!recvQueue.empty())	×
43	recvQueue.pop()->run(&msgHandler, playerId);	×
44	}	×
45
NEW 46	void swap(NetworkPlayer& lhs, NetworkPlayer& rhs) noexcept	×
47	{
48	using std::swap;
49	swap(lhs.playerId, rhs.playerId);	×
50	swap(lhs.recvQueue, rhs.recvQueue);	×
51	swap(lhs.sendQueue, rhs.sendQueue);	×
52	swap(lhs.socket, rhs.socket);	×
53	}	×

Return-To-The-Roots / s25client / 15651574485

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous