0716167f-ab73-4e8b-922e-160b009f1109

Committed 04 Jun 2025 06:59PM UTC coverage: 85.904% (+0.1%) from 85.795%

Build # 0716167f-ab73-4e8b-922e-160b009f1109

Build Type

push

circleci

Committed by

web-flow

Commit Message

Refactoring ProjectXmlPresenter to ensure that certain XML Elements are not created when they are empty (#1515)

* Refactoring ProjectXmlPresenter to improve parsing for certain Project metadata values; Ensuring that certain XML elements cannot be created with empty content (these would otherwise invalidate the XML Document)

* Introducing some additional refactoring steps for the ProjectXmlPresenter

Run Details

4 of 4 branches covered (100.0%)

149 of 156 new or added lines in 6 files covered. (95.51%)

1 existing line in 1 file now uncovered.

2968 of 3455 relevant lines covered (85.9%)

583.47 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

86.67

/app/services/xml_node_builder.rb

# frozen_string_literal: true
class XmlNodeBuilder
  XML_VERSION = "1.0"

  attr_reader :document, :node

  # @return [String]
  def xml_version
    XML_VERSION
  end

  # @return [Array<String>]
  def xml_document_args
    [
      xml_version
    ]
  end

  # @return [Nokogiri::XML::Document]
  def build_document
    Nokogiri::XML::Document.new(*xml_document_args)
  end

  # @return [Nokogiri::XML::Element]
  def build
    return node if node.present?

    @node = document.root
  end

  # @param [Nokogiri::XML::Document] document
  def initialize(document: nil)
    @document = document || build_document

    @node = nil
  end
end

1	# frozen_string_literal: true
2	class XmlNodeBuilder	1✔
3	XML_VERSION = "1.0"	1✔
4
5	attr_reader :document, :node	1✔
6
7	# @return [String]
8	def xml_version	1✔
9	XML_VERSION	640✔
10	end
11
12	# @return [Array<String>]
13	def xml_document_args	1✔
14	[
15	xml_version	640✔
16	]
17	end
18
19	# @return [Nokogiri::XML::Document]
20	def build_document	1✔
21	Nokogiri::XML::Document.new(*xml_document_args)	640✔
22	end
23
24	# @return [Nokogiri::XML::Element]
25	def build	1✔
NEW 26	return node if node.present?	×
27
UNCOV 28	@node = document.root	×
29	end
30
31	# @param [Nokogiri::XML::Document] document
32	def initialize(document: nil)	1✔
33	@document = document \|\| build_document	3,566✔
34
35	@node = nil	3,566✔
36	end
37	end

pulibrary / tigerdata-app / 0716167f-ab73-4e8b-922e-160b009f1109

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous