15385647784

Committed 02 Jun 2025 06:44AM UTC coverage: 42.77% (-0.03%) from 42.803%

Build # 15385647784

Build Type

push

github

Committed by

web-flow

Commit Message

refact: bump tablewriter to v1, fix the breaking change (#2024)

* refact: bump tablewriter to v1, fix the breaking change

Signed-off-by: Keming <kemingyang@tensorchord.ai>

* fix lint

Signed-off-by: Keming <kemingyang@tensorchord.ai>

---------

Signed-off-by: Keming <kemingyang@tensorchord.ai>

Run Details

67 of 105 new or added lines in 11 files covered. (63.81%)

7 existing lines in 3 files now uncovered.

5218 of 12200 relevant lines covered (42.77%)

164.31 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

84.32

/pkg/progress/progressui/printer.go

// Copyright 2023 The envd Authors
// Copyright 2023 The buildkit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//      http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package progressui

import (
        "container/ring"
        "context"
        "fmt"
        "io"
        "os"
        "sort"
        "strings"
        "time"

        "github.com/opencontainers/go-digest"
        "github.com/tonistiigi/units"
)

const antiFlicker = 5 * time.Second
const maxDelay = 10 * time.Second
const minTimeDelta = 5 * time.Second
const minProgressDelta = 0.05 // %

const logsBufferSize = 10

type lastStatus struct {
        Current   int64
        Timestamp time.Time
}

type textMux struct {
        w         io.Writer
        current   digest.Digest
        last      map[string]lastStatus
        notFirst  bool
        nextIndex int
}

func (p *textMux) printVtx(t *trace, dgst digest.Digest) {
        if p.last == nil {
                p.last = make(map[string]lastStatus)
        }

        v, ok := t.byDigest[dgst]
        if !ok {
                return
        }

        if v.index == 0 {
                p.nextIndex++
                v.index = p.nextIndex
        }

        if dgst != p.current {
                if p.current != "" {
                        old := t.byDigest[p.current]
                        if old.logsPartial {
                                fmt.Fprintln(p.w, "")
                        }
                        old.logsOffset = 0
                        old.count = 0
                        fmt.Fprintf(p.w, "#%d ...\n", old.index)
                }

                if p.notFirst {
                        fmt.Fprintln(p.w, "")
                } else {
                        p.notFirst = true
                }

                if os.Getenv("PROGRESS_NO_TRUNC") == "0" {
                        fmt.Fprintf(p.w, "#%d %s\n", v.index, limitString(v.Name, 72))
                } else {
                        fmt.Fprintf(p.w, "#%d %s\n", v.index, v.Name)
                }
        }

        if len(v.events) != 0 {
                v.logsOffset = 0
        }
        for _, ev := range v.events {
                fmt.Fprintf(p.w, "#%d %s\n", v.index, ev)
        }
        v.events = v.events[:0]

        isOpenStatus := false // remote cache loading can currently produce status updates without active vertex
        for _, s := range v.statuses {
                if _, ok := v.statusUpdates[s.ID]; ok {
                        doPrint := true

                        if last, ok := p.last[s.ID]; ok && s.Completed == nil {
                                var progressDelta float64
                                if s.Total > 0 {
                                        progressDelta = float64(s.Current-last.Current) / float64(s.Total)
                                }
                                timeDelta := s.Timestamp.Sub(last.Timestamp)
                                if progressDelta < minProgressDelta && timeDelta < minTimeDelta {
                                        doPrint = false
                                }
                        }

                        if !doPrint {
                                continue
                        }

                        p.last[s.ID] = lastStatus{
                                Timestamp: s.Timestamp,
                                Current:   s.Current,
                        }

                        var bytes string
                        if s.Total != 0 {
                                bytes = fmt.Sprintf(" %.2f / %.2f", units.Bytes(s.Current), units.Bytes(s.Total))
                        } else if s.Current != 0 {
                                bytes = fmt.Sprintf(" %.2f", units.Bytes(s.Current))
                        }
                        var tm string
                        endTime := s.Timestamp
                        if s.Completed != nil {
                                endTime = *s.Completed
                        }
                        if s.Started != nil {
                                diff := endTime.Sub(*s.Started).Seconds()
                                if diff > 0.01 {
                                        tm = fmt.Sprintf(" %.1fs", diff)
                                }
                        }
                        if s.Completed != nil {
                                tm += " done"
                        } else {
                                isOpenStatus = true
                        }
                        fmt.Fprintf(p.w, "#%d %s%s%s\n", v.index, s.ID, bytes, tm)
                }
        }
        v.statusUpdates = map[string]struct{}{}

        for _, w := range v.warnings[v.warningIdx:] {
                fmt.Fprintf(p.w, "#%d WARN: %s\n", v.index, w.Short)
                v.warningIdx++
        }

        for i, l := range v.logs {
                if i == 0 {
                        l = l[v.logsOffset:]
                }
                fmt.Fprintf(p.w, "%s", l)
                if i != len(v.logs)-1 || !v.logsPartial {
                        fmt.Fprintln(p.w, "")
                }
                if v.logsBuffer == nil {
                        v.logsBuffer = ring.New(logsBufferSize)
                }
                v.logsBuffer.Value = l
                if !v.logsPartial {
                        v.logsBuffer = v.logsBuffer.Next()
                }
        }

        if len(v.logs) > 0 {
                if v.logsPartial {
                        v.logs = v.logs[len(v.logs)-1:]
                        v.logsOffset = len(v.logs[0])
                } else {
                        v.logs = nil
                        v.logsOffset = 0
                }
        }

        p.current = dgst
        if v.isCompleted() && !isOpenStatus {
                p.current = ""
                v.count = 0

                if v.Error != "" {
                        if v.logsPartial {
                                fmt.Fprintln(p.w, "")
                        }
                        if strings.HasSuffix(v.Error, context.Canceled.Error()) {
                                fmt.Fprintf(p.w, "#%d CANCELED\n", v.index)
                        } else {
                                fmt.Fprintf(p.w, "#%d ERROR: %s\n", v.index, v.Error)
                        }
                } else if v.Cached {
                        fmt.Fprintf(p.w, "#%d CACHED\n", v.index)
                } else {
                        tm := ""
                        var ivals []interval
                        for _, ival := range v.intervals {
                                ivals = append(ivals, ival)
                        }
                        ivals = mergeIntervals(ivals)
                        if len(ivals) > 0 {
                                var dt float64
                                for _, ival := range ivals {
                                        dt += ival.duration().Seconds()
                                }
                                tm = fmt.Sprintf(" %.1fs", dt)
                        }
                        fmt.Fprintf(p.w, "#%d DONE%s\n", v.index, tm)
                }
        }

        delete(t.updates, dgst)
}

func sortCompleted(t *trace, m map[digest.Digest]struct{}) []digest.Digest {
        out := make([]digest.Digest, 0, len(m))
        for k := range m {
                out = append(out, k)
        }
        sort.Slice(out, func(i, j int) bool {
                vtxi := t.byDigest[out[i]]
                vtxj := t.byDigest[out[j]]
                return vtxi.mostRecentInterval().stop.Before(*vtxj.mostRecentInterval().stop)
        })
        return out
}

func (p *textMux) print(t *trace) {
        completed := map[digest.Digest]struct{}{}
        rest := map[digest.Digest]struct{}{}

        for dgst := range t.updates {
                v, ok := t.byDigest[dgst]
                if !ok {
                        continue
                }
                if v.ProgressGroup != nil || v.hidden {
                        // skip vtxs in a group (they are merged into a single vtx) and hidden ones
                        continue
                }
                if v.isCompleted() {
                        completed[dgst] = struct{}{}
                } else {
                        rest[dgst] = struct{}{}
                }
        }

        current := p.current

        // items that have completed need to be printed first
        if _, ok := completed[current]; ok {
                p.printVtx(t, current)
        }

        for _, dgst := range sortCompleted(t, completed) {
                if dgst != current {
                        p.printVtx(t, dgst)
                }
        }

        if len(rest) == 0 {
                if current != "" {
                        if v := t.byDigest[current]; v.isStarted() && !v.isCompleted() {
                                return
                        }
                }
                // make any open vertex active
                for dgst, v := range t.byDigest {
                        if v.isStarted() && !v.isCompleted() && v.ProgressGroup == nil && !v.hidden {
                                p.printVtx(t, dgst)
                                return
                        }
                }
                return
        }

        // now print the active one
        if _, ok := rest[current]; ok {
                p.printVtx(t, current)
        }

        stats := map[digest.Digest]*vtxStat{}
        now := time.Now()
        sum := 0.0
        var max digest.Digest
        if current != "" {
                rest[current] = struct{}{}
        }
        for dgst := range rest {
                v, ok := t.byDigest[dgst]
                if !ok {
                        continue
                }
                if v.lastBlockTime == nil {
                        // shouldn't happen, but not worth crashing over
                        continue
                }
                tm := now.Sub(*v.lastBlockTime)
                speed := float64(v.count) / tm.Seconds()
                overLimit := tm > maxDelay && dgst != current
                stats[dgst] = &vtxStat{blockTime: tm, speed: speed, overLimit: overLimit}
                sum += speed
                if overLimit || max == "" || stats[max].speed < speed {
                        max = dgst
                }
        }
        for dgst := range stats {
                stats[dgst].share = stats[dgst].speed / sum
        }

        if _, ok := completed[current]; ok || current == "" {
                p.printVtx(t, max)
                return
        }

        // show items that were hidden
        for dgst := range rest {
                if stats[dgst].overLimit {
                        p.printVtx(t, dgst)
                        return
                }
        }

        // fair split between vertices
        if 1.0/(1.0-stats[current].share)*antiFlicker.Seconds() < stats[current].blockTime.Seconds() {
                p.printVtx(t, max)
                return
        }
}

type vtxStat struct {
        blockTime time.Duration
        speed     float64
        share     float64
        overLimit bool
}

func limitString(s string, l int) string {
        if len(s) > l {
                return s[:l] + "..."
        }
        return s
}

1	// Copyright 2023 The envd Authors
2	// Copyright 2023 The buildkit Authors
3	//
4	// Licensed under the Apache License, Version 2.0 (the "License");
5	// you may not use this file except in compliance with the License.
6	// You may obtain a copy of the License at
7	//
8	// http://www.apache.org/licenses/LICENSE-2.0
9	//
10	// Unless required by applicable law or agreed to in writing, software
11	// distributed under the License is distributed on an "AS IS" BASIS,
12	// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	// See the License for the specific language governing permissions and
14	// limitations under the License.
15
16	package progressui
17
18	import (
19	"container/ring"
20	"context"
21	"fmt"
22	"io"
23	"os"
24	"sort"
25	"strings"
26	"time"
27
28	"github.com/opencontainers/go-digest"
29	"github.com/tonistiigi/units"
30	)
31
32	const antiFlicker = 5 * time.Second
33	const maxDelay = 10 * time.Second
34	const minTimeDelta = 5 * time.Second
35	const minProgressDelta = 0.05 // %
36
37	const logsBufferSize = 10
38
39	type lastStatus struct {
40	Current int64
41	Timestamp time.Time
42	}
43
44	type textMux struct {
45	w io.Writer
46	current digest.Digest
47	last map[string]lastStatus
48	notFirst bool
49	nextIndex int
50	}
51
52	func (p textMux) printVtx(t trace, dgst digest.Digest) {	1,937✔
53	if p.last == nil {	1,964✔
54	p.last = make(map[string]lastStatus)	27✔
55	}	27✔
56
57	v, ok := t.byDigest[dgst]	1,937✔
58	if !ok {	1,937✔
59	return	×
60	}	×
61
62	if v.index == 0 {	2,853✔
63	p.nextIndex++	916✔
64	v.index = p.nextIndex	916✔
65	}	916✔
66
67	if dgst != p.current {	2,925✔
68	if p.current != "" {	1,030✔
69	old := t.byDigest[p.current]	42✔
70	if old.logsPartial {	42✔
UNCOV 71	fmt.Fprintln(p.w, "")	×
UNCOV 72	}	×
73	old.logsOffset = 0	42✔
74	old.count = 0	42✔
75	fmt.Fprintf(p.w, "#%d ...\n", old.index)	42✔
76	}
77
78	if p.notFirst {	1,949✔
79	fmt.Fprintln(p.w, "")	961✔
80	} else {	988✔
81	p.notFirst = true	27✔
82	}	27✔
83
84	if os.Getenv("PROGRESS_NO_TRUNC") == "0" {	988✔
85	fmt.Fprintf(p.w, "#%d %s\n", v.index, limitString(v.Name, 72))	×
86	} else {	988✔
87	fmt.Fprintf(p.w, "#%d %s\n", v.index, v.Name)	988✔
88	}	988✔
89	}
90
91	if len(v.events) != 0 {	1,937✔
92	v.logsOffset = 0	×
93	}	×
94	for _, ev := range v.events {	1,937✔
95	fmt.Fprintf(p.w, "#%d %s\n", v.index, ev)	×
96	}	×
97	v.events = v.events[:0]	1,937✔
98		1,937✔
99	isOpenStatus := false // remote cache loading can currently produce status updates without active vertex	1,937✔
100	for _, s := range v.statuses {	3,026✔
101	if _, ok := v.statusUpdates[s.ID]; ok {	1,558✔
102	doPrint := true	469✔
103		469✔
104	if last, ok := p.last[s.ID]; ok && s.Completed == nil {	534✔
105	var progressDelta float64	65✔
106	if s.Total > 0 {	86✔
107	progressDelta = float64(s.Current-last.Current) / float64(s.Total)	21✔
108	}	21✔
109	timeDelta := s.Timestamp.Sub(last.Timestamp)	65✔
110	if progressDelta < minProgressDelta && timeDelta < minTimeDelta {	121✔
111	doPrint = false	56✔
112	}	56✔
113	}
114
115	if !doPrint {	525✔
116	continue	56✔
117	}
118
119	p.last[s.ID] = lastStatus{	413✔
120	Timestamp: s.Timestamp,	413✔
121	Current: s.Current,	413✔
122	}	413✔
123		413✔
124	var bytes string	413✔
125	if s.Total != 0 {	521✔
126	bytes = fmt.Sprintf(" %.2f / %.2f", units.Bytes(s.Current), units.Bytes(s.Total))	108✔
127	} else if s.Current != 0 {	434✔
128	bytes = fmt.Sprintf(" %.2f", units.Bytes(s.Current))	21✔
129	}	21✔
130	var tm string	413✔
131	endTime := s.Timestamp	413✔
132	if s.Completed != nil {	738✔
133	endTime = *s.Completed	325✔
134	}	325✔
135	if s.Started != nil {	826✔
136	diff := endTime.Sub(*s.Started).Seconds()	413✔
137	if diff > 0.01 {	638✔
138	tm = fmt.Sprintf(" %.1fs", diff)	225✔
139	}	225✔
140	}
141	if s.Completed != nil {	738✔
142	tm += " done"	325✔
143	} else {	413✔
144	isOpenStatus = true	88✔
145	}	88✔
146	fmt.Fprintf(p.w, "#%d %s%s%s\n", v.index, s.ID, bytes, tm)	413✔
147	}
148	}
149	v.statusUpdates = map[string]struct{}{}	1,937✔
150		1,937✔
151	for _, w := range v.warnings[v.warningIdx:] {	1,937✔
152	fmt.Fprintf(p.w, "#%d WARN: %s\n", v.index, w.Short)	×
153	v.warningIdx++	×
154	}	×
155
156	for i, l := range v.logs {	10,429✔
157	if i == 0 {	9,231✔
158	l = l[v.logsOffset:]	739✔
159	}	739✔
160	fmt.Fprintf(p.w, "%s", l)	8,492✔
161	if i != len(v.logs)-1 \|\| !v.logsPartial {	16,643✔
162	fmt.Fprintln(p.w, "")	8,151✔
163	}	8,151✔
164	if v.logsBuffer == nil {	8,540✔
165	v.logsBuffer = ring.New(logsBufferSize)	48✔
166	}	48✔
167	v.logsBuffer.Value = l	8,492✔
168	if !v.logsPartial {	12,337✔
169	v.logsBuffer = v.logsBuffer.Next()	3,845✔
170	}	3,845✔
171	}
172
173	if len(v.logs) > 0 {	2,676✔
174	if v.logsPartial {	1,080✔
175	v.logs = v.logs[len(v.logs)-1:]	341✔
176	v.logsOffset = len(v.logs[0])	341✔
177	} else {	739✔
178	v.logs = nil	398✔
179	v.logsOffset = 0	398✔
180	}	398✔
181	}
182
183	p.current = dgst	1,937✔
184	if v.isCompleted() && !isOpenStatus {	2,883✔
185	p.current = ""	946✔
186	v.count = 0	946✔
187		946✔
188	if v.Error != "" {	946✔
189	if v.logsPartial {	×
190	fmt.Fprintln(p.w, "")	×
191	}	×
192	if strings.HasSuffix(v.Error, context.Canceled.Error()) {	×
193	fmt.Fprintf(p.w, "#%d CANCELED\n", v.index)	×
194	} else {	×
195	fmt.Fprintf(p.w, "#%d ERROR: %s\n", v.index, v.Error)	×
196	}	×
197	} else if v.Cached {	1,448✔
198	fmt.Fprintf(p.w, "#%d CACHED\n", v.index)	502✔
199	} else {	946✔
200	tm := ""	444✔
201	var ivals []interval	444✔
202	for _, ival := range v.intervals {	943✔
203	ivals = append(ivals, ival)	499✔
204	}	499✔
205	ivals = mergeIntervals(ivals)	444✔
206	if len(ivals) > 0 {	888✔
207	var dt float64	444✔
208	for _, ival := range ivals {	943✔
209	dt += ival.duration().Seconds()	499✔
210	}	499✔
211	tm = fmt.Sprintf(" %.1fs", dt)	444✔
212	}
213	fmt.Fprintf(p.w, "#%d DONE%s\n", v.index, tm)	444✔
214	}
215	}
216
217	delete(t.updates, dgst)	1,937✔
218	}
219
220	func sortCompleted(t *trace, m map[digest.Digest]struct{}) []digest.Digest {	3,574✔
221	out := make([]digest.Digest, 0, len(m))	3,574✔
222	for k := range m {	4,520✔
223	out = append(out, k)	946✔
224	}	946✔
225	sort.Slice(out, func(i, j int) bool {	5,170✔
226	vtxi := t.byDigest[out[i]]	1,596✔
227	vtxj := t.byDigest[out[j]]	1,596✔
228	return vtxi.mostRecentInterval().stop.Before(*vtxj.mostRecentInterval().stop)	1,596✔
229	})	1,596✔
230	return out	3,574✔
231	}
232
233	func (p textMux) print(t trace) {	3,574✔
234	completed := map[digest.Digest]struct{}{}	3,574✔
235	rest := map[digest.Digest]struct{}{}	3,574✔
236		3,574✔
237	for dgst := range t.updates {	5,816✔
238	v, ok := t.byDigest[dgst]	2,242✔
239	if !ok {	2,242✔
240	continue	×
241	}
242	if v.ProgressGroup != nil \|\| v.hidden {	2,242✔
243	// skip vtxs in a group (they are merged into a single vtx) and hidden ones	×
244	continue	×
245	}
246	if v.isCompleted() {	3,188✔
247	completed[dgst] = struct{}{}	946✔
248	} else {	2,242✔
249	rest[dgst] = struct{}{}	1,296✔
250	}	1,296✔
251	}
252
253	current := p.current	3,574✔
254		3,574✔
255	// items that have completed need to be printed first	3,574✔
256	if _, ok := completed[current]; ok {	3,725✔
257	p.printVtx(t, current)	151✔
258	}	151✔
259
260	for _, dgst := range sortCompleted(t, completed) {	4,520✔
261	if dgst != current {	1,741✔
262	p.printVtx(t, dgst)	795✔
263	}	795✔
264	}
265
266	if len(rest) == 0 {	6,070✔
267	if current != "" {	4,962✔
268	if v := t.byDigest[current]; v.isStarted() && !v.isCompleted() {	4,862✔
269	return	2,396✔
270	}	2,396✔
271	}
272	// make any open vertex active
273	for dgst, v := range t.byDigest {	3,124✔
274	if v.isStarted() && !v.isCompleted() && v.ProgressGroup == nil && !v.hidden {	3,040✔
275	p.printVtx(t, dgst)	16✔
276	return	16✔
277	}	16✔
278	}
279	return	84✔
280	}
281
282	// now print the active one
283	if _, ok := rest[current]; ok {	1,884✔
284	p.printVtx(t, current)	806✔
285	}	806✔
286
287	stats := map[digest.Digest]*vtxStat{}	1,078✔
288	now := time.Now()	1,078✔
289	sum := 0.0	1,078✔
290	var max digest.Digest	1,078✔
291	if current != "" {	2,068✔
292	rest[current] = struct{}{}	990✔
293	}	990✔
294	for dgst := range rest {	2,558✔
295	v, ok := t.byDigest[dgst]	1,480✔
296	if !ok {	1,480✔
297	continue	×
298	}
299	if v.lastBlockTime == nil {	1,480✔
300	// shouldn't happen, but not worth crashing over	×
301	continue	×
302	}
303	tm := now.Sub(*v.lastBlockTime)	1,480✔
304	speed := float64(v.count) / tm.Seconds()	1,480✔
305	overLimit := tm > maxDelay && dgst != current	1,480✔
306	stats[dgst] = &vtxStat{blockTime: tm, speed: speed, overLimit: overLimit}	1,480✔
307	sum += speed	1,480✔
308	if overLimit \|\| max == "" \|\| stats[max].speed < speed {	2,699✔
309	max = dgst	1,219✔
310	}	1,219✔
311	}
312	for dgst := range stats {	2,558✔
313	stats[dgst].share = stats[dgst].speed / sum	1,480✔
314	}	1,480✔
315
316	if _, ok := completed[current]; ok \|\| current == "" {	1,247✔
317	p.printVtx(t, max)	169✔
318	return	169✔
319	}	169✔
320
321	// show items that were hidden
322	for dgst := range rest {	2,100✔
323	if stats[dgst].overLimit {	1,191✔
324	p.printVtx(t, dgst)	×
325	return	×
326	}	×
327	}
328
329	// fair split between vertices
330	if 1.0/(1.0-stats[current].share)*antiFlicker.Seconds() < stats[current].blockTime.Seconds() {	909✔
UNCOV 331	p.printVtx(t, max)	×
UNCOV 332	return	×
UNCOV 333	}	×
334	}
335
336	type vtxStat struct {
337	blockTime time.Duration
338	speed float64
339	share float64
340	overLimit bool
341	}
342
343	func limitString(s string, l int) string {	×
344	if len(s) > l {	×
345	return s[:l] + "..."	×
346	}	×
347	return s	×
348	}

tensorchord / envd / 15385647784

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous