010cdbf8-27fb-4569-b695-f7eca55b1bcc

Committed 30 May 2025 10:09PM UTC coverage: 42.382% (-49.3%) from 91.682%

Build # 010cdbf8-27fb-4569-b695-f7eca55b1bcc

Build Type

push

circleci

Committed by

sandbergja

Commit Message

Refactor from Generics to a Type alias for clarity

Instead of using a generic type <T>, we give these closures specific type aliases,
CommunityIdSelector and CollectionIdsSelector, that gives more insight about what
they do.

As a bonus, this makes the compiled binary slighlty smaller.

Run Details

1630 of 3846 relevant lines covered (42.38%)

2.45 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.0

/app/controllers/application_controller.rb

class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
  include ApplicationHelper

  def after_sign_out_path_for(_resource_or_scope)
    request.referer
  end

  def handle_alma_exception(exception:, message:)
    if exception.is_a?(Alma::PerSecondThresholdError)
      Rails.logger.error "HTTP 429. #{message} #{exception}"
      head :too_many_requests
    elsif exception.is_a?(Alma::NotFoundError)
      Rails.logger.error "HTTP 404. #{message} #{exception}"
      head :not_found
    elsif exception.is_a?(Alma::StandardError)
      Rails.logger.error "HTTP 400. #{message} #{exception}"
      head :bad_request
    elsif exception.is_a?(Net::ReadTimeout)
      Rails.logger.error "HTTP 504. #{message} #{exception}"
      head :gateway_timeout
    else
      Rails.logger.error "HTTP 500. #{message} #{exception}"
      head :internal_server_error
    end
  end
end

1	class ApplicationController < ActionController::Base	1✔
2	# Prevent CSRF attacks by raising an exception.
3	# For APIs, you may want to use :null_session instead.
4	protect_from_forgery with: :exception	1✔
5	include ApplicationHelper	1✔
6
7	def after_sign_out_path_for(_resource_or_scope)	1✔
8	request.referer	×
9	end
10
11	def handle_alma_exception(exception:, message:)	1✔
12	if exception.is_a?(Alma::PerSecondThresholdError)	5✔
13	Rails.logger.error "HTTP 429. #{message} #{exception}"	2✔
14	head :too_many_requests	2✔
15	elsif exception.is_a?(Alma::NotFoundError)	3✔
16	Rails.logger.error "HTTP 404. #{message} #{exception}"	1✔
17	head :not_found	1✔
18	elsif exception.is_a?(Alma::StandardError)	2✔
19	Rails.logger.error "HTTP 400. #{message} #{exception}"	1✔
20	head :bad_request	1✔
21	elsif exception.is_a?(Net::ReadTimeout)	1✔
22	Rails.logger.error "HTTP 504. #{message} #{exception}"	×
23	head :gateway_timeout	×
24	else
25	Rails.logger.error "HTTP 500. #{message} #{exception}"	1✔
26	head :internal_server_error	1✔
27	end
28	end
29	end

pulibrary / bibdata / 010cdbf8-27fb-4569-b695-f7eca55b1bcc

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous