15211570615

Committed 23 May 2025 01:02PM UTC coverage: 70.407% (-2.0%) from 72.366%

Build # 15211570615

Build Type

Pull #539

github

Committed by

lerouxb

Commit Message

don't include the shell api twice

Pull Request Pull Request #539: chore: don't include the shell api twice

Run Details

1526 of 2447 branches covered (62.36%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

11 existing lines in 4 files now uncovered.

3268 of 4362 relevant lines covered (74.92%)

563.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.5

/packages/devtools-connect/src/oidc/handler.ts

import type { RedirectServerRequestInfo } from '@mongodb-js/oidc-plugin';
import type { DevtoolsConnectOptions } from '../connect';
import {
  getStaticPage,
  HttpServerPage,
} from '@mongodb-js/oidc-http-server-pages';

export function oidcServerRequestHandler(
  options: Pick<DevtoolsConnectOptions, 'productDocsLink' | 'productName'>,
  info: RedirectServerRequestInfo,
): void {
  const { productDocsLink, productName } = options;
  const { res, result, status } = info;
  res.statusCode = status;

  if (result === 'redirecting') {
    res.setHeader('Location', info.location);
    res.end();
    return;
  }

  // This CSP is fairly restrictive. Since we are sending static pages only, the security
  // effects of this are limited, but this is also helpful for verifying that the generated
  // pages do not unintentionally rely on external resources (which they should never do).
  res.setHeader(
    'Content-Security-Policy',
    "default-src 'self'; style-src 'unsafe-inline'",
  );
  res.setHeader('Content-Type', 'text/html; charset=utf-8');

  switch (result) {
    case 'accepted':
      res.end(
        getStaticPage(HttpServerPage.OIDCAcceptedPage, {
          productDocsLink,
          productName,
        }),
      );
      break;
    case 'rejected':
      res.end(
        getStaticPage(HttpServerPage.OIDCErrorPage, {
          productDocsLink,
          productName,
          error: info.error,
          errorDescription: info.errorDescription,
          errorURI: info.errorURI,
        }),
      );
      break;
    default:
      res.end(
        getStaticPage(HttpServerPage.OIDCNotFoundPage, {
          productDocsLink,
          productName,
        }),
      );
      break;
  }
}

1	import type { RedirectServerRequestInfo } from '@mongodb-js/oidc-plugin';
2	import type { DevtoolsConnectOptions } from '../connect';	1✔
3	import {	1✔
4	getStaticPage,	1✔
5	HttpServerPage,
6	} from '@mongodb-js/oidc-http-server-pages';	×
7		×
UNCOV 8	export function oidcServerRequestHandler(	×
9	options: Pick<DevtoolsConnectOptions, 'productDocsLink' \| 'productName'>,	×
10	info: RedirectServerRequestInfo,	×
11	): void {	×
12	const { productDocsLink, productName } = options;	×
13	const { res, result, status } = info;
14	res.statusCode = status;	×
15		×
16	if (result === 'redirecting') {	×
17	res.setHeader('Location', info.location);
18	res.end();	×
19	return;
20	}
21
22	// This CSP is fairly restrictive. Since we are sending static pages only, the security	×
23	// effects of this are limited, but this is also helpful for verifying that the generated
24	// pages do not unintentionally rely on external resources (which they should never do).	×
25	res.setHeader(
26	'Content-Security-Policy',
27	"default-src 'self'; style-src 'unsafe-inline'",
28	);
29	res.setHeader('Content-Type', 'text/html; charset=utf-8');
30
31	switch (result) {	×
32	case 'accepted':
33	res.end(	×
34	getStaticPage(HttpServerPage.OIDCAcceptedPage, {
35	productDocsLink,
36	productName,
37	}),	×
38	);
39	break;
40	case 'rejected':
41	res.end(
42	getStaticPage(HttpServerPage.OIDCErrorPage, {
43	productDocsLink,
44	productName,
45	error: info.error,
46	errorDescription: info.errorDescription,
47	errorURI: info.errorURI,
48	}),
49	);
50	break;
51	default:
52	res.end(
53	getStaticPage(HttpServerPage.OIDCNotFoundPage, {
54	productDocsLink,
55	productName,
56	}),
57	);
58	break;
59	}
60	}

mongodb-js / devtools-shared / 15211570615

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous