15133993414

Committed 20 May 2025 09:30AM UTC coverage: 26.313% (-1.2%) from 27.493%

Build # 15133993414

Build Type

Pull #7161

github

Committed by

web-flow

Commit Message

Merge e2c03d45f into 5459ba375

Pull Request Pull Request #7161: fix(metadata): infer parameter string type from schema

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

11019 existing lines in 363 files now uncovered.

12898 of 49018 relevant lines covered (26.31%)

34.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.24

/src/Symfony/Bundle/ArgumentResolver/PayloadArgumentResolver.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\Bundle\ArgumentResolver;

use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use ApiPlatform\State\SerializerContextBuilderInterface;
use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
use ApiPlatform\State\Util\RequestAttributesExtractor;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Controller\ValueResolverInterface;
use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;

final class PayloadArgumentResolver implements CompatibleValueResolverInterface
{
    use OperationRequestInitiatorTrait;

    public function __construct(
        ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory,
        private readonly SerializerContextBuilderInterface $serializationContextBuilder,
    ) {
        $this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;
    }

    public function supports(Request $request, ArgumentMetadata $argument): bool
    {
        if ($argument->isVariadic()) {
            return false;
        }

        $class = $argument->getType();

        if (null === $class) {
            return false;
        }

        if (null === $request->attributes->get('data')) {
            return false;
        }

        $inputClass = $this->getExpectedInputClass($request);

        if (null === $inputClass) {
            return false;
        }

        return $inputClass === $class || is_subclass_of($inputClass, $class);
    }

    public function resolve(Request $request, ArgumentMetadata $argument): iterable
    {
        if (interface_exists(ValueResolverInterface::class)) {
            if (!$this->supports($request, $argument)) {
                return [];
            }
        }

        yield $request->attributes->get('data');
    }

    private function getExpectedInputClass(Request $request): ?string
    {
        $operation = $this->initializeOperation($request);
        if (Request::METHOD_DELETE === $request->getMethod() || $request->isMethodSafe() || !($operation?->canDeserialize() ?? true)) {
            return null;
        }

        $context = $this->serializationContextBuilder->createFromRequest($request, false, RequestAttributesExtractor::extractAttributes($request));

        return $context['input']['class'] ?? $context['resource_class'] ?? null;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\Bundle\ArgumentResolver;
15
16	use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
17	use ApiPlatform\State\SerializerContextBuilderInterface;
18	use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
19	use ApiPlatform\State\Util\RequestAttributesExtractor;
20	use Symfony\Component\HttpFoundation\Request;
21	use Symfony\Component\HttpKernel\Controller\ValueResolverInterface;
22	use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata;
23
24	final class PayloadArgumentResolver implements CompatibleValueResolverInterface
25	{
26	use OperationRequestInitiatorTrait;
27
28	public function __construct(
29	ResourceMetadataCollectionFactoryInterface $resourceMetadataCollectionFactory,
30	private readonly SerializerContextBuilderInterface $serializationContextBuilder,
31	) {
UNCOV 32	$this->resourceMetadataCollectionFactory = $resourceMetadataCollectionFactory;	16✔
33	}
34
35	public function supports(Request $request, ArgumentMetadata $argument): bool
36	{
UNCOV 37	if ($argument->isVariadic()) {	16✔
UNCOV 38	return false;	1✔
39	}
40
UNCOV 41	$class = $argument->getType();	15✔
42
UNCOV 43	if (null === $class) {	15✔
UNCOV 44	return false;	1✔
45	}
46
UNCOV 47	if (null === $request->attributes->get('data')) {	14✔
UNCOV 48	return false;	1✔
49	}
50
UNCOV 51	$inputClass = $this->getExpectedInputClass($request);	13✔
52
UNCOV 53	if (null === $inputClass) {	13✔
UNCOV 54	return false;	6✔
55	}
56
UNCOV 57	return $inputClass === $class \|\| is_subclass_of($inputClass, $class);	7✔
58	}
59
60	public function resolve(Request $request, ArgumentMetadata $argument): iterable
61	{
UNCOV 62	if (interface_exists(ValueResolverInterface::class)) {	4✔
UNCOV 63	if (!$this->supports($request, $argument)) {	4✔
64	return [];	×
65	}
66	}
67
UNCOV 68	yield $request->attributes->get('data');	4✔
69	}
70
71	private function getExpectedInputClass(Request $request): ?string
72	{
UNCOV 73	$operation = $this->initializeOperation($request);	13✔
UNCOV 74	if (Request::METHOD_DELETE === $request->getMethod() \|\| $request->isMethodSafe() \|\| !($operation?->canDeserialize() ?? true)) {	13✔
UNCOV 75	return null;	6✔
76	}
77
UNCOV 78	$context = $this->serializationContextBuilder->createFromRequest($request, false, RequestAttributesExtractor::extractAttributes($request));	7✔
79
UNCOV 80	return $context['input']['class'] ?? $context['resource_class'] ?? null;	7✔
81	}
82	}

api-platform / core / 15133993414

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous