15133993414

Committed 20 May 2025 09:30AM UTC coverage: 26.313% (-1.2%) from 27.493%

Build # 15133993414

Build Type

Pull #7161

github

Committed by

web-flow

Commit Message

Merge e2c03d45f into 5459ba375

Pull Request Pull Request #7161: fix(metadata): infer parameter string type from schema

Run Details

0 of 2 new or added lines in 1 file covered. (0.0%)

11019 existing lines in 363 files now uncovered.

12898 of 49018 relevant lines covered (26.31%)

34.33 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.0

/src/Doctrine/Orm/Metadata/Property/DoctrineOrmPropertyMetadataFactory.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Doctrine\Orm\Metadata\Property;

use ApiPlatform\Metadata\ApiProperty;
use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
use Doctrine\ORM\Mapping\ClassMetadata;
use Doctrine\ORM\Mapping\FieldMapping;
use Doctrine\Persistence\ManagerRegistry;

/**
 * Use Doctrine metadata to populate the identifier property.
 *
 * @author Kévin Dunglas <dunglas@gmail.com>
 */
final class DoctrineOrmPropertyMetadataFactory implements PropertyMetadataFactoryInterface
{
    public function __construct(private readonly ManagerRegistry $managerRegistry, private readonly PropertyMetadataFactoryInterface $decorated)
    {
    }

    /**
     * {@inheritdoc}
     */
    public function create(string $resourceClass, string $property, array $options = []): ApiProperty
    {
        $propertyMetadata = $this->decorated->create($resourceClass, $property, $options);

        if (null !== $propertyMetadata->isIdentifier()) {
            return $propertyMetadata;
        }

        $manager = $this->managerRegistry->getManagerForClass($resourceClass);
        if (!$manager) {
            return $propertyMetadata;
        }
        $doctrineClassMetadata = $manager->getClassMetadata($resourceClass);

        $identifiers = $doctrineClassMetadata->getIdentifier();
        foreach ($identifiers as $identifier) {
            if ($identifier === $property) {
                $propertyMetadata = $propertyMetadata->withIdentifier(true);

                if (null !== $propertyMetadata->isWritable()) {
                    break;
                }

                if ($doctrineClassMetadata instanceof ClassMetadata) {
                    $writable = $doctrineClassMetadata->isIdentifierNatural();
                } else {
                    $writable = false;
                }

                $propertyMetadata = $propertyMetadata->withWritable($writable);

                break;
            }
        }

        if ($doctrineClassMetadata instanceof ClassMetadata && \in_array($property, $doctrineClassMetadata->getFieldNames(), true)) {
            $fieldMapping = $doctrineClassMetadata->getFieldMapping($property);
            if (class_exists(FieldMapping::class) && $fieldMapping instanceof FieldMapping) {
                $propertyMetadata = $propertyMetadata->withDefault($fieldMapping->default ?? $propertyMetadata->getDefault());
            } else {
                $propertyMetadata = $propertyMetadata->withDefault($fieldMapping['options']['default'] ?? $propertyMetadata->getDefault());
            }
        }

        return $propertyMetadata;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Doctrine\Orm\Metadata\Property;
15
16	use ApiPlatform\Metadata\ApiProperty;
17	use ApiPlatform\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
18	use Doctrine\ORM\Mapping\ClassMetadata;
19	use Doctrine\ORM\Mapping\FieldMapping;
20	use Doctrine\Persistence\ManagerRegistry;
21
22	/**
23	* Use Doctrine metadata to populate the identifier property.
24	*
25	* @author Kévin Dunglas <dunglas@gmail.com>
26	*/
27	final class DoctrineOrmPropertyMetadataFactory implements PropertyMetadataFactoryInterface
28	{
29	public function __construct(private readonly ManagerRegistry $managerRegistry, private readonly PropertyMetadataFactoryInterface $decorated)
30	{
UNCOV 31	}	271✔
32
33	/**
34	* {@inheritdoc}
35	*/
36	public function create(string $resourceClass, string $property, array $options = []): ApiProperty
37	{
UNCOV 38	$propertyMetadata = $this->decorated->create($resourceClass, $property, $options);	74✔
39
UNCOV 40	if (null !== $propertyMetadata->isIdentifier()) {	74✔
41	return $propertyMetadata;	×
42	}
43
UNCOV 44	$manager = $this->managerRegistry->getManagerForClass($resourceClass);	74✔
UNCOV 45	if (!$manager) {	74✔
UNCOV 46	return $propertyMetadata;	49✔
47	}
UNCOV 48	$doctrineClassMetadata = $manager->getClassMetadata($resourceClass);	37✔
49
UNCOV 50	$identifiers = $doctrineClassMetadata->getIdentifier();	37✔
UNCOV 51	foreach ($identifiers as $identifier) {	37✔
UNCOV 52	if ($identifier === $property) {	37✔
UNCOV 53	$propertyMetadata = $propertyMetadata->withIdentifier(true);	35✔
54
UNCOV 55	if (null !== $propertyMetadata->isWritable()) {	35✔
UNCOV 56	break;	35✔
57	}
58
59	if ($doctrineClassMetadata instanceof ClassMetadata) {	×
60	$writable = $doctrineClassMetadata->isIdentifierNatural();	×
61	} else {
62	$writable = false;	×
63	}
64
65	$propertyMetadata = $propertyMetadata->withWritable($writable);	×
66
67	break;	×
68	}
69	}
70
UNCOV 71	if ($doctrineClassMetadata instanceof ClassMetadata && \in_array($property, $doctrineClassMetadata->getFieldNames(), true)) {	37✔
UNCOV 72	$fieldMapping = $doctrineClassMetadata->getFieldMapping($property);	37✔
UNCOV 73	if (class_exists(FieldMapping::class) && $fieldMapping instanceof FieldMapping) {	37✔
UNCOV 74	$propertyMetadata = $propertyMetadata->withDefault($fieldMapping->default ?? $propertyMetadata->getDefault());	37✔
75	} else {
76	$propertyMetadata = $propertyMetadata->withDefault($fieldMapping['options']['default'] ?? $propertyMetadata->getDefault());	×
77	}
78	}
79
UNCOV 80	return $propertyMetadata;	37✔
81	}
82	}

api-platform / core / 15133993414

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous