• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #4087

17 May 2025 01:40AM UTC coverage: 62.757% (-0.3%) from 63.048%
#4087

push

travis-ci

GitHub
fix: double close wal meta file. (#31059)

156587 of 317922 branches covered (49.25%)

Branch coverage included in aggregate %.

241845 of 316955 relevant lines covered (76.3%)

6570724.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

69.19
/source/libs/executor/src/sortoperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "executorInt.h"
17
#include "filter.h"
18
#include "operator.h"
19
#include "querytask.h"
20
#include "tdatablock.h"
21

22
typedef struct SSortOpGroupIdCalc {
23
  STupleHandle* pSavedTuple;
24
  SArray*       pSortColsArr;
25
  char*         keyBuf;
26
  int32_t       lastKeysLen; // default to be 0
27
  uint64_t      lastGroupId;
28
  bool          excludePKCol;
29
} SSortOpGroupIdCalc;
30

31
typedef struct SSortOperatorInfo {
32
  SOptrBasicInfo      binfo;
33
  uint32_t            sortBufSize;  // max buffer size for in-memory sort
34
  SArray*             pSortInfo;
35
  SSortHandle*        pSortHandle;
36
  SColMatchInfo       matchInfo;
37
  int32_t             bufPageSize;
38
  int64_t             startTs;      // sort start time
39
  uint64_t            sortElapsed;  // sort elapsed time, time to flush to disk not included.
40
  SLimitInfo          limitInfo;
41
  uint64_t            maxTupleLength;
42
  int64_t             maxRows;
43
  SSortOpGroupIdCalc* pGroupIdCalc;
44
} SSortOperatorInfo;
45

46
static int32_t doSort(SOperatorInfo* pOperator, SSDataBlock** pResBlock);
47
static int32_t doOpenSortOperator(SOperatorInfo* pOperator);
48
static int32_t getExplainExecInfo(SOperatorInfo* pOptr, void** pOptrExplain, uint32_t* len);
49
static int32_t doGroupSort(SOperatorInfo* pOperator, SSDataBlock** pResBlock);
50

51
static void destroySortOperatorInfo(void* param);
52
static void calcSortOperMaxTupleLength(SSortOperatorInfo* pSortOperInfo, SNodeList* pSortKeys);
53

54
static void destroySortOpGroupIdCalc(SSortOpGroupIdCalc* pCalc);
55

56
// todo add limit/offset impl
57
int32_t createSortOperatorInfo(SOperatorInfo* downstream, SSortPhysiNode* pSortNode, SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
228,867✔
58
  QRY_PARAM_CHECK(pOptrInfo);
228,867!
59

60
  int32_t code = 0;
228,867✔
61
  int32_t lino = 0;
228,867✔
62

63
  SSortOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SSortOperatorInfo));
228,867!
64
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
228,962!
65
  if (pInfo == NULL || pOperator == NULL) {
229,000!
66
    code = terrno;
×
67
    goto _error;
×
68
  }
69

70
  pOperator->pTaskInfo = pTaskInfo;
229,011✔
71
  SDataBlockDescNode* pDescNode = pSortNode->node.pOutputDataBlockDesc;
229,011✔
72

73
  int32_t numOfCols = 0;
229,011✔
74
  code = createExprInfo(pSortNode->pExprs, NULL, &pOperator->exprSupp.pExprInfo, &numOfCols);
229,011✔
75
  QUERY_CHECK_CODE(code, lino, _error);
228,993!
76

77
  pOperator->exprSupp.numOfExprs = numOfCols;
228,993✔
78
  int32_t numOfOutputCols = 0;
228,993✔
79
  code =
80
      extractColMatchInfo(pSortNode->pTargets, pDescNode, &numOfOutputCols, COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
228,993✔
81
  if (code != TSDB_CODE_SUCCESS) {
229,017!
82
    goto _error;
×
83
  }
84
  
85
  calcSortOperMaxTupleLength(pInfo, pSortNode->pSortKeys);
229,017✔
86
  pInfo->maxRows = -1;
229,004✔
87
  if (pSortNode->node.pLimit && ((SLimitNode*)pSortNode->node.pLimit)->limit) {
229,004✔
88
    SLimitNode* pLimit = (SLimitNode*)pSortNode->node.pLimit;
29,393✔
89
    if (pLimit->limit->datum.i > 0) {
29,393✔
90
      pInfo->maxRows = pLimit->limit->datum.i + (pLimit->offset ? pLimit->offset->datum.i : 0);
29,364✔
91
    }
92
  }
93

94
  pOperator->exprSupp.pCtx =
228,925✔
95
      createSqlFunctionCtx(pOperator->exprSupp.pExprInfo, numOfCols, &pOperator->exprSupp.rowEntryInfoOffset, &pTaskInfo->storageAPI.functionStore);
229,004✔
96
  QUERY_CHECK_NULL(pOperator->exprSupp.pCtx, code, lino, _error, terrno);
228,925!
97
  initResultSizeInfo(&pOperator->resultInfo, 1024);
228,925✔
98
  code = filterInitFromNode((SNode*)pSortNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0);
228,906✔
99
  if (code != TSDB_CODE_SUCCESS) {
228,950!
100
    goto _error;
×
101
  }
102

103
  pInfo->binfo.pRes = createDataBlockFromDescNode(pDescNode);
228,950✔
104
  QUERY_CHECK_NULL(pInfo->binfo.pRes, code, lino, _error, terrno);
229,012!
105

106
  pInfo->pSortInfo = createSortInfo(pSortNode->pSortKeys);
229,012✔
107
  TSDB_CHECK_NULL(pInfo->pSortInfo, code, lino, _error, terrno);
229,035✔
108

109
  if (pSortNode->calcGroupId) {
228,930✔
110
    int32_t keyLen;
111
    SSortOpGroupIdCalc* pGroupIdCalc = pInfo->pGroupIdCalc = taosMemoryCalloc(1, sizeof(SSortOpGroupIdCalc));
944!
112
    if (!pGroupIdCalc) {
944!
113
      code = terrno;
×
114
      goto _error;
×
115
    }
116
    SNodeList* pSortColsNodeArr = makeColsNodeArrFromSortKeys(pSortNode->pSortKeys);
944✔
117
    if (!pSortColsNodeArr) code = terrno;
944!
118
    if (TSDB_CODE_SUCCESS == code) {
944!
119
      pGroupIdCalc->pSortColsArr = makeColumnArrayFromList(pSortColsNodeArr);
944✔
120
      if (!pGroupIdCalc->pSortColsArr) code = terrno;
944!
121
      nodesClearList(pSortColsNodeArr);
944✔
122
    }
123
    if (TSDB_CODE_SUCCESS == code) {
944!
124
      // PK ts col should always at last, see partColOptCreateSort
125
      if (pSortNode->excludePkCol) taosArrayPop(pGroupIdCalc->pSortColsArr);
944✔
126
      code = extractKeysLen(pGroupIdCalc->pSortColsArr, &keyLen);
944✔
127
      QUERY_CHECK_CODE(code, lino, _error);
944!
128
    }
129
    if (TSDB_CODE_SUCCESS == code) {
944!
130
      pGroupIdCalc->lastKeysLen = 0;
944✔
131
      pGroupIdCalc->keyBuf = taosMemoryCalloc(1, keyLen);
944!
132
      if (!pGroupIdCalc->keyBuf) {
944!
133
        code = terrno;
×
134
      }
135
    }
136
  }
137
  if (code != TSDB_CODE_SUCCESS) goto _error;
228,930!
138

139
  pInfo->binfo.inputTsOrder = pSortNode->node.inputTsOrder;
228,930✔
140
  pInfo->binfo.outputTsOrder = pSortNode->node.outputTsOrder;
228,930✔
141
  initLimitInfo(pSortNode->node.pLimit, pSortNode->node.pSlimit, &pInfo->limitInfo);
228,930✔
142

143
  setOperatorInfo(pOperator, "SortOperator", QUERY_NODE_PHYSICAL_PLAN_SORT, true, OP_NOT_OPENED, pInfo, pTaskInfo);
229,017✔
144

145

146
  // lazy evaluation for the following parameter since the input datablock is not known till now.
147
  //  pInfo->bufPageSize  = rowSize < 1024 ? 1024 * 2 : rowSize * 2;
148
  //  there are headers, so pageSize = rowSize + header pInfo->sortBufSize  = pInfo->bufPageSize * 16;
149
  // TODO dynamic set the available sort buffer
150

151
  pOperator->fpSet =
152
      createOperatorFpSet(doOpenSortOperator, doSort, NULL, destroySortOperatorInfo, optrDefaultBufFn, getExplainExecInfo, optrDefaultGetNextExtFn, NULL);
229,003✔
153

154
  code = appendDownstream(pOperator, &downstream, 1);
228,976✔
155
  if (code != TSDB_CODE_SUCCESS) {
229,007!
156
    goto _error;
×
157
  }
158

159
  *pOptrInfo = pOperator;
229,007✔
160
  return TSDB_CODE_SUCCESS;
229,007✔
161

162
_error:
×
163
  if (pInfo != NULL) {
×
164
    destroySortOperatorInfo(pInfo);
×
165
  }
166
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
167
  pTaskInfo->code = code;
×
168
  return code;
×
169
}
170

171
int32_t appendOneRowToDataBlock(SSDataBlock* pBlock, STupleHandle* pTupleHandle) {
154,415,358✔
172
  int32_t code = 0;
154,415,358✔
173
  for (int32_t i = 0; i < taosArrayGetSize(pBlock->pDataBlock); ++i) {
829,468,938✔
174
    SColumnInfoData* pColInfo = taosArrayGet(pBlock->pDataBlock, i);
674,376,444✔
175
    if (pColInfo == NULL) {
668,855,179!
176
      return terrno;
×
177
    }
178

179
    bool isNull = tsortIsNullVal(pTupleHandle, i);
668,855,179✔
180
    if (isNull) {
664,377,512✔
181
      colDataSetNULL(pColInfo, pBlock->info.rows);
72,620,604✔
182
    } else {
183
      char* pData = NULL;
591,756,908✔
184
      tsortGetValue(pTupleHandle, i, (void**) &pData);
591,756,908✔
185

186
      if (pData != NULL) {
596,528,129✔
187
        code = colDataSetVal(pColInfo, pBlock->info.rows, pData, false);
596,263,454✔
188
        if (code) {
602,168,301!
189
          return code;
×
190
        }
191
      }
192
    }
193
  }
194

195
  pBlock->info.dataLoad = 1;
145,972,461✔
196

197
  SDataBlockInfo info = {0};
145,972,461✔
198
  tsortGetBlockInfo(pTupleHandle, &info);
145,972,461✔
199

200
  pBlock->info.scanFlag = info.scanFlag;
155,073,707✔
201
  pBlock->info.rows += 1;
155,073,707✔
202
  return code;
155,073,707✔
203
}
204

205
/**
206
 * @brief get next tuple with group id attached, here assume that all tuples are sorted by group keys
207
 * @param [in, out] pBlock the output block, the group id will be saved in it
208
 * @retval NULL if next group tuple arrived and this new group tuple will be saved in pInfo.pSavedTuple
209
 */
210
static int32_t nextTupleWithGroupId(SSortHandle* pHandle, SSortOperatorInfo* pInfo, SSDataBlock* pBlock,
21,783,835✔
211
                                    STupleHandle** pTupleHandle) {
212
  QRY_PARAM_CHECK(pTupleHandle);
21,783,835!
213

214
  int32_t       code = 0;
21,783,835✔
215
  STupleHandle* retTuple = pInfo->pGroupIdCalc->pSavedTuple;
21,783,835✔
216
  if (!retTuple) {
21,783,835✔
217
    code = tsortNextTuple(pHandle, &retTuple);
21,312,545✔
218
    if (code) {
21,388,618✔
219
      qError("failed to get next tuple, code:%s", tstrerror(code));
15,764!
220
      return code;
×
221
    }
222
  }
223

224
  if (retTuple) {
21,844,144!
225
    int32_t newGroup;
226
    if (pInfo->pGroupIdCalc->pSavedTuple) {
21,851,735✔
227
      newGroup = true;
479,119✔
228
      pInfo->pGroupIdCalc->pSavedTuple = NULL;
479,119✔
229
    } else {
230
      newGroup = tsortCompAndBuildKeys(pInfo->pGroupIdCalc->pSortColsArr, pInfo->pGroupIdCalc->keyBuf,
21,372,616✔
231
                                       &pInfo->pGroupIdCalc->lastKeysLen, retTuple);
21,372,616✔
232
    }
233

234
    bool emptyBlock = (pBlock->info.rows == 0);
21,753,883✔
235
    if (newGroup) {
21,753,883✔
236
      if (!emptyBlock) {
955,912✔
237
        // new group arrived, and we have already copied some tuples for cur group, save the new group tuple, return
238
        // NULL. Note that the keyBuf and lastKeysLen has been updated to new value
239
        pInfo->pGroupIdCalc->pSavedTuple = retTuple;
481,537✔
240
        retTuple = NULL;
481,537✔
241
      } else {
242
        // new group with empty block
243
        pInfo->pGroupIdCalc->lastGroupId = pBlock->info.id.groupId =
483,568✔
244
            calcGroupId(pInfo->pGroupIdCalc->keyBuf, pInfo->pGroupIdCalc->lastKeysLen);
474,375✔
245
      }
246
    } else {
247
      if (emptyBlock) {
20,797,971✔
248
        // new block but not new group, assign last group id to it
249
        pBlock->info.id.groupId = pInfo->pGroupIdCalc->lastGroupId;
6,795✔
250
      } else {
251
        // not new group and not empty block and ret NOT NULL, just return the tuple
252
      }
253
    }
254
  }
255

256
  *pTupleHandle = retTuple;
21,755,485✔
257
  return code;
21,755,485✔
258
}
259

260
static int32_t getSortedBlockData(SSortHandle* pHandle, SSDataBlock* pDataBlock, int32_t capacity, SArray* pColMatchInfo,
938,539✔
261
                                SSortOperatorInfo* pInfo, SSDataBlock** pResBlock) {
262
  QRY_PARAM_CHECK(pResBlock);
938,539!
263
  blockDataCleanup(pDataBlock);
938,539✔
264

265
  int32_t       lino = 0;
932,135✔
266
  int32_t       code = 0;
932,135✔
267
  STupleHandle* pTupleHandle = NULL;
932,135✔
268
  SSDataBlock*  p = NULL;
932,135✔
269

270
  code = tsortGetSortedDataBlock(pHandle, &p);
932,135✔
271
  if (p == NULL || (code != 0)) {
935,684!
272
    return code;
39,602✔
273
  }
274

275
  code = blockDataEnsureCapacity(p, capacity);
896,082✔
276
  QUERY_CHECK_CODE(code, lino, _error);
896,909!
277

278
  while (1) {
279
    if (pInfo->pGroupIdCalc) {
64,517,753✔
280
      code = nextTupleWithGroupId(pHandle, pInfo, p, &pTupleHandle);
21,789,717✔
281
    } else {
282
      code = tsortNextTuple(pHandle, &pTupleHandle);
42,728,036✔
283
    }
284

285
    TSDB_CHECK_CODE(code, lino, _error);
64,483,003!
286
    if (pTupleHandle == NULL) {
64,483,003✔
287
      break;
855,109✔
288
    }
289

290
    code = appendOneRowToDataBlock(p, pTupleHandle);
63,627,894✔
291
    QUERY_CHECK_CODE(code, lino, _error);
63,657,099!
292

293
    if (p->info.rows >= capacity) {
63,657,099✔
294
      break;
36,255✔
295
    }
296
  }
297

298
  QUERY_CHECK_CODE(code, lino, _error);
891,364!
299

300
  if (p->info.rows > 0) {
891,364✔
301
    code = blockDataEnsureCapacity(pDataBlock, capacity);
714,672✔
302
    QUERY_CHECK_CODE(code, lino, _error);
714,077!
303

304
    // todo extract function to handle this
305
    int32_t numOfCols = taosArrayGetSize(pColMatchInfo);
714,077✔
306
    for (int32_t i = 0; i < numOfCols; ++i) {
3,327,300✔
307
      SColMatchItem* pmInfo = taosArrayGet(pColMatchInfo, i);
2,617,591✔
308
      QUERY_CHECK_NULL(pmInfo, code, lino, _error, terrno);
2,612,765!
309

310
      SColumnInfoData* pSrc = taosArrayGet(p->pDataBlock, pmInfo->srcSlotId);
2,612,765✔
311
      QUERY_CHECK_NULL(pSrc, code, lino, _error, terrno);
2,608,706!
312

313
      SColumnInfoData* pDst = taosArrayGet(pDataBlock->pDataBlock, pmInfo->dstSlotId);
2,608,706✔
314
      QUERY_CHECK_NULL(pDst, code, lino, _error, terrno);
2,603,754!
315

316
      code = colDataAssign(pDst, pSrc, p->info.rows, &pDataBlock->info);
2,603,754✔
317
      QUERY_CHECK_CODE(code, lino, _error);
2,613,785!
318
    }
319

320
    pDataBlock->info.dataLoad = 1;
709,709✔
321
    pDataBlock->info.rows = p->info.rows;
709,709✔
322
    pDataBlock->info.scanFlag = p->info.scanFlag;
709,709✔
323
    pDataBlock->info.id.groupId = p->info.id.groupId;
709,709✔
324
  }
325

326
  blockDataDestroy(p);
886,401✔
327
  *pResBlock = (pDataBlock->info.rows > 0) ? pDataBlock : NULL;
899,088✔
328
  return code;
899,088✔
329

330
  _error:
×
331
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
332

333
  blockDataDestroy(p);
×
334
  return code;
×
335
}
336

337
int32_t loadNextDataBlock(void* param, SSDataBlock** ppBlock) {
752,388✔
338
  SOperatorInfo* pOperator = (SOperatorInfo*)param;
752,388✔
339
  int32_t        code = pOperator->fpSet.getNextFn(pOperator, ppBlock);
752,388✔
340
  if (code) {
752,375!
341
    qError("failed to get next data block from upstream, %s code:%s", __func__, tstrerror(code));
×
342
  } else {
343
    code = blockDataCheck(*ppBlock);
752,375✔
344
    if (code) {
752,402!
345
      qError("failed to check block data, %s code:%s", __func__, tstrerror(code));
×
346
    }
347
  }
348
  return code;
752,382✔
349
}
350

351
// todo refactor: merged with fetch fp
352
void applyScalarFunction(SSDataBlock* pBlock, void* param) {
523,597✔
353
  SOperatorInfo*     pOperator = param;
523,597✔
354
  SSortOperatorInfo* pSort = pOperator->info;
523,597✔
355
  if (pOperator->exprSupp.pExprInfo != NULL && pOperator->exprSupp.numOfExprs > 0) {
523,597!
356
    int32_t code = projectApplyFunctions(pOperator->exprSupp.pExprInfo, pBlock, pBlock, pOperator->exprSupp.pCtx,
711✔
357
                                         pOperator->exprSupp.numOfExprs, NULL);
358
    if (code != TSDB_CODE_SUCCESS) {
711!
359
      T_LONG_JMP(pOperator->pTaskInfo->env, code);
×
360
    }
361
  }
362
}
523,597✔
363

364
int32_t doOpenSortOperator(SOperatorInfo* pOperator) {
935,613✔
365
  SSortOperatorInfo* pInfo = pOperator->info;
935,613✔
366
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
935,613✔
367
  int32_t            code = TSDB_CODE_SUCCESS;
935,613✔
368
  int32_t            lino = 0;
935,613✔
369
  SSortSource* pSource =NULL;
935,613✔
370

371
  if (OPTR_IS_OPENED(pOperator)) {
935,613✔
372
    return code;
706,752✔
373
  }
374

375
  pInfo->startTs = taosGetTimestampUs();
228,939✔
376
  //  pInfo->binfo.pRes is not equalled to the input datablock.
377
  pInfo->pSortHandle = NULL;
228,939✔
378
  code =
379
      tsortCreateSortHandle(pInfo->pSortInfo, SORT_SINGLESOURCE_SORT, -1, -1, NULL, pTaskInfo->id.str, pInfo->maxRows,
228,939✔
380
                            pInfo->maxTupleLength, tsPQSortMemThreshold * 1024 * 1024, &pInfo->pSortHandle);
228,939✔
381
  QUERY_CHECK_CODE(code, lino, _end);
228,878!
382

383
  tsortSetFetchRawDataFp(pInfo->pSortHandle, loadNextDataBlock, applyScalarFunction, pOperator);
228,878✔
384

385
  pSource = taosMemoryCalloc(1, sizeof(SSortSource));
228,832!
386
  QUERY_CHECK_NULL(pSource, code, lino, _end, terrno);
229,039!
387

388
  pSource->param = pOperator->pDownstream[0];
229,039✔
389
  pSource->onlyRef = true;
229,039✔
390

391
  code = tsortAddSource(pInfo->pSortHandle, pSource);
229,039✔
392
  QUERY_CHECK_CODE(code, lino, _end);
228,914!
393
  pSource = NULL;
228,914✔
394

395
  code = tsortOpen(pInfo->pSortHandle);
228,914✔
396
  QUERY_CHECK_CODE(code, lino, _end);
229,013!
397
  pOperator->cost.openCost = (taosGetTimestampUs() - pInfo->startTs) / 1000.0;
229,040✔
398
  pOperator->status = OP_RES_TO_RETURN;
229,040✔
399
  OPTR_SET_OPENED(pOperator);
229,040✔
400

401
_end:
229,040✔
402
  if (pSource) {
229,040!
403
    taosMemoryFree(pSource);
×
404
  }
405
  if (code != TSDB_CODE_SUCCESS) {
229,041!
406
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
407
    pTaskInfo->code = code;
×
408
    T_LONG_JMP(pTaskInfo->env, code);
×
409
  }
410
  return code;
229,041✔
411
}
412

413
int32_t doSort(SOperatorInfo* pOperator, SSDataBlock** pResBlock) {
936,127✔
414
  QRY_PARAM_CHECK(pResBlock);
936,127!
415
  int32_t code = TSDB_CODE_SUCCESS;
936,127✔
416
  int32_t lino = 0;
936,127✔
417
  if (pOperator->status == OP_EXEC_DONE) {
936,127✔
418
    return code;
4✔
419
  }
420

421
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
936,123✔
422
  SSortOperatorInfo* pInfo = pOperator->info;
936,123✔
423

424
  code = pOperator->fpSet._openFn(pOperator);
936,123✔
425
  QUERY_CHECK_CODE(code, lino, _end);
935,482!
426

427
  // multi-group case not handle here
428
  SSDataBlock* pBlock = NULL;
935,482✔
429
  while (1) {
395✔
430
    if (tsortIsClosed(pInfo->pSortHandle)) {
935,877!
431
      code = TSDB_CODE_TSC_QUERY_CANCELLED;
×
432
      QUERY_CHECK_CODE(code, lino, _end);
×
433
    }
434

435
    code = getSortedBlockData(pInfo->pSortHandle, pInfo->binfo.pRes, pOperator->resultInfo.capacity,
939,135✔
436
                                pInfo->matchInfo.pList, pInfo, &pBlock);
437
    QUERY_CHECK_CODE(code, lino, _end);
938,009!
438
    if (pBlock == NULL) {
938,009✔
439
      setOperatorCompleted(pOperator);
223,629✔
440
      return code;
223,627✔
441
    }
442

443
    code = doFilter(pBlock, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo);
714,380✔
444
    QUERY_CHECK_CODE(code, lino, _end);
713,863!
445

446
    if (blockDataGetNumOfRows(pBlock) == 0) {
713,863!
447
      continue;
×
448
    }
449

450
    // there are bugs?
451
    bool limitReached = applyLimitOffset(&pInfo->limitInfo, pBlock, pTaskInfo);
713,494✔
452
    if (limitReached) {
713,047✔
453
      resetLimitInfoForNextGroup(&pInfo->limitInfo);
15,619✔
454
    }
455

456
    pOperator->resultInfo.totalRows += pBlock->info.rows;
713,094✔
457
    if (pBlock->info.rows > 0) {
713,094✔
458
      break;
712,699✔
459
    }
460
  }
461

462
  *pResBlock = blockDataGetNumOfRows(pBlock) > 0 ? pBlock : NULL;
712,699!
463
_end:
712,025✔
464
  if (code != TSDB_CODE_SUCCESS) {
712,025!
465
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
466
    pTaskInfo->code = code;
×
467
    T_LONG_JMP(pTaskInfo->env, code);
×
468
  }
469
  return code;
712,025✔
470
}
471

472
void destroySortOperatorInfo(void* param) {
229,019✔
473
  SSortOperatorInfo* pInfo = (SSortOperatorInfo*)param;
229,019✔
474
  blockDataDestroy(pInfo->binfo.pRes);
229,019✔
475
  pInfo->binfo.pRes = NULL;
229,058✔
476

477
  tsortDestroySortHandle(pInfo->pSortHandle);
229,058✔
478
  taosArrayDestroy(pInfo->pSortInfo);
229,058✔
479
  taosArrayDestroy(pInfo->matchInfo.pList);
229,057✔
480
  destroySortOpGroupIdCalc(pInfo->pGroupIdCalc);
229,059✔
481
  taosMemoryFreeClear(param);
229,046!
482
}
229,046✔
483

484
int32_t getExplainExecInfo(SOperatorInfo* pOptr, void** pOptrExplain, uint32_t* len) {
303✔
485
  SSortExecInfo* pInfo = taosMemoryCalloc(1, sizeof(SSortExecInfo));
303!
486
  if (pInfo == NULL) {
303!
487
    return terrno;
×
488
  }
489

490
  SSortOperatorInfo* pOperatorInfo = (SSortOperatorInfo*)pOptr->info;
303✔
491

492
  *pInfo = tsortGetSortExecInfo(pOperatorInfo->pSortHandle);
303✔
493
  *pOptrExplain = pInfo;
303✔
494
  *len = sizeof(SSortExecInfo);
303✔
495
  return TSDB_CODE_SUCCESS;
303✔
496
}
497

498
static void calcSortOperMaxTupleLength(SSortOperatorInfo* pSortOperInfo, SNodeList* pSortKeys) {
228,934✔
499
  SColMatchInfo* pColItem = &pSortOperInfo->matchInfo;
228,934✔
500
  size_t         size = taosArrayGetSize(pColItem->pList);
228,934✔
501
  for (size_t i = 0; i < size; ++i) {
1,231,573✔
502
    SColMatchItem* pInfo = taosArrayGet(pColItem->pList, i);
1,002,575✔
503
    if (pInfo == NULL) {
1,002,588!
504
      continue;
×
505
    }
506

507
    pSortOperInfo->maxTupleLength += pInfo->dataType.bytes;
1,002,588✔
508
  }
509

510
  size = LIST_LENGTH(pSortKeys);
228,998!
511
  for (size_t i = 0; i < size; ++i) {
580,256✔
512
    SOrderByExprNode* pOrderExprNode = (SOrderByExprNode*)nodesListGetNode(pSortKeys, i);
351,252✔
513
    pSortOperInfo->maxTupleLength += ((SColumnNode*)pOrderExprNode->pExpr)->node.resType.bytes;
351,258✔
514
  }
515
}
229,004✔
516

517
static void destroySortOpGroupIdCalc(SSortOpGroupIdCalc* pCalc) {
229,044✔
518
  if (pCalc) {
229,044✔
519
    taosArrayDestroy(pCalc->pSortColsArr);
944✔
520
    taosMemoryFree(pCalc->keyBuf);
944!
521
    taosMemoryFree(pCalc);
944!
522
  }
523
}
229,044✔
524

525
//=====================================================================================
526
// Group Sort Operator
527
typedef enum EChildOperatorStatus { CHILD_OP_NEW_GROUP, CHILD_OP_SAME_GROUP, CHILD_OP_FINISHED } EChildOperatorStatus;
528

529
typedef struct SGroupSortOperatorInfo {
530
  SOptrBasicInfo       binfo;
531
  SArray*              pSortInfo;
532
  SColMatchInfo        matchInfo;
533
  int64_t              startTs;
534
  uint64_t             sortElapsed;
535
  bool                 hasGroupId;
536
  uint64_t             currGroupId;
537
  SSDataBlock*         prefetchedSortInput;
538
  SSortHandle*         pCurrSortHandle;
539
  EChildOperatorStatus childOpStatus;
540
  SSortExecInfo        sortExecInfo;
541
} SGroupSortOperatorInfo;
542

543
int32_t getGroupSortedBlockData(SSortHandle* pHandle, SSDataBlock* pDataBlock, int32_t capacity, SArray* pColMatchInfo,
360✔
544
                                SGroupSortOperatorInfo* pInfo, SSDataBlock** pResBlock) {
545
  QRY_PARAM_CHECK(pResBlock);
360!
546

547
  blockDataCleanup(pDataBlock);
360✔
548
  int32_t code = blockDataEnsureCapacity(pDataBlock, capacity);
360✔
549
  if (code) {
360!
550
    return code;
×
551
  }
552

553
  SSDataBlock* p = NULL;
360✔
554
  code = tsortGetSortedDataBlock(pHandle, &p);
360✔
555
  if (p == NULL || (code != 0)) {
360!
556
    return code;
×
557
  }
558

559
  code = blockDataEnsureCapacity(p, capacity);
360✔
560
  if (code) {
360!
561
    return code;
×
562
  }
563

564
  while (1) {
18,000✔
565
    STupleHandle* pTupleHandle = NULL;
18,360✔
566
    code = tsortNextTuple(pHandle, &pTupleHandle);
18,360✔
567
    if (pTupleHandle == NULL || code != 0) {
18,360!
568
      break;
569
    }
570

571
    code = appendOneRowToDataBlock(p, pTupleHandle);
18,000✔
572
    if (code) {
18,000!
573
      break;
×
574
    }
575

576
    if (p->info.rows >= capacity) {
18,000!
577
      break;
×
578
    }
579
  }
580

581
  if (p->info.rows > 0) {
360✔
582
    int32_t numOfCols = taosArrayGetSize(pColMatchInfo);
180✔
583
    for (int32_t i = 0; i < numOfCols; ++i) {
540✔
584
      SColMatchItem* pmInfo = taosArrayGet(pColMatchInfo, i);
360✔
585
      if (pmInfo == NULL) {
360!
586
        return terrno;
×
587
      }
588

589
      SColumnInfoData* pSrc = taosArrayGet(p->pDataBlock, pmInfo->srcSlotId);
360✔
590
      if (pSrc == NULL) {
360!
591
        return terrno;
×
592
      }
593

594
      SColumnInfoData* pDst = taosArrayGet(pDataBlock->pDataBlock, pmInfo->dstSlotId);
360✔
595
      if (pDst == NULL) {
360!
596
        return terrno;
×
597
      }
598

599
      code = colDataAssign(pDst, pSrc, p->info.rows, &pDataBlock->info);
360✔
600
      if (code) {
360!
601
        return code;
×
602
      }
603
    }
604

605
    pDataBlock->info.rows = p->info.rows;
180✔
606
    pDataBlock->info.capacity = p->info.rows;
180✔
607
    pDataBlock->info.scanFlag = p->info.scanFlag;
180✔
608
  }
609

610
  blockDataDestroy(p);
360✔
611
  *pResBlock = (pDataBlock->info.rows > 0) ? pDataBlock : NULL;
360✔
612
  return code;
360✔
613
}
614

615
typedef struct SGroupSortSourceParam {
616
  SOperatorInfo*          childOpInfo;
617
  SGroupSortOperatorInfo* grpSortOpInfo;
618
} SGroupSortSourceParam;
619

620
int32_t fetchNextGroupSortDataBlock(void* param, SSDataBlock** ppBlock) {
360✔
621
  int32_t                 code = 0;
360✔
622
  int32_t                 lino = 0;
360✔
623
  SGroupSortSourceParam*  source = param;
360✔
624
  SGroupSortOperatorInfo* grpSortOpInfo = source->grpSortOpInfo;
360✔
625
  SSDataBlock*            block = NULL;
360✔
626

627
  QRY_PARAM_CHECK(ppBlock);
360!
628

629
  if (grpSortOpInfo->prefetchedSortInput) {
360✔
630
    block = grpSortOpInfo->prefetchedSortInput;
180✔
631
    grpSortOpInfo->prefetchedSortInput = NULL;
180✔
632
    *ppBlock = block;
180✔
633
  } else {
634
    SOperatorInfo* childOp = source->childOpInfo;
180✔
635
    code = childOp->fpSet.getNextFn(childOp, &block);
180✔
636
    QUERY_CHECK_CODE(code, lino, _end);
180!
637

638
    if (block != NULL) {
180!
639
      code = blockDataCheck(block);
×
640
      QUERY_CHECK_CODE(code, lino, _end);
×
641
      if (block->info.id.groupId == grpSortOpInfo->currGroupId) {
×
642
        grpSortOpInfo->childOpStatus = CHILD_OP_SAME_GROUP;
×
643
        *ppBlock = block;
×
644
      } else {
645
        grpSortOpInfo->childOpStatus = CHILD_OP_NEW_GROUP;
×
646
        grpSortOpInfo->prefetchedSortInput = block;
×
647
      }
648
    } else {
649
      grpSortOpInfo->childOpStatus = CHILD_OP_FINISHED;
180✔
650
    }
651
  }
652

653
  return code;
360✔
654
_end:
×
655
  if (code != 0) {
×
656
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
657
  }
658
  return code;
×
659
}
660

661
int32_t beginSortGroup(SOperatorInfo* pOperator) {
180✔
662
  SGroupSortOperatorInfo* pInfo = pOperator->info;
180✔
663
  SExecTaskInfo*          pTaskInfo = pOperator->pTaskInfo;
180✔
664

665
  //  pInfo->binfo.pRes is not equalled to the input datablock.
666
  pInfo->pCurrSortHandle = NULL;
180✔
667

668
  int32_t code = tsortCreateSortHandle(pInfo->pSortInfo, SORT_SINGLESOURCE_SORT, -1, -1, NULL, pTaskInfo->id.str, 0, 0,
180✔
669
                                       0, &pInfo->pCurrSortHandle);
670
  if (code) {
180!
671
    return code;
×
672
  }
673

674
  tsortSetFetchRawDataFp(pInfo->pCurrSortHandle, fetchNextGroupSortDataBlock, applyScalarFunction, pOperator);
180✔
675

676
  SSortSource*           ps = taosMemoryCalloc(1, sizeof(SSortSource));
180!
677
  SGroupSortSourceParam* param = taosMemoryCalloc(1, sizeof(SGroupSortSourceParam));
180!
678
  if (ps == NULL || param == NULL) {
180!
679
    taosMemoryFree(ps);
×
680
    taosMemoryFree(param);
×
681
    return terrno;
×
682
  }
683

684
  param->childOpInfo = pOperator->pDownstream[0];
180✔
685
  param->grpSortOpInfo = pInfo;
180✔
686

687
  ps->param = param;
180✔
688
  ps->onlyRef = false;
180✔
689
  code = tsortAddSource(pInfo->pCurrSortHandle, ps);
180✔
690
  if (code != 0) {
180!
691
    return code;
×
692
  }
693

694
  code = tsortOpen(pInfo->pCurrSortHandle);
180✔
695
  return code;
180✔
696
}
697

698
int32_t finishSortGroup(SOperatorInfo* pOperator) {
180✔
699
  SGroupSortOperatorInfo* pInfo = pOperator->info;
180✔
700

701
  SSortExecInfo sortExecInfo = tsortGetSortExecInfo(pInfo->pCurrSortHandle);
180✔
702

703
  pInfo->sortExecInfo.sortMethod = sortExecInfo.sortMethod;
180✔
704
  pInfo->sortExecInfo.sortBuffer = sortExecInfo.sortBuffer;
180✔
705
  pInfo->sortExecInfo.loops += sortExecInfo.loops;
180✔
706
  pInfo->sortExecInfo.readBytes += sortExecInfo.readBytes;
180✔
707
  pInfo->sortExecInfo.writeBytes += sortExecInfo.writeBytes;
180✔
708

709
  tsortDestroySortHandle(pInfo->pCurrSortHandle);
180✔
710
  pInfo->pCurrSortHandle = NULL;
180✔
711

712
  return TSDB_CODE_SUCCESS;
180✔
713
}
714

715
int32_t doGroupSort(SOperatorInfo* pOperator, SSDataBlock** pResBlock) {
385✔
716
  QRY_PARAM_CHECK(pResBlock);
385!
717
  SExecTaskInfo*          pTaskInfo = pOperator->pTaskInfo;
385✔
718
  SGroupSortOperatorInfo* pInfo = pOperator->info;
385✔
719
  int32_t                 code = TSDB_CODE_SUCCESS;
385✔
720
  int32_t                 lino = 0;
385✔
721

722
  if (pOperator->status == OP_EXEC_DONE) {
385!
723
    return code;
×
724
  }
725

726
  code = pOperator->fpSet._openFn(pOperator);
385✔
727
  QUERY_CHECK_CODE(code, lino, _end);
385!
728

729
  if (!pInfo->hasGroupId) {
385✔
730
    pInfo->hasGroupId = true;
205✔
731

732
    pInfo->prefetchedSortInput = getNextBlockFromDownstream(pOperator, 0);
205✔
733
    if (pInfo->prefetchedSortInput == NULL) {
205✔
734
      setOperatorCompleted(pOperator);
25✔
735
      return code;
25✔
736
    }
737

738
    pInfo->currGroupId = pInfo->prefetchedSortInput->info.id.groupId;
180✔
739
    pInfo->childOpStatus = CHILD_OP_NEW_GROUP;
180✔
740
    code = beginSortGroup(pOperator);
180✔
741
    QUERY_CHECK_CODE(code, lino, _end);
180!
742
  }
743

744
  SSDataBlock* pBlock = NULL;
360✔
745
  while (pInfo->pCurrSortHandle != NULL) {
360!
746
    if (tsortIsClosed(pInfo->pCurrSortHandle)) {
360!
747
      code = TSDB_CODE_TSC_QUERY_CANCELLED;
×
748
      QUERY_CHECK_CODE(code, lino, _end);
×
749
    }
750

751
    // beginSortGroup would fetch all child blocks of pInfo->currGroupId;
752
    if (pInfo->childOpStatus == CHILD_OP_SAME_GROUP) {
360!
753
      code = TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR;
×
754
      QUERY_CHECK_CODE(code, lino, _end);
×
755
    }
756

757
    code = getGroupSortedBlockData(pInfo->pCurrSortHandle, pInfo->binfo.pRes, pOperator->resultInfo.capacity,
360✔
758
                                     pInfo->matchInfo.pList, pInfo, &pBlock);
759
    QUERY_CHECK_CODE(code, lino, _end);
360!
760
    if (pBlock != NULL) {
360✔
761
      pBlock->info.id.groupId = pInfo->currGroupId;
180✔
762
      pOperator->resultInfo.totalRows += pBlock->info.rows;
180✔
763
      *pResBlock = pBlock;
180✔
764
      return code;
180✔
765
    } else {
766
      if (pInfo->childOpStatus == CHILD_OP_NEW_GROUP) {
180!
767
        (void) finishSortGroup(pOperator);
×
768
        pInfo->currGroupId = pInfo->prefetchedSortInput->info.id.groupId;
×
769
        code = beginSortGroup(pOperator);
×
770
        QUERY_CHECK_CODE(code, lino, _end);
×
771
      } else if (pInfo->childOpStatus == CHILD_OP_FINISHED) {
180!
772
        (void) finishSortGroup(pOperator);
180✔
773
        setOperatorCompleted(pOperator);
180✔
774
        return code;
180✔
775
      }
776
    }
777
  }
778

779
_end:
×
780
  if (code != TSDB_CODE_SUCCESS) {
×
781
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
782
    pTaskInfo->code = code;
×
783
    T_LONG_JMP(pTaskInfo->env, code);
×
784
  }
785
  return code;
×
786
}
787

788
int32_t getGroupSortExplainExecInfo(SOperatorInfo* pOptr, void** pOptrExplain, uint32_t* len) {
×
789
  SGroupSortOperatorInfo* pInfo = (SGroupSortOperatorInfo*)pOptr->info;
×
790
  *pOptrExplain = &pInfo->sortExecInfo;
×
791
  *len = sizeof(SSortExecInfo);
×
792
  return TSDB_CODE_SUCCESS;
×
793
}
794

795
void destroyGroupSortOperatorInfo(void* param) {
205✔
796
  SGroupSortOperatorInfo* pInfo = (SGroupSortOperatorInfo*)param;
205✔
797
  blockDataDestroy(pInfo->binfo.pRes);
205✔
798
  pInfo->binfo.pRes = NULL;
205✔
799

800
  taosArrayDestroy(pInfo->pSortInfo);
205✔
801
  taosArrayDestroy(pInfo->matchInfo.pList);
205✔
802

803
  tsortDestroySortHandle(pInfo->pCurrSortHandle);
205✔
804
  pInfo->pCurrSortHandle = NULL;
205✔
805

806
  taosMemoryFreeClear(param);
205!
807
}
205✔
808

809
int32_t createGroupSortOperatorInfo(SOperatorInfo* downstream, SGroupSortPhysiNode* pSortPhyNode,
205✔
810
                                    SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
811
  QRY_PARAM_CHECK(pOptrInfo);
205!
812
  int32_t code = 0;
205✔
813
  int32_t lino = 0;
205✔
814

815
  SGroupSortOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SGroupSortOperatorInfo));
205!
816
  SOperatorInfo*          pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
205!
817
  if (pInfo == NULL || pOperator == NULL) {
205!
818
    code = terrno;
×
819
    goto _error;
×
820
  }
821

822
  SExprSupp*          pSup = &pOperator->exprSupp;
205✔
823
  SDataBlockDescNode* pDescNode = pSortPhyNode->node.pOutputDataBlockDesc;
205✔
824

825
  int32_t    numOfCols = 0;
205✔
826
  SExprInfo* pExprInfo = NULL;
205✔
827
  code = createExprInfo(pSortPhyNode->pExprs, NULL, &pExprInfo, &numOfCols);
205✔
828
  QUERY_CHECK_CODE(code, lino, _error);
205!
829

830
  pSup->pExprInfo = pExprInfo;
205✔
831
  pSup->numOfExprs = numOfCols;
205✔
832

833
  initResultSizeInfo(&pOperator->resultInfo, 1024);
205✔
834
  pOperator->exprSupp.pCtx = createSqlFunctionCtx(pExprInfo, numOfCols, &pOperator->exprSupp.rowEntryInfoOffset,
205✔
835
                                                  &pTaskInfo->storageAPI.functionStore);
836
  QUERY_CHECK_NULL(pOperator->exprSupp.pCtx, code, lino, _error, terrno);
205!
837

838
  pInfo->binfo.pRes = createDataBlockFromDescNode(pDescNode);
205✔
839
  QUERY_CHECK_NULL(pInfo->binfo.pRes, code, lino, _error, terrno);
205!
840

841
  code = blockDataEnsureCapacity(pInfo->binfo.pRes, pOperator->resultInfo.capacity);
205✔
842
  TSDB_CHECK_CODE(code, lino, _error);
205!
843

844
  pInfo->binfo.inputTsOrder = pSortPhyNode->node.inputTsOrder;
205✔
845
  pInfo->binfo.outputTsOrder = pSortPhyNode->node.outputTsOrder;
205✔
846

847
  int32_t numOfOutputCols = 0;
205✔
848
  code = extractColMatchInfo(pSortPhyNode->pTargets, pDescNode, &numOfOutputCols, COL_MATCH_FROM_SLOT_ID,
205✔
849
                             &pInfo->matchInfo);
850
  TSDB_CHECK_CODE(code, lino, _error);
205!
851

852
  pInfo->pSortInfo = createSortInfo(pSortPhyNode->pSortKeys);
205✔
853
  setOperatorInfo(pOperator, "GroupSortOperator", QUERY_NODE_PHYSICAL_PLAN_GROUP_SORT, false, OP_NOT_OPENED, pInfo,
205✔
854
                  pTaskInfo);
855
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doGroupSort, NULL, destroyGroupSortOperatorInfo,
205✔
856
                                         optrDefaultBufFn, getGroupSortExplainExecInfo, optrDefaultGetNextExtFn, NULL);
857

858
  code = appendDownstream(pOperator, &downstream, 1);
205✔
859
  if (code != TSDB_CODE_SUCCESS) {
205!
860
    goto _error;
×
861
  }
862

863
  *pOptrInfo = pOperator;
205✔
864
  return TSDB_CODE_SUCCESS;
205✔
865

866
_error:
×
867
  pTaskInfo->code = code;
×
868
  if (pInfo != NULL) {
×
869
    destroyGroupSortOperatorInfo(pInfo);
×
870
  }
871
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
872
  return code;
×
873
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc