#4087

Committed 17 May 2025 01:40AM UTC coverage: 62.757% (-0.3%) from 63.048%

Build # #4087

Build Type

push

travis-ci

Committed by GitHub

Commit Message

fix: double close wal meta file. (#31059)

Run Details

156587 of 317922 branches covered (49.25%)

Branch coverage included in aggregate %.

241845 of 316955 relevant lines covered (76.3%)

6570724.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.44

/source/dnode/snode/src/snode.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "executor.h"
#include "rsync.h"
#include "sndInt.h"
#include "tqCommon.h"
#include "tuuid.h"

// clang-format off
#define sndError(...) do {  if (sndDebugFlag & DEBUG_ERROR) { taosPrintLog("SND ERROR ", DEBUG_ERROR, sndDebugFlag, __VA_ARGS__);}} while (0)
#define sndInfo(...)  do {  if (sndDebugFlag & DEBUG_INFO)  { taosPrintLog("SND INFO  ", DEBUG_INFO,  sndDebugFlag, __VA_ARGS__);}} while (0)
#define sndDebug(...) do {  if (sndDebugFlag & DEBUG_DEBUG) { taosPrintLog("SND DEBUG ", DEBUG_DEBUG, sndDebugFlag, __VA_ARGS__);}} while (0)
// clang-format on

int32_t sndBuildStreamTask(SSnode *pSnode, SStreamTask *pTask, int64_t nextProcessVer) {
  if (!(pTask->info.taskLevel == TASK_LEVEL__AGG && taosArrayGetSize(pTask->upstreamInfo.pList) != 0)) {
    return TSDB_CODE_INVALID_PARA;
  }
  int32_t code = streamTaskInit(pTask, pSnode->pMeta, &pSnode->msgCb, nextProcessVer);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
  }

  pTask->pBackend = NULL;
  streamTaskOpenAllUpstreamInput(pTask);

  streamTaskResetUpstreamStageInfo(pTask);

  SCheckpointInfo *pChkInfo = &pTask->chkInfo;
  tqSetRestoreVersionInfo(pTask);

  char *p = streamTaskGetStatus(pTask).name;
  if (pTask->info.fillHistory == STREAM_HISTORY_TASK) {
    sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64
            " nextProcessVer:%" PRId64
            " child id:%d, level:%d, status:%s taskType:%d, related stream task:0x%x trigger:%" PRId64 " ms",
            SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
            pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
            (int32_t)pTask->streamTaskId.taskId, pTask->info.delaySchedParam);
  } else {
    sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64
            " nextProcessVer:%" PRId64
            " child id:%d, level:%d, status:%s taskType:%d, related helper-task:0x%x trigger:%" PRId64 " ms",
            SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
            pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
            (int32_t)pTask->hTaskInfo.id.taskId, pTask->info.delaySchedParam);
  }
  return 0;
}

SSnode *sndOpen(const char *path, const SSnodeOpt *pOption) {
  int32_t code = 0;
  SSnode *pSnode = taosMemoryCalloc(1, sizeof(SSnode));
  if (pSnode == NULL) {
    return NULL;
  }

  stopRsync();
  code = startRsync();
  if (code != 0) {
    terrno = code;
    goto _ERR;
  }

  pSnode->msgCb = pOption->msgCb;
  code = streamMetaOpen(path, pSnode, (FTaskBuild *)sndBuildStreamTask, tqExpandStreamTask, SNODE_HANDLE,
                        taosGetTimestampMs(), tqStartTaskCompleteCallback, &pSnode->pMeta);
  if (code != TSDB_CODE_SUCCESS) {
    terrno = code;
    goto _ERR;
  }

  streamMetaLoadAllTasks(pSnode->pMeta);
  return pSnode;

_ERR:
  taosMemoryFree(pSnode);
  return NULL;
}

int32_t sndInit(SSnode *pSnode) {
  if (streamTaskSchedTask(&pSnode->msgCb, pSnode->pMeta->vgId, 0, 0, STREAM_EXEC_T_START_ALL_TASKS, false) != 0) {
    sndError("failed to start all tasks");
  }
  return 0;
}

void sndClose(SSnode *pSnode) {
  stopRsync();

  streamMetaNotifyClose(pSnode->pMeta);
  if (streamMetaCommit(pSnode->pMeta) != 0) {
    sndError("failed to commit stream meta");
  }
  streamMetaClose(pSnode->pMeta);
  taosMemoryFree(pSnode);
}

int32_t sndProcessStreamMsg(SSnode *pSnode, SRpcMsg *pMsg) {
  switch (pMsg->msgType) {
    case TDMT_STREAM_TASK_RUN:
      return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);
    case TDMT_STREAM_TASK_DISPATCH:
      return tqStreamTaskProcessDispatchReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_TASK_DISPATCH_RSP:
      return tqStreamTaskProcessDispatchRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE:
      return tqStreamTaskProcessRetrieveReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_RSP:  // 1036
      break;
    case TDMT_VND_STREAM_TASK_CHECK:
      return tqStreamTaskProcessCheckReq(pSnode->pMeta, pMsg);
    case TDMT_VND_STREAM_TASK_CHECK_RSP:
      return tqStreamTaskProcessCheckRsp(pSnode->pMeta, pMsg, true);
    case TDMT_STREAM_TASK_CHECKPOINT_READY:
      return tqStreamTaskProcessCheckpointReadyMsg(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_HEARTBEAT_RSP:
      return tqStreamProcessStreamHbRsp(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_REQ_CHKPT_RSP:
      return tqStreamProcessReqCheckpointRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_TASK_CHECKPOINT_READY_RSP:
      return tqStreamProcessCheckpointReadyRsp(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_CHKPT_REPORT_RSP:
      return tqStreamProcessChkptReportRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_TRIGGER:
      return tqStreamTaskProcessRetrieveTriggerReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_TRIGGER_RSP:
      return tqStreamTaskProcessRetrieveTriggerRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_CHKPT_EXEC:
      return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);
    default:
      sndError("invalid snode msg:%d", pMsg->msgType);
      return TSDB_CODE_INVALID_MSG;
  }
  return 0;
}

int32_t sndProcessWriteMsg(SSnode *pSnode, SRpcMsg *pMsg, SRpcMsg *pRsp) {
  switch (pMsg->msgType) {
    case TDMT_STREAM_TASK_DEPLOY: {
      void   *pReq = POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead));
      int32_t len = pMsg->contLen - sizeof(SMsgHead);
      return tqStreamTaskProcessDeployReq(pSnode->pMeta, &pSnode->msgCb, pMsg->info.conn.applyIndex, pReq, len, true,
                                          true);
    }

    case TDMT_STREAM_TASK_DROP:
      return tqStreamTaskProcessDropReq(pSnode->pMeta, pMsg->pCont, pMsg->contLen);
    case TDMT_VND_STREAM_TASK_UPDATE:
      return tqStreamTaskProcessUpdateReq(pSnode->pMeta, &pSnode->msgCb, pMsg, true, true);
    case TDMT_VND_STREAM_TASK_RESET:
      return tqStreamTaskProcessTaskResetReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_VND_STREAM_ALL_STOP:
      return tqStreamTaskProcessAllTaskStopReq(pSnode->pMeta, &pSnode->msgCb, pMsg);
    case TDMT_STREAM_TASK_PAUSE:
      return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_STREAM_TASK_RESUME:
      return tqStreamTaskProcessTaskResumeReq(pSnode->pMeta, pMsg->info.conn.applyIndex, pMsg->pCont, false);
    case TDMT_STREAM_TASK_STOP:
      return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_STREAM_TASK_START:
      return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_STREAM_TASK_UPDATE_CHKPT:
      return tqStreamTaskProcessUpdateCheckpointReq(pSnode->pMeta, true, pMsg->pCont);
    case TDMT_STREAM_CONSEN_CHKPT:
      return tqStreamTaskProcessConsenChkptIdReq(pSnode->pMeta, pMsg);
    default:
      return TSDB_CODE_INVALID_MSG;
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "executor.h"
17	#include "rsync.h"
18	#include "sndInt.h"
19	#include "tqCommon.h"
20	#include "tuuid.h"
21
22	// clang-format off
23	#define sndError(...) do { if (sndDebugFlag & DEBUG_ERROR) { taosPrintLog("SND ERROR ", DEBUG_ERROR, sndDebugFlag, __VA_ARGS__);}} while (0)
24	#define sndInfo(...) do { if (sndDebugFlag & DEBUG_INFO) { taosPrintLog("SND INFO ", DEBUG_INFO, sndDebugFlag, __VA_ARGS__);}} while (0)
25	#define sndDebug(...) do { if (sndDebugFlag & DEBUG_DEBUG) { taosPrintLog("SND DEBUG ", DEBUG_DEBUG, sndDebugFlag, __VA_ARGS__);}} while (0)
26	// clang-format on
27
28	int32_t sndBuildStreamTask(SSnode pSnode, SStreamTask pTask, int64_t nextProcessVer) {	101✔
29	if (!(pTask->info.taskLevel == TASK_LEVEL__AGG && taosArrayGetSize(pTask->upstreamInfo.pList) != 0)) {	101!
30	return TSDB_CODE_INVALID_PARA;	×
31	}
32	int32_t code = streamTaskInit(pTask, pSnode->pMeta, &pSnode->msgCb, nextProcessVer);	101✔
33	if (code != TSDB_CODE_SUCCESS) {	101!
34	return code;	×
35	}
36
37	pTask->pBackend = NULL;	101✔
38	streamTaskOpenAllUpstreamInput(pTask);	101✔
39
40	streamTaskResetUpstreamStageInfo(pTask);	101✔
41
42	SCheckpointInfo *pChkInfo = &pTask->chkInfo;	101✔
43	tqSetRestoreVersionInfo(pTask);	101✔
44
45	char *p = streamTaskGetStatus(pTask).name;	101✔
46	if (pTask->info.fillHistory == STREAM_HISTORY_TASK) {	101✔
47	sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64	31!
48	" nextProcessVer:%" PRId64
49	" child id:%d, level:%d, status:%s taskType:%d, related stream task:0x%x trigger:%" PRId64 " ms",
50	SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
51	pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
52	(int32_t)pTask->streamTaskId.taskId, pTask->info.delaySchedParam);
53	} else {
54	sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64	70!
55	" nextProcessVer:%" PRId64
56	" child id:%d, level:%d, status:%s taskType:%d, related helper-task:0x%x trigger:%" PRId64 " ms",
57	SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
58	pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
59	(int32_t)pTask->hTaskInfo.id.taskId, pTask->info.delaySchedParam);
60	}
61	return 0;	101✔
62	}
63
64	SSnode sndOpen(const char path, const SSnodeOpt *pOption) {	39✔
65	int32_t code = 0;	39✔
66	SSnode *pSnode = taosMemoryCalloc(1, sizeof(SSnode));	39!
67	if (pSnode == NULL) {	39!
68	return NULL;	×
69	}
70
71	stopRsync();	39✔
72	code = startRsync();	39✔
73	if (code != 0) {	39!
74	terrno = code;	×
75	goto _ERR;	×
76	}
77
78	pSnode->msgCb = pOption->msgCb;	39✔
79	code = streamMetaOpen(path, pSnode, (FTaskBuild *)sndBuildStreamTask, tqExpandStreamTask, SNODE_HANDLE,	78✔
80	taosGetTimestampMs(), tqStartTaskCompleteCallback, &pSnode->pMeta);
81	if (code != TSDB_CODE_SUCCESS) {	39!
82	terrno = code;	×
83	goto _ERR;	×
84	}
85
86	streamMetaLoadAllTasks(pSnode->pMeta);	39✔
87	return pSnode;	39✔
88
89	_ERR:	×
90	taosMemoryFree(pSnode);	×
91	return NULL;	×
92	}
93
94	int32_t sndInit(SSnode *pSnode) {	39✔
95	if (streamTaskSchedTask(&pSnode->msgCb, pSnode->pMeta->vgId, 0, 0, STREAM_EXEC_T_START_ALL_TASKS, false) != 0) {	39!
96	sndError("failed to start all tasks");	×
97	}
98	return 0;	39✔
99	}
100
101	void sndClose(SSnode *pSnode) {	39✔
102	stopRsync();	39✔
103
104	streamMetaNotifyClose(pSnode->pMeta);	39✔
105	if (streamMetaCommit(pSnode->pMeta) != 0) {	39!
106	sndError("failed to commit stream meta");	×
107	}
108	streamMetaClose(pSnode->pMeta);	39✔
109	taosMemoryFree(pSnode);	39!
110	}	39✔
111
112	int32_t sndProcessStreamMsg(SSnode pSnode, SRpcMsg pMsg) {	21,335✔
113	switch (pMsg->msgType) {	21,335!
114	case TDMT_STREAM_TASK_RUN:	1,022✔
115	return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);	1,022✔
116	case TDMT_STREAM_TASK_DISPATCH:	2,040✔
117	return tqStreamTaskProcessDispatchReq(pSnode->pMeta, pMsg);	2,040✔
118	case TDMT_STREAM_TASK_DISPATCH_RSP:	2,114✔
119	return tqStreamTaskProcessDispatchRsp(pSnode->pMeta, pMsg);	2,114✔
120	case TDMT_STREAM_RETRIEVE:	×
121	return tqStreamTaskProcessRetrieveReq(pSnode->pMeta, pMsg);	×
122	case TDMT_STREAM_RETRIEVE_RSP: // 1036	111✔
123	break;	111✔
124	case TDMT_VND_STREAM_TASK_CHECK:	751✔
125	return tqStreamTaskProcessCheckReq(pSnode->pMeta, pMsg);	751✔
126	case TDMT_VND_STREAM_TASK_CHECK_RSP:	343✔
127	return tqStreamTaskProcessCheckRsp(pSnode->pMeta, pMsg, true);	343✔
128	case TDMT_STREAM_TASK_CHECKPOINT_READY:	1,138✔
129	return tqStreamTaskProcessCheckpointReadyMsg(pSnode->pMeta, pMsg);	1,138✔
130	case TDMT_MND_STREAM_HEARTBEAT_RSP:	9,728✔
131	return tqStreamProcessStreamHbRsp(pSnode->pMeta, pMsg);	9,728✔
132	case TDMT_MND_STREAM_REQ_CHKPT_RSP:	29✔
133	return tqStreamProcessReqCheckpointRsp(pSnode->pMeta, pMsg);	29✔
134	case TDMT_STREAM_TASK_CHECKPOINT_READY_RSP:	1,138✔
135	return tqStreamProcessCheckpointReadyRsp(pSnode->pMeta, pMsg);	1,138✔
136	case TDMT_MND_STREAM_CHKPT_REPORT_RSP:	555✔
137	return tqStreamProcessChkptReportRsp(pSnode->pMeta, pMsg);	555✔
138	case TDMT_STREAM_RETRIEVE_TRIGGER:	×
139	return tqStreamTaskProcessRetrieveTriggerReq(pSnode->pMeta, pMsg);	×
140	case TDMT_STREAM_RETRIEVE_TRIGGER_RSP:	×
141	return tqStreamTaskProcessRetrieveTriggerRsp(pSnode->pMeta, pMsg);	×
142	case TDMT_STREAM_CHKPT_EXEC:	2,367✔
143	return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);	2,367✔
144	default:	×
145	sndError("invalid snode msg:%d", pMsg->msgType);	×
146	return TSDB_CODE_INVALID_MSG;	×
147	}
148	return 0;	111✔
149	}
150
151	int32_t sndProcessWriteMsg(SSnode pSnode, SRpcMsg pMsg, SRpcMsg *pRsp) {	729✔
152	switch (pMsg->msgType) {	729!
153	case TDMT_STREAM_TASK_DEPLOY: {	89✔
154	void *pReq = POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead));	89✔
155	int32_t len = pMsg->contLen - sizeof(SMsgHead);	89✔
156	return tqStreamTaskProcessDeployReq(pSnode->pMeta, &pSnode->msgCb, pMsg->info.conn.applyIndex, pReq, len, true,	89✔
157	true);
158	}
159
160	case TDMT_STREAM_TASK_DROP:	48✔
161	return tqStreamTaskProcessDropReq(pSnode->pMeta, pMsg->pCont, pMsg->contLen);	48✔
162	case TDMT_VND_STREAM_TASK_UPDATE:	3✔
163	return tqStreamTaskProcessUpdateReq(pSnode->pMeta, &pSnode->msgCb, pMsg, true, true);	3✔
164	case TDMT_VND_STREAM_TASK_RESET:	×
165	return tqStreamTaskProcessTaskResetReq(pSnode->pMeta, pMsg->pCont);	×
166	case TDMT_VND_STREAM_ALL_STOP:	×
167	return tqStreamTaskProcessAllTaskStopReq(pSnode->pMeta, &pSnode->msgCb, pMsg);	×
168	case TDMT_STREAM_TASK_PAUSE:	15✔
169	return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);	15✔
170	case TDMT_STREAM_TASK_RESUME:	15✔
171	return tqStreamTaskProcessTaskResumeReq(pSnode->pMeta, pMsg->info.conn.applyIndex, pMsg->pCont, false);	15✔
172	case TDMT_STREAM_TASK_STOP:	×
173	return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);	×
174	case TDMT_STREAM_TASK_START:	×
175	return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);	×
176	case TDMT_STREAM_TASK_UPDATE_CHKPT:	553✔
177	return tqStreamTaskProcessUpdateCheckpointReq(pSnode->pMeta, true, pMsg->pCont);	553✔
178	case TDMT_STREAM_CONSEN_CHKPT:	6✔
179	return tqStreamTaskProcessConsenChkptIdReq(pSnode->pMeta, pMsg);	6✔
180	default:	×
181	return TSDB_CODE_INVALID_MSG;	×
182	}
183	}

taosdata / TDengine / #4087

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous