15057632786

Committed 15 May 2025 09:01PM UTC coverage: 72.267% (+0.02%) from 72.244%

Build # 15057632786

Build Type

push

github

Committed by

bluca

Commit Message

man: document how to hook stuff into system wakeup

Fixes: #6364

Run Details

298523 of 413084 relevant lines covered (72.27%)

738132.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.47

/src/sysctl/sysctl.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <getopt.h>
#include <stdio.h>
#include <sys/stat.h>

#include "alloc-util.h"
#include "build.h"
#include "conf-files.h"
#include "constants.h"
#include "creds-util.h"
#include "errno-util.h"
#include "fd-util.h"
#include "fileio.h"
#include "glob-util.h"
#include "hashmap.h"
#include "log.h"
#include "main-func.h"
#include "pager.h"
#include "path-util.h"
#include "pretty-print.h"
#include "string-util.h"
#include "strv.h"
#include "sysctl-util.h"

static char **arg_prefixes = NULL;
static CatFlags arg_cat_flags = CAT_CONFIG_OFF;
static bool arg_strict = false;
static PagerFlags arg_pager_flags = 0;

STATIC_DESTRUCTOR_REGISTER(arg_prefixes, strv_freep);

typedef struct Option {
        char *key;
        char *value;
        bool ignore_failure;
} Option;

static Option *option_free(Option *o) {
        if (!o)
                return NULL;

        free(o->key);
        free(o->value);

        return mfree(o);
}

DEFINE_TRIVIAL_CLEANUP_FUNC(Option*, option_free);
DEFINE_HASH_OPS_WITH_VALUE_DESTRUCTOR(option_hash_ops, char, string_hash_func, string_compare_func, Option, option_free);

static bool test_prefix(const char *p) {
        if (strv_isempty(arg_prefixes))
                return true;

        return path_startswith_strv(p, arg_prefixes);
}

static Option *option_new(
                const char *key,
                const char *value,
                bool ignore_failure) {

        _cleanup_(option_freep) Option *o = NULL;

        assert(key);

        o = new(Option, 1);
        if (!o)
                return NULL;

        *o = (Option) {
                .key = strdup(key),
                .value = value ? strdup(value) : NULL,
                .ignore_failure = ignore_failure,
        };

        if (!o->key)
                return NULL;
        if (value && !o->value)
                return NULL;

        return TAKE_PTR(o);
}

static int sysctl_write_or_warn(const char *key, const char *value, bool ignore_failure, bool ignore_enoent) {
        int r;

        r = sysctl_write(key, value);
        if (r < 0) {
                /* Proceed without failing if ignore_failure is true.
                 * If the sysctl is not available in the kernel or we are running with reduced privileges and
                 * cannot write it, then log about the issue, and proceed without failing. Unless strict mode
                 * (arg_strict = true) is enabled, in which case we should fail. (EROFS is treated as a
                 * permission problem here, since that's how container managers usually protected their
                 * sysctls.)
                 * In all other cases log an error and make the tool fail. */
                if (ignore_failure || (!arg_strict && (r == -EROFS || ERRNO_IS_PRIVILEGE(r))))
                        log_debug_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);
                else if (ignore_enoent && r == -ENOENT)
                        log_warning_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);
                else
                        return log_error_errno(r, "Couldn't write '%s' to '%s': %m", value, key);
        }

        return 0;
}

static int apply_glob_option_with_prefix(OrderedHashmap *sysctl_options, Option *option, const char *prefix) {
        _cleanup_strv_free_ char **paths = NULL;
        _cleanup_free_ char *pattern = NULL;
        int r;

        assert(sysctl_options);
        assert(option);

        if (prefix) {
                _cleanup_free_ char *key = NULL;

                r = path_glob_can_match(option->key, prefix, &key);
                if (r < 0)
                        return log_error_errno(r, "Failed to check if the glob '%s' matches prefix '%s': %m",
                                               option->key, prefix);
                if (r == 0) {
                        log_debug("The glob '%s' does not match prefix '%s'.", option->key, prefix);
                        return 0;
                }

                log_debug("The glob '%s' is prefixed with '%s': '%s'", option->key, prefix, key);

                if (!string_is_glob(key)) {
                        /* The prefixed pattern is not glob anymore. Let's skip to call glob(). */
                        if (ordered_hashmap_contains(sysctl_options, key)) {
                                log_debug("Not setting %s (explicit setting exists).", key);
                                return 0;
                        }

                        return sysctl_write_or_warn(key, option->value,
                                                    /* ignore_failure = */ option->ignore_failure,
                                                    /* ignore_enoent = */ true);
                }

                pattern = path_join("/proc/sys", key);
        } else
                pattern = path_join("/proc/sys", option->key);
        if (!pattern)
                return log_oom();

        r = glob_extend(&paths, pattern, GLOB_NOCHECK);
        if (r < 0) {
                if (r == -ENOENT) {
                        log_debug("No match for glob: %s", option->key);
                        return 0;
                }
                if (option->ignore_failure || ERRNO_IS_PRIVILEGE(r)) {
                        log_debug_errno(r, "Failed to resolve glob '%s', ignoring: %m", option->key);
                        return 0;
                } else
                        return log_error_errno(r, "Couldn't resolve glob '%s': %m", option->key);
        }

        STRV_FOREACH(s, paths) {
                const char *key;

                assert_se(key = path_startswith(*s, "/proc/sys"));

                if (ordered_hashmap_contains(sysctl_options, key)) {
                        log_debug("Not setting %s (explicit setting exists).", key);
                        continue;
                }

                RET_GATHER(r,
                           sysctl_write_or_warn(key, option->value,
                                                /* ignore_failure = */ option->ignore_failure,
                                                /* ignore_enoent = */ !arg_strict));
        }

        return r;
}

static int apply_glob_option(OrderedHashmap *sysctl_options, Option *option) {
        int r = 0;

        if (strv_isempty(arg_prefixes))
                return apply_glob_option_with_prefix(sysctl_options, option, NULL);

        STRV_FOREACH(i, arg_prefixes)
                RET_GATHER(r, apply_glob_option_with_prefix(sysctl_options, option, *i));
        return r;
}

static int apply_all(OrderedHashmap *sysctl_options) {
        Option *option;
        int r = 0;

        ORDERED_HASHMAP_FOREACH(option, sysctl_options) {
                int k;

                /* Ignore "negative match" options, they are there only to exclude stuff from globs. */
                if (!option->value)
                        continue;

                if (string_is_glob(option->key))
                        k = apply_glob_option(sysctl_options, option);
                else
                        k = sysctl_write_or_warn(option->key, option->value,
                                                 /* ignore_failure = */ option->ignore_failure,
                                                 /* ignore_enoent = */ !arg_strict);
                RET_GATHER(r, k);
        }

        return r;
}

static int parse_file(OrderedHashmap **sysctl_options, const char *path, bool ignore_enoent) {
        _cleanup_fclose_ FILE *f = NULL;
        _cleanup_free_ char *pp = NULL;
        unsigned c = 0;
        int r;

        assert(path);

        r = search_and_fopen(path, "re", NULL, (const char**) CONF_PATHS_STRV("sysctl.d"), &f, &pp);
        if (r < 0) {
                if (ignore_enoent && r == -ENOENT)
                        return 0;

                return log_error_errno(r, "Failed to open file '%s', ignoring: %m", path);
        }

        log_debug("Parsing %s", pp);
        for (;;) {
                _cleanup_(option_freep) Option *new_option = NULL;
                _cleanup_free_ char *l = NULL;
                bool ignore_failure = false;
                Option *existing;
                char *value;
                int k;

                k = read_stripped_line(f, LONG_LINE_MAX, &l);
                if (k == 0)
                        break;
                if (k < 0)
                        return log_error_errno(k, "Failed to read file '%s', ignoring: %m", pp);

                c++;

                if (isempty(l))
                        continue;
                if (strchr(COMMENTS, l[0]))
                        continue;

                char *p = l;
                value = strchr(p, '=');
                if (value) {
                        if (p[0] == '-') {
                                ignore_failure = true;
                                p++;
                        }

                        *value = 0;
                        value++;
                        value = strstrip(value);

                } else {
                        if (p[0] == '-')
                                /* We have a "negative match" option. Let's continue with value==NULL. */
                                p++;
                        else {
                                log_syntax(NULL, LOG_WARNING, pp, c, 0,
                                           "Line is not an assignment, ignoring: %s", p);
                                if (r == 0)
                                        r = -EINVAL;
                                continue;
                        }
                }

                p = strstrip(p);
                p = sysctl_normalize(p);

                /* We can't filter out globs at this point, we'll need to do that later. */
                if (!string_is_glob(p) &&
                    !test_prefix(p))
                        continue;

                existing = ordered_hashmap_get(*sysctl_options, p);
                if (existing) {
                        if (streq_ptr(value, existing->value)) {
                                existing->ignore_failure = existing->ignore_failure || ignore_failure;
                                continue;
                        }

                        log_debug("Overwriting earlier assignment of %s at '%s:%u'.", p, pp, c);
                        option_free(ordered_hashmap_remove(*sysctl_options, p));
                }

                new_option = option_new(p, value, ignore_failure);
                if (!new_option)
                        return log_oom();

                k = ordered_hashmap_ensure_put(sysctl_options, &option_hash_ops, new_option->key, new_option);
                if (k < 0)
                        return log_error_errno(k, "Failed to add sysctl variable %s to hashmap: %m", p);

                TAKE_PTR(new_option);
        }

        return r;
}

static int read_credential_lines(OrderedHashmap **sysctl_options) {
        _cleanup_free_ char *j = NULL;
        const char *d;
        int r;

        r = get_credentials_dir(&d);
        if (r == -ENXIO)
                return 0;
        if (r < 0)
                return log_error_errno(r, "Failed to get credentials directory: %m");

        j = path_join(d, "sysctl.extra");
        if (!j)
                return log_oom();

        (void) parse_file(sysctl_options, j, /* ignore_enoent= */ true);
        return 0;
}

static int cat_config(char **files) {
        pager_open(arg_pager_flags);

        return cat_files(NULL, files, arg_cat_flags);
}

static int help(void) {
        _cleanup_free_ char *link = NULL;
        int r;

        r = terminal_urlify_man("systemd-sysctl.service", "8", &link);
        if (r < 0)
                return log_oom();

        printf("%s [OPTIONS...] [CONFIGURATION FILE...]\n\n"
               "Applies kernel sysctl settings.\n\n"
               "  -h --help             Show this help\n"
               "     --version          Show package version\n"
               "     --cat-config       Show configuration files\n"
               "     --tldr             Show non-comment parts of configuration\n"
               "     --prefix=PATH      Only apply rules with the specified prefix\n"
               "     --no-pager         Do not pipe output into a pager\n"
               "\nSee the %s for details.\n",
               program_invocation_short_name,
               link);

        return 0;
}

static int parse_argv(int argc, char *argv[]) {

        enum {
                ARG_VERSION = 0x100,
                ARG_CAT_CONFIG,
                ARG_TLDR,
                ARG_PREFIX,
                ARG_NO_PAGER,
                ARG_STRICT,
        };

        static const struct option options[] = {
                { "help",       no_argument,       NULL, 'h'            },
                { "version",    no_argument,       NULL, ARG_VERSION    },
                { "cat-config", no_argument,       NULL, ARG_CAT_CONFIG },
                { "tldr",       no_argument,       NULL, ARG_TLDR       },
                { "prefix",     required_argument, NULL, ARG_PREFIX     },
                { "no-pager",   no_argument,       NULL, ARG_NO_PAGER   },
                { "strict",     no_argument,       NULL, ARG_STRICT     },
                {}
        };

        int c;

        assert(argc >= 0);
        assert(argv);

        while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0)

                switch (c) {

                case 'h':
                        return help();

                case ARG_VERSION:
                        return version();

                case ARG_CAT_CONFIG:
                        arg_cat_flags = CAT_CONFIG_ON;
                        break;

                case ARG_TLDR:
                        arg_cat_flags = CAT_TLDR;
                        break;

                case ARG_PREFIX: {
                        const char *s;
                        char *p;

                        /* We used to require people to specify absolute paths
                         * in /proc/sys in the past. This is kinda useless, but
                         * we need to keep compatibility. We now support any
                         * sysctl name available. */
                        sysctl_normalize(optarg);

                        s = path_startswith(optarg, "/proc/sys");
                        p = strdup(s ?: optarg);
                        if (!p)
                                return log_oom();

                        if (strv_consume(&arg_prefixes, p) < 0)
                                return log_oom();

                        break;
                }

                case ARG_NO_PAGER:
                        arg_pager_flags |= PAGER_DISABLE;
                        break;

                case ARG_STRICT:
                        arg_strict = true;
                        break;

                case '?':
                        return -EINVAL;

                default:
                        assert_not_reached();
                }

        if (arg_cat_flags != CAT_CONFIG_OFF && argc > optind)
                return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
                                       "Positional arguments are not allowed with --cat-config/--tldr.");

        return 1;
}

static int run(int argc, char *argv[]) {
        _cleanup_ordered_hashmap_free_ OrderedHashmap *sysctl_options = NULL;
        int r;

        r = parse_argv(argc, argv);
        if (r <= 0)
                return r;

        log_setup();

        umask(0022);

        if (argc > optind) {
                r = 0;

                for (int i = optind; i < argc; i++)
                        RET_GATHER(r, parse_file(&sysctl_options, argv[i], false));

        } else {
                _cleanup_strv_free_ char **files = NULL;

                r = conf_files_list_strv(&files, ".conf", NULL, 0, (const char**) CONF_PATHS_STRV("sysctl.d"));
                if (r < 0)
                        return log_error_errno(r, "Failed to enumerate sysctl.d files: %m");

                if (arg_cat_flags != CAT_CONFIG_OFF)
                        return cat_config(files);

                STRV_FOREACH(f, files)
                        RET_GATHER(r, parse_file(&sysctl_options, *f, true));

                RET_GATHER(r, read_credential_lines(&sysctl_options));
        }

        RET_GATHER(r, apply_all(sysctl_options));

        return r;
}

DEFINE_MAIN_FUNCTION(run);

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <getopt.h>
4	#include <stdio.h>
5	#include <sys/stat.h>
6
7	#include "alloc-util.h"
8	#include "build.h"
9	#include "conf-files.h"
10	#include "constants.h"
11	#include "creds-util.h"
12	#include "errno-util.h"
13	#include "fd-util.h"
14	#include "fileio.h"
15	#include "glob-util.h"
16	#include "hashmap.h"
17	#include "log.h"
18	#include "main-func.h"
19	#include "pager.h"
20	#include "path-util.h"
21	#include "pretty-print.h"
22	#include "string-util.h"
23	#include "strv.h"
24	#include "sysctl-util.h"
25
26	static char **arg_prefixes = NULL;
27	static CatFlags arg_cat_flags = CAT_CONFIG_OFF;
28	static bool arg_strict = false;
29	static PagerFlags arg_pager_flags = 0;
30
31	STATIC_DESTRUCTOR_REGISTER(arg_prefixes, strv_freep);	1,040✔
32
33	typedef struct Option {
34	char *key;
35	char *value;
36	bool ignore_failure;
37	} Option;
38
39	static Option option_free(Option o) {	5,980✔
40	if (!o)	5,980✔
41	return NULL;
42
43	free(o->key);	5,980✔
44	free(o->value);	5,980✔
45
46	return mfree(o);	5,980✔
47	}
48
49	DEFINE_TRIVIAL_CLEANUP_FUNC(Option*, option_free);	140,638✔
50	DEFINE_HASH_OPS_WITH_VALUE_DESTRUCTOR(option_hash_ops, char, string_hash_func, string_compare_func, Option, option_free);	5,980✔
51
52	static bool test_prefix(const char *p) {	24,856✔
53	if (strv_isempty(arg_prefixes))	24,856✔
54	return true;
55
56	return path_startswith_strv(p, arg_prefixes);	21,984✔
57	}
58
59	static Option *option_new(	5,980✔
60	const char *key,
61	const char *value,
62	bool ignore_failure) {
63
64	_cleanup_(option_freep) Option *o = NULL;	5,980✔
65
66	assert(key);	5,980✔
67
68	o = new(Option, 1);	5,980✔
69	if (!o)	5,980✔
70	return NULL;
71
72	*o = (Option) {	11,960✔
73	.key = strdup(key),	5,980✔
74	.value = value ? strdup(value) : NULL,	5,980✔
75	.ignore_failure = ignore_failure,
76	};
77
78	if (!o->key)	5,980✔
79	return NULL;
80	if (value && !o->value)	5,980✔
81	return NULL;
82
83	return TAKE_PTR(o);	5,980✔
84	}
85
86	static int sysctl_write_or_warn(const char key, const char value, bool ignore_failure, bool ignore_enoent) {	5,620✔
87	int r;	5,620✔
88
89	r = sysctl_write(key, value);	5,620✔
90	if (r < 0) {	5,620✔
91	/* Proceed without failing if ignore_failure is true.
92	* If the sysctl is not available in the kernel or we are running with reduced privileges and
93	* cannot write it, then log about the issue, and proceed without failing. Unless strict mode
94	* (arg_strict = true) is enabled, in which case we should fail. (EROFS is treated as a
95	* permission problem here, since that's how container managers usually protected their
96	* sysctls.)
97	* In all other cases log an error and make the tool fail. */
98	if (ignore_failure \|\| (!arg_strict && (r == -EROFS \|\| ERRNO_IS_PRIVILEGE(r))))	1,073✔
99	log_debug_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);	434✔
100	else if (ignore_enoent && r == -ENOENT)	639✔
101	log_warning_errno(r, "Couldn't write '%s' to '%s', ignoring: %m", value, key);	638✔
102	else
103	return log_error_errno(r, "Couldn't write '%s' to '%s': %m", value, key);	1✔
104	}
105
106	return 0;
107	}
108
109	static int apply_glob_option_with_prefix(OrderedHashmap sysctl_options, Option option, const char *prefix) {	11,352✔
110	_cleanup_strv_free_ char **paths = NULL;	×
111	_cleanup_free_ char *pattern = NULL;	11,352✔
112	int r;	11,352✔
113
114	assert(sysctl_options);	11,352✔
115	assert(option);	11,352✔
116
117	if (prefix) {	11,352✔
118	_cleanup_free_ char *key = NULL;	10,992✔
119
120	r = path_glob_can_match(option->key, prefix, &key);	10,992✔
121	if (r < 0)	10,992✔
122	return log_error_errno(r, "Failed to check if the glob '%s' matches prefix '%s': %m",	×
123	option->key, prefix);
124	if (r == 0) {	10,992✔
125	log_debug("The glob '%s' does not match prefix '%s'.", option->key, prefix);	8,244✔
126	return 0;	8,244✔
127	}
128
129	log_debug("The glob '%s' is prefixed with '%s': '%s'", option->key, prefix, key);	2,748✔
130
131	if (!string_is_glob(key)) {	2,748✔
132	/* The prefixed pattern is not glob anymore. Let's skip to call glob(). */
133	if (ordered_hashmap_contains(sysctl_options, key)) {	2,748✔
134	log_debug("Not setting %s (explicit setting exists).", key);	×
135	return 0;	×
136	}
137
138	return sysctl_write_or_warn(key, option->value,	2,748✔
139	/* ignore_failure = */ option->ignore_failure,	2,748✔
140	/* ignore_enoent = */ true);
141	}
142
143	pattern = path_join("/proc/sys", key);	×
144	} else
145	pattern = path_join("/proc/sys", option->key);	360✔
146	if (!pattern)	360✔
147	return log_oom();	×
148
149	r = glob_extend(&paths, pattern, GLOB_NOCHECK);	360✔
150	if (r < 0) {	360✔
151	if (r == -ENOENT) {	×
152	log_debug("No match for glob: %s", option->key);	×
153	return 0;	×
154	}
155	if (option->ignore_failure \|\| ERRNO_IS_PRIVILEGE(r)) {	×
156	log_debug_errno(r, "Failed to resolve glob '%s', ignoring: %m", option->key);	×
157	return 0;	×
158	} else
159	return log_error_errno(r, "Couldn't resolve glob '%s': %m", option->key);	×
160	}
161
162	STRV_FOREACH(s, paths) {	1,440✔
163	const char *key;	1,080✔
164
165	assert_se(key = path_startswith(*s, "/proc/sys"));	1,080✔
166
167	if (ordered_hashmap_contains(sysctl_options, key)) {	1,080✔
168	log_debug("Not setting %s (explicit setting exists).", key);	720✔
169	continue;	720✔
170	}
171
172	RET_GATHER(r,	360✔
173	sysctl_write_or_warn(key, option->value,
174	/* ignore_failure = */ option->ignore_failure,
175	/* ignore_enoent = */ !arg_strict));
176	}
177
178	return r;
179	}
180
181	static int apply_glob_option(OrderedHashmap sysctl_options, Option option) {	3,108✔
182	int r = 0;	3,108✔
183
184	if (strv_isempty(arg_prefixes))	3,108✔
185	return apply_glob_option_with_prefix(sysctl_options, option, NULL);	360✔
186
187	STRV_FOREACH(i, arg_prefixes)	13,740✔
188	RET_GATHER(r, apply_glob_option_with_prefix(sysctl_options, option, *i));	10,992✔
189	return r;
190	}
191
192	static int apply_all(OrderedHashmap *sysctl_options) {	1,040✔
193	Option *option;	1,040✔
194	int r = 0;	1,040✔
195
196	ORDERED_HASHMAP_FOREACH(option, sysctl_options) {	7,020✔
197	int k;	5,980✔
198
199	/* Ignore "negative match" options, they are there only to exclude stuff from globs. */
200	if (!option->value)	5,980✔
201	continue;	360✔
202
203	if (string_is_glob(option->key))	5,620✔
204	k = apply_glob_option(sysctl_options, option);	3,108✔
205	else
206	k = sysctl_write_or_warn(option->key, option->value,	2,512✔
207	/* ignore_failure = */ option->ignore_failure,	2,512✔
208	/* ignore_enoent = */ !arg_strict);	2,512✔
209	RET_GATHER(r, k);	5,620✔
210	}
211
212	return r;	1,040✔
213	}
214
215	static int parse_file(OrderedHashmap *sysctl_options, const char path, bool ignore_enoent) {	5,298✔
216	_cleanup_fclose_ FILE *f = NULL;	5,298✔
217	_cleanup_free_ char *pp = NULL;	5,298✔
218	unsigned c = 0;	5,298✔
219	int r;	5,298✔
220
221	assert(path);	5,298✔
222
223	r = search_and_fopen(path, "re", NULL, (const char**) CONF_PATHS_STRV("sysctl.d"), &f, &pp);	5,298✔
224	if (r < 0) {	5,298✔
225	if (ignore_enoent && r == -ENOENT)	120✔
226	return 0;
227
228	return log_error_errno(r, "Failed to open file '%s', ignoring: %m", path);	×
229	}
230
231	log_debug("Parsing %s", pp);	5,178✔
232	for (;;) {	134,658✔
233	_cleanup_(option_freep) Option *new_option = NULL;	×
234	_cleanup_free_ char *l = NULL;	134,658✔
235	bool ignore_failure = false;	134,658✔
236	Option *existing;	134,658✔
237	char *value;	134,658✔
238	int k;	134,658✔
239
240	k = read_stripped_line(f, LONG_LINE_MAX, &l);	134,658✔
241	if (k == 0)	134,658✔
242	break;
243	if (k < 0)	129,480✔
244	return log_error_errno(k, "Failed to read file '%s', ignoring: %m", pp);	×
245
246	c++;	129,480✔
247
248	if (isempty(l))	129,480✔
249	continue;	20,720✔
250	if (strchr(COMMENTS, l[0]))	108,760✔
251	continue;	80,796✔
252
253	char *p = l;	27,964✔
254	value = strchr(p, '=');	27,964✔
255	if (value) {	27,964✔
256	if (p[0] == '-') {	24,856✔
257	ignore_failure = true;	2,074✔
258	p++;	2,074✔
259	}
260
261	*value = 0;	24,856✔
262	value++;	24,856✔
263	value = strstrip(value);	24,856✔
264
265	} else {
266	if (p[0] == '-')	3,108✔
267	/* We have a "negative match" option. Let's continue with value==NULL. */
268	p++;	3,108✔
269	else {
270	log_syntax(NULL, LOG_WARNING, pp, c, 0,	×
271	"Line is not an assignment, ignoring: %s", p);
272	if (r == 0)	×
273	r = -EINVAL;	×
274	continue;	×
275	}
276	}
277
278	p = strstrip(p);	27,964✔
279	p = sysctl_normalize(p);	27,964✔
280
281	/* We can't filter out globs at this point, we'll need to do that later. */
282	if (!string_is_glob(p) &&	52,820✔
283	!test_prefix(p))	24,856✔
284	continue;	21,984✔
285
286	existing = ordered_hashmap_get(*sysctl_options, p);	5,980✔
287	if (existing) {	5,980✔
288	if (streq_ptr(value, existing->value)) {	×
289	existing->ignore_failure = existing->ignore_failure \|\| ignore_failure;	×
290	continue;	×
291	}
292
293	log_debug("Overwriting earlier assignment of %s at '%s:%u'.", p, pp, c);	×
294	option_free(ordered_hashmap_remove(*sysctl_options, p));	×
295	}
296
297	new_option = option_new(p, value, ignore_failure);	5,980✔
298	if (!new_option)	5,980✔
299	return log_oom();	×
300
301	k = ordered_hashmap_ensure_put(sysctl_options, &option_hash_ops, new_option->key, new_option);	5,980✔
302	if (k < 0)	5,980✔
303	return log_error_errno(k, "Failed to add sysctl variable %s to hashmap: %m", p);	×
304
305	TAKE_PTR(new_option);	5,980✔
306	}
307
308	return r;	5,178✔
309	}
310
311	static int read_credential_lines(OrderedHashmap **sysctl_options) {	1,036✔
312	_cleanup_free_ char *j = NULL;	1,036✔
313	const char *d;	1,036✔
314	int r;	1,036✔
315
316	r = get_credentials_dir(&d);	1,036✔
317	if (r == -ENXIO)	1,036✔
318	return 0;
319	if (r < 0)	120✔
320	return log_error_errno(r, "Failed to get credentials directory: %m");	×
321
322	j = path_join(d, "sysctl.extra");	120✔
323	if (!j)	120✔
324	return log_oom();	×
325
326	(void) parse_file(sysctl_options, j, /* ignore_enoent= */ true);	120✔
327	return 0;
328	}
329
330	static int cat_config(char **files) {	×
331	pager_open(arg_pager_flags);	×
332
333	return cat_files(NULL, files, arg_cat_flags);	×
334	}
335
336	static int help(void) {	×
337	_cleanup_free_ char *link = NULL;	×
338	int r;	×
339
340	r = terminal_urlify_man("systemd-sysctl.service", "8", &link);	×
341	if (r < 0)	×
342	return log_oom();	×
343
344	printf("%s [OPTIONS...] [CONFIGURATION FILE...]\n\n"	×
345	"Applies kernel sysctl settings.\n\n"
346	" -h --help Show this help\n"
347	" --version Show package version\n"
348	" --cat-config Show configuration files\n"
349	" --tldr Show non-comment parts of configuration\n"
350	" --prefix=PATH Only apply rules with the specified prefix\n"
351	" --no-pager Do not pipe output into a pager\n"
352	"\nSee the %s for details.\n",
353	program_invocation_short_name,
354	link);
355
356	return 0;
357	}
358
359	static int parse_argv(int argc, char *argv[]) {	1,040✔
360
361	enum {	1,040✔
362	ARG_VERSION = 0x100,
363	ARG_CAT_CONFIG,
364	ARG_TLDR,
365	ARG_PREFIX,
366	ARG_NO_PAGER,
367	ARG_STRICT,
368	};
369
370	static const struct option options[] = {	1,040✔
371	{ "help", no_argument, NULL, 'h' },
372	{ "version", no_argument, NULL, ARG_VERSION },
373	{ "cat-config", no_argument, NULL, ARG_CAT_CONFIG },
374	{ "tldr", no_argument, NULL, ARG_TLDR },
375	{ "prefix", required_argument, NULL, ARG_PREFIX },
376	{ "no-pager", no_argument, NULL, ARG_NO_PAGER },
377	{ "strict", no_argument, NULL, ARG_STRICT },
378	{}
379	};
380
381	int c;	1,040✔
382
383	assert(argc >= 0);	1,040✔
384	assert(argv);	1,040✔
385
386	while ((c = getopt_long(argc, argv, "h", options, NULL)) >= 0)	4,706✔
387
388	switch (c) {	3,666✔
389
390	case 'h':	×
391	return help();	×
392
393	case ARG_VERSION:	×
394	return version();	×
395
396	case ARG_CAT_CONFIG:	×
397	arg_cat_flags = CAT_CONFIG_ON;	×
398	break;	×
399
400	case ARG_TLDR:	×
401	arg_cat_flags = CAT_TLDR;	×
402	break;	×
403
404	case ARG_PREFIX: {	3,664✔
405	const char *s;	3,664✔
406	char *p;	3,664✔
407
408	/* We used to require people to specify absolute paths
409	* in /proc/sys in the past. This is kinda useless, but
410	* we need to keep compatibility. We now support any
411	* sysctl name available. */
412	sysctl_normalize(optarg);	3,664✔
413
414	s = path_startswith(optarg, "/proc/sys");	3,664✔
415	p = strdup(s ?: optarg);	3,664✔
416	if (!p)	3,664✔
417	return log_oom();	×
418
419	if (strv_consume(&arg_prefixes, p) < 0)	3,664✔
420	return log_oom();	×
421
422	break;
423	}
424
425	case ARG_NO_PAGER:	×
426	arg_pager_flags \|= PAGER_DISABLE;	×
427	break;	×
428
429	case ARG_STRICT:	2✔
430	arg_strict = true;	2✔
431	break;	2✔
432
433	case '?':
434	return -EINVAL;
435
436	default:	×
437	assert_not_reached();	×
438	}
439
440	if (arg_cat_flags != CAT_CONFIG_OFF && argc > optind)	1,040✔
441	return log_error_errno(SYNTHETIC_ERRNO(EINVAL),	×
442	"Positional arguments are not allowed with --cat-config/--tldr.");
443
444	return 1;
445	}
446
447	static int run(int argc, char *argv[]) {	1,040✔
448	_cleanup_ordered_hashmap_free_ OrderedHashmap *sysctl_options = NULL;	1,040✔
449	int r;	1,040✔
450
451	r = parse_argv(argc, argv);	1,040✔
452	if (r <= 0)	1,040✔
453	return r;
454
455	log_setup();	1,040✔
456
457	umask(0022);	1,040✔
458
459	if (argc > optind) {	1,040✔
460	r = 0;
461
462	for (int i = optind; i < argc; i++)	8✔
463	RET_GATHER(r, parse_file(&sysctl_options, argv[i], false));	4✔
464
465	} else {
466	_cleanup_strv_free_ char **files = NULL;	×
467
468	r = conf_files_list_strv(&files, ".conf", NULL, 0, (const char**) CONF_PATHS_STRV("sysctl.d"));	1,036✔
469	if (r < 0)	1,036✔
470	return log_error_errno(r, "Failed to enumerate sysctl.d files: %m");	×
471
472	if (arg_cat_flags != CAT_CONFIG_OFF)	1,036✔
473	return cat_config(files);	×
474
475	STRV_FOREACH(f, files)	6,210✔
476	RET_GATHER(r, parse_file(&sysctl_options, *f, true));	5,174✔
477
478	RET_GATHER(r, read_credential_lines(&sysctl_options));	1,036✔
479	}
480
481	RET_GATHER(r, apply_all(sysctl_options));	1,040✔
482
483	return r;
484	}
485
486	DEFINE_MAIN_FUNCTION(run);	1,040✔

systemd / systemd / 15057632786

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous