08cde213-5978-4890-9b66-c7d91a3748c6

Committed 14 May 2025 04:22PM UTC coverage: 97.411% (+2.4%) from 94.984%

Build # 08cde213-5978-4890-9b66-c7d91a3748c6

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[FIX] Admin Dashboard test is failing intermittently

**ISSUE**
The Admin Dashboard test is failing intermittently, but not
consistently in local test and CI environments.

**DIAGNOSIS**
The test suite is sometimes proceeding to reload the ETD in the
spec before turbolinks had submitted the form data.

**RESOLUTION**
Waiting for content that appears after the page refresh ensures
that the JavaScript on the page has had time to finish executing
and the application has recieved the form submission before
proceeding with additional test steps.

Run Details

2822 of 2897 relevant lines covered (97.41%)

52.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/validators/my_program_validator.rb

class MyProgramValidator < ActiveModel::Validator
  def validate(record)
    return unless current_tab?(record)
    fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]
    fields_to_validate.each do |field|
      # TODO: confirm whether subfields are never required by Emory
      next if field == :subfield
      record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?
    end
  end

  def parsed_data(record)
    return {} unless record.data
    JSON.parse(record.data)
  end

  def current_tab?(record)
    parsed_data(record)['currentTab'] == "My Program"
  end
end

1	class MyProgramValidator < ActiveModel::Validator	4✔
2	def validate(record)	4✔
3	return unless current_tab?(record)	91✔
4	fields_to_validate = ::Hyrax::EtdForm.my_program_terms - [:partnering_agency]	3✔
5	fields_to_validate.each do \|field\|	3✔
6	# TODO: confirm whether subfields are never required by Emory
7	next if field == :subfield	12✔
8	record.errors.add(field, "#{field} is required") if parsed_data(record)[field.to_s].blank?	9✔
9	end
10	end
11
12	def parsed_data(record)	4✔
13	return {} unless record.data	100✔
14	JSON.parse(record.data)	74✔
15	end
16
17	def current_tab?(record)	4✔
18	parsed_data(record)['currentTab'] == "My Program"	91✔
19	end
20	end

curationexperts / laevigata / 08cde213-5978-4890-9b66-c7d91a3748c6

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous