14996555649

Committed 13 May 2025 12:26PM UTC coverage: 90.296% (-0.01%) from 90.31%

Build # 14996555649

Build Type

push

github

Committed by

web-flow

Commit Message

feat: use Decoder Service for decoding data (#2559)

Removes validation of the aforementioned `dataDecoded`, replacing usage of it with that fetched from the Decoder Service:

- Do not validated, ergo remove, `dataDecoded` from multisig, module and creation transactions.
- Replace all usage of `transaction.dataDecoded` with that fetched from the Decoder Service.
- Update tests accordingly.

Run Details

3292 of 3977 branches covered (82.78%)

Branch coverage included in aggregate %.

57 of 63 new or added lines in 7 files covered. (90.48%)

2 existing lines in 2 files now uncovered.

11428 of 12325 relevant lines covered (92.72%)

555.27 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

90.0

/src/domain/data-decoder/v2/data-decoder.repository.ts

import { Inject, Injectable } from '@nestjs/common';
import {
  DataDecoded,
  DataDecodedSchema,
} from '@/domain/data-decoder/v2/entities/data-decoded.entity';
import { IDataDecoderRepository } from '@/domain/data-decoder/v2/data-decoder.repository.interface';
import { IDataDecoderApi } from '@/domain/interfaces/data-decoder-api.interface';
import { Page } from '@/domain/entities/page.entity';
import {
  Contract,
  ContractPageSchema,
} from '@/domain/data-decoder/v2/entities/contract.entity';
import { Transaction } from '@/domain/safe/entities/transaction.entity';
import { ILoggingService, LoggingService } from '@/logging/logging.interface';
import { asError } from '@/logging/utils';

@Injectable()
export class DataDecoderRepository implements IDataDecoderRepository {
  constructor(
    @Inject(IDataDecoderApi)
    private readonly dataDecoderApi: IDataDecoderApi,
    @Inject(LoggingService) private readonly loggingService: ILoggingService,
  ) {}

  public async getDecodedData(args: {
    chainId: string;
    data: `0x${string}`;
    to: `0x${string}`;
  }): Promise<DataDecoded> {
    const dataDecoded = await this.dataDecoderApi.getDecodedData(args);
    return DataDecodedSchema.parse(dataDecoded);
  }

  public async getContracts(args: {
    chainIds: Array<string>;
    address: `0x${string}`;
  }): Promise<Page<Contract>> {
    const contracts = await this.dataDecoderApi.getContracts(args);
    return ContractPageSchema.parse(contracts);
  }

  public async getTransactionDataDecoded(args: {
    chainId: string;
    transaction: Transaction;
  }): Promise<DataDecoded | null> {
    const data = this.getDataDecodedData(args.transaction);

    if (!data || data === '0x') {
      return null;
    }

    try {
      return await this.getDecodedData({
        chainId: args.chainId,
        data,
        to: this.getDataDecodedTo(args.transaction),
      });
    } catch (e) {
      this.loggingService.warn(
        `Error decoding transaction data: ${asError(e).message}`,
      );
      return null;
    }
  }

  private getDataDecodedData(transaction: Transaction): `0x${string}` | null {
    // Multisig transaction
    if ('data' in transaction) {
      return transaction.data;
    }
    // Creation
    if ('setupData' in transaction) {
      return transaction.setupData;
    }

    throw Error('Unrecognized transaction type');
  }

  private getDataDecodedTo(transaction: Transaction): `0x${string}` {
    // Multisig transaction
    if ('to' in transaction) {
      return transaction.to;
    }
    // Native transfer
    if ('from' in transaction) {
      return transaction.from;
    }
    // Creation
    if ('factoryAddress' in transaction) {
      return transaction.factoryAddress;
    }

    throw Error('Unrecognized transaction type');
  }
}

1	import { Inject, Injectable } from '@nestjs/common';	106✔
2	import {	106✔
3	DataDecoded,
4	DataDecodedSchema,
5	} from '@/domain/data-decoder/v2/entities/data-decoded.entity';
6	import { IDataDecoderRepository } from '@/domain/data-decoder/v2/data-decoder.repository.interface';
7	import { IDataDecoderApi } from '@/domain/interfaces/data-decoder-api.interface';	106✔
8	import { Page } from '@/domain/entities/page.entity';
9	import {	106✔
10	Contract,
11	ContractPageSchema,
12	} from '@/domain/data-decoder/v2/entities/contract.entity';
13	import { Transaction } from '@/domain/safe/entities/transaction.entity';
14	import { ILoggingService, LoggingService } from '@/logging/logging.interface';	106✔
15	import { asError } from '@/logging/utils';	106✔
16
17	@Injectable()
18	export class DataDecoderRepository implements IDataDecoderRepository {	106✔
19	constructor(
20	@Inject(IDataDecoderApi)
21	private readonly dataDecoderApi: IDataDecoderApi,	1,614✔
22	@Inject(LoggingService) private readonly loggingService: ILoggingService,	1,614✔
23	) {}
24
25	public async getDecodedData(args: {
26	chainId: string;
27	data: `0x${string}`;
28	to: `0x${string}`;
29	}): Promise<DataDecoded> {
30	const dataDecoded = await this.dataDecoderApi.getDecodedData(args);	520✔
31	return DataDecodedSchema.parse(dataDecoded);	308✔
32	}
33
34	public async getContracts(args: {
35	chainIds: Array<string>;
36	address: `0x${string}`;
37	}): Promise<Page<Contract>> {
38	const contracts = await this.dataDecoderApi.getContracts(args);	×
39	return ContractPageSchema.parse(contracts);	×
40	}
41
42	public async getTransactionDataDecoded(args: {
43	chainId: string;
44	transaction: Transaction;
45	}): Promise<DataDecoded \| null> {
46	const data = this.getDataDecodedData(args.transaction);	524✔
47
48	if (!data \|\| data === '0x') {	524✔
49	return null;	4✔
50	}
51
52	try {	520✔
53	return await this.getDecodedData({	520✔
54	chainId: args.chainId,
55	data,
56	to: this.getDataDecodedTo(args.transaction),
57	});
58	} catch (e) {
59	this.loggingService.warn(	212✔
60	`Error decoding transaction data: ${asError(e).message}`,
61	);
62	return null;	212✔
63	}
64	}
65
66	private getDataDecodedData(transaction: Transaction): `0x${string}` \| null {
67	// Multisig transaction
68	if ('data' in transaction) {	524✔
69	return transaction.data;	518✔
70	}
71	// Creation
72	if ('setupData' in transaction) {	6✔
73	return transaction.setupData;	6✔
74	}
75
NEW 76	throw Error('Unrecognized transaction type');	×
77	}
78
79	private getDataDecodedTo(transaction: Transaction): `0x${string}` {
80	// Multisig transaction
81	if ('to' in transaction) {	520✔
82	return transaction.to;	440✔
83	}
84	// Native transfer
85	if ('from' in transaction) {	80✔
86	return transaction.from;	74✔
87	}
88	// Creation
89	if ('factoryAddress' in transaction) {	6✔
90	return transaction.factoryAddress;	6✔
91	}
92
NEW 93	throw Error('Unrecognized transaction type');	×
94	}
95	}

safe-global / safe-client-gateway / 14996555649

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous