14967870200

Committed 12 May 2025 08:47AM UTC coverage: 23.685% (+15.2%) from 8.477%

Build # 14967870200

Build Type

push

github

Committed by

web-flow

Commit Message

fix(serializer): invalid uri variable 400 response (#7135)

Run Details

1 of 2 new or added lines in 2 files covered. (50.0%)

2825 existing lines in 152 files now uncovered.

11409 of 48169 relevant lines covered (23.69%)

54.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/src/Symfony/Validator/State/ParameterValidatorProvider.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\Validator\State;

use ApiPlatform\Metadata\Operation;
use ApiPlatform\Metadata\Parameter;
use ApiPlatform\State\ParameterNotFound;
use ApiPlatform\State\ProviderInterface;
use ApiPlatform\State\Util\ParameterParserTrait;
use ApiPlatform\Validator\Exception\ValidationException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Validator\ConstraintViolation;
use Symfony\Component\Validator\ConstraintViolationInterface;
use Symfony\Component\Validator\ConstraintViolationList;
use Symfony\Component\Validator\Validator\ValidatorInterface;

/**
 * Validates parameters using the Symfony validator.
 *
 * @experimental
 */
final class ParameterValidatorProvider implements ProviderInterface
{
    use ParameterParserTrait;

    public function __construct(
        private readonly ValidatorInterface $validator,
        private readonly ProviderInterface $decorated,
    ) {
    }

    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
    {
        if (!($request = $context['request'] ?? null) instanceof Request) {
            return $this->decorated->provide($operation, $uriVariables, $context);
        }

        $operation = $request->attributes->get('_api_operation') ?? $operation;
        if (!($operation->getQueryParameterValidationEnabled() ?? true)) {
            return $this->decorated->provide($operation, $uriVariables, $context);
        }

        $constraintViolationList = new ConstraintViolationList();
        foreach ($operation->getParameters() ?? [] as $parameter) {
            if (!$constraints = $parameter->getConstraints()) {
                continue;
            }

            $value = $parameter->getValue();
            if ($value instanceof ParameterNotFound) {
                $value = null;
            }

            $violations = [];
            if (\is_array($value) && $properties = $parameter->getExtraProperties()['_properties'] ?? []) {
                foreach ($properties as $property) {
                    $violations = [...$violations, ...$this->validator->validate($value[$property] ?? null, $constraints)];
                }
            } else {
                $violations = $this->validator->validate($value, $constraints);
            }

            foreach ($violations as $violation) {
                $constraintViolationList->add(new ConstraintViolation(
                    $violation->getMessage(),
                    $violation->getMessageTemplate(),
                    $violation->getParameters(),
                    $violation->getRoot(),
                    $this->getProperty($parameter, $violation),
                    $violation->getInvalidValue(),
                    $violation->getPlural(),
                    $violation->getCode(),
                    $violation->getConstraint(),
                    $violation->getCause()
                ));
            }
        }

        if (0 !== \count($constraintViolationList)) {
            throw new ValidationException($constraintViolationList);
        }

        return $this->decorated->provide($operation, $uriVariables, $context);
    }

    // There's a `property` inside Parameter but it's used for hydra:search only as here we want the parameter name instead
    private function getProperty(Parameter $parameter, ConstraintViolationInterface $violation): string
    {
        $key = $parameter->getKey();

        if (str_contains($key, '[:property]')) {
            return str_replace('[:property]', $violation->getPropertyPath(), $key);
        }

        if (str_contains($key, ':property')) {
            return str_replace(':property', $violation->getPropertyPath(), $key);
        }

        if ($p = $violation->getPropertyPath()) {
            return $p;
        }

        return $key;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\Validator\State;
15
16	use ApiPlatform\Metadata\Operation;
17	use ApiPlatform\Metadata\Parameter;
18	use ApiPlatform\State\ParameterNotFound;
19	use ApiPlatform\State\ProviderInterface;
20	use ApiPlatform\State\Util\ParameterParserTrait;
21	use ApiPlatform\Validator\Exception\ValidationException;
22	use Symfony\Component\HttpFoundation\Request;
23	use Symfony\Component\Validator\ConstraintViolation;
24	use Symfony\Component\Validator\ConstraintViolationInterface;
25	use Symfony\Component\Validator\ConstraintViolationList;
26	use Symfony\Component\Validator\Validator\ValidatorInterface;
27
28	/**
29	* Validates parameters using the Symfony validator.
30	*
31	* @experimental
32	*/
33	final class ParameterValidatorProvider implements ProviderInterface
34	{
35	use ParameterParserTrait;
36
37	public function __construct(
38	private readonly ValidatorInterface $validator,
39	private readonly ProviderInterface $decorated,
40	) {
41	}	1,284✔
42
43	public function provide(Operation $operation, array $uriVariables = [], array $context = []): object\|array\|null
44	{
45	if (!($request = $context['request'] ?? null) instanceof Request) {	1,284✔
46	return $this->decorated->provide($operation, $uriVariables, $context);	×
47	}
48
49	$operation = $request->attributes->get('_api_operation') ?? $operation;	1,284✔
50	if (!($operation->getQueryParameterValidationEnabled() ?? true)) {	1,284✔
UNCOV 51	return $this->decorated->provide($operation, $uriVariables, $context);	×
52	}
53
54	$constraintViolationList = new ConstraintViolationList();	1,284✔
55	foreach ($operation->getParameters() ?? [] as $parameter) {	1,284✔
56	if (!$constraints = $parameter->getConstraints()) {	490✔
57	continue;	431✔
58	}
59
60	$value = $parameter->getValue();	449✔
61	if ($value instanceof ParameterNotFound) {	449✔
62	$value = null;	408✔
63	}
64
65	$violations = [];	449✔
66	if (\is_array($value) && $properties = $parameter->getExtraProperties()['_properties'] ?? []) {	449✔
UNCOV 67	foreach ($properties as $property) {	×
UNCOV 68	$violations = [...$violations, ...$this->validator->validate($value[$property] ?? null, $constraints)];	×
69	}
70	} else {
71	$violations = $this->validator->validate($value, $constraints);	449✔
72	}
73
74	foreach ($violations as $violation) {	449✔
75	$constraintViolationList->add(new ConstraintViolation(	24✔
76	$violation->getMessage(),	24✔
77	$violation->getMessageTemplate(),	24✔
78	$violation->getParameters(),	24✔
79	$violation->getRoot(),	24✔
80	$this->getProperty($parameter, $violation),	24✔
81	$violation->getInvalidValue(),	24✔
82	$violation->getPlural(),	24✔
83	$violation->getCode(),	24✔
84	$violation->getConstraint(),	24✔
85	$violation->getCause()	24✔
86	));	24✔
87	}
88	}
89
90	if (0 !== \count($constraintViolationList)) {	1,284✔
91	throw new ValidationException($constraintViolationList);	24✔
92	}
93
94	return $this->decorated->provide($operation, $uriVariables, $context);	1,284✔
95	}
96
97	// There's a `property` inside Parameter but it's used for hydra:search only as here we want the parameter name instead
98	private function getProperty(Parameter $parameter, ConstraintViolationInterface $violation): string
99	{
100	$key = $parameter->getKey();	24✔
101
102	if (str_contains($key, '[:property]')) {	24✔
UNCOV 103	return str_replace('[:property]', $violation->getPropertyPath(), $key);	×
104	}
105
106	if (str_contains($key, ':property')) {	24✔
107	return str_replace(':property', $violation->getPropertyPath(), $key);	×
108	}
109
110	if ($p = $violation->getPropertyPath()) {	24✔
111	return $p;	×
112	}
113
114	return $key;	24✔
115	}
116	}

api-platform / core / 14967870200

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous