14967870200

Committed 12 May 2025 08:47AM UTC coverage: 23.685% (+15.2%) from 8.477%

Build # 14967870200

Build Type

push

github

Committed by

web-flow

Commit Message

fix(serializer): invalid uri variable 400 response (#7135)

Run Details

1 of 2 new or added lines in 2 files covered. (50.0%)

2825 existing lines in 152 files now uncovered.

11409 of 48169 relevant lines covered (23.69%)

54.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/src/Symfony/Security/ResourceAccessChecker.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\Security;

use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
use Symfony\Component\Security\Core\Authentication\AuthenticationTrustResolverInterface;
use Symfony\Component\Security\Core\Authentication\Token\NullToken;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;

/**
 * Checks if the logged user has sufficient permissions to access the given resource.
 *
 * @author Kévin Dunglas <dunglas@gmail.com>
 */
final class ResourceAccessChecker implements ResourceAccessCheckerInterface
{
    public function __construct(private readonly ?ExpressionLanguage $expressionLanguage = null, private readonly ?AuthenticationTrustResolverInterface $authenticationTrustResolver = null, private readonly ?RoleHierarchyInterface $roleHierarchy = null, private readonly ?TokenStorageInterface $tokenStorage = null, private readonly ?AuthorizationCheckerInterface $authorizationChecker = null)
    {
    }

    public function isGranted(string $resourceClass, string $expression, array $extraVariables = []): bool
    {
        if (null === $this->tokenStorage || null === $this->authenticationTrustResolver) {
            throw new \LogicException('The "symfony/security" library must be installed to use the "security" attribute.');
        }

        if (null === $this->expressionLanguage) {
            throw new \LogicException('The "symfony/expression-language" library must be installed to use the "security" attribute.');
        }

        $variables = array_merge($extraVariables, [
            'trust_resolver' => $this->authenticationTrustResolver,
            'auth_checker' => $this->authorizationChecker, // needed for the is_granted expression function
        ]);

        if (null === $token = $this->tokenStorage->getToken()) {
            $token = new NullToken();
        }

        $variables = array_merge($variables, $this->getVariables($token));

        return (bool) $this->expressionLanguage->evaluate($expression, $variables);
    }

    /**
     * @copyright Fabien Potencier <fabien@symfony.com>
     *
     * @see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/Authorization/Voter/ExpressionVoter.php
     */
    private function getVariables(TokenInterface $token): array
    {
        return [
            'token' => $token,
            'user' => $token->getUser(),
            'roles' => $this->getEffectiveRoles($token),
        ];
    }

    /**
     * @return string[]
     */
    private function getEffectiveRoles(TokenInterface $token): array
    {
        if (null === $this->roleHierarchy) {
            return $token->getRoleNames();
        }

        return $this->roleHierarchy->getReachableRoleNames($token->getRoleNames());
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\Security;
15
16	use Symfony\Component\ExpressionLanguage\ExpressionLanguage;
17	use Symfony\Component\Security\Core\Authentication\AuthenticationTrustResolverInterface;
18	use Symfony\Component\Security\Core\Authentication\Token\NullToken;
19	use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
20	use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
21	use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
22	use Symfony\Component\Security\Core\Role\RoleHierarchyInterface;
23
24	/**
25	* Checks if the logged user has sufficient permissions to access the given resource.
26	*
27	* @author Kévin Dunglas <dunglas@gmail.com>
28	*/
29	final class ResourceAccessChecker implements ResourceAccessCheckerInterface
30	{
31	public function __construct(private readonly ?ExpressionLanguage $expressionLanguage = null, private readonly ?AuthenticationTrustResolverInterface $authenticationTrustResolver = null, private readonly ?RoleHierarchyInterface $roleHierarchy = null, private readonly ?TokenStorageInterface $tokenStorage = null, private readonly ?AuthorizationCheckerInterface $authorizationChecker = null)
32	{
33	}	1,562✔
34
35	public function isGranted(string $resourceClass, string $expression, array $extraVariables = []): bool
36	{
37	if (null === $this->tokenStorage \|\| null === $this->authenticationTrustResolver) {	136✔
UNCOV 38	throw new \LogicException('The "symfony/security" library must be installed to use the "security" attribute.');	×
39	}
40
41	if (null === $this->expressionLanguage) {	136✔
UNCOV 42	throw new \LogicException('The "symfony/expression-language" library must be installed to use the "security" attribute.');	×
43	}
44
45	$variables = array_merge($extraVariables, [	136✔
46	'trust_resolver' => $this->authenticationTrustResolver,	136✔
47	'auth_checker' => $this->authorizationChecker, // needed for the is_granted expression function	136✔
48	]);	136✔
49
50	if (null === $token = $this->tokenStorage->getToken()) {	136✔
51	$token = new NullToken();	16✔
52	}
53
54	$variables = array_merge($variables, $this->getVariables($token));	136✔
55
56	return (bool) $this->expressionLanguage->evaluate($expression, $variables);	136✔
57	}
58
59	/**
60	* @copyright Fabien Potencier <fabien@symfony.com>
61	*
62	* @see https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Security/Core/Authorization/Voter/ExpressionVoter.php
63	*/
64	private function getVariables(TokenInterface $token): array
65	{
66	return [	136✔
67	'token' => $token,	136✔
68	'user' => $token->getUser(),	136✔
69	'roles' => $this->getEffectiveRoles($token),	136✔
70	];	136✔
71	}
72
73	/**
74	* @return string[]
75	*/
76	private function getEffectiveRoles(TokenInterface $token): array
77	{
78	if (null === $this->roleHierarchy) {	136✔
UNCOV 79	return $token->getRoleNames();	×
80	}
81
82	return $this->roleHierarchy->getReachableRoleNames($token->getRoleNames());	136✔
83	}
84	}

api-platform / core / 14967870200

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous