14967870200

Committed 12 May 2025 08:47AM UTC coverage: 23.685% (+15.2%) from 8.477%

Build # 14967870200

Build Type

push

github

Committed by

web-flow

Commit Message

fix(serializer): invalid uri variable 400 response (#7135)

Run Details

1 of 2 new or added lines in 2 files covered. (50.0%)

2825 existing lines in 152 files now uncovered.

11409 of 48169 relevant lines covered (23.69%)

54.89 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/src/Doctrine/Orm/Metadata/Resource/DoctrineOrmResourceCollectionMetadataFactory.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Doctrine\Orm\Metadata\Resource;

use ApiPlatform\Doctrine\Orm\State\CollectionProvider;
use ApiPlatform\Doctrine\Orm\State\ItemProvider;
use ApiPlatform\Doctrine\Orm\State\Options;
use ApiPlatform\Metadata\ApiResource;
use ApiPlatform\Metadata\CollectionOperationInterface;
use ApiPlatform\Metadata\DeleteOperationInterface;
use ApiPlatform\Metadata\Operation;
use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
use ApiPlatform\State\Util\StateOptionsTrait;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\Persistence\ManagerRegistry;

final class DoctrineOrmResourceCollectionMetadataFactory implements ResourceMetadataCollectionFactoryInterface
{
    use StateOptionsTrait;

    public function __construct(private readonly ManagerRegistry $managerRegistry, private readonly ResourceMetadataCollectionFactoryInterface $decorated)
    {
    }

    /**
     * {@inheritdoc}
     */
    public function create(string $resourceClass): ResourceMetadataCollection
    {
        $resourceMetadataCollection = $this->decorated->create($resourceClass);

        /** @var ApiResource $resourceMetadata */
        foreach ($resourceMetadataCollection as $i => $resourceMetadata) {
            $operations = $resourceMetadata->getOperations();

            if ($operations) {
                /** @var Operation $operation */
                foreach ($resourceMetadata->getOperations() as $operationName => $operation) {
                    $entityClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);

                    if (!$this->managerRegistry->getManagerForClass($entityClass) instanceof EntityManagerInterface) {
                        continue;
                    }

                    $operations->add($operationName, $this->addDefaults($operation));
                }

                $resourceMetadata = $resourceMetadata->withOperations($operations);
            }

            $graphQlOperations = $resourceMetadata->getGraphQlOperations();

            if ($graphQlOperations) {
                foreach ($graphQlOperations as $operationName => $graphQlOperation) {
                    $entityClass = $this->getStateOptionsClass($graphQlOperation, $graphQlOperation->getClass(), Options::class);

                    if (!$this->managerRegistry->getManagerForClass($entityClass) instanceof EntityManagerInterface) {
                        continue;
                    }

                    $graphQlOperations[$operationName] = $this->addDefaults($graphQlOperation);
                }

                $resourceMetadata = $resourceMetadata->withGraphQlOperations($graphQlOperations);
            }

            $resourceMetadataCollection[$i] = $resourceMetadata;
        }

        return $resourceMetadataCollection;
    }

    private function addDefaults(Operation $operation): Operation
    {
        if (null === $operation->getProvider()) {
            $operation = $operation->withProvider($this->getProvider($operation));
        }

        $options = $operation->getStateOptions() ?: new Options();
        if ($options instanceof Options && null === $options->getHandleLinks()) {
            $options = $options->withHandleLinks('api_platform.doctrine.orm.links_handler');
            $operation = $operation->withStateOptions($options);
        }

        if (null === $operation->getProcessor()) {
            $operation = $operation->withProcessor($this->getProcessor($operation));
        }

        return $operation;
    }

    private function getProvider(Operation $operation): string
    {
        if ($operation instanceof CollectionOperationInterface) {
            return CollectionProvider::class;
        }

        return ItemProvider::class;
    }

    private function getProcessor(Operation $operation): string
    {
        if ($operation instanceof DeleteOperationInterface) {
            return 'api_platform.doctrine.orm.state.remove_processor';
        }

        return 'api_platform.doctrine.orm.state.persist_processor';
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Doctrine\Orm\Metadata\Resource;
15
16	use ApiPlatform\Doctrine\Orm\State\CollectionProvider;
17	use ApiPlatform\Doctrine\Orm\State\ItemProvider;
18	use ApiPlatform\Doctrine\Orm\State\Options;
19	use ApiPlatform\Metadata\ApiResource;
20	use ApiPlatform\Metadata\CollectionOperationInterface;
21	use ApiPlatform\Metadata\DeleteOperationInterface;
22	use ApiPlatform\Metadata\Operation;
23	use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
24	use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
25	use ApiPlatform\State\Util\StateOptionsTrait;
26	use Doctrine\ORM\EntityManagerInterface;
27	use Doctrine\Persistence\ManagerRegistry;
28
29	final class DoctrineOrmResourceCollectionMetadataFactory implements ResourceMetadataCollectionFactoryInterface
30	{
31	use StateOptionsTrait;
32
33	public function __construct(private readonly ManagerRegistry $managerRegistry, private readonly ResourceMetadataCollectionFactoryInterface $decorated)
34	{
UNCOV 35	}	845✔
36
37	/**
38	* {@inheritdoc}
39	*/
40	public function create(string $resourceClass): ResourceMetadataCollection
41	{
UNCOV 42	$resourceMetadataCollection = $this->decorated->create($resourceClass);	32✔
43
44	/** @var ApiResource $resourceMetadata */
UNCOV 45	foreach ($resourceMetadataCollection as $i => $resourceMetadata) {	32✔
UNCOV 46	$operations = $resourceMetadata->getOperations();	30✔
47
UNCOV 48	if ($operations) {	30✔
49	/** @var Operation $operation */
UNCOV 50	foreach ($resourceMetadata->getOperations() as $operationName => $operation) {	30✔
UNCOV 51	$entityClass = $this->getStateOptionsClass($operation, $operation->getClass(), Options::class);	30✔
52
UNCOV 53	if (!$this->managerRegistry->getManagerForClass($entityClass) instanceof EntityManagerInterface) {	30✔
UNCOV 54	continue;	5✔
55	}
56
UNCOV 57	$operations->add($operationName, $this->addDefaults($operation));	28✔
58	}
59
UNCOV 60	$resourceMetadata = $resourceMetadata->withOperations($operations);	30✔
61	}
62
UNCOV 63	$graphQlOperations = $resourceMetadata->getGraphQlOperations();	30✔
64
UNCOV 65	if ($graphQlOperations) {	30✔
UNCOV 66	foreach ($graphQlOperations as $operationName => $graphQlOperation) {	27✔
UNCOV 67	$entityClass = $this->getStateOptionsClass($graphQlOperation, $graphQlOperation->getClass(), Options::class);	27✔
68
UNCOV 69	if (!$this->managerRegistry->getManagerForClass($entityClass) instanceof EntityManagerInterface) {	27✔
UNCOV 70	continue;	3✔
71	}
72
UNCOV 73	$graphQlOperations[$operationName] = $this->addDefaults($graphQlOperation);	26✔
74	}
75
UNCOV 76	$resourceMetadata = $resourceMetadata->withGraphQlOperations($graphQlOperations);	27✔
77	}
78
UNCOV 79	$resourceMetadataCollection[$i] = $resourceMetadata;	30✔
80	}
81
UNCOV 82	return $resourceMetadataCollection;	32✔
83	}
84
85	private function addDefaults(Operation $operation): Operation
86	{
UNCOV 87	if (null === $operation->getProvider()) {	28✔
UNCOV 88	$operation = $operation->withProvider($this->getProvider($operation));	28✔
89	}
90
UNCOV 91	$options = $operation->getStateOptions() ?: new Options();	28✔
UNCOV 92	if ($options instanceof Options && null === $options->getHandleLinks()) {	28✔
UNCOV 93	$options = $options->withHandleLinks('api_platform.doctrine.orm.links_handler');	27✔
UNCOV 94	$operation = $operation->withStateOptions($options);	27✔
95	}
96
UNCOV 97	if (null === $operation->getProcessor()) {	28✔
UNCOV 98	$operation = $operation->withProcessor($this->getProcessor($operation));	28✔
99	}
100
UNCOV 101	return $operation;	28✔
102	}
103
104	private function getProvider(Operation $operation): string
105	{
UNCOV 106	if ($operation instanceof CollectionOperationInterface) {	28✔
UNCOV 107	return CollectionProvider::class;	27✔
108	}
109
UNCOV 110	return ItemProvider::class;	27✔
111	}
112
113	private function getProcessor(Operation $operation): string
114	{
UNCOV 115	if ($operation instanceof DeleteOperationInterface) {	28✔
UNCOV 116	return 'api_platform.doctrine.orm.state.remove_processor';	24✔
117	}
118
UNCOV 119	return 'api_platform.doctrine.orm.state.persist_processor';	28✔
120	}
121	}

api-platform / core / 14967870200

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous