14967095168

Committed 12 May 2025 08:08AM UTC coverage: 22.155% (+13.7%) from 8.457%

Build # 14967095168

Build Type

Pull #7135

github

Committed by

web-flow

Commit Message

Merge 574a2b863 into 4dd0cdfc4

Pull Request Pull Request #7135: fix(symfony,laravel): InvalidUriVariableException status code (e400)

Run Details

1 of 2 new or added lines in 2 files covered. (50.0%)

120 existing lines in 12 files now uncovered.

10846 of 48956 relevant lines covered (22.15%)

10.12 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/Symfony/EventListener/SerializeListener.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\EventListener;

use ApiPlatform\Metadata\Error;
use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use ApiPlatform\State\ProcessorInterface;
use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
use ApiPlatform\State\Util\RequestAttributesExtractor;
use Symfony\Component\HttpKernel\Event\ViewEvent;

/**
 * Serializes data.
 *
 * @author Kévin Dunglas <dunglas@gmail.com>
 */
final class SerializeListener
{
    use OperationRequestInitiatorTrait;

    /**
     * @param ProcessorInterface<mixed,mixed> $processor
     */
    public function __construct(private readonly ProcessorInterface $processor, ?ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null)
    {
        $this->resourceMetadataCollectionFactory = $resourceMetadataFactory;
    }

    /**
     * Serializes the data to the requested format.
     */
    public function onKernelView(ViewEvent $event): void
    {
        $controllerResult = $event->getControllerResult();
        $request = $event->getRequest();
        $operation = $this->initializeOperation($request);

        $attributes = RequestAttributesExtractor::extractAttributes($request);

        if (!($attributes['respond'] ?? $request->attributes->getBoolean('_api_respond', false)) || !$operation) {
            return;
        }

        if (null === $operation->canSerialize()) {
            $operation = $operation->withSerialize(true);
        }

        if ($operation instanceof Error) {
            // we don't want the FlattenException
            $controllerResult = $request->attributes->get('data') ?? $controllerResult;
        }

        $uriVariables = $request->attributes->get('_api_uri_variables') ?? [];
        $serialized = $this->processor->process($controllerResult, $operation, $uriVariables, [
            'request' => $request,
            'uri_variables' => $uriVariables,
            'resource_class' => $operation->getClass(),
        ]);

        $event->setControllerResult($serialized);
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\EventListener;
15
16	use ApiPlatform\Metadata\Error;
17	use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
18	use ApiPlatform\State\ProcessorInterface;
19	use ApiPlatform\State\Util\OperationRequestInitiatorTrait;
20	use ApiPlatform\State\Util\RequestAttributesExtractor;
21	use Symfony\Component\HttpKernel\Event\ViewEvent;
22
23	/**
24	* Serializes data.
25	*
26	* @author Kévin Dunglas <dunglas@gmail.com>
27	*/
28	final class SerializeListener
29	{
30	use OperationRequestInitiatorTrait;
31
32	/**
33	* @param ProcessorInterface<mixed,mixed> $processor
34	*/
35	public function __construct(private readonly ProcessorInterface $processor, ?ResourceMetadataCollectionFactoryInterface $resourceMetadataFactory = null)
36	{
UNCOV 37	$this->resourceMetadataCollectionFactory = $resourceMetadataFactory;	×
38	}
39
40	/**
41	* Serializes the data to the requested format.
42	*/
43	public function onKernelView(ViewEvent $event): void
44	{
UNCOV 45	$controllerResult = $event->getControllerResult();	×
UNCOV 46	$request = $event->getRequest();	×
UNCOV 47	$operation = $this->initializeOperation($request);	×
48
UNCOV 49	$attributes = RequestAttributesExtractor::extractAttributes($request);	×
50
UNCOV 51	if (!($attributes['respond'] ?? $request->attributes->getBoolean('_api_respond', false)) \|\| !$operation) {	×
52	return;	×
53	}
54
UNCOV 55	if (null === $operation->canSerialize()) {	×
UNCOV 56	$operation = $operation->withSerialize(true);	×
57	}
58
UNCOV 59	if ($operation instanceof Error) {	×
60	// we don't want the FlattenException
UNCOV 61	$controllerResult = $request->attributes->get('data') ?? $controllerResult;	×
62	}
63
UNCOV 64	$uriVariables = $request->attributes->get('_api_uri_variables') ?? [];	×
UNCOV 65	$serialized = $this->processor->process($controllerResult, $operation, $uriVariables, [	×
UNCOV 66	'request' => $request,	×
UNCOV 67	'uri_variables' => $uriVariables,	×
UNCOV 68	'resource_class' => $operation->getClass(),	×
UNCOV 69	]);	×
70
UNCOV 71	$event->setControllerResult($serialized);	×
72	}
73	}

api-platform / core / 14967095168

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous