• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 14966983219

12 May 2025 08:03AM UTC coverage: 21.715% (-0.008%) from 21.723%
14966983219

push

github

web-flow
We've seen instances of a VPC being left with a now-deleted subnet on (#5228)

its status field.

We believe this is due to a race condition where we patch a VPC without
taking care of ResourceVersion. For now, every time we run
`handleAddOrUpdateVpc` we ensure the vpc.Status.Subnets field is
correct.

Fixes: #5220

Signed-off-by: Andrew Lee <alee@evroc.com>
Co-authored-by: Andrew Lee <alee@evroc.com>

0 of 7 new or added lines in 1 file covered. (0.0%)

2 existing lines in 1 file now uncovered.

10253 of 47216 relevant lines covered (21.72%)

0.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/pkg/controller/vpc.go
1
package controller
2

3
import (
4
        "context"
5
        "encoding/json"
6
        "errors"
7
        "fmt"
8
        "maps"
9
        "math"
10
        "net"
11
        "reflect"
12
        "slices"
13
        "sort"
14
        "strings"
15
        "time"
16

17
        v1 "k8s.io/api/core/v1"
18
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
19
        metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
20
        "k8s.io/apimachinery/pkg/labels"
21
        "k8s.io/apimachinery/pkg/types"
22
        "k8s.io/client-go/tools/cache"
23
        "k8s.io/klog/v2"
24
        "sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
25

26
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
27
        "github.com/kubeovn/kube-ovn/pkg/ovsdb/ovnnb"
28
        "github.com/kubeovn/kube-ovn/pkg/util"
29
)
30

31
func (c *Controller) enqueueAddVpc(obj any) {
×
32
        vpc := obj.(*kubeovnv1.Vpc)
×
33
        key := cache.MetaObjectToName(vpc).String()
×
34
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !ok {
×
35
                klog.V(3).Infof("enqueue add vpc %s", key)
×
36
                c.addOrUpdateVpcQueue.Add(key)
×
37
        }
×
38
}
39

40
func vpcBFDPortChanged(oldObj, newObj *kubeovnv1.BFDPort) bool {
×
41
        if oldObj == nil && newObj == nil {
×
42
                return false
×
43
        }
×
44
        if oldObj == nil || newObj == nil {
×
45
                return true
×
46
        }
×
47
        return oldObj.Enabled != newObj.Enabled || oldObj.IP != newObj.IP || !reflect.DeepEqual(oldObj.NodeSelector, newObj.NodeSelector)
×
48
}
49

50
func (c *Controller) enqueueUpdateVpc(oldObj, newObj any) {
×
51
        oldVpc := oldObj.(*kubeovnv1.Vpc)
×
52
        newVpc := newObj.(*kubeovnv1.Vpc)
×
53

×
54
        if !newVpc.DeletionTimestamp.IsZero() ||
×
55
                !slices.Equal(oldVpc.Spec.Namespaces, newVpc.Spec.Namespaces) ||
×
56
                !reflect.DeepEqual(oldVpc.Spec.StaticRoutes, newVpc.Spec.StaticRoutes) ||
×
57
                !reflect.DeepEqual(oldVpc.Spec.PolicyRoutes, newVpc.Spec.PolicyRoutes) ||
×
58
                !reflect.DeepEqual(oldVpc.Spec.VpcPeerings, newVpc.Spec.VpcPeerings) ||
×
59
                !maps.Equal(oldVpc.Annotations, newVpc.Annotations) ||
×
60
                !slices.Equal(oldVpc.Spec.ExtraExternalSubnets, newVpc.Spec.ExtraExternalSubnets) ||
×
61
                oldVpc.Spec.EnableExternal != newVpc.Spec.EnableExternal ||
×
62
                oldVpc.Spec.EnableBfd != newVpc.Spec.EnableBfd ||
×
63
                vpcBFDPortChanged(oldVpc.Spec.BFDPort, newVpc.Spec.BFDPort) ||
×
64
                oldVpc.Labels[util.VpcExternalLabel] != newVpc.Labels[util.VpcExternalLabel] {
×
65
                // TODO:// label VpcExternalLabel replace with spec enable external
×
66

×
67
                if newVpc.Annotations == nil {
×
68
                        newVpc.Annotations = make(map[string]string)
×
69
                }
×
70
                newVpc.Annotations[util.VpcLastPolicies] = convertPolicies(oldVpc.Spec.PolicyRoutes)
×
71

×
72
                key := cache.MetaObjectToName(newVpc).String()
×
73
                klog.Infof("enqueue update vpc %s", key)
×
74
                c.addOrUpdateVpcQueue.Add(key)
×
75
        }
76
}
77

78
func (c *Controller) enqueueDelVpc(obj any) {
×
79
        vpc := obj.(*kubeovnv1.Vpc)
×
80
        if _, ok := vpc.Labels[util.VpcExternalLabel]; !vpc.Status.Default || !ok {
×
81
                klog.V(3).Infof("enqueue delete vpc %s", vpc.Name)
×
82
                c.delVpcQueue.Add(vpc)
×
83
        }
×
84
}
85

86
func (c *Controller) handleDelVpc(vpc *kubeovnv1.Vpc) error {
×
87
        c.vpcKeyMutex.LockKey(vpc.Name)
×
88
        defer func() { _ = c.vpcKeyMutex.UnlockKey(vpc.Name) }()
×
89
        klog.Infof("handle delete vpc %s", vpc.Name)
×
90

×
91
        // should delete vpc subnets first
×
92
        var err error
×
93
        for _, subnet := range vpc.Status.Subnets {
×
94
                if _, err = c.subnetsLister.Get(subnet); err != nil {
×
95
                        if k8serrors.IsNotFound(err) {
×
96
                                continue
×
97
                        }
98
                        err = fmt.Errorf("failed to get subnet %s for vpc %s: %w", subnet, vpc.Name, err)
×
99
                } else {
×
100
                        err = fmt.Errorf("failed to delete vpc %s, please delete subnet %s first", vpc.Name, subnet)
×
101
                }
×
102
                klog.Error(err)
×
103
                return err
×
104
        }
105

106
        if err := c.deleteVpcLb(vpc); err != nil {
×
107
                klog.Error(err)
×
108
                return err
×
109
        }
×
110

111
        if err := c.handleDelVpcExternalSubnet(vpc.Name, c.config.ExternalGatewaySwitch); err != nil {
×
112
                klog.Errorf("failed to delete external connection for vpc %s, error %v", vpc.Name, err)
×
113
                return err
×
114
        }
×
115

116
        for _, subnet := range vpc.Status.ExtraExternalSubnets {
×
117
                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
118
                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnet); err != nil {
×
119
                        klog.Error(err)
×
120
                        return err
×
121
                }
×
122
        }
123

124
        if err := c.deleteVpcRouter(vpc.Status.Router); err != nil {
×
125
                klog.Error(err)
×
126
                return err
×
127
        }
×
128

129
        return nil
×
130
}
131

132
func (c *Controller) handleUpdateVpcStatus(key string) error {
×
133
        c.vpcKeyMutex.LockKey(key)
×
134
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
135
        klog.Infof("handle status update for vpc %s", key)
×
136

×
137
        cachedVpc, err := c.vpcsLister.Get(key)
×
138
        if err != nil {
×
139
                if k8serrors.IsNotFound(err) {
×
140
                        return nil
×
141
                }
×
142
                klog.Error(err)
×
143
                return err
×
144
        }
145
        vpc := cachedVpc.DeepCopy()
×
146

×
147
        subnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
148
        if err != nil {
×
149
                klog.Error(err)
×
150
                return err
×
151
        }
×
152

153
        change := vpc.Status.DefaultLogicalSwitch != defaultSubnet
×
154

×
155
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
156
        vpc.Status.Subnets = subnets
×
157

×
158
        if !vpc.Spec.BFDPort.IsEnabled() && !vpc.Status.BFDPort.IsEmpty() {
×
159
                vpc.Status.BFDPort.Clear()
×
160
        }
×
161
        bytes, err := vpc.Status.Bytes()
×
162
        if err != nil {
×
163
                klog.Error(err)
×
164
                return err
×
165
        }
×
166

167
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
168
        if err != nil {
×
169
                klog.Error(err)
×
170
                return err
×
171
        }
×
172

173
        if len(vpc.Status.Subnets) == 0 {
×
174
                klog.Infof("vpc %s has no subnets, add to queue", vpc.Name)
×
175
                c.addOrUpdateVpcQueue.AddAfter(vpc.Name, 5*time.Second)
×
176
        }
×
177

178
        if change {
×
179
                for _, ns := range vpc.Spec.Namespaces {
×
180
                        c.addNamespaceQueue.Add(ns)
×
181
                }
×
182
        }
183

184
        natGws, err := c.vpcNatGatewayLister.List(labels.Everything())
×
185
        if err != nil {
×
186
                klog.Error(err)
×
187
                return err
×
188
        }
×
189
        for _, gw := range natGws {
×
190
                if key == gw.Spec.Vpc {
×
191
                        c.updateVpcSubnetQueue.Add(gw.Name)
×
192
                }
×
193
        }
194
        return nil
×
195
}
196

197
type VpcLoadBalancer struct {
198
        TCPLoadBalancer      string
199
        TCPSessLoadBalancer  string
200
        UDPLoadBalancer      string
201
        UDPSessLoadBalancer  string
202
        SctpLoadBalancer     string
203
        SctpSessLoadBalancer string
204
}
205

206
func (c *Controller) GenVpcLoadBalancer(vpcKey string) *VpcLoadBalancer {
×
207
        if vpcKey == c.config.ClusterRouter || vpcKey == "" {
×
208
                return &VpcLoadBalancer{
×
209
                        TCPLoadBalancer:      c.config.ClusterTCPLoadBalancer,
×
210
                        TCPSessLoadBalancer:  c.config.ClusterTCPSessionLoadBalancer,
×
211
                        UDPLoadBalancer:      c.config.ClusterUDPLoadBalancer,
×
212
                        UDPSessLoadBalancer:  c.config.ClusterUDPSessionLoadBalancer,
×
213
                        SctpLoadBalancer:     c.config.ClusterSctpLoadBalancer,
×
214
                        SctpSessLoadBalancer: c.config.ClusterSctpSessionLoadBalancer,
×
215
                }
×
216
        }
×
217
        return &VpcLoadBalancer{
×
218
                TCPLoadBalancer:      fmt.Sprintf("vpc-%s-tcp-load", vpcKey),
×
219
                TCPSessLoadBalancer:  fmt.Sprintf("vpc-%s-tcp-sess-load", vpcKey),
×
220
                UDPLoadBalancer:      fmt.Sprintf("vpc-%s-udp-load", vpcKey),
×
221
                UDPSessLoadBalancer:  fmt.Sprintf("vpc-%s-udp-sess-load", vpcKey),
×
222
                SctpLoadBalancer:     fmt.Sprintf("vpc-%s-sctp-load", vpcKey),
×
223
                SctpSessLoadBalancer: fmt.Sprintf("vpc-%s-sctp-sess-load", vpcKey),
×
224
        }
×
225
}
226

227
func (c *Controller) addLoadBalancer(vpc string) (*VpcLoadBalancer, error) {
×
228
        vpcLbConfig := c.GenVpcLoadBalancer(vpc)
×
229
        if err := c.initLB(vpcLbConfig.TCPLoadBalancer, string(v1.ProtocolTCP), false); err != nil {
×
230
                return nil, err
×
231
        }
×
232
        if err := c.initLB(vpcLbConfig.TCPSessLoadBalancer, string(v1.ProtocolTCP), true); err != nil {
×
233
                return nil, err
×
234
        }
×
235
        if err := c.initLB(vpcLbConfig.UDPLoadBalancer, string(v1.ProtocolUDP), false); err != nil {
×
236
                return nil, err
×
237
        }
×
238
        if err := c.initLB(vpcLbConfig.UDPSessLoadBalancer, string(v1.ProtocolUDP), true); err != nil {
×
239
                return nil, err
×
240
        }
×
241
        if err := c.initLB(vpcLbConfig.SctpLoadBalancer, string(v1.ProtocolSCTP), false); err != nil {
×
242
                return nil, err
×
243
        }
×
244
        if err := c.initLB(vpcLbConfig.SctpSessLoadBalancer, string(v1.ProtocolSCTP), true); err != nil {
×
245
                return nil, err
×
246
        }
×
247

248
        return vpcLbConfig, nil
×
249
}
250

251
func (c *Controller) handleAddOrUpdateVpc(key string) error {
×
252
        c.vpcKeyMutex.LockKey(key)
×
253
        defer func() { _ = c.vpcKeyMutex.UnlockKey(key) }()
×
254
        klog.Infof("handle add/update vpc %s", key)
×
255

×
256
        cachedVpc, err := c.vpcsLister.Get(key)
×
257
        if err != nil {
×
258
                if k8serrors.IsNotFound(err) {
×
259
                        return nil
×
260
                }
×
261
                klog.Error(err)
×
262
                return err
×
263
        }
264

265
        vpc, err := c.formatVpc(cachedVpc.DeepCopy())
×
266
        if err != nil {
×
267
                klog.Errorf("failed to format vpc %s: %v", key, err)
×
268
                return err
×
269
        }
×
270

271
        if err = c.createVpcRouter(key); err != nil {
×
272
                klog.Errorf("failed to create vpc router for vpc %s: %v", key, err)
×
273
                return err
×
274
        }
×
275

276
        var newPeers []string
×
277
        for _, peering := range vpc.Spec.VpcPeerings {
×
278
                if err = util.CheckCidrs(peering.LocalConnectIP); err != nil {
×
279
                        klog.Errorf("invalid cidr %s", peering.LocalConnectIP)
×
280
                        return err
×
281
                }
×
282

283
                newPeers = append(newPeers, peering.RemoteVpc)
×
284
                if err := c.OVNNbClient.CreatePeerRouterPort(vpc.Name, peering.RemoteVpc, peering.LocalConnectIP); err != nil {
×
285
                        klog.Errorf("create peer router port for vpc %s, %v", vpc.Name, err)
×
286
                        return err
×
287
                }
×
288
        }
289
        for _, oldPeer := range vpc.Status.VpcPeerings {
×
290
                if !slices.Contains(newPeers, oldPeer) {
×
291
                        if err = c.OVNNbClient.DeleteLogicalRouterPort(fmt.Sprintf("%s-%s", vpc.Name, oldPeer)); err != nil {
×
292
                                klog.Errorf("delete peer router port for vpc %s, %v", vpc.Name, err)
×
293
                                return err
×
294
                        }
×
295
                }
296
        }
297

298
        // handle static route
299
        var (
×
300
                staticExistedRoutes []*ovnnb.LogicalRouterStaticRoute
×
301
                staticTargetRoutes  []*kubeovnv1.StaticRoute
×
302
                staticRouteMapping  map[string][]*kubeovnv1.StaticRoute
×
303
        )
×
304

×
305
        staticExistedRoutes, err = c.OVNNbClient.ListLogicalRouterStaticRoutes(vpc.Name, nil, nil, "", nil)
×
306
        if err != nil {
×
307
                klog.Errorf("failed to get vpc %s static route list, %v", vpc.Name, err)
×
308
                return err
×
309
        }
×
310

311
        var externalSubnet *kubeovnv1.Subnet
×
312
        externalSubnetExist := false
×
313
        if c.config.EnableEipSnat {
×
314
                externalSubnet, err = c.subnetsLister.Get(c.config.ExternalGatewaySwitch)
×
315
                if err != nil {
×
316
                        klog.Warningf("enable-eip-snat need external subnet %s to be exist: %v", c.config.ExternalGatewaySwitch, err)
×
317
                } else {
×
318
                        externalSubnetExist = true
×
319
                }
×
320
        }
321

322
        staticRouteMapping = c.getRouteTablesByVpc(vpc)
×
323
        staticTargetRoutes = vpc.Spec.StaticRoutes
×
324
        if vpc.Name == c.config.ClusterRouter {
×
325
                if _, ok := staticRouteMapping[util.MainRouteTable]; !ok {
×
326
                        staticRouteMapping[util.MainRouteTable] = nil
×
327
                }
×
328

329
                joinSubnet, err := c.subnetsLister.Get(c.config.NodeSwitch)
×
330
                if err != nil {
×
331
                        if !k8serrors.IsNotFound(err) {
×
332
                                klog.Errorf("failed to get node switch subnet %s: %v", c.config.NodeSwitch, err)
×
333
                                return err
×
334
                        }
×
335
                        c.addOrUpdateVpcQueue.Add(vpc.Name)
×
336
                        return nil
×
337
                }
338
                gatewayV4, gatewayV6 := util.SplitStringIP(joinSubnet.Spec.Gateway)
×
339
                if gatewayV4 != "" {
×
340
                        for table := range staticRouteMapping {
×
341
                                staticTargetRoutes = append(
×
342
                                        staticTargetRoutes,
×
343
                                        &kubeovnv1.StaticRoute{
×
344
                                                Policy:     kubeovnv1.PolicyDst,
×
345
                                                CIDR:       "0.0.0.0/0",
×
346
                                                NextHopIP:  gatewayV4,
×
347
                                                RouteTable: table,
×
348
                                        },
×
349
                                )
×
350
                        }
×
351
                }
352
                if gatewayV6 != "" {
×
353
                        for table := range staticRouteMapping {
×
354
                                staticTargetRoutes = append(
×
355
                                        staticTargetRoutes,
×
356
                                        &kubeovnv1.StaticRoute{
×
357
                                                Policy:     kubeovnv1.PolicyDst,
×
358
                                                CIDR:       "::/0",
×
359
                                                NextHopIP:  gatewayV6,
×
360
                                                RouteTable: table,
×
361
                                        },
×
362
                                )
×
363
                        }
×
364
                }
365
                if c.config.EnableEipSnat {
×
366
                        cm, err := c.configMapsLister.ConfigMaps(c.config.ExternalGatewayConfigNS).Get(util.ExternalGatewayConfig)
×
367
                        if err == nil {
×
368
                                nextHop := cm.Data["external-gw-addr"]
×
369
                                if nextHop == "" {
×
370
                                        if !externalSubnetExist {
×
371
                                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
372
                                                klog.Error(err)
×
373
                                                return err
×
374
                                        }
×
375
                                        nextHop = externalSubnet.Spec.Gateway
×
376
                                        if nextHop == "" {
×
377
                                                klog.Errorf("no available gateway address")
×
378
                                                return errors.New("no available gateway address")
×
379
                                        }
×
380
                                }
381
                                if strings.Contains(nextHop, "/") {
×
382
                                        nextHop = strings.Split(nextHop, "/")[0]
×
383
                                }
×
384

385
                                lr, err := c.OVNNbClient.GetLogicalRouter(vpc.Name, false)
×
386
                                if err != nil {
×
387
                                        klog.Errorf("failed to get logical router %s: %v", vpc.Name, err)
×
388
                                        return err
×
389
                                }
×
390

391
                                for _, nat := range lr.Nat {
×
392
                                        info, err := c.OVNNbClient.GetNATByUUID(nat)
×
393
                                        if err != nil {
×
394
                                                klog.Errorf("failed to get nat ip info for vpc %s, %v", vpc.Name, err)
×
395
                                                return err
×
396
                                        }
×
397
                                        if info.LogicalIP != "" {
×
398
                                                for table := range staticRouteMapping {
×
399
                                                        staticTargetRoutes = append(
×
400
                                                                staticTargetRoutes,
×
401
                                                                &kubeovnv1.StaticRoute{
×
402
                                                                        Policy:     kubeovnv1.PolicySrc,
×
403
                                                                        CIDR:       info.LogicalIP,
×
404
                                                                        NextHopIP:  nextHop,
×
405
                                                                        RouteTable: table,
×
406
                                                                },
×
407
                                                        )
×
408
                                                }
×
409
                                        }
410
                                }
411
                        }
412
                }
413
        }
414

415
        routeNeedDel, routeNeedAdd, err := diffStaticRoute(staticExistedRoutes, staticTargetRoutes)
×
416
        if err != nil {
×
417
                klog.Errorf("failed to diff vpc %s static route, %v", vpc.Name, err)
×
418
                return err
×
419
        }
×
420

421
        for _, item := range routeNeedDel {
×
422
                klog.Infof("vpc %s del static route: %+v", vpc.Name, item)
×
423
                policy := convertPolicy(item.Policy)
×
424
                if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(vpc.Name, &item.RouteTable, &policy, item.CIDR, item.NextHopIP); err != nil {
×
425
                        klog.Errorf("del vpc %s static route failed, %v", vpc.Name, err)
×
426
                        return err
×
427
                }
×
428
        }
429

430
        for _, item := range routeNeedAdd {
×
431
                if item.BfdID != "" {
×
432
                        klog.Infof("vpc %s add static ecmp route: %+v", vpc.Name, item)
×
433
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
434
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, &item.BfdID, nil, item.NextHopIP,
×
435
                        ); err != nil {
×
436
                                klog.Errorf("failed to add bfd static route to vpc %s , %v", vpc.Name, err)
×
437
                                return err
×
438
                        }
×
439
                } else {
×
440
                        klog.Infof("vpc %s add static route: %+v", vpc.Name, item)
×
441
                        if err = c.OVNNbClient.AddLogicalRouterStaticRoute(
×
442
                                vpc.Name, item.RouteTable, convertPolicy(item.Policy), item.CIDR, nil, nil, item.NextHopIP,
×
443
                        ); err != nil {
×
444
                                klog.Errorf("failed to add normal static route to vpc %s , %v", vpc.Name, err)
×
445
                                return err
×
446
                        }
×
447
                }
448
        }
449

450
        // handle policy route
451
        var (
×
452
                policyRouteExisted, policyRouteNeedDel, policyRouteNeedAdd []*kubeovnv1.PolicyRoute
×
453
                policyRouteLogical                                         []*ovnnb.LogicalRouterPolicy
×
454
                externalIDs                                                = map[string]string{"vendor": util.CniTypeName}
×
455
        )
×
456

×
457
        if vpc.Name == c.config.ClusterRouter {
×
458
                policyRouteExisted = reversePolicies(vpc.Annotations[util.VpcLastPolicies])
×
459
                // diff list
×
460
                policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithExisted(policyRouteExisted, vpc.Spec.PolicyRoutes)
×
461
        } else {
×
462
                if vpc.Spec.PolicyRoutes == nil {
×
463
                        // do not clean default vpc policy routes
×
464
                        if err = c.OVNNbClient.ClearLogicalRouterPolicy(vpc.Name); err != nil {
×
465
                                klog.Errorf("clean all vpc %s policy route failed, %v", vpc.Name, err)
×
466
                                return err
×
467
                        }
×
468
                } else {
×
469
                        policyRouteLogical, err = c.OVNNbClient.ListLogicalRouterPolicies(vpc.Name, -1, nil, true)
×
470
                        if err != nil {
×
471
                                klog.Errorf("failed to get vpc %s policy route list, %v", vpc.Name, err)
×
472
                                return err
×
473
                        }
×
474
                        // diff vpc policy route
475
                        policyRouteNeedDel, policyRouteNeedAdd = diffPolicyRouteWithLogical(policyRouteLogical, vpc.Spec.PolicyRoutes)
×
476
                }
477
        }
478
        // delete policies non-exist
479
        for _, item := range policyRouteNeedDel {
×
480
                klog.Infof("delete policy route for router: %s, priority: %d, match %s", vpc.Name, item.Priority, item.Match)
×
481
                if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpc.Name, item.Priority, item.Match); err != nil {
×
482
                        klog.Errorf("del vpc %s policy route failed, %v", vpc.Name, err)
×
483
                        return err
×
484
                }
×
485
        }
486
        // add new policies
487
        for _, item := range policyRouteNeedAdd {
×
488
                klog.Infof("add policy route for router: %s, match %s, action %s, nexthop %s, externalID %v", c.config.ClusterRouter, item.Match, string(item.Action), item.NextHopIP, externalIDs)
×
489
                if err = c.OVNNbClient.AddLogicalRouterPolicy(vpc.Name, item.Priority, item.Match, string(item.Action), []string{item.NextHopIP}, nil, externalIDs); err != nil {
×
490
                        klog.Errorf("add policy route to vpc %s failed, %v", vpc.Name, err)
×
491
                        return err
×
492
                }
×
493
        }
494

NEW
495
        vpcSubnets, defaultSubnet, err := c.getVpcSubnets(vpc)
×
NEW
496
        if err != nil {
×
NEW
497
                klog.Error(err)
×
NEW
498
                return err
×
NEW
499
        }
×
500

NEW
501
        vpc.Status.Subnets = vpcSubnets
×
NEW
502
        vpc.Status.DefaultLogicalSwitch = defaultSubnet
×
503
        vpc.Status.Router = key
×
504
        vpc.Status.Standby = true
×
505
        vpc.Status.VpcPeerings = newPeers
×
506
        if c.config.EnableLb {
×
507
                vpcLb, err := c.addLoadBalancer(key)
×
508
                if err != nil {
×
509
                        klog.Error(err)
×
510
                        return err
×
511
                }
×
512
                vpc.Status.TCPLoadBalancer = vpcLb.TCPLoadBalancer
×
513
                vpc.Status.TCPSessionLoadBalancer = vpcLb.TCPSessLoadBalancer
×
514
                vpc.Status.UDPLoadBalancer = vpcLb.UDPLoadBalancer
×
515
                vpc.Status.UDPSessionLoadBalancer = vpcLb.UDPSessLoadBalancer
×
516
                vpc.Status.SctpLoadBalancer = vpcLb.SctpLoadBalancer
×
517
                vpc.Status.SctpSessionLoadBalancer = vpcLb.SctpSessLoadBalancer
×
518
        }
519
        bytes, err := vpc.Status.Bytes()
×
520
        if err != nil {
×
521
                klog.Error(err)
×
522
                return err
×
523
        }
×
524
        vpc, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(), vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status")
×
525
        if err != nil {
×
526
                klog.Error(err)
×
527
                return err
×
528
        }
×
529

530
        if len(vpc.Annotations) != 0 && strings.ToLower(vpc.Annotations[util.VpcLbAnnotation]) == "on" {
×
531
                if err = c.createVpcLb(vpc); err != nil {
×
532
                        klog.Error(err)
×
533
                        return err
×
534
                }
×
535
        } else if err = c.deleteVpcLb(vpc); err != nil {
×
536
                klog.Error(err)
×
537
                return err
×
538
        }
×
539

540
        subnets, err := c.subnetsLister.List(labels.Everything())
×
541
        if err != nil {
×
542
                klog.Error(err)
×
543
                return err
×
544
        }
×
545
        custVpcEnableExternalMultiHopEcmp := false
×
546
        for _, subnet := range subnets {
×
547
                if subnet.Spec.Vpc == key {
×
548
                        c.addOrUpdateSubnetQueue.Add(subnet.Name)
×
549
                        if vpc.Name != util.DefaultVpc && vpc.Spec.EnableBfd && subnet.Spec.EnableEcmp {
×
550
                                custVpcEnableExternalMultiHopEcmp = true
×
551
                        }
×
552
                }
553
        }
554

555
        if vpc.Name != util.DefaultVpc {
×
556
                if cachedVpc.Spec.EnableExternal {
×
557
                        if !externalSubnetExist {
×
558
                                err = fmt.Errorf("failed to get external subnet %s", c.config.ExternalGatewaySwitch)
×
559
                                klog.Error(err)
×
560
                                return err
×
561
                        }
×
562
                        if externalSubnet.Spec.LogicalGateway {
×
563
                                klog.Infof("no need to handle external connection for logical gw external subnet %s", c.config.ExternalGatewaySwitch)
×
564
                                return nil
×
565
                        }
×
566
                        if !cachedVpc.Status.EnableExternal {
×
567
                                // connect vpc to default external
×
568
                                klog.Infof("connect external network with vpc %s", vpc.Name)
×
569
                                if err := c.handleAddVpcExternalSubnet(key, c.config.ExternalGatewaySwitch); err != nil {
×
570
                                        klog.Errorf("failed to add default external connection for vpc %s, error %v", key, err)
×
571
                                        return err
×
572
                                }
×
573
                        }
574
                        if vpc.Spec.EnableBfd {
×
575
                                // create bfd between lrp and physical switch gw
×
576
                                // bfd status down means current lrp binding chassis node external nic lost external network connectivity
×
577
                                // should switch lrp to another node
×
578
                                lrpEipName := fmt.Sprintf("%s-%s", key, c.config.ExternalGatewaySwitch)
×
579
                                v4ExtGw, _ := util.SplitStringIP(externalSubnet.Spec.Gateway)
×
580
                                // TODO: dualstack
×
581
                                if _, err := c.OVNNbClient.CreateBFD(lrpEipName, v4ExtGw, c.config.BfdMinRx, c.config.BfdMinTx, c.config.BfdDetectMult, nil); err != nil {
×
582
                                        klog.Error(err)
×
583
                                        return err
×
584
                                }
×
585
                                // TODO: support multi external nic
586
                                if custVpcEnableExternalMultiHopEcmp {
×
587
                                        klog.Infof("remove normal static ecmp route for vpc %s", vpc.Name)
×
588
                                        // auto remove normal type static route, if using ecmp based bfd
×
589
                                        if err := c.reconcileCustomVpcDelNormalStaticRoute(vpc.Name); err != nil {
×
590
                                                klog.Errorf("failed to reconcile del vpc %q normal static route", vpc.Name)
×
591
                                                return err
×
592
                                        }
×
593
                                }
594
                        }
595
                        if cachedVpc.Spec.ExtraExternalSubnets != nil {
×
596
                                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
597
                        }
×
598
                        // add external subnets only in spec and delete external subnets only in status
599
                        if !slices.Equal(vpc.Spec.ExtraExternalSubnets, vpc.Status.ExtraExternalSubnets) {
×
600
                                for _, subnetStatus := range cachedVpc.Status.ExtraExternalSubnets {
×
601
                                        if !slices.Contains(cachedVpc.Spec.ExtraExternalSubnets, subnetStatus) {
×
602
                                                klog.Infof("delete external subnet %s connection for vpc %s", subnetStatus, vpc.Name)
×
603
                                                if err := c.handleDelVpcExternalSubnet(vpc.Name, subnetStatus); err != nil {
×
604
                                                        klog.Errorf("failed to delete external subnet %s connection for vpc %s, error %v", subnetStatus, vpc.Name, err)
×
605
                                                        return err
×
606
                                                }
×
607
                                        }
608
                                }
609
                                for _, subnetSpec := range cachedVpc.Spec.ExtraExternalSubnets {
×
610
                                        if !slices.Contains(cachedVpc.Status.ExtraExternalSubnets, subnetSpec) {
×
611
                                                klog.Infof("connect external subnet %s with vpc %s", subnetSpec, vpc.Name)
×
612
                                                if err := c.handleAddVpcExternalSubnet(key, subnetSpec); err != nil {
×
613
                                                        klog.Errorf("failed to add external subnet %s connection for vpc %s, error %v", subnetSpec, key, err)
×
614
                                                        return err
×
615
                                                }
×
616
                                        }
617
                                }
618
                                if err := c.updateVpcAddExternalStatus(key, true); err != nil {
×
619
                                        klog.Errorf("failed to update additional external subnets status, %v", err)
×
620
                                        return err
×
621
                                }
×
622
                        }
623
                }
624

625
                if !cachedVpc.Spec.EnableBfd && cachedVpc.Status.EnableBfd {
×
626
                        lrpEipName := fmt.Sprintf("%s-%s", key, c.config.ExternalGatewaySwitch)
×
627
                        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpEipName, ""); err != nil {
×
628
                                klog.Error(err)
×
629
                                return err
×
630
                        }
×
631
                        if err := c.handleDeleteVpcStaticRoute(key); err != nil {
×
632
                                klog.Errorf("failed to delete bfd route for vpc %s, error %v", key, err)
×
633
                                return err
×
634
                        }
×
635
                }
636

637
                if !cachedVpc.Spec.EnableExternal && cachedVpc.Status.EnableExternal {
×
638
                        // disconnect vpc to default external
×
639
                        if err := c.handleDelVpcExternalSubnet(key, c.config.ExternalGatewaySwitch); err != nil {
×
640
                                klog.Errorf("failed to delete external connection for vpc %s, error %v", key, err)
×
641
                                return err
×
642
                        }
×
643
                }
644

645
                if cachedVpc.Status.ExtraExternalSubnets != nil && !cachedVpc.Spec.EnableExternal {
×
646
                        // disconnect vpc to extra external subnets
×
647
                        for _, subnet := range cachedVpc.Status.ExtraExternalSubnets {
×
648
                                klog.Infof("disconnect external network %s to vpc %s", subnet, vpc.Name)
×
649
                                if err := c.handleDelVpcExternalSubnet(key, subnet); err != nil {
×
650
                                        klog.Error(err)
×
651
                                        return err
×
652
                                }
×
653
                        }
654
                        if err := c.updateVpcAddExternalStatus(key, false); err != nil {
×
655
                                klog.Errorf("failed to update additional external subnets status, %v", err)
×
656
                                return err
×
657
                        }
×
658
                }
659
        }
660

661
        bfdPortName, bfdPortNodes, err := c.reconcileVpcBfdLRP(vpc)
×
662
        if err != nil {
×
663
                klog.Error(err)
×
664
                return err
×
665
        }
×
666
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
667
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{}
×
668
        } else {
×
669
                vpc.Status.BFDPort = kubeovnv1.BFDPortStatus{
×
670
                        Name:  bfdPortName,
×
671
                        IP:    vpc.Spec.BFDPort.IP,
×
672
                        Nodes: bfdPortNodes,
×
673
                }
×
674
        }
×
675
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().
×
676
                UpdateStatus(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
677
                klog.Error(err)
×
678
                return err
×
679
        }
×
680

681
        return nil
×
682
}
683

684
func (c *Controller) reconcileVpcBfdLRP(vpc *kubeovnv1.Vpc) (string, []string, error) {
×
685
        portName := "bfd@" + vpc.Name
×
686
        if vpc.Spec.BFDPort == nil || !vpc.Spec.BFDPort.Enabled {
×
687
                if err := c.OVNNbClient.DeleteLogicalRouterPort(portName); err != nil {
×
688
                        err = fmt.Errorf("failed to delete BFD LRP %s: %w", portName, err)
×
689
                        klog.Error(err)
×
690
                        return portName, nil, err
×
691
                }
×
692
                if err := c.OVNNbClient.DeleteHAChassisGroup(portName); err != nil {
×
693
                        err = fmt.Errorf("failed to delete HA chassis group %s: %w", portName, err)
×
694
                        klog.Error(err)
×
695
                        return portName, nil, err
×
696
                }
×
697
                return portName, nil, nil
×
698
        }
699

700
        var err error
×
701
        chassisCount := 3
×
702
        selector := labels.Everything()
×
703
        if vpc.Spec.BFDPort.NodeSelector != nil {
×
704
                chassisCount = math.MaxInt
×
705
                if selector, err = metav1.LabelSelectorAsSelector(vpc.Spec.BFDPort.NodeSelector); err != nil {
×
706
                        err = fmt.Errorf("failed to parse node selector %q: %w", vpc.Spec.BFDPort.NodeSelector.String(), err)
×
707
                        klog.Error(err)
×
708
                        return portName, nil, err
×
709
                }
×
710
        }
711

712
        nodes, err := c.nodesLister.List(selector)
×
713
        if err != nil {
×
714
                err = fmt.Errorf("failed to list nodes with selector %q: %w", vpc.Spec.BFDPort.NodeSelector, err)
×
715
                klog.Error(err)
×
716
                return portName, nil, err
×
717
        }
×
718
        if len(nodes) == 0 {
×
719
                err = fmt.Errorf("no nodes found by selector %q", selector.String())
×
720
                klog.Error(err)
×
721
                return portName, nil, err
×
722
        }
×
723

724
        nodeNames := make([]string, 0, len(nodes))
×
725
        chassisCount = min(chassisCount, len(nodes))
×
726
        chassisNames := make([]string, 0, chassisCount)
×
727
        for _, nodes := range nodes[:chassisCount] {
×
728
                chassis, err := c.OVNSbClient.GetChassisByHost(nodes.Name)
×
729
                if err != nil {
×
730
                        err = fmt.Errorf("failed to get chassis of node %s: %w", nodes.Name, err)
×
731
                        klog.Error(err)
×
732
                        return portName, nil, err
×
733
                }
×
734
                chassisNames = append(chassisNames, chassis.Name)
×
735
                nodeNames = append(nodeNames, nodes.Name)
×
736
        }
737

738
        networks := strings.Split(vpc.Spec.BFDPort.IP, ",")
×
739
        if err = c.OVNNbClient.CreateLogicalRouterPort(vpc.Name, portName, "", networks); err != nil {
×
740
                klog.Error(err)
×
741
                return portName, nil, err
×
742
        }
×
743
        if err = c.OVNNbClient.UpdateLogicalRouterPortNetworks(portName, networks); err != nil {
×
744
                klog.Error(err)
×
745
                return portName, nil, err
×
746
        }
×
747
        if err = c.OVNNbClient.UpdateLogicalRouterPortOptions(portName, map[string]string{"bfd-only": "true"}); err != nil {
×
748
                klog.Error(err)
×
749
                return portName, nil, err
×
750
        }
×
751
        if err = c.OVNNbClient.CreateHAChassisGroup(portName, chassisNames, map[string]string{"lrp": portName}); err != nil {
×
752
                klog.Error(err)
×
753
                return portName, nil, err
×
754
        }
×
755
        if err = c.OVNNbClient.SetLogicalRouterPortHAChassisGroup(portName, portName); err != nil {
×
756
                klog.Error(err)
×
757
                return portName, nil, err
×
758
        }
×
759

760
        return portName, nodeNames, nil
×
761
}
762

763
func (c *Controller) addPolicyRouteToVpc(vpcName string, policy *kubeovnv1.PolicyRoute, externalIDs map[string]string) error {
×
764
        var (
×
765
                nextHops []string
×
766
                err      error
×
767
        )
×
768

×
769
        if policy.NextHopIP != "" {
×
770
                nextHops = strings.Split(policy.NextHopIP, ",")
×
771
        }
×
772

773
        if err = c.OVNNbClient.AddLogicalRouterPolicy(vpcName, policy.Priority, policy.Match, string(policy.Action), nextHops, nil, externalIDs); err != nil {
×
774
                klog.Errorf("add policy route to vpc %s failed, %v", vpcName, err)
×
775
                return err
×
776
        }
×
777
        return nil
×
778
}
779

780
func buildExternalIDsMapKey(match, action string, priority int) string {
×
781
        return fmt.Sprintf("%s-%s-%d", match, action, priority)
×
782
}
×
783

784
func (c *Controller) batchAddPolicyRouteToVpc(name string, policies []*kubeovnv1.PolicyRoute, externalIDs map[string]map[string]string) error {
×
785
        if len(policies) == 0 {
×
786
                return nil
×
787
        }
×
788
        start := time.Now()
×
789
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
790
        for _, policy := range policies {
×
791
                var nextHops []string
×
792
                if policy.NextHopIP != "" {
×
793
                        nextHops = strings.Split(policy.NextHopIP, ",")
×
794
                }
×
795
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
796
                        Priority:    policy.Priority,
×
797
                        Nexthops:    nextHops,
×
798
                        Action:      string(policy.Action),
×
799
                        Match:       policy.Match,
×
800
                        ExternalIDs: externalIDs[buildExternalIDsMapKey(policy.Match, string(policy.Action), policy.Priority)],
×
801
                })
×
802
        }
803

804
        if err := c.OVNNbClient.BatchAddLogicalRouterPolicy(name, routerPolicies...); err != nil {
×
805
                klog.Errorf("batch add policy route to vpc %s failed, %v", name, err)
×
806
                return err
×
807
        }
×
808
        klog.Infof("take to %v batch add policy route to vpc %s policies %d", time.Since(start), name, len(policies))
×
809
        return nil
×
810
}
811

812
func (c *Controller) deletePolicyRouteFromVpc(vpcName string, priority int, match string) error {
×
813
        var (
×
814
                vpc, cachedVpc *kubeovnv1.Vpc
×
815
                err            error
×
816
        )
×
817

×
818
        if err = c.OVNNbClient.DeleteLogicalRouterPolicy(vpcName, priority, match); err != nil {
×
819
                klog.Error(err)
×
820
                return err
×
821
        }
×
822

823
        cachedVpc, err = c.vpcsLister.Get(vpcName)
×
824
        if err != nil {
×
825
                if k8serrors.IsNotFound(err) {
×
826
                        return nil
×
827
                }
×
828
                klog.Error(err)
×
829
                return err
×
830
        }
831
        vpc = cachedVpc.DeepCopy()
×
832
        // make sure custom policies not be deleted
×
833
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
834
        if err != nil {
×
835
                klog.Error(err)
×
836
                return err
×
837
        }
×
838
        return nil
×
839
}
840

841
func (c *Controller) batchDeletePolicyRouteFromVpc(name string, policies []*kubeovnv1.PolicyRoute) error {
×
842
        var (
×
843
                vpc, cachedVpc *kubeovnv1.Vpc
×
844
                err            error
×
845
        )
×
846

×
847
        start := time.Now()
×
848
        routerPolicies := make([]*ovnnb.LogicalRouterPolicy, 0, len(policies))
×
849
        for _, policy := range policies {
×
850
                routerPolicies = append(routerPolicies, &ovnnb.LogicalRouterPolicy{
×
851
                        Priority: policy.Priority,
×
852
                        Match:    policy.Match,
×
853
                })
×
854
        }
×
855

856
        if err = c.OVNNbClient.BatchDeleteLogicalRouterPolicy(name, routerPolicies); err != nil {
×
857
                return err
×
858
        }
×
859
        klog.V(3).Infof("take to %v batch delete policy route from vpc %s policies %d", time.Since(start), name, len(policies))
×
860

×
861
        cachedVpc, err = c.vpcsLister.Get(name)
×
862
        if err != nil {
×
863
                if k8serrors.IsNotFound(err) {
×
864
                        return nil
×
865
                }
×
866
                klog.Error(err)
×
867
                return err
×
868
        }
869
        vpc = cachedVpc.DeepCopy()
×
870
        // make sure custom policies not be deleted
×
871
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
872
        if err != nil {
×
873
                klog.Error(err)
×
874
                return err
×
875
        }
×
876
        return nil
×
877
}
878

879
func (c *Controller) addStaticRouteToVpc(name string, route *kubeovnv1.StaticRoute) error {
×
880
        if route.BfdID != "" {
×
881
                klog.Infof("vpc %s add static ecmp route: %+v", name, route)
×
882
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
883
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, &route.BfdID, nil, route.NextHopIP,
×
884
                ); err != nil {
×
885
                        klog.Errorf("failed to add bfd static route to vpc %s , %v", name, err)
×
886
                        return err
×
887
                }
×
888
        } else {
×
889
                klog.Infof("vpc %s add static route: %+v", name, route)
×
890
                if err := c.OVNNbClient.AddLogicalRouterStaticRoute(
×
891
                        name, route.RouteTable, convertPolicy(route.Policy), route.CIDR, nil, nil, route.NextHopIP,
×
892
                ); err != nil {
×
893
                        klog.Errorf("failed to add normal static route to vpc %s , %v", name, err)
×
894
                        return err
×
895
                }
×
896
        }
897
        return nil
×
898
}
899

900
func (c *Controller) deleteStaticRouteFromVpc(name, table, cidr, nextHop string, policy kubeovnv1.RoutePolicy) error {
×
901
        var (
×
902
                policyStr string
×
903
                err       error
×
904
        )
×
905

×
906
        policyStr = convertPolicy(policy)
×
907
        if err = c.OVNNbClient.DeleteLogicalRouterStaticRoute(name, &table, &policyStr, cidr, nextHop); err != nil {
×
908
                klog.Errorf("del vpc %s static route failed, %v", name, err)
×
909
                return err
×
910
        }
×
911

912
        return nil
×
913
}
914

915
func (c *Controller) batchDeleteStaticRouteFromVpc(name string, staticRoutes []*kubeovnv1.StaticRoute) error {
×
916
        var (
×
917
                vpc, cachedVpc *kubeovnv1.Vpc
×
918
                err            error
×
919
        )
×
920
        start := time.Now()
×
921
        routeCount := len(staticRoutes)
×
922
        delRoutes := make([]*ovnnb.LogicalRouterStaticRoute, 0, routeCount)
×
923
        for _, sr := range staticRoutes {
×
924
                policyStr := convertPolicy(sr.Policy)
×
925
                newRoute := &ovnnb.LogicalRouterStaticRoute{
×
926
                        RouteTable: sr.RouteTable,
×
927
                        Nexthop:    sr.NextHopIP,
×
928
                        Policy:     &policyStr,
×
929
                        IPPrefix:   sr.CIDR,
×
930
                }
×
931
                delRoutes = append(delRoutes, newRoute)
×
932
        }
×
933
        if err = c.OVNNbClient.BatchDeleteLogicalRouterStaticRoute(name, delRoutes); err != nil {
×
934
                klog.Errorf("batch del vpc %s static route %d failed, %v", name, routeCount, err)
×
935
                return err
×
936
        }
×
937
        klog.V(3).Infof("take to %v batch delete static route from vpc %s static routes %d", time.Since(start), name, len(delRoutes))
×
938

×
939
        cachedVpc, err = c.vpcsLister.Get(name)
×
940
        if err != nil {
×
941
                if k8serrors.IsNotFound(err) {
×
942
                        return nil
×
943
                }
×
944
                klog.Error(err)
×
945
                return err
×
946
        }
947
        vpc = cachedVpc.DeepCopy()
×
948
        // make sure custom policies not be deleted
×
949
        _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
950
        if err != nil {
×
951
                klog.Error(err)
×
952
                return err
×
953
        }
×
954
        return nil
×
955
}
956

957
func diffPolicyRouteWithExisted(exists, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
958
        var (
×
959
                dels, adds []*kubeovnv1.PolicyRoute
×
960
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
961
                key        string
×
962
                ok         bool
×
963
        )
×
964

×
965
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
966
        for _, item := range exists {
×
967
                existsMap[getPolicyRouteItemKey(item)] = item
×
968
        }
×
969
        // load policies to add
970
        for _, item := range target {
×
971
                key = getPolicyRouteItemKey(item)
×
972

×
973
                if _, ok = existsMap[key]; ok {
×
974
                        delete(existsMap, key)
×
975
                } else {
×
976
                        adds = append(adds, item)
×
977
                }
×
978
        }
979
        // load policies to delete
980
        for _, item := range existsMap {
×
981
                dels = append(dels, item)
×
982
        }
×
983
        return dels, adds
×
984
}
985

986
func diffPolicyRouteWithLogical(exists []*ovnnb.LogicalRouterPolicy, target []*kubeovnv1.PolicyRoute) ([]*kubeovnv1.PolicyRoute, []*kubeovnv1.PolicyRoute) {
×
987
        var (
×
988
                dels, adds []*kubeovnv1.PolicyRoute
×
989
                existsMap  map[string]*kubeovnv1.PolicyRoute
×
990
                key        string
×
991
                ok         bool
×
992
        )
×
993
        existsMap = make(map[string]*kubeovnv1.PolicyRoute, len(exists))
×
994

×
995
        for _, item := range exists {
×
996
                policy := &kubeovnv1.PolicyRoute{
×
997
                        Priority: item.Priority,
×
998
                        Match:    item.Match,
×
999
                        Action:   kubeovnv1.PolicyRouteAction(item.Action),
×
1000
                }
×
1001
                existsMap[getPolicyRouteItemKey(policy)] = policy
×
1002
        }
×
1003

1004
        for _, item := range target {
×
1005
                key = getPolicyRouteItemKey(item)
×
1006

×
1007
                if _, ok = existsMap[key]; ok {
×
1008
                        delete(existsMap, key)
×
1009
                } else {
×
1010
                        adds = append(adds, item)
×
1011
                }
×
1012
        }
1013

1014
        for _, item := range existsMap {
×
1015
                dels = append(dels, item)
×
1016
        }
×
1017
        return dels, adds
×
1018
}
1019

1020
func getPolicyRouteItemKey(item *kubeovnv1.PolicyRoute) (key string) {
×
1021
        return fmt.Sprintf("%d:%s:%s:%s", item.Priority, item.Match, item.Action, item.NextHopIP)
×
1022
}
×
1023

1024
func diffStaticRoute(exist []*ovnnb.LogicalRouterStaticRoute, target []*kubeovnv1.StaticRoute) (routeNeedDel, routeNeedAdd []*kubeovnv1.StaticRoute, err error) {
×
1025
        existRouteMap := make(map[string]*kubeovnv1.StaticRoute, len(exist))
×
1026
        for _, item := range exist {
×
1027
                policy := kubeovnv1.PolicyDst
×
1028
                if item.Policy != nil && *item.Policy == ovnnb.LogicalRouterStaticRoutePolicySrcIP {
×
1029
                        policy = kubeovnv1.PolicySrc
×
1030
                }
×
1031
                route := &kubeovnv1.StaticRoute{
×
1032
                        Policy:     policy,
×
1033
                        CIDR:       item.IPPrefix,
×
1034
                        NextHopIP:  item.Nexthop,
×
1035
                        RouteTable: item.RouteTable,
×
1036
                        ECMPMode:   util.StaticRouteBfdEcmp,
×
1037
                }
×
1038
                if item.BFD != nil {
×
1039
                        route.BfdID = *item.BFD
×
1040
                }
×
1041
                existRouteMap[getStaticRouteItemKey(route)] = route
×
1042
        }
1043

1044
        for _, item := range target {
×
1045
                key := getStaticRouteItemKey(item)
×
1046
                if _, ok := existRouteMap[key]; ok {
×
1047
                        delete(existRouteMap, key)
×
1048
                } else {
×
1049
                        routeNeedAdd = append(routeNeedAdd, item)
×
1050
                }
×
1051
        }
1052
        for _, item := range existRouteMap {
×
1053
                routeNeedDel = append(routeNeedDel, item)
×
1054
        }
×
1055
        return
×
1056
}
1057

1058
func getStaticRouteItemKey(item *kubeovnv1.StaticRoute) string {
×
1059
        var key string
×
1060
        if item.Policy == kubeovnv1.PolicyDst {
×
1061
                key = fmt.Sprintf("%s:dst:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1062
        } else {
×
1063
                key = fmt.Sprintf("%s:src:%s=>%s", item.RouteTable, item.CIDR, item.NextHopIP)
×
1064
        }
×
1065
        return key
×
1066
}
1067

1068
func (c *Controller) formatVpc(vpc *kubeovnv1.Vpc) (*kubeovnv1.Vpc, error) {
×
1069
        var changed bool
×
1070
        for _, item := range vpc.Spec.StaticRoutes {
×
1071
                // check policy
×
1072
                if item.Policy == "" {
×
1073
                        item.Policy = kubeovnv1.PolicyDst
×
1074
                        changed = true
×
1075
                }
×
1076
                if item.Policy != kubeovnv1.PolicyDst && item.Policy != kubeovnv1.PolicySrc {
×
1077
                        return nil, fmt.Errorf("unknown policy type: %q", item.Policy)
×
1078
                }
×
1079
                // check cidr
1080
                if strings.Contains(item.CIDR, "/") {
×
1081
                        if _, _, err := net.ParseCIDR(item.CIDR); err != nil {
×
1082
                                return nil, fmt.Errorf("invalid cidr %q: %w", item.CIDR, err)
×
1083
                        }
×
1084
                } else if ip := net.ParseIP(item.CIDR); ip == nil {
×
1085
                        return nil, fmt.Errorf("invalid ip %q", item.CIDR)
×
1086
                }
×
1087
                // check next hop ip
1088
                if ip := net.ParseIP(item.NextHopIP); ip == nil {
×
1089
                        return nil, fmt.Errorf("invalid next hop ip %q", item.NextHopIP)
×
1090
                }
×
1091
        }
1092

1093
        for _, route := range vpc.Spec.PolicyRoutes {
×
1094
                if route.Action != kubeovnv1.PolicyRouteActionReroute {
×
1095
                        if route.NextHopIP != "" {
×
1096
                                route.NextHopIP = ""
×
1097
                                changed = true
×
1098
                        }
×
1099
                } else {
×
1100
                        // ecmp policy route may reroute to multiple next hop ips
×
1101
                        for ipStr := range strings.SplitSeq(route.NextHopIP, ",") {
×
1102
                                if ip := net.ParseIP(ipStr); ip == nil {
×
1103
                                        err := fmt.Errorf("invalid next hop ips: %s", route.NextHopIP)
×
1104
                                        klog.Error(err)
×
1105
                                        return nil, err
×
1106
                                }
×
1107
                        }
1108
                }
1109
        }
1110

1111
        if vpc.DeletionTimestamp.IsZero() && !slices.Contains(vpc.GetFinalizers(), util.KubeOVNControllerFinalizer) {
×
1112
                controllerutil.AddFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1113
                changed = true
×
1114
        }
×
1115

1116
        if !vpc.DeletionTimestamp.IsZero() && len(vpc.Status.Subnets) == 0 {
×
1117
                controllerutil.RemoveFinalizer(vpc, util.KubeOVNControllerFinalizer)
×
1118
                changed = true
×
1119
        }
×
1120

1121
        if changed {
×
1122
                newVpc, err := c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{})
×
1123
                if err != nil {
×
1124
                        klog.Errorf("failed to update vpc %s: %v", vpc.Name, err)
×
1125
                        return nil, err
×
1126
                }
×
1127
                return newVpc, nil
×
1128
        }
1129

1130
        return vpc, nil
×
1131
}
1132

1133
func convertPolicies(list []*kubeovnv1.PolicyRoute) string {
×
1134
        if list == nil {
×
1135
                return ""
×
1136
        }
×
1137

1138
        var (
×
1139
                res []byte
×
1140
                err error
×
1141
        )
×
1142

×
1143
        if res, err = json.Marshal(list); err != nil {
×
1144
                klog.Errorf("failed to serialize policy routes %v , reason : %v", list, err)
×
1145
                return ""
×
1146
        }
×
1147
        return string(res)
×
1148
}
1149

1150
func reversePolicies(origin string) []*kubeovnv1.PolicyRoute {
×
1151
        if origin == "" {
×
1152
                return nil
×
1153
        }
×
1154

1155
        var (
×
1156
                list []*kubeovnv1.PolicyRoute
×
1157
                err  error
×
1158
        )
×
1159

×
1160
        if err = json.Unmarshal([]byte(origin), &list); err != nil {
×
1161
                klog.Errorf("failed to deserialize policy routes %v , reason : %v", list, err)
×
1162
                return nil
×
1163
        }
×
1164
        return list
×
1165
}
1166

1167
func convertPolicy(origin kubeovnv1.RoutePolicy) string {
×
1168
        if origin == kubeovnv1.PolicyDst {
×
1169
                return ovnnb.LogicalRouterStaticRoutePolicyDstIP
×
1170
        }
×
1171
        return ovnnb.LogicalRouterStaticRoutePolicySrcIP
×
1172
}
1173

1174
func reversePolicy(origin ovnnb.LogicalRouterStaticRoutePolicy) kubeovnv1.RoutePolicy {
×
1175
        if origin == ovnnb.LogicalRouterStaticRoutePolicyDstIP {
×
1176
                return kubeovnv1.PolicyDst
×
1177
        }
×
1178
        return kubeovnv1.PolicySrc
×
1179
}
1180

1181
func (c *Controller) getVpcSubnets(vpc *kubeovnv1.Vpc) (subnets []string, defaultSubnet string, err error) {
×
1182
        subnets = []string{}
×
1183
        allSubnets, err := c.subnetsLister.List(labels.Everything())
×
1184
        if err != nil {
×
1185
                klog.Error(err)
×
1186
                return nil, "", err
×
1187
        }
×
1188

1189
        for _, subnet := range allSubnets {
×
1190
                if subnet.Spec.Vpc != vpc.Name || !subnet.DeletionTimestamp.IsZero() || !isOvnSubnet(subnet) {
×
1191
                        continue
×
1192
                }
1193

1194
                subnets = append(subnets, subnet.Name)
×
1195
                if subnet.Spec.Default {
×
1196
                        defaultSubnet = subnet.Name
×
1197
                }
×
1198

1199
                if vpc.Name != util.DefaultVpc && vpc.Spec.DefaultSubnet != "" && vpc.Spec.DefaultSubnet == subnet.Name {
×
1200
                        defaultSubnet = vpc.Spec.DefaultSubnet
×
1201
                }
×
1202
        }
1203
        return
×
1204
}
1205

1206
// createVpcRouter create router to connect logical switches in vpc
1207
func (c *Controller) createVpcRouter(lr string) error {
×
1208
        if err := c.OVNNbClient.CreateLogicalRouter(lr); err != nil {
×
1209
                klog.Errorf("create logical router %s failed: %v", lr, err)
×
1210
                return err
×
1211
        }
×
1212

1213
        vpcRouter, err := c.OVNNbClient.GetLogicalRouter(lr, false)
×
1214
        if err != nil {
×
1215
                klog.Errorf("get logical router %s failed: %v", lr, err)
×
1216
                return err
×
1217
        }
×
1218

1219
        vpcRouter.Options = map[string]string{"always_learn_from_arp_request": "false", "dynamic_neigh_routers": "true", "mac_binding_age_threshold": "300"}
×
1220
        err = c.OVNNbClient.UpdateLogicalRouter(vpcRouter, &vpcRouter.Options)
×
1221
        if err != nil {
×
1222
                klog.Errorf("update logical router %s failed: %v", lr, err)
×
1223
                return err
×
1224
        }
×
1225
        return nil
×
1226
}
1227

1228
// deleteVpcRouter delete router to connect logical switches in vpc
1229
func (c *Controller) deleteVpcRouter(lr string) error {
×
1230
        return c.OVNNbClient.DeleteLogicalRouter(lr)
×
1231
}
×
1232

1233
func (c *Controller) handleAddVpcExternalSubnet(key, subnet string) error {
×
1234
        cachedSubnet, err := c.subnetsLister.Get(subnet)
×
1235
        if err != nil {
×
1236
                klog.Error(err)
×
1237
                return err
×
1238
        }
×
1239
        lrpEipName := fmt.Sprintf("%s-%s", key, subnet)
×
1240
        cachedEip, err := c.ovnEipsLister.Get(lrpEipName)
×
1241
        var needCreateEip bool
×
1242
        if err != nil {
×
1243
                if !k8serrors.IsNotFound(err) {
×
1244
                        klog.Error(err)
×
1245
                        return err
×
1246
                }
×
1247
                needCreateEip = true
×
1248
        }
1249
        var v4ip, v6ip, mac string
×
1250
        klog.V(3).Infof("create vpc lrp eip %s", lrpEipName)
×
1251
        if needCreateEip {
×
1252
                if v4ip, v6ip, mac, err = c.acquireIPAddress(subnet, lrpEipName, lrpEipName); err != nil {
×
1253
                        klog.Errorf("failed to acquire ip address for lrp eip %s, %v", lrpEipName, err)
×
1254
                        return err
×
1255
                }
×
1256
                if err := c.createOrUpdateOvnEipCR(lrpEipName, subnet, v4ip, v6ip, mac, util.OvnEipTypeLRP); err != nil {
×
1257
                        klog.Errorf("failed to create ovn eip for lrp %s: %v", lrpEipName, err)
×
1258
                        return err
×
1259
                }
×
1260
        } else {
×
1261
                v4ip = cachedEip.Spec.V4Ip
×
1262
                mac = cachedEip.Spec.MacAddress
×
1263
        }
×
1264
        if v4ip == "" || mac == "" {
×
1265
                err := fmt.Errorf("lrp '%s' ip or mac should not be empty", lrpEipName)
×
1266
                klog.Error(err)
×
1267
                return err
×
1268
        }
×
1269
        // init lrp gw chassis group
1270
        chassises := []string{}
×
1271
        sel, _ := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{util.ExGatewayLabel: "true"}})
×
1272
        gwNodes, err := c.nodesLister.List(sel)
×
1273
        if err != nil {
×
1274
                klog.Errorf("failed to list external gw nodes, %v", err)
×
1275
                return err
×
1276
        }
×
1277
        for _, gwNode := range gwNodes {
×
1278
                annoChassisName := gwNode.Annotations[util.ChassisAnnotation]
×
1279
                if annoChassisName == "" {
×
1280
                        err := fmt.Errorf("node %s has no chassis annotation, kube-ovn-cni not ready", gwNode.Name)
×
1281
                        klog.Error(err)
×
1282
                        return err
×
1283
                }
×
1284
                klog.Infof("get node %s chassis: %s", gwNode.Name, annoChassisName)
×
1285
                chassis, err := c.OVNSbClient.GetChassis(annoChassisName, false)
×
1286
                if err != nil {
×
1287
                        klog.Errorf("failed to get node %s chassis: %s, %v", gwNode.Name, annoChassisName, err)
×
1288
                        return err
×
1289
                }
×
1290
                chassises = append(chassises, chassis.Name)
×
1291
        }
1292

1293
        if len(chassises) == 0 {
×
1294
                err := errors.New("no external gw nodes")
×
1295
                klog.Error(err)
×
1296
                return err
×
1297
        }
×
1298

1299
        v4ipCidr, err := util.GetIPAddrWithMask(v4ip, cachedSubnet.Spec.CIDRBlock)
×
1300
        if err != nil {
×
1301
                klog.Error(err)
×
1302
                return err
×
1303
        }
×
1304
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1305
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1306

×
1307
        if err := c.OVNNbClient.CreateLogicalPatchPort(subnet, key, lspName, lrpName, v4ipCidr, mac, chassises...); err != nil {
×
1308
                klog.Errorf("failed to connect router '%s' to external: %v", key, err)
×
1309
                return err
×
1310
        }
×
1311

1312
        cachedVpc, err := c.vpcsLister.Get(key)
×
1313
        if err != nil {
×
1314
                if k8serrors.IsNotFound(err) {
×
1315
                        return nil
×
1316
                }
×
1317
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1318
                return err
×
1319
        }
1320
        if subnet == c.config.ExternalGatewaySwitch {
×
1321
                vpc := cachedVpc.DeepCopy()
×
1322
                vpc.Status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1323
                bytes, err := vpc.Status.Bytes()
×
1324
                if err != nil {
×
1325
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1326
                        return err
×
1327
                }
×
1328
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1329
                        vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1330
                        err := fmt.Errorf("failed to patch vpc %s status, %w", vpc.Name, err)
×
1331
                        klog.Error(err)
×
1332
                        return err
×
1333
                }
×
1334
        }
1335
        if _, err = c.ovnEipsLister.Get(lrpEipName); err != nil {
×
1336
                err := fmt.Errorf("failed to get ovn eip %s, %w", lrpEipName, err)
×
1337
                klog.Error(err)
×
1338
                return err
×
1339
        }
×
1340
        return nil
×
1341
}
1342

1343
func (c *Controller) handleDeleteVpcStaticRoute(key string) error {
×
1344
        vpc, err := c.vpcsLister.Get(key)
×
1345
        if err != nil {
×
1346
                if k8serrors.IsNotFound(err) {
×
1347
                        return nil
×
1348
                }
×
1349
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1350
                return err
×
1351
        }
1352
        needUpdate := false
×
1353
        newStaticRoutes := make([]*kubeovnv1.StaticRoute, 0, len(vpc.Spec.StaticRoutes))
×
1354
        for _, route := range vpc.Spec.StaticRoutes {
×
1355
                if route.ECMPMode != util.StaticRouteBfdEcmp {
×
1356
                        newStaticRoutes = append(newStaticRoutes, route)
×
1357
                        needUpdate = true
×
1358
                }
×
1359
        }
1360
        // keep non ecmp bfd routes
1361
        vpc.Spec.StaticRoutes = newStaticRoutes
×
1362
        if needUpdate {
×
1363
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Update(context.Background(), vpc, metav1.UpdateOptions{}); err != nil {
×
1364
                        klog.Errorf("failed to update vpc spec static route %s, %v", vpc.Name, err)
×
1365
                        return err
×
1366
                }
×
1367
        }
1368
        if err = c.patchVpcBfdStatus(vpc.Name); err != nil {
×
1369
                klog.Errorf("failed to patch vpc %s, %v", vpc.Name, err)
×
1370
                return err
×
1371
        }
×
1372
        return nil
×
1373
}
1374

1375
func (c *Controller) handleDelVpcExternalSubnet(key, subnet string) error {
×
1376
        lspName := fmt.Sprintf("%s-%s", subnet, key)
×
1377
        lrpName := fmt.Sprintf("%s-%s", key, subnet)
×
1378
        klog.V(3).Infof("delete vpc lrp %s", lrpName)
×
1379
        if err := c.OVNNbClient.RemoveLogicalPatchPort(lspName, lrpName); err != nil {
×
1380
                klog.Errorf("failed to disconnect router '%s' to external, %v", key, err)
×
1381
                return err
×
1382
        }
×
1383

1384
        if err := c.config.KubeOvnClient.KubeovnV1().OvnEips().Delete(context.Background(), lrpName, metav1.DeleteOptions{}); err != nil {
×
1385
                if !k8serrors.IsNotFound(err) {
×
1386
                        klog.Errorf("failed to delete ovn eip %s, %v", lrpName, err)
×
1387
                        return err
×
1388
                }
×
1389
        }
1390
        if err := c.OVNNbClient.DeleteBFDByDstIP(lrpName, ""); err != nil {
×
1391
                klog.Error(err)
×
1392
                return err
×
1393
        }
×
1394
        cachedVpc, err := c.vpcsLister.Get(key)
×
1395
        if err != nil {
×
1396
                if k8serrors.IsNotFound(err) {
×
1397
                        return nil
×
1398
                }
×
1399
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1400
                return err
×
1401
        }
1402
        if subnet == c.config.ExternalGatewaySwitch {
×
1403
                vpc := cachedVpc.DeepCopy()
×
1404
                vpc.Status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1405
                vpc.Status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1406
                bytes, err := vpc.Status.Bytes()
×
1407
                if err != nil {
×
1408
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1409
                        return err
×
1410
                }
×
1411
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1412
                        vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1413
                        if k8serrors.IsNotFound(err) {
×
1414
                                return nil
×
1415
                        }
×
1416
                        klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1417
                        return err
×
1418
                }
1419
        }
1420
        return nil
×
1421
}
1422

1423
func (c *Controller) patchVpcBfdStatus(key string) error {
×
1424
        cachedVpc, err := c.vpcsLister.Get(key)
×
1425
        if err != nil {
×
1426
                if k8serrors.IsNotFound(err) {
×
1427
                        return nil
×
1428
                }
×
1429
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1430
                return err
×
1431
        }
1432

1433
        if cachedVpc.Status.EnableBfd != cachedVpc.Spec.EnableBfd {
×
1434
                status := cachedVpc.Status.DeepCopy()
×
1435
                status.EnableExternal = cachedVpc.Spec.EnableExternal
×
1436
                status.EnableBfd = cachedVpc.Spec.EnableBfd
×
1437
                bytes, err := status.Bytes()
×
1438
                if err != nil {
×
1439
                        klog.Errorf("failed to marshal vpc status: %v", err)
×
1440
                        return err
×
1441
                }
×
1442
                if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1443
                        cachedVpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1444
                        klog.Error(err)
×
1445
                        return err
×
1446
                }
×
1447
        }
1448
        return nil
×
1449
}
1450

1451
func (c *Controller) getRouteTablesByVpc(vpc *kubeovnv1.Vpc) map[string][]*kubeovnv1.StaticRoute {
×
1452
        rtbs := make(map[string][]*kubeovnv1.StaticRoute)
×
1453
        for _, route := range vpc.Spec.StaticRoutes {
×
1454
                rtbs[route.RouteTable] = append(rtbs[route.RouteTable], route)
×
1455
        }
×
1456
        return rtbs
×
1457
}
1458

1459
func (c *Controller) updateVpcAddExternalStatus(key string, addExternalStatus bool) error {
×
1460
        cachedVpc, err := c.vpcsLister.Get(key)
×
1461
        if err != nil {
×
1462
                klog.Errorf("failed to get vpc %s, %v", key, err)
×
1463
                return err
×
1464
        }
×
1465
        vpc := cachedVpc.DeepCopy()
×
1466
        if addExternalStatus && vpc.Spec.ExtraExternalSubnets != nil {
×
1467
                sort.Strings(vpc.Spec.ExtraExternalSubnets)
×
1468
                vpc.Status.ExtraExternalSubnets = vpc.Spec.ExtraExternalSubnets
×
1469
        } else {
×
1470
                vpc.Status.ExtraExternalSubnets = nil
×
1471
        }
×
1472
        bytes, err := vpc.Status.Bytes()
×
1473
        if err != nil {
×
1474
                klog.Errorf("failed to get vpc bytes, %v", err)
×
1475
                return err
×
1476
        }
×
1477
        if _, err = c.config.KubeOvnClient.KubeovnV1().Vpcs().Patch(context.Background(),
×
1478
                vpc.Name, types.MergePatchType, bytes, metav1.PatchOptions{}, "status"); err != nil {
×
1479
                klog.Errorf("failed to patch vpc %s, %v", key, err)
×
1480
                return err
×
1481
        }
×
1482

1483
        return nil
×
1484
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc