14954769666

Committed 11 May 2025 10:14AM UTC coverage: 0.0% (-8.5%) from 8.457%

Build # 14954769666

Build Type

Pull #7135

github

Committed by

web-flow

Commit Message

Merge bf21e0bc7 into 4dd0cdfc4

Pull Request Pull Request #7135: fix(symfony,laravel): InvalidUriVariableException status code (e400)

Run Details

0 of 2 new or added lines in 2 files covered. (0.0%)

11040 existing lines in 370 files now uncovered.

0 of 48303 relevant lines covered (0.0%)

0.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/Symfony/Security/State/LinkAccessCheckerProvider.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Symfony\Security\State;

use ApiPlatform\Metadata\HttpOperation;
use ApiPlatform\Metadata\Link;
use ApiPlatform\Metadata\Operation;
use ApiPlatform\State\ProviderInterface;
use ApiPlatform\Symfony\Security\Exception\AccessDeniedException;
use ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface;

/**
 * Checks the individual parts of the linked resource for access rights.
 *
 * @experimental
 */
final class LinkAccessCheckerProvider implements ProviderInterface
{
    public function __construct(
        private readonly ProviderInterface $decorated,
        private readonly ResourceAccessCheckerInterface $resourceAccessChecker,
    ) {
    }

    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null
    {
        $request = ($context['request'] ?? null);

        $data = $this->decorated->provide($operation, $uriVariables, $context);

        if ($operation instanceof HttpOperation && $operation->getUriVariables()) {
            foreach ($operation->getUriVariables() as $uriVariable) {
                if (!$uriVariable instanceof Link || !$uriVariable->getSecurity()) {
                    continue;
                }

                $targetResource = $uriVariable->getFromClass() ?? $uriVariable->getToClass();

                if (!$targetResource) {
                    continue;
                }

                $propertyName = $uriVariable->getToProperty() ?? $uriVariable->getFromProperty();
                $securityObjectName = $uriVariable->getSecurityObjectName();

                if (!$securityObjectName) {
                    $securityObjectName = $propertyName;
                }

                if (!$securityObjectName) {
                    continue;
                }

                $resourceAccessCheckerContext = [
                    'object' => $data,
                    'previous_object' => $request?->attributes->get('previous_data'),
                    $securityObjectName => $request?->attributes->get($securityObjectName),
                    'request' => $request,
                ];

                if (!$this->resourceAccessChecker->isGranted($targetResource, $uriVariable->getSecurity(), $resourceAccessCheckerContext)) {
                    throw new AccessDeniedException($uriVariable->getSecurityMessage() ?? 'Access Denied.');
                }
            }
        }

        return $data;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Symfony\Security\State;
15
16	use ApiPlatform\Metadata\HttpOperation;
17	use ApiPlatform\Metadata\Link;
18	use ApiPlatform\Metadata\Operation;
19	use ApiPlatform\State\ProviderInterface;
20	use ApiPlatform\Symfony\Security\Exception\AccessDeniedException;
21	use ApiPlatform\Symfony\Security\ResourceAccessCheckerInterface;
22
23	/**
24	* Checks the individual parts of the linked resource for access rights.
25	*
26	* @experimental
27	*/
28	final class LinkAccessCheckerProvider implements ProviderInterface
29	{
30	public function __construct(
31	private readonly ProviderInterface $decorated,
32	private readonly ResourceAccessCheckerInterface $resourceAccessChecker,
33	) {
UNCOV 34	}	×
35
36	public function provide(Operation $operation, array $uriVariables = [], array $context = []): object\|array\|null
37	{
UNCOV 38	$request = ($context['request'] ?? null);	×
39
UNCOV 40	$data = $this->decorated->provide($operation, $uriVariables, $context);	×
41
UNCOV 42	if ($operation instanceof HttpOperation && $operation->getUriVariables()) {	×
UNCOV 43	foreach ($operation->getUriVariables() as $uriVariable) {	×
UNCOV 44	if (!$uriVariable instanceof Link \|\| !$uriVariable->getSecurity()) {	×
UNCOV 45	continue;	×
46	}
47
UNCOV 48	$targetResource = $uriVariable->getFromClass() ?? $uriVariable->getToClass();	×
49
UNCOV 50	if (!$targetResource) {	×
51	continue;	×
52	}
53
UNCOV 54	$propertyName = $uriVariable->getToProperty() ?? $uriVariable->getFromProperty();	×
UNCOV 55	$securityObjectName = $uriVariable->getSecurityObjectName();	×
56
UNCOV 57	if (!$securityObjectName) {	×
UNCOV 58	$securityObjectName = $propertyName;	×
59	}
60
UNCOV 61	if (!$securityObjectName) {	×
62	continue;	×
63	}
64
UNCOV 65	$resourceAccessCheckerContext = [	×
UNCOV 66	'object' => $data,	×
UNCOV 67	'previous_object' => $request?->attributes->get('previous_data'),	×
UNCOV 68	$securityObjectName => $request?->attributes->get($securityObjectName),	×
UNCOV 69	'request' => $request,	×
UNCOV 70	];	×
71
UNCOV 72	if (!$this->resourceAccessChecker->isGranted($targetResource, $uriVariable->getSecurity(), $resourceAccessCheckerContext)) {	×
UNCOV 73	throw new AccessDeniedException($uriVariable->getSecurityMessage() ?? 'Access Denied.');	×
74	}
75	}
76	}
77
UNCOV 78	return $data;	×
79	}
80	}

api-platform / core / 14954769666

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous