#674

Committed 07 May 2025 02:48PM UTC coverage: 87.247% (+0.01%) from 87.237%

Build # #674

Build Type

push

Committed by

Commit Message

Implement SonarCloud quality suggestions #159

Run Details

11 of 13 new or added lines in 6 files covered. (84.62%)

1 existing line in 1 file now uncovered.

5521 of 6328 relevant lines covered (87.25%)

0.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

67.65

/src/main/java/de/gwdg/metadataqa/api/model/EdmFieldInstance.java

package de.gwdg.metadataqa.api.model;

import java.util.Objects;
import org.apache.commons.lang3.StringUtils;

/**
 * EDM field instance
 *
 * @author Péter Király <peter.kiraly at gwdg.de>
 */
public class EdmFieldInstance extends XmlFieldInstance {

  private String resource;

  public EdmFieldInstance() {
    super();
  }

  public EdmFieldInstance(String value) {
    super(value);
  }

  public EdmFieldInstance(String value, String language) {
    super(value, language);
  }

  public EdmFieldInstance(String value, String language, String resource) {
    super(value, language);
    this.resource = resource;
  }

  public String getResource() {
    return resource;
  }

  public void setResource(String resource) {
    this.resource = resource;
  }

  public boolean hasResource() {
    return StringUtils.isNotBlank(resource);
  }

  @Override
  public boolean isEmpty() {
    return !hasValue() && !hasLanguage() && !hasResource();
  }

  public boolean isUrl() {
    return (hasResource() || (hasValue() && (getValue().startsWith("http://") || getValue().startsWith("https://"))));
  }

  public String getUrl() {
    if (hasResource()) {
      return getResource();
    }

    if (isUrl()) {
      return getValue();
    }

    return null;
  }

  @Override
  public String toString() {
    return "EdmFieldInstance{" + "value=" + getValue() + ", language=" + getLanguage() + ", resource=" + resource + '}';
  }

  @Override
  public int hashCode() {
    var hash = 5;
    hash = 19 * hash + Objects.hashCode(getValue());
    hash = 19 * hash + Objects.hashCode(getLanguage());
    hash = 19 * hash + Objects.hashCode(getResource());
    return hash;
  }

  @Override
  public boolean equals(Object other) {
    if (!(other instanceof EdmFieldInstance))
      return false;

    if (this == other)
      return true;

    return equalsTo((EdmFieldInstance) other);
  }

  private boolean equalsTo(EdmFieldInstance other) {
    return Objects.equals(this.getValue(), other.getValue())
        && Objects.equals(this.getLanguage(), other.getLanguage())
        && Objects.equals(this.getResource(), other.getResource());
  }
}

1	package de.gwdg.metadataqa.api.model;
2
3	import java.util.Objects;
4	import org.apache.commons.lang3.StringUtils;
5
6	/**
7	* EDM field instance
8	*
9	* @author Péter Király <peter.kiraly at gwdg.de>
10	*/
11	public class EdmFieldInstance extends XmlFieldInstance {
12
13	private String resource;
14
15	public EdmFieldInstance() {
16	super();	1✔
17	}	1✔
18
19	public EdmFieldInstance(String value) {
20	super(value);	1✔
21	}	1✔
22
23	public EdmFieldInstance(String value, String language) {
24	super(value, language);	1✔
25	}	1✔
26
27	public EdmFieldInstance(String value, String language, String resource) {
28	super(value, language);	1✔
29	this.resource = resource;	1✔
30	}	1✔
31
32	public String getResource() {
33	return resource;	1✔
34	}
35
36	public void setResource(String resource) {
37	this.resource = resource;	1✔
38	}	1✔
39
40	public boolean hasResource() {
41	return StringUtils.isNotBlank(resource);	1✔
42	}
43
44	@Override
45	public boolean isEmpty() {
46	return !hasValue() && !hasLanguage() && !hasResource();	1✔
47	}
48
49	public boolean isUrl() {
50	return (hasResource() \|\| (hasValue() && (getValue().startsWith("http://") \|\| getValue().startsWith("https://"))));	1✔
51	}
52
53	public String getUrl() {
54	if (hasResource()) {	1✔
55	return getResource();	1✔
56	}
57
58	if (isUrl()) {	×
59	return getValue();	×
60	}
61
62	return null;	×
63	}
64
65	@Override
66	public String toString() {
67	return "EdmFieldInstance{" + "value=" + getValue() + ", language=" + getLanguage() + ", resource=" + resource + '}';	×
68	}
69
70	@Override
71	public int hashCode() {
72	var hash = 5;	×
73	hash = 19 * hash + Objects.hashCode(getValue());	×
74	hash = 19 * hash + Objects.hashCode(getLanguage());	×
75	hash = 19 * hash + Objects.hashCode(getResource());	×
76	return hash;	×
77	}
78
79	@Override
80	public boolean equals(Object other) {
81	if (!(other instanceof EdmFieldInstance))	1✔
UNCOV 82	return false;	×
83
84	if (this == other)	1✔
85	return true;	×
86
87	return equalsTo((EdmFieldInstance) other);	1✔
88	}
89
90	private boolean equalsTo(EdmFieldInstance other) {
91	return Objects.equals(this.getValue(), other.getValue())	1✔
92	&& Objects.equals(this.getLanguage(), other.getLanguage())	1✔
93	&& Objects.equals(this.getResource(), other.getResource());	1✔
94	}
95	}

pkiraly / metadata-qa-api / #674

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous