14838030052

Committed 05 May 2025 01:48PM UTC coverage: 7.178% (-1.3%) from 8.459%

Build # 14838030052

Build Type

Pull #7122

github

Committed by

web-flow

Commit Message

Merge ecae612bf into f55606b01

Pull Request Pull Request #7122: Cherry picks from main (deprecations)

Run Details

0 of 35 new or added lines in 9 files covered. (0.0%)

2157 existing lines in 159 files now uncovered.

10774 of 150101 relevant lines covered (7.18%)

3.23 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

97.67

/src/Validator/Metadata/Resource/Factory/ParameterValidationResourceMetadataCollectionFactory.php

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Validator\Metadata\Resource\Factory;

use ApiPlatform\Metadata\HttpOperation;
use ApiPlatform\Metadata\Parameter;
use ApiPlatform\Metadata\Parameters;
use ApiPlatform\Metadata\QueryParameter;
use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
use ApiPlatform\OpenApi\Model\Parameter as OpenApiParameter;
use Psr\Container\ContainerInterface;
use Symfony\Component\Validator\Constraints\Choice;
use Symfony\Component\Validator\Constraints\Count;
use Symfony\Component\Validator\Constraints\DivisibleBy;
use Symfony\Component\Validator\Constraints\GreaterThan;
use Symfony\Component\Validator\Constraints\GreaterThanOrEqual;
use Symfony\Component\Validator\Constraints\Length;
use Symfony\Component\Validator\Constraints\LessThan;
use Symfony\Component\Validator\Constraints\LessThanOrEqual;
use Symfony\Component\Validator\Constraints\NotBlank;
use Symfony\Component\Validator\Constraints\NotNull;
use Symfony\Component\Validator\Constraints\Regex;
use Symfony\Component\Validator\Constraints\Type;
use Symfony\Component\Validator\Constraints\Unique;

final class ParameterValidationResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
{
    public function __construct(
        private readonly ?ResourceMetadataCollectionFactoryInterface $decorated = null,
        private readonly ?ContainerInterface $filterLocator = null,
    ) {
    }

    public function create(string $resourceClass): ResourceMetadataCollection
    {
        $resourceMetadataCollection = $this->decorated?->create($resourceClass) ?? new ResourceMetadataCollection($resourceClass);

        foreach ($resourceMetadataCollection as $i => $resource) {
            $operations = $resource->getOperations();

            foreach ($operations as $operationName => $operation) {
                $parameters = $operation->getParameters() ?? new Parameters();
                foreach ($parameters as $key => $parameter) {
                    $parameters->add($key, $this->addSchemaValidation($parameter));
                }

                // As we deprecate the parameter validator, we declare a parameter for each filter transfering validation to the new system
                if ($operation->getFilters() && 0 === $parameters->count()) {
                    $parameters = $this->addFilterValidation($operation);
                }

                if (\count($parameters) > 0) {
                    $operations->add($operationName, $operation->withParameters($parameters));
                }
            }

            $resourceMetadataCollection[$i] = $resource->withOperations($operations->sort());

            if (!$graphQlOperations = $resource->getGraphQlOperations()) {
                continue;
            }

            foreach ($graphQlOperations as $operationName => $operation) {
                $parameters = $operation->getParameters() ?? new Parameters();
                foreach ($operation->getParameters() ?? [] as $key => $parameter) {
                    $parameters->add($key, $this->addSchemaValidation($parameter));
                }

                if (\count($parameters) > 0) {
                    $graphQlOperations[$operationName] = $operation->withParameters($parameters);
                }
            }

            $resourceMetadataCollection[$i] = $resource->withGraphQlOperations($graphQlOperations);
        }

        return $resourceMetadataCollection;
    }

    private function addSchemaValidation(Parameter $parameter, ?array $schema = null, ?bool $required = null, ?OpenApiParameter $openApi = null): Parameter
    {
        if (null !== $parameter->getConstraints()) {
            return $parameter;
        }

        $schema ??= $parameter->getSchema();
        $required ??= $parameter->getRequired() ?? false;
        $openApi ??= $parameter->getOpenApi();

        // When it's an array of openapi parameters take the first one as it's probably just a variant of the query parameter,
        // only getAllowEmptyValue is used here anyways
        if (\is_array($openApi)) {
            $openApi = $openApi[0];
        } elseif (false === $openApi) {
            $openApi = null;
        }

        $assertions = [];

        if ($required && false !== ($allowEmptyValue = $openApi?->getAllowEmptyValue())) {
            $assertions[] = new NotNull(message: \sprintf('The parameter "%s" is required.', $parameter->getKey()));
        }

        if (false === ($allowEmptyValue ?? $openApi?->getAllowEmptyValue())) {
            $assertions[] = new NotBlank(allowNull: !$required);
        }

        if (isset($schema['exclusiveMinimum'])) {
            $assertions[] = new GreaterThan(value: $schema['exclusiveMinimum']);
        }

        if (isset($schema['exclusiveMaximum'])) {
            $assertions[] = new LessThan(value: $schema['exclusiveMaximum']);
        }

        if (isset($schema['minimum'])) {
            $assertions[] = new GreaterThanOrEqual(value: $schema['minimum']);
        }

        if (isset($schema['maximum'])) {
            $assertions[] = new LessThanOrEqual(value: $schema['maximum']);
        }

        if (isset($schema['pattern'])) {
            $assertions[] = new Regex('#'.$schema['pattern'].'#');
        }

        if (isset($schema['maxLength']) || isset($schema['minLength'])) {
            $assertions[] = new Length(min: $schema['minLength'] ?? null, max: $schema['maxLength'] ?? null);
        }

        if (isset($schema['minItems']) || isset($schema['maxItems'])) {
            $assertions[] = new Count(min: $schema['minItems'] ?? null, max: $schema['maxItems'] ?? null);
        }

        if (isset($schema['multipleOf'])) {
            $assertions[] = new DivisibleBy(value: $schema['multipleOf']);
        }

        if ($schema['uniqueItems'] ?? false) {
            $assertions[] = new Unique();
        }

        if (isset($schema['enum'])) {
            $assertions[] = new Choice(choices: $schema['enum']);
        }

        if (isset($schema['type']) && 'array' === $schema['type']) {
            $assertions[] = new Type(type: 'array');
        }

        if (!$assertions) {
            return $parameter;
        }

        if (1 === \count($assertions)) {
            return $parameter->withConstraints($assertions[0]);
        }

        return $parameter->withConstraints($assertions);
    }

    private function addFilterValidation(HttpOperation $operation): Parameters
    {
        $parameters = new Parameters();
        $internalPriority = -1;

        foreach ($operation->getFilters() as $filter) {
            if (!$this->filterLocator->has($filter)) {
                continue;
            }

            $filter = $this->filterLocator->get($filter);
            foreach ($filter->getDescription($operation->getClass()) as $parameterName => $definition) {
                $key = $parameterName;
                $required = $definition['required'] ?? false;
                $schema = $definition['schema'] ?? null;

                $openApi = null;
                if (isset($definition['openapi']) && $definition['openapi'] instanceof OpenApiParameter) {
                    $openApi = $definition['openapi'];
                }

                // The query parameter validator forced this, lets maintain BC on filters
                if (true === $required && !$openApi) {
                    $openApi = new OpenApiParameter(name: $key, in: 'query', allowEmptyValue: false);
                }

                $parameters->add($key, $this->addSchemaValidation(
                    // we disable openapi and hydra on purpose as their docs comes from filters see the condition for addFilterValidation above
                    new QueryParameter(key: $key, property: $definition['property'] ?? null, priority: $internalPriority--, schema: $schema, openApi: false, hydra: false),
                    $schema,
                    $required,
                    $openApi
                ));
            }
        }

        return $parameters;
    }
}

1	<?php
2
3	/*
4	* This file is part of the API Platform project.
5	*
6	* (c) Kévin Dunglas <dunglas@gmail.com>
7	*
8	* For the full copyright and license information, please view the LICENSE
9	* file that was distributed with this source code.
10	*/
11
12	declare(strict_types=1);
13
14	namespace ApiPlatform\Validator\Metadata\Resource\Factory;
15
16	use ApiPlatform\Metadata\HttpOperation;
17	use ApiPlatform\Metadata\Parameter;
18	use ApiPlatform\Metadata\Parameters;
19	use ApiPlatform\Metadata\QueryParameter;
20	use ApiPlatform\Metadata\Resource\Factory\ResourceMetadataCollectionFactoryInterface;
21	use ApiPlatform\Metadata\Resource\ResourceMetadataCollection;
22	use ApiPlatform\OpenApi\Model\Parameter as OpenApiParameter;
23	use Psr\Container\ContainerInterface;
24	use Symfony\Component\Validator\Constraints\Choice;
25	use Symfony\Component\Validator\Constraints\Count;
26	use Symfony\Component\Validator\Constraints\DivisibleBy;
27	use Symfony\Component\Validator\Constraints\GreaterThan;
28	use Symfony\Component\Validator\Constraints\GreaterThanOrEqual;
29	use Symfony\Component\Validator\Constraints\Length;
30	use Symfony\Component\Validator\Constraints\LessThan;
31	use Symfony\Component\Validator\Constraints\LessThanOrEqual;
32	use Symfony\Component\Validator\Constraints\NotBlank;
33	use Symfony\Component\Validator\Constraints\NotNull;
34	use Symfony\Component\Validator\Constraints\Regex;
35	use Symfony\Component\Validator\Constraints\Type;
36	use Symfony\Component\Validator\Constraints\Unique;
37
38	final class ParameterValidationResourceMetadataCollectionFactory implements ResourceMetadataCollectionFactoryInterface
39	{
40	public function __construct(
41	private readonly ?ResourceMetadataCollectionFactoryInterface $decorated = null,
42	private readonly ?ContainerInterface $filterLocator = null,
43	) {
44	}	255✔
45
46	public function create(string $resourceClass): ResourceMetadataCollection
47	{
48	$resourceMetadataCollection = $this->decorated?->create($resourceClass) ?? new ResourceMetadataCollection($resourceClass);	37✔
49
50	foreach ($resourceMetadataCollection as $i => $resource) {	37✔
51	$operations = $resource->getOperations();	36✔
52
53	foreach ($operations as $operationName => $operation) {	36✔
54	$parameters = $operation->getParameters() ?? new Parameters();	36✔
55	foreach ($parameters as $key => $parameter) {	36✔
56	$parameters->add($key, $this->addSchemaValidation($parameter));	14✔
57	}
58
59	// As we deprecate the parameter validator, we declare a parameter for each filter transfering validation to the new system
60	if ($operation->getFilters() && 0 === $parameters->count()) {	36✔
61	$parameters = $this->addFilterValidation($operation);	2✔
62	}
63
64	if (\count($parameters) > 0) {	36✔
65	$operations->add($operationName, $operation->withParameters($parameters));	16✔
66	}
67	}
68
69	$resourceMetadataCollection[$i] = $resource->withOperations($operations->sort());	36✔
70
71	if (!$graphQlOperations = $resource->getGraphQlOperations()) {	36✔
72	continue;	17✔
73	}
74
75	foreach ($graphQlOperations as $operationName => $operation) {	28✔
76	$parameters = $operation->getParameters() ?? new Parameters();	28✔
77	foreach ($operation->getParameters() ?? [] as $key => $parameter) {	28✔
78	$parameters->add($key, $this->addSchemaValidation($parameter));	1✔
79	}
80
81	if (\count($parameters) > 0) {	28✔
82	$graphQlOperations[$operationName] = $operation->withParameters($parameters);	1✔
83	}
84	}
85
86	$resourceMetadataCollection[$i] = $resource->withGraphQlOperations($graphQlOperations);	28✔
87	}
88
89	return $resourceMetadataCollection;	37✔
90	}
91
92	private function addSchemaValidation(Parameter $parameter, ?array $schema = null, ?bool $required = null, ?OpenApiParameter $openApi = null): Parameter
93	{
94	if (null !== $parameter->getConstraints()) {	16✔
95	return $parameter;	2✔
96	}
97
98	$schema ??= $parameter->getSchema();	15✔
99	$required ??= $parameter->getRequired() ?? false;	15✔
100	$openApi ??= $parameter->getOpenApi();	15✔
101
102	// When it's an array of openapi parameters take the first one as it's probably just a variant of the query parameter,
103	// only getAllowEmptyValue is used here anyways
104	if (\is_array($openApi)) {	15✔
105	$openApi = $openApi[0];	4✔
106	} elseif (false === $openApi) {	14✔
107	$openApi = null;	3✔
108	}
109
110	$assertions = [];	15✔
111
112	if ($required && false !== ($allowEmptyValue = $openApi?->getAllowEmptyValue())) {	15✔
113	$assertions[] = new NotNull(message: \sprintf('The parameter "%s" is required.', $parameter->getKey()));	1✔
114	}
115
116	if (false === ($allowEmptyValue ?? $openApi?->getAllowEmptyValue())) {	15✔
117	$assertions[] = new NotBlank(allowNull: !$required);	6✔
118	}
119
120	if (isset($schema['exclusiveMinimum'])) {	15✔
121	$assertions[] = new GreaterThan(value: $schema['exclusiveMinimum']);	1✔
122	}
123
124	if (isset($schema['exclusiveMaximum'])) {	15✔
125	$assertions[] = new LessThan(value: $schema['exclusiveMaximum']);	1✔
126	}
127
128	if (isset($schema['minimum'])) {	15✔
129	$assertions[] = new GreaterThanOrEqual(value: $schema['minimum']);	1✔
130	}
131
132	if (isset($schema['maximum'])) {	15✔
133	$assertions[] = new LessThanOrEqual(value: $schema['maximum']);	1✔
134	}
135
136	if (isset($schema['pattern'])) {	15✔
137	$assertions[] = new Regex('#'.$schema['pattern'].'#');	1✔
138	}
139
140	if (isset($schema['maxLength']) \|\| isset($schema['minLength'])) {	15✔
141	$assertions[] = new Length(min: $schema['minLength'] ?? null, max: $schema['maxLength'] ?? null);	1✔
142	}
143
144	if (isset($schema['minItems']) \|\| isset($schema['maxItems'])) {	15✔
145	$assertions[] = new Count(min: $schema['minItems'] ?? null, max: $schema['maxItems'] ?? null);	1✔
146	}
147
148	if (isset($schema['multipleOf'])) {	15✔
149	$assertions[] = new DivisibleBy(value: $schema['multipleOf']);	1✔
150	}
151
152	if ($schema['uniqueItems'] ?? false) {	15✔
153	$assertions[] = new Unique();	1✔
154	}
155
156	if (isset($schema['enum'])) {	15✔
157	$assertions[] = new Choice(choices: $schema['enum']);	5✔
158	}
159
160	if (isset($schema['type']) && 'array' === $schema['type']) {	15✔
161	$assertions[] = new Type(type: 'array');	1✔
162	}
163
164	if (!$assertions) {	15✔
165	return $parameter;	12✔
166	}
167
168	if (1 === \count($assertions)) {	7✔
169	return $parameter->withConstraints($assertions[0]);	7✔
170	}
171
172	return $parameter->withConstraints($assertions);	3✔
173	}
174
175	private function addFilterValidation(HttpOperation $operation): Parameters
176	{
177	$parameters = new Parameters();	2✔
178	$internalPriority = -1;	2✔
179
180	foreach ($operation->getFilters() as $filter) {	2✔
181	if (!$this->filterLocator->has($filter)) {	2✔
UNCOV 182	continue;	×
183	}
184
185	$filter = $this->filterLocator->get($filter);	2✔
186	foreach ($filter->getDescription($operation->getClass()) as $parameterName => $definition) {	2✔
187	$key = $parameterName;	2✔
188	$required = $definition['required'] ?? false;	2✔
189	$schema = $definition['schema'] ?? null;	2✔
190
191	$openApi = null;	2✔
192	if (isset($definition['openapi']) && $definition['openapi'] instanceof OpenApiParameter) {	2✔
193	$openApi = $definition['openapi'];	1✔
194	}
195
196	// The query parameter validator forced this, lets maintain BC on filters
197	if (true === $required && !$openApi) {	2✔
UNCOV 198	$openApi = new OpenApiParameter(name: $key, in: 'query', allowEmptyValue: false);	×
199	}
200
201	$parameters->add($key, $this->addSchemaValidation(	2✔
202	// we disable openapi and hydra on purpose as their docs comes from filters see the condition for addFilterValidation above
203	new QueryParameter(key: $key, property: $definition['property'] ?? null, priority: $internalPriority--, schema: $schema, openApi: false, hydra: false),	2✔
204	$schema,	2✔
205	$required,	2✔
206	$openApi	2✔
207	));	2✔
208	}
209	}
210
211	return $parameters;	2✔
212	}
213	}

api-platform / core / 14838030052

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous