14790544976

Committed 02 May 2025 07:09AM UTC coverage: 31.845% (-0.03%) from 31.87%

Build # 14790544976

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1742 from shaforostoff/rgbmatrix_memleak

Fix high RAM usage related to RGB scripts

Run Details

6 of 13 new or added lines in 8 files covered. (46.15%)

13 existing lines in 3 files now uncovered.

14675 of 46082 relevant lines covered (31.85%)

26491.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

14.0

/engine/src/rgbplain.cpp

/*
  Q Light Controller Plus
  rgbplain.cpp

  Copyright (c) Massimo Callegari

  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0.txt

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
*/

#include <QXmlStreamReader>
#include <QXmlStreamWriter>
#include <QDebug>

#include "rgbplain.h"
#include "doc.h"

RGBPlain::RGBPlain(Doc * doc)
    : RGBAlgorithm(doc)
{
}

RGBPlain::RGBPlain(const RGBPlain& a, QObject *parent)
    : QObject(parent)
    , RGBAlgorithm(a.doc())
{
}

RGBPlain::~RGBPlain()
{
}

RGBAlgorithm* RGBPlain::clone() const
{
    RGBPlain* plain = new RGBPlain(*this);
    return static_cast<RGBAlgorithm*> (plain);
}

/****************************************************************************
 * RGBAlgorithm
 ****************************************************************************/

int RGBPlain::rgbMapStepCount(const QSize& size)
{
    Q_UNUSED(size);
    return 1;
}

void RGBPlain::rgbMapSetColors(const QVector<uint> &colors)
{
    Q_UNUSED(colors);
}

QVector<uint> RGBPlain::rgbMapGetColors()
{
    return QVector<uint>();
}

void RGBPlain::rgbMap(const QSize& size, uint rgb, int step, RGBMap &map)
{
    Q_UNUSED(step);
    map.resize(size.height());
    for (int y = 0; y < size.height(); y++)
    {
        map[y].resize(size.width());
        map[y].fill(rgb);
    }
}

QString RGBPlain::name() const
{
    return QString("Plain Color");
}

QString RGBPlain::author() const
{
    return QString("Massimo Callegari");
}

int RGBPlain::apiVersion() const
{
    return 1;
}

void RGBPlain::setColors(QVector<QColor> colors)
{
    RGBAlgorithm::setColors(colors);
}

RGBAlgorithm::Type RGBPlain::type() const
{
    return RGBAlgorithm::Plain;
}

int RGBPlain::acceptColors() const
{
    return 1; // only start color is accepted
}

bool RGBPlain::loadXML(QXmlStreamReader &root)
{
    if (root.name() != KXMLQLCRGBAlgorithm)
    {
        qWarning() << Q_FUNC_INFO << "RGB Algorithm node not found";
        return false;
    }

    if (root.attributes().value(KXMLQLCRGBAlgorithmType).toString() != KXMLQLCRGBPlain)
    {
        qWarning() << Q_FUNC_INFO << "RGB Algorithm is not Plain";
        return false;
    }

    root.skipCurrentElement();

    return true;
}

bool RGBPlain::saveXML(QXmlStreamWriter *doc) const
{
    Q_ASSERT(doc != NULL);

    doc->writeStartElement(KXMLQLCRGBAlgorithm);
    doc->writeAttribute(KXMLQLCRGBAlgorithmType, KXMLQLCRGBPlain);
    doc->writeEndElement();

    return true;
}

1	/*
2	Q Light Controller Plus
3	rgbplain.cpp
4
5	Copyright (c) Massimo Callegari
6
7	Licensed under the Apache License, Version 2.0 (the "License");
8	you may not use this file except in compliance with the License.
9	You may obtain a copy of the License at
10
11	http://www.apache.org/licenses/LICENSE-2.0.txt
12
13	Unless required by applicable law or agreed to in writing, software
14	distributed under the License is distributed on an "AS IS" BASIS,
15	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
16	See the License for the specific language governing permissions and
17	limitations under the License.
18	*/
19
20	#include <QXmlStreamReader>
21	#include <QXmlStreamWriter>
22	#include <QDebug>
23
24	#include "rgbplain.h"
25	#include "doc.h"
26
27	RGBPlain::RGBPlain(Doc * doc)	17✔
28	: RGBAlgorithm(doc)	17✔
29	{
30	}	17✔
31
32	RGBPlain::RGBPlain(const RGBPlain& a, QObject *parent)	×
33	: QObject(parent)
34	, RGBAlgorithm(a.doc())	×
35	{
36	}	×
37
38	RGBPlain::~RGBPlain()	17✔
39	{
40	}	17✔
41
42	RGBAlgorithm* RGBPlain::clone() const	×
43	{
44	RGBPlain* plain = new RGBPlain(*this);	×
45	return static_cast<RGBAlgorithm*> (plain);	×
46	}
47
48	/****************************************************************************
49	* RGBAlgorithm
50	****************************************************************************/
51
52	int RGBPlain::rgbMapStepCount(const QSize& size)	×
53	{
54	Q_UNUSED(size);
55	return 1;	×
56	}
57
NEW 58	void RGBPlain::rgbMapSetColors(const QVector<uint> &colors)	×
59	{
60	Q_UNUSED(colors);
61	}	×
62
63	QVector<uint> RGBPlain::rgbMapGetColors()	×
64	{
65	return QVector<uint>();	×
66	}
67
68	void RGBPlain::rgbMap(const QSize& size, uint rgb, int step, RGBMap &map)	×
69	{
70	Q_UNUSED(step);
71	map.resize(size.height());	×
72	for (int y = 0; y < size.height(); y++)	×
73	{
74	map[y].resize(size.width());	×
75	map[y].fill(rgb);	×
76	}
77	}	×
78
79	QString RGBPlain::name() const	16✔
80	{
81	return QString("Plain Color");	16✔
82	}
83
84	QString RGBPlain::author() const	×
85	{
86	return QString("Massimo Callegari");	×
87	}
88
89	int RGBPlain::apiVersion() const	×
90	{
91	return 1;	×
92	}
93
94	void RGBPlain::setColors(QVector<QColor> colors)	×
95	{
96	RGBAlgorithm::setColors(colors);	×
97	}	×
98
99	RGBAlgorithm::Type RGBPlain::type() const	×
100	{
101	return RGBAlgorithm::Plain;	×
102	}
103
104	int RGBPlain::acceptColors() const	×
105	{
106	return 1; // only start color is accepted	×
107	}
108
109	bool RGBPlain::loadXML(QXmlStreamReader &root)	×
110	{
111	if (root.name() != KXMLQLCRGBAlgorithm)	×
112	{
113	qWarning() << Q_FUNC_INFO << "RGB Algorithm node not found";	×
114	return false;	×
115	}
116
117	if (root.attributes().value(KXMLQLCRGBAlgorithmType).toString() != KXMLQLCRGBPlain)	×
118	{
119	qWarning() << Q_FUNC_INFO << "RGB Algorithm is not Plain";	×
120	return false;	×
121	}
122
123	root.skipCurrentElement();	×
124
125	return true;	×
126	}
127
128	bool RGBPlain::saveXML(QXmlStreamWriter *doc) const	×
129	{
130	Q_ASSERT(doc != NULL);
131
132	doc->writeStartElement(KXMLQLCRGBAlgorithm);	×
133	doc->writeAttribute(KXMLQLCRGBAlgorithmType, KXMLQLCRGBPlain);	×
134	doc->writeEndElement();	×
135
136	return true;	×
137	}

mcallegari / qlcplus / 14790544976

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous