14790544976

Committed 02 May 2025 07:09AM UTC coverage: 31.845% (-0.03%) from 31.87%

Build # 14790544976

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #1742 from shaforostoff/rgbmatrix_memleak

Fix high RAM usage related to RGB scripts

Run Details

6 of 13 new or added lines in 8 files covered. (46.15%)

13 existing lines in 3 files now uncovered.

14675 of 46082 relevant lines covered (31.85%)

26491.26 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

74.65

/engine/src/rgbalgorithm.cpp

/*
  Q Light Controller Plus
  rgbalgorithm.cpp

  Copyright (c) Heikki Junnila
                Massimo Callegari

  Licensed under the Apache License, Version 2.0 (the "License");
  you may not use this file except in compliance with the License.
  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0.txt

  Unless required by applicable law or agreed to in writing, software
  distributed under the License is distributed on an "AS IS" BASIS,
  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  See the License for the specific language governing permissions and
  limitations under the License.
*/

#include <QXmlStreamReader>
#include <QXmlStreamWriter>
#include <QStringList>
#include <QDebug>

#include "rgbscriptscache.h"
#include "rgbalgorithm.h"
#include "rgbaudio.h"
#include "rgbimage.h"
#include "rgbplain.h"
#include "rgbtext.h"
#include "doc.h"

#ifdef QT_QML_LIB
  #include "rgbscriptv4.h"
#else
  #include "rgbscript.h"
#endif

RGBAlgorithm::RGBAlgorithm(Doc * doc)
    : m_doc(doc)
{
}

void RGBAlgorithm::setColors(QVector<QColor> colors)
{
    int nCols = acceptColors();
    m_colors.clear();

    for (int i = 0; i < nCols; i++)
    {
        if (i < colors.count())
            m_colors.append(colors.at(i));
    }
}

QColor RGBAlgorithm::getColor(uint i) const
{
    if (i >= (uint)m_colors.count())
        return QColor();

    return m_colors[i];
}

/****************************************************************************
 * Available algorithms
 ****************************************************************************/

QStringList RGBAlgorithm::algorithms(Doc * doc)
{
    QStringList list;
    RGBPlain plain(doc);
    RGBText text(doc);
    RGBImage image(doc);
    RGBAudio audio(doc);
    list << plain.name();
    list << text.name();
    list << image.name();
    list << audio.name();
    list << doc->rgbScriptsCache()->names();
    return list;
}

RGBAlgorithm* RGBAlgorithm::algorithm(Doc * doc, const QString& name)
{
    RGBText text(doc);
    RGBImage image(doc);
    RGBAudio audio(doc);
    RGBPlain plain(doc);
    if (name == text.name())
        return text.clone();
    else if (name == image.name())
        return image.clone();
    else if (name == audio.name())
        return audio.clone();
    else if (name == plain.name())
        return plain.clone();
    else
        return doc->rgbScriptsCache()->script(name);
}

/****************************************************************************
 * Load & Save
 ****************************************************************************/

RGBAlgorithm* RGBAlgorithm::loader(Doc * doc, QXmlStreamReader &root)
{
    RGBAlgorithm* algo = NULL;

    if (root.name() != KXMLQLCRGBAlgorithm)
    {
        qWarning() << Q_FUNC_INFO << "RGB Algorithm node not found";
        return NULL;
    }

    QString type = root.attributes().value(KXMLQLCRGBAlgorithmType).toString();
    if (type == KXMLQLCRGBImage)
    {
        RGBImage image(doc);
        if (image.loadXML(root) == true)
            algo = image.clone();
    }
    else if (type == KXMLQLCRGBText)
    {
        RGBText text(doc);
        if (text.loadXML(root) == true)
            algo = text.clone();
    }
    else if (type == KXMLQLCRGBAudio)
    {
        RGBAudio audio(doc);
        if (audio.loadXML(root) == true)
            algo = audio.clone();
    }
    else if (type == KXMLQLCRGBScript)
    {
        RGBScript* scr = doc->rgbScriptsCache()->script(root.readElementText());
        if (scr->apiVersion() > 0 && scr->name().isEmpty() == false)
            algo = scr;
        else
            delete scr;
    }
    else if (type == KXMLQLCRGBPlain)
    {
        RGBPlain plain(doc);
        if (plain.loadXML(root) == true)
            algo = plain.clone();
    }
    else
    {
        qWarning() << "Unrecognized RGB algorithm type:" << type;
    }

    return algo;
}

1	/*
2	Q Light Controller Plus
3	rgbalgorithm.cpp
4
5	Copyright (c) Heikki Junnila
6	Massimo Callegari
7
8	Licensed under the Apache License, Version 2.0 (the "License");
9	you may not use this file except in compliance with the License.
10	You may obtain a copy of the License at
11
12	http://www.apache.org/licenses/LICENSE-2.0.txt
13
14	Unless required by applicable law or agreed to in writing, software
15	distributed under the License is distributed on an "AS IS" BASIS,
16	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17	See the License for the specific language governing permissions and
18	limitations under the License.
19	*/
20
21	#include <QXmlStreamReader>
22	#include <QXmlStreamWriter>
23	#include <QStringList>
24	#include <QDebug>
25
26	#include "rgbscriptscache.h"
27	#include "rgbalgorithm.h"
28	#include "rgbaudio.h"
29	#include "rgbimage.h"
30	#include "rgbplain.h"
31	#include "rgbtext.h"
32	#include "doc.h"
33
34	#ifdef QT_QML_LIB
35	#include "rgbscriptv4.h"
36	#else
37	#include "rgbscript.h"
38	#endif
39
40	RGBAlgorithm::RGBAlgorithm(Doc * doc)	191✔
41	: m_doc(doc)	191✔
42	{
43	}	191✔
44
45	void RGBAlgorithm::setColors(QVector<QColor> colors)	17✔
46	{
47	int nCols = acceptColors();	17✔
48	m_colors.clear();	17✔
49
50	for (int i = 0; i < nCols; i++)	54✔
51	{
52	if (i < colors.count())	37✔
53	m_colors.append(colors.at(i));	35✔
54	}
55	}	17✔
56
57	QColor RGBAlgorithm::getColor(uint i) const	3✔
58	{
59	if (i >= (uint)m_colors.count())	3✔
60	return QColor();
61
62	return m_colors[i];	3✔
63	}
64
65	/****************************************************************************
66	* Available algorithms
67	****************************************************************************/
68
69	QStringList RGBAlgorithm::algorithms(Doc * doc)	1✔
70	{
71	QStringList list;
72	RGBPlain plain(doc);	1✔
73	RGBText text(doc);	1✔
74	RGBImage image(doc);	1✔
75	RGBAudio audio(doc);	1✔
76	list << plain.name();	2✔
77	list << text.name();	2✔
78	list << image.name();	2✔
79	list << audio.name();	2✔
80	list << doc->rgbScriptsCache()->names();	1✔
81	return list;	1✔
82	}	1✔
83
84	RGBAlgorithm* RGBAlgorithm::algorithm(Doc * doc, const QString& name)	16✔
85	{
86	RGBText text(doc);	16✔
87	RGBImage image(doc);	16✔
88	RGBAudio audio(doc);	16✔
89	RGBPlain plain(doc);	16✔
90	if (name == text.name())	16✔
91	return text.clone();	1✔
92	else if (name == image.name())	15✔
93	return image.clone();	×
94	else if (name == audio.name())	15✔
95	return audio.clone();	×
96	else if (name == plain.name())	15✔
97	return plain.clone();	×
98	else
99	return doc->rgbScriptsCache()->script(name);	30✔
100	}	16✔
101
102	/****************************************************************************
103	* Load & Save
104	****************************************************************************/
105
106	RGBAlgorithm* RGBAlgorithm::loader(Doc * doc, QXmlStreamReader &root)	5✔
107	{
108	RGBAlgorithm* algo = NULL;
109
110	if (root.name() != KXMLQLCRGBAlgorithm)	10✔
111	{
112	qWarning() << Q_FUNC_INFO << "RGB Algorithm node not found";	2✔
113	return NULL;	2✔
114	}
115
116	QString type = root.attributes().value(KXMLQLCRGBAlgorithmType).toString();	3✔
117	if (type == KXMLQLCRGBImage)	3✔
118	{
119	RGBImage image(doc);	×
120	if (image.loadXML(root) == true)	×
121	algo = image.clone();	×
122	}	×
123	else if (type == KXMLQLCRGBText)	3✔
124	{
125	RGBText text(doc);	1✔
126	if (text.loadXML(root) == true)	1✔
127	algo = text.clone();	1✔
128	}	1✔
129	else if (type == KXMLQLCRGBAudio)	2✔
130	{
131	RGBAudio audio(doc);	×
132	if (audio.loadXML(root) == true)	×
133	algo = audio.clone();	×
134	}	×
135	else if (type == KXMLQLCRGBScript)	2✔
136	{
137	RGBScript* scr = doc->rgbScriptsCache()->script(root.readElementText());	2✔
138	if (scr->apiVersion() > 0 && scr->name().isEmpty() == false)	2✔
139	algo = scr;
140	else
NEW 141	delete scr;	×
142	}
143	else if (type == KXMLQLCRGBPlain)	×
144	{
145	RGBPlain plain(doc);	×
146	if (plain.loadXML(root) == true)	×
147	algo = plain.clone();	×
148	}	×
149	else
150	{
151	qWarning() << "Unrecognized RGB algorithm type:" << type;	×
152	}
153
154	return algo;
155	}	3✔

mcallegari / qlcplus / 14790544976

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous