14766779411

Committed 30 Apr 2025 04:55PM UTC coverage: 72.225% (-0.06%) from 72.282%

Build # 14766779411

Build Type

push

github

Committed by

web-flow

Commit Message

wait-online: handle varlink connection errors while waiting for DNS (#37283)

Currently, if systemd-networkd-wait-online is started with --dns, and
systemd-resolved is not running, it will exit with an error right away.
Similarly, if systemd-resolved is restarted while waiting for DNS
configuration, systemd-networkd-wait-online will not attempt to
re-connect, and will potentially never see subsequent DNS
configurations.

Improve this by adding socket units for the systemd-resolved varlink
servers, and re-establish the connection in systemd-networkd-wait-online
when we receive `SD_VARLINK_ERROR_DISCONNECTED`.

Coverage Stats

8 of 16 new or added lines in 2 files covered. (50.0%)

5825 existing lines in 217 files now uncovered.

297168 of 411450 relevant lines covered (72.22%)

695892.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.0

/src/network/netdev/vrf.c

/* SPDX-License-Identifier: LGPL-2.1-or-later */

#include <linux/if_arp.h>
#include <net/if.h>
#include <netinet/in.h>

#include "vrf.h"

static int netdev_vrf_fill_message_create(NetDev *netdev, Link *link, sd_netlink_message *m) {
        assert(!link);
        assert(m);

        Vrf *v = VRF(netdev);
        int r;

        r = sd_netlink_message_append_u32(m, IFLA_VRF_TABLE, v->table);
        if (r < 0)
                return r;

        return 0;
}

static bool vrf_can_set_mac(NetDev *netdev, const struct hw_addr_data *hw_addr) {
        return true;
}

const NetDevVTable vrf_vtable = {
        .object_size = sizeof(Vrf),
        .sections = NETDEV_COMMON_SECTIONS "VRF\0",
        .fill_message_create = netdev_vrf_fill_message_create,
        .create_type = NETDEV_CREATE_INDEPENDENT,
        .can_set_mac = vrf_can_set_mac,
        .iftype = ARPHRD_ETHER,
        .generate_mac = true,
        .keep_existing = true,
};

1	/* SPDX-License-Identifier: LGPL-2.1-or-later */
2
3	#include <linux/if_arp.h>
4	#include <net/if.h>
5	#include <netinet/in.h>
6
7	#include "vrf.h"
8
9	static int netdev_vrf_fill_message_create(NetDev netdev, Link link, sd_netlink_message *m) {	4✔
10	assert(!link);	4✔
11	assert(m);	4✔
12
13	Vrf *v = VRF(netdev);	4✔
14	int r;	4✔
15
16	r = sd_netlink_message_append_u32(m, IFLA_VRF_TABLE, v->table);	4✔
17	if (r < 0)	4✔
UNCOV 18	return r;	×
19
20	return 0;
21	}
22
UNCOV 23	static bool vrf_can_set_mac(NetDev netdev, const struct hw_addr_data hw_addr) {	×
24	return true;	×
25	}
26
27	const NetDevVTable vrf_vtable = {
28	.object_size = sizeof(Vrf),
29	.sections = NETDEV_COMMON_SECTIONS "VRF\0",
30	.fill_message_create = netdev_vrf_fill_message_create,
31	.create_type = NETDEV_CREATE_INDEPENDENT,
32	.can_set_mac = vrf_can_set_mac,
33	.iftype = ARPHRD_ETHER,
34	.generate_mac = true,
35	.keep_existing = true,
36	};

systemd / systemd / 14766779411

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous