14751702925

Committed 30 Apr 2025 09:47AM UTC coverage: 73.843%. First build

Build # 14751702925

Build Type

Pull #176

github

Committed by

fmenezes

Commit Message

fix: send error as error

Pull Request Pull Request #176: fix: improve api error messages

Run Details

154 of 283 branches covered (54.42%)

Branch coverage included in aggregate %.

10 of 13 new or added lines in 1 file covered. (76.92%)

628 of 776 relevant lines covered (80.93%)

39.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

76.92

/src/common/atlas/apiClientError.ts

import { ApiError } from "./openapi.js";

export class ApiClientError extends Error {
    private constructor(
        message: string,
        public readonly response?: Response,
        public readonly body?: ApiError
    ) {
        super(message);
        this.name = "ApiClientError";
    }

    static async fromResponse(
        response: Response,
        message: string = `error calling Atlas API`
    ): Promise<ApiClientError> {
        let text: string = "";
        let body: ApiError | undefined = undefined;
        try {
            body = (await response.json()) as ApiError;
            text = body.reason || "unknown error";
            if (body.detail && body.detail.length > 0) {
                text = `${text}; ${body.detail}`;
            }
        } catch {
            try {
                text = await response.text();
            } catch {
                text = "";
            }
        }

        if (text.length > 0) {
            text = `${message}: [${response.status} ${response.statusText}] ${text.trim()}`;
        } else {
            text = `${message}: ${response.status} ${response.statusText}`;
        }

        return new ApiClientError(text, response, body);
    }
}

1	import { ApiError } from "./openapi.js";
2
3	export class ApiClientError extends Error {
4	private constructor(
5	message: string,
6	public readonly response?: Response,	1✔
7	public readonly body?: ApiError	1✔
8	) {
9	super(message);	1✔
10	this.name = "ApiClientError";	1✔
11	}
12
13	static async fromResponse(
14	response: Response,
15	message: string = `error calling Atlas API`	1✔
16	): Promise<ApiClientError> {
17	let text: string = "";	1✔
18	let body: ApiError \| undefined = undefined;	1✔
19	try {	1✔
20	body = (await response.json()) as ApiError;	1✔
21	text = body.reason \|\| "unknown error";	1!
22	if (body.detail && body.detail.length > 0) {	1✔
23	text = `${text}; ${body.detail}`;	1✔
24	}
25	} catch {
NEW 26	try {	×
27	text = await response.text();	×
28	} catch {
NEW 29	text = "";	×
30	}
31	}
32
33	if (text.length > 0) {	1!
34	text = `${message}: [${response.status} ${response.statusText}] ${text.trim()}`;	1✔
35	} else {
NEW 36	text = `${message}: ${response.status} ${response.statusText}`;	×
37	}
38
39	return new ApiClientError(text, response, body);	1✔
40	}
41	}

mongodb-js / mongodb-mcp-server / 14751702925

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous