14747615958

Committed 30 Apr 2025 05:46AM UTC coverage: 62.971% (-0.6%) from 63.597%

Build # 14747615958

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #15470 from miodvallat/friday_combing

More low-hanging fruits from the views work

Run Details

40751 of 99124 branches covered (41.11%)

Branch coverage included in aggregate %.

12 of 18 new or added lines in 12 files covered. (66.67%)

397 existing lines in 29 files now uncovered.

125864 of 165466 relevant lines covered (76.07%)

3958772.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

47.55

/pdns/statnode.cc

#include "statnode.hh"

StatNode::Stat StatNode::print(unsigned int depth, Stat newstat, bool silent) const
{
  if(!silent) {
    cout<<string(depth, ' ');
    cout<<name<<": "<<endl;
  }
  Stat childstat;
  childstat.queries += s.queries;
  childstat.noerrors += s.noerrors;
  childstat.nxdomains += s.nxdomains;
  childstat.servfails += s.servfails;
  childstat.drops += s.drops;
  childstat.bytes += s.bytes;
  childstat.hits += s.hits;

  if(children.size()>1024 && !silent) {
    cout<<string(depth, ' ')<<name<<": too many to print"<<endl;
  }
  for(const children_t::value_type& child :  children) {
    childstat=child.second.print(depth+8, childstat, silent || children.size()>1024);
  }
  if(!silent || children.size()>1)
    cout<<string(depth, ' ')<<childstat.queries<<" queries, " << 
      childstat.noerrors<<" noerrors, "<< 
      childstat.nxdomains<<" nxdomains, "<< 
      childstat.servfails<<" servfails, "<< 
      childstat.drops<<" drops, "<<
      childstat.bytes<<" bytes, "<<
      childstat.hits<<" hits"<<endl;

  newstat+=childstat;

  return newstat;
}

void StatNode::visit(const visitor_t& visitor, Stat& newstat, unsigned int depth) const
{
  Stat childstat(s);

  for (const auto& child : children) {
    child.second.visit(visitor, childstat, depth+8);
  }

  visitor(this, s, childstat);

  newstat += childstat;
}

void StatNode::submit(const DNSName& domain, int rcode, unsigned int bytes, bool hit, const std::optional<ComboAddress>& remote)
{
  //  cerr<<"FIRST submit called on '"<<domain<<"'"<<endl;
  std::vector<string> tmp = domain.getRawLabels();
  if (tmp.empty()) {
    return;
  }

  auto last = tmp.end() - 1;
  children[*last].submit(last, tmp.begin(), "", rcode, bytes, remote, 1, hit);
}

/* www.powerdns.com. -> 
   .                 <- fullnames
   com.
   powerdns.com
   www.powerdns.com. 
*/

void StatNode::submit(std::vector<string>::const_iterator end, std::vector<string>::const_iterator begin, const std::string& domain, int rcode, unsigned int bytes, const std::optional<ComboAddress>& remote, unsigned int count, bool hit)
{
  //  cerr<<"Submit called for domain='"<<domain<<"': ";
  //  for(const std::string& n :  labels) 
  //    cerr<<n<<".";
  //  cerr<<endl;
  if (name.empty()) {

    name=*end;
    //    cerr<<"Set short name to '"<<name<<"'"<<endl;
  }
  else {
    //    cerr<<"Short name was already set to '"<<name<<"'"<<endl;
  }

  if (end == begin) {
    if (fullname.empty()) {
      size_t needed = name.size() + 1 + domain.size();
      if (fullname.capacity() < needed) {
        fullname.reserve(needed);
      }
      fullname = name;
      fullname.append(".");
      fullname.append(domain);
      labelsCount = count;
    }
    //    cerr<<"Hit the end, set our fullname to '"<<fullname<<"'"<<endl<<endl;
    s.queries++;
    s.bytes += bytes;
    if (rcode < 0) {
      s.drops++;
    }
    else if (rcode == RCode::NoError) {
      s.noerrors++;
    }
    else if (rcode == RCode::ServFail) {
      s.servfails++;
    }
    else if (rcode == RCode::NXDomain) {
      s.nxdomains++;
    }

    if (remote) {
      s.remotes[*remote]++;
    }

    if (hit) {
      ++s.hits;
    }
  }
  else {
    if (fullname.empty()) {
      size_t needed = name.size() + 1 + domain.size();
      if (fullname.capacity() < needed) {
        fullname.reserve(needed);
      }
      fullname = name;
      fullname.append(".");
      fullname.append(domain);
      labelsCount = count;
    }
    //    cerr<<"Not yet end, set our fullname to '"<<fullname<<"', recursing"<<endl;
    --end;
    children[*end].submit(end, begin, fullname, rcode, bytes, remote, count+1, hit);
  }
}

1	#include "statnode.hh"
2
3	StatNode::Stat StatNode::print(unsigned int depth, Stat newstat, bool silent) const
4	{	×
5	if(!silent) {	×
6	cout<<string(depth, ' ');	×
7	cout<<name<<": "<<endl;	×
8	}	×
9	Stat childstat;	×
10	childstat.queries += s.queries;	×
11	childstat.noerrors += s.noerrors;	×
12	childstat.nxdomains += s.nxdomains;	×
13	childstat.servfails += s.servfails;	×
14	childstat.drops += s.drops;	×
15	childstat.bytes += s.bytes;	×
16	childstat.hits += s.hits;	×
17
18	if(children.size()>1024 && !silent) {	×
19	cout<<string(depth, ' ')<<name<<": too many to print"<<endl;	×
20	}	×
21	for(const children_t::value_type& child : children) {	×
22	childstat=child.second.print(depth+8, childstat, silent \|\| children.size()>1024);	×
23	}	×
24	if(!silent \|\| children.size()>1)	×
25	cout<<string(depth, ' ')<<childstat.queries<<" queries, " <<	×
26	childstat.noerrors<<" noerrors, "<<	×
27	childstat.nxdomains<<" nxdomains, "<<	×
28	childstat.servfails<<" servfails, "<<	×
29	childstat.drops<<" drops, "<<	×
30	childstat.bytes<<" bytes, "<<	×
31	childstat.hits<<" hits"<<endl;	×
32
33	newstat+=childstat;	×
34
35	return newstat;	×
36	}	×
37
38	void StatNode::visit(const visitor_t& visitor, Stat& newstat, unsigned int depth) const
39	{	25✔
40	Stat childstat(s);	25✔
41
42	for (const auto& child : children) {	25✔
43	child.second.visit(visitor, childstat, depth+8);	20✔
44	}	20✔
45
46	visitor(this, s, childstat);	25✔
47
48	newstat += childstat;	25✔
49	}	25✔
50
51	void StatNode::submit(const DNSName& domain, int rcode, unsigned int bytes, bool hit, const std::optional<ComboAddress>& remote)
52	{	4✔
53	// cerr<<"FIRST submit called on '"<<domain<<"'"<<endl;
54	std::vector<string> tmp = domain.getRawLabels();	4✔
55	if (tmp.empty()) {	4!
56	return;	×
57	}	×
58
59	auto last = tmp.end() - 1;	4✔
60	children[*last].submit(last, tmp.begin(), "", rcode, bytes, remote, 1, hit);	4✔
61	}	4✔
62
63	/* www.powerdns.com. ->
64	. <- fullnames
65	com.
66	powerdns.com
67	www.powerdns.com.
68	*/
69
70	void StatNode::submit(std::vector<string>::const_iterator end, std::vector<string>::const_iterator begin, const std::string& domain, int rcode, unsigned int bytes, const std::optional<ComboAddress>& remote, unsigned int count, bool hit)
71	{	20✔
72	// cerr<<"Submit called for domain='"<<domain<<"': ";
73	// for(const std::string& n : labels)
74	// cerr<<n<<".";
75	// cerr<<endl;
76	if (name.empty()) {	20!
77
78	name=*end;	20✔
79	// cerr<<"Set short name to '"<<name<<"'"<<endl;
80	}	20✔
UNCOV 81	else {	×
82	// cerr<<"Short name was already set to '"<<name<<"'"<<endl;
UNCOV 83	}	×
84
85	if (end == begin) {	20✔
86	if (fullname.empty()) {	4!
87	size_t needed = name.size() + 1 + domain.size();	4✔
88	if (fullname.capacity() < needed) {	4!
89	fullname.reserve(needed);	4✔
90	}	4✔
91	fullname = name;	4✔
92	fullname.append(".");	4✔
93	fullname.append(domain);	4✔
94	labelsCount = count;	4✔
95	}	4✔
96	// cerr<<"Hit the end, set our fullname to '"<<fullname<<"'"<<endl<<endl;
97	s.queries++;	4✔
98	s.bytes += bytes;	4✔
99	if (rcode < 0) {	4!
100	s.drops++;	×
101	}	×
102	else if (rcode == RCode::NoError) {	4!
103	s.noerrors++;	4✔
104	}	4✔
105	else if (rcode == RCode::ServFail) {	×
106	s.servfails++;	×
107	}	×
108	else if (rcode == RCode::NXDomain) {	×
109	s.nxdomains++;	×
110	}	×
111
112	if (remote) {	4!
113	s.remotes[*remote]++;	×
114	}	×
115
116	if (hit) {	4!
117	++s.hits;	×
118	}	×
119	}	4✔
120	else {	16✔
121	if (fullname.empty()) {	16!
122	size_t needed = name.size() + 1 + domain.size();	16✔
123	if (fullname.capacity() < needed) {	16✔
124	fullname.reserve(needed);	8✔
125	}	8✔
126	fullname = name;	16✔
127	fullname.append(".");	16✔
128	fullname.append(domain);	16✔
129	labelsCount = count;	16✔
130	}	16✔
131	// cerr<<"Not yet end, set our fullname to '"<<fullname<<"', recursing"<<endl;
132	--end;	16✔
133	children[*end].submit(end, begin, fullname, rcode, bytes, remote, count+1, hit);	16✔
134	}	16✔
135	}	20✔

PowerDNS / pdns / 14747615958

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous