• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gcivil-nyu-org / team4-wed-spring25 / 639

23 Apr 2025 09:22PM UTC coverage: 93.493% (+0.6%) from 92.93%
639

push

travis-pro

web-flow
Merge pull request #303 from gcivil-nyu-org/develop

Develop to main

322 of 331 new or added lines in 9 files covered. (97.28%)

1 existing line in 1 file now uncovered.

1681 of 1798 relevant lines covered (93.49%)

0.93 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

78.04
/parks/views.py
1
from django.shortcuts import render
1✔
2
from django.shortcuts import get_object_or_404
1✔
3
from django.shortcuts import redirect
1✔
4
from django.http import (  # noqa: F401  # Ignore "imported but unused"
1✔
5
    HttpResponseForbidden,
6
    HttpResponse,
7
    JsonResponse,
8
    HttpResponsePermanentRedirect,
9
)
10
from django.urls import reverse  # noqa: F401  # Ignore "imported but unused"
1✔
11
from django.db.models import OuterRef, Subquery, CharField, Q, Avg, Count, Prefetch
1✔
12
from django.db.models.functions import Cast
1✔
13
from .models import (
1✔
14
    DogRunNew,
15
    Review,
16
    ParkImage,
17
    ReviewReport,
18
    ImageReport,
19
    ParkPresence,
20
    Reply,
21
    ReplyReport,
22
)
23
from django.forms.models import model_to_dict
1✔
24
from django.contrib.auth.decorators import login_required
1✔
25

26
import json
1✔
27
import datetime
1✔
28
from django.contrib import messages
1✔
29
from django.utils import timezone
1✔
30
from django.utils.timezone import now, localtime
1✔
31
from django.views.decorators.http import require_POST
1✔
32
from django.views.decorators.cache import never_cache
1✔
33
from datetime import timedelta
1✔
34

35
from django.contrib.auth.models import User
1✔
36
from .models import Message
1✔
37
from collections import defaultdict
1✔
38

39

40
@login_required
1✔
41
def chat_view(request, username):
1✔
42
    recipient = get_object_or_404(User, username=username)
1✔
43
    messages = Message.objects.filter(
1✔
44
        sender__in=[request.user, recipient], recipient__in=[request.user, recipient]
45
    )
46
    if request.method == "POST":
1✔
47
        content = request.POST.get("content")
1✔
48
        if content:
1✔
49
            Message.objects.create(
1✔
50
                sender=request.user, recipient=recipient, content=content
51
            )
52
            return redirect("chat_view", username=username)
1✔
53
    return render(
1✔
54
        request, "parks/chat.html", {"recipient": recipient, "messages": messages}
55
    )
56

57

58
@login_required
1✔
59
def all_messages_view(request):
1✔
60
    user = request.user
1✔
61
    # Get all messages involving the user, either sent or received
62
    messages = (
1✔
63
        Message.objects.filter(Q(sender=user) | Q(recipient=user))
64
        .select_related("sender", "recipient")
65
        .order_by("-timestamp")
66
    )
67

68
    # Group by the *other* user
69
    grouped = defaultdict(list)
1✔
70
    for msg in messages:
1✔
71
        other_user = msg.recipient if msg.sender == user else msg.sender
1✔
72
        grouped[other_user.username].append(msg)
1✔
73

74
    return render(
1✔
75
        request, "parks/all_messages.html", {"grouped_messages": dict(grouped)}
76
    )
77

78

79
@login_required
1✔
80
def delete_conversation(request, sender_username):
1✔
81
    # Get the recipient user object (the sender of the conversation)
82
    recipient = get_object_or_404(User, username=sender_username)
1✔
83

84
    # Delete messages where the user is either the sender or recipient
85
    Message.objects.filter(
1✔
86
        sender__in=[request.user, recipient], recipient__in=[request.user, recipient]
87
    ).delete()
88

89
    # Redirect to the all messages view after deleting the conversation
90
    return redirect("all_messages")
1✔
91

92

93
@login_required
1✔
94
@require_POST
1✔
95
def checkin_view(request):
1✔
96
    data = json.loads(request.body)
×
97
    park_id = data.get("park_id")
×
98
    park = get_object_or_404(DogRunNew, id=park_id)
×
99

100
    # Remove existing 'current' check-ins from other parks
101
    ParkPresence.objects.filter(user=request.user, status="current").exclude(
×
102
        park=park
103
    ).delete()
104

105
    # Check in to this park
106
    presence, created = ParkPresence.objects.update_or_create(
×
107
        user=request.user,
108
        park=park,
109
        defaults={"status": "current", "time": timezone.now()},
110
    )
111

112
    return JsonResponse({"status": "checked in", "new": created})
×
113

114

115
@login_required
1✔
116
@require_POST
1✔
117
def bethere_view(request):
1✔
118
    try:
×
119
        data = json.loads(request.body)
×
120
        park_id = data.get("park_id")
×
121
        time_str = data.get("time")  # e.g. "17:30"
×
122

123
        if not park_id or not time_str:
×
124
            return JsonResponse({"error": "Missing park_id or time"}, status=400)
×
125

126
        # Parse and validate time
127
        try:
×
128
            arrival_time = datetime.datetime.strptime(time_str, "%H:%M").time()
×
129
        except ValueError:
×
130
            return JsonResponse({"error": "Invalid time format"}, status=400)
×
131

132
        current_datetime = now()
×
133
        today = current_datetime.date()
×
134
        arrival_datetime = timezone.make_aware(
×
135
            datetime.datetime.combine(today, arrival_time)
136
        )
137

138
        if arrival_datetime < current_datetime:
×
139
            return JsonResponse({"error": "Cannot select a past time"}, status=400)
×
140

141
        park = get_object_or_404(DogRunNew, id=park_id)
×
142

143
        # ✅ Save the full datetime, not just the time
144
        presence, created = ParkPresence.objects.update_or_create(
×
145
            user=request.user,
146
            park=park,
147
            defaults={"status": "On their way", "time": arrival_datetime},
148
        )
149

150
        formatted_time = arrival_datetime.strftime("%I:%M %p")
×
151
        return JsonResponse({"status": "on their way", "time": formatted_time})
×
152

153
    except Exception as e:
154
        import traceback
155

156
        print(traceback.format_exc())
157
        return JsonResponse({"error": str(e)}, status=500)
158

159

160
def expire_old_checkins():
1✔
161
    expiration_time = timezone.now() - timedelta(hours=1)
1✔
162
    ParkPresence.objects.filter(status="current", time__lt=expiration_time).delete()
1✔
163

164

165
def home_view(request):
1✔
UNCOV
166
    return render(request, "parks/home.html")
×
167

168

169
@never_cache
1✔
170
def park_and_map(request):
1✔
171
    # Get filter values from GET request
172
    query = request.GET.get("query", "").strip()
1✔
173
    filter_value = request.GET.get("filter", "").strip()
1✔
174
    accessible_value = request.GET.get("accessible", "").strip()
1✔
175
    borough_value = request.GET.get("borough", "").strip().upper()
1✔
176

177
    thumbnail = ParkImage.objects.filter(
1✔
178
        park_id=OuterRef("pk"), is_removed=False, review__is_removed=False
179
    ).values("image")[:1]
180

181
    # Fetch all dog runs from the database
182
    parks = (
1✔
183
        DogRunNew.objects.all()
184
        .order_by("id")
185
        .prefetch_related("images")
186
        .annotate(
187
            thumbnail_url=Cast(Subquery(thumbnail), output_field=CharField()),
188
            average_rating=Avg("reviews__rating", filter=Q(reviews__is_removed=False)),
189
            review_count=Count("reviews", filter=Q(reviews__is_removed=False)),
190
        )
191
    )
192

193
    # Search by ZIP, name, or Google name
194
    if query:
1✔
195
        parks = parks.filter(
×
196
            Q(name__icontains=query)
197
            | Q(google_name__icontains=query)
198
            | Q(zip_code__icontains=query)
199
        )
200

201
    # Filter by park type (e.g., "Off-Leash")
202
    if filter_value:
1✔
203
        parks = parks.filter(dogruns_type__iexact=filter_value)
×
204

205
    # Filter by accessibility only if explicitly set to "True" or "False"
206
    if accessible_value == "True":
1✔
207
        parks = parks.filter(accessible=True)
×
208
    elif accessible_value == "False":
1✔
209
        parks = parks.filter(accessible=False)
×
210

211
    if borough_value:
1✔
212
        parks = parks.filter(borough=borough_value)
1✔
213

214
    # Convert parks to JSON (for JS use)
215
    # parks_json = json.dumps(list(parks.values()))
216

217
    parks_json = json.dumps(
1✔
218
        [
219
            {
220
                **model_to_dict(park),
221
                "thumbnail_url": park.thumbnail_url,
222
                "average_rating": park.average_rating,
223
                "review_count": park.review_count,
224
                "url": park.detail_page_url(),
225
            }
226
            for park in parks
227
        ]
228
    )
229

230
    # Render the template
231
    return render(
1✔
232
        request,
233
        "parks/combined_view.html",
234
        {
235
            "parks": parks,
236
            "parks_json": parks_json,
237
            "query": query,
238
            "selected_type": filter_value,
239
            "selected_accessible": accessible_value,
240
            "selected_borough": borough_value,
241
        },
242
    )
243

244

245
@never_cache
1✔
246
def park_detail(request, slug, id):
1✔
247
    park = get_object_or_404(DogRunNew, id=id)
1✔
248
    if slug != park.slug:
1✔
249
        return HttpResponsePermanentRedirect(park.detail_page_url())
1✔
250

251
    images = ParkImage.objects.filter(
1✔
252
        park=park, is_removed=False, review__is_removed=False
253
    )
254

255
    # Prefetch only non-removed images for each review
256
    visible_images = Prefetch(
1✔
257
        "images",
258
        queryset=ParkImage.objects.filter(is_removed=False),
259
        to_attr="visible_images",
260
    )
261
    reviews = park.reviews.filter(is_removed=False).prefetch_related(
1✔
262
        visible_images, "replies__user__userprofile", "user__userprofile"  # load avatar
263
    )
264
    reviews = park.reviews.filter(is_removed=False).prefetch_related(visible_images)
1✔
265

266
    average_rating = reviews.aggregate(Avg("rating"))["rating__avg"]
1✔
267

268
    # Clean up expired "On their way" entries
269
    now = localtime()
1✔
270
    # Call the function to expire old check-ins
271
    expire_old_checkins()
1✔
272

273
    ParkPresence.objects.filter(park=park, status="On their way", time__lt=now).delete()
1✔
274

275
    # Updated counts after cleanup
276
    current_count = ParkPresence.objects.filter(park=park, status="current").count()
1✔
277
    on_the_way_count = ParkPresence.objects.filter(
1✔
278
        park=park, status="On their way", time__isnull=False, time__gte=now
279
    ).count()
280

281
    if request.user.is_authenticated and request.method == "POST":
1✔
282
        form_type = request.POST.get("form_type")
1✔
283

284
        if form_type == "submit_review":
1✔
285
            review_text = request.POST.get("text", "").strip()
1✔
286
            rating_value = request.POST.get("rating", "").strip()
1✔
287

288
            if not rating_value.isdigit():
1✔
289
                messages.error(request, "Please select a rating before submitting.")
×
290
                return redirect(park.detail_page_url())
×
291

292
            rating = int(rating_value)
1✔
293
            if rating < 1 or rating > 5:
1✔
294
                return render(
×
295
                    request,
296
                    "parks/park_detail.html",
297
                    {
298
                        "park": park,
299
                        "images": images,
300
                        "reviews": reviews,
301
                        "error_message": "Rating must be between 1 and 5 stars!",
302
                        "average_rating": average_rating,
303
                        "current_count": current_count,
304
                        "on_the_way_count": on_the_way_count,
305
                    },
306
                )
307

308
            review = Review.objects.create(
1✔
309
                park=park,
310
                text=review_text if review_text else "",
311
                rating=rating,
312
                user=request.user,
313
            )
314
            images = request.FILES.getlist("images")
1✔
315
            ALLOWED_IMAGE_TYPES = ["image/jpeg", "image/png", "image/webp"]
1✔
316

317
            invalid_type = any(
1✔
318
                img.content_type not in ALLOWED_IMAGE_TYPES for img in images
319
            )
320

321
            if invalid_type:
1✔
322
                messages.error(request, "Only JPEG, PNG, or WebP images are allowed.")
×
323
                review.delete()
×
324
                return redirect("park_detail", slug=park.slug, id=park.id)
×
325

326
            MAX_IMAGE_SIZE = 5 * 1024 * 1024  # 5 MB
1✔
327

328
            invalid_images = [img for img in images if img.size > MAX_IMAGE_SIZE]
1✔
329

330
            if invalid_images:
1✔
331
                messages.error(request, "Each image must be under 5 MB.")
×
332
                review.delete()
×
333
                return redirect("park_detail", slug=park.slug, id=park.id)
×
334

335
            # Save valid images
336
            for image in images:
1✔
337
                ParkImage.objects.create(
1✔
338
                    park=park, image=image, review=review, user=request.user
339
                )
340

341
            messages.success(request, "Your review was submitted successfully!")
1✔
342
            return redirect(park.detail_page_url())
1✔
343

344
        elif form_type == "check_in":
1✔
345
            ParkPresence.objects.create(
1✔
346
                user=request.user,
347
                park=park,
348
                status="current",
349
                time=now,
350
            )
351

352
        elif form_type == "be_there_at":
1✔
353
            time_str = request.POST.get("time")
1✔
354
            try:
1✔
355
                arrival_time = timezone.datetime.combine(
1✔
356
                    now.date(), timezone.datetime.strptime(time_str, "%H:%M").time()
357
                )
358
                arrival_time = timezone.make_aware(
1✔
359
                    arrival_time
360
                )  # Make it timezone aware
361
            except (ValueError, TypeError):
×
362
                arrival_time = None
×
363

364
            if arrival_time and arrival_time >= now:
1✔
365
                ParkPresence.objects.create(
1✔
366
                    user=request.user,
367
                    park=park,
368
                    status="on_the_way",
369
                    time=arrival_time,
370
                )
371
        # report reviews
372
        elif form_type == "report_review":
1✔
373
            if request.user.is_authenticated:
1✔
374
                review_id = request.POST.get("review_id")
1✔
375
                reason = request.POST.get("reason", "").strip()
1✔
376

377
                if review_id and reason:
1✔
378
                    review = get_object_or_404(Review, id=review_id)
1✔
379

380
                    # prevent duplicate reports by the same user
381
                    exists = ReviewReport.objects.filter(
1✔
382
                        review=review, reported_by=request.user
383
                    ).exists()
384

385
                    if exists:
1✔
386
                        messages.error(
1✔
387
                            request, "You have already reported this review before."
388
                        )
389
                    else:
390
                        ReviewReport.objects.create(
1✔
391
                            review=review, reported_by=request.user, reason=reason
392
                        )
393
                        messages.success(
1✔
394
                            request, "Your review report was submitted successfully."
395
                        )
396
            else:
397
                messages.error(request, "You must be logged in to report a review.")
×
398

399
            return redirect(park.detail_page_url())
1✔
400

401
        elif form_type == "submit_reply":
1✔
402
            if request.user.is_authenticated:
1✔
403
                parent_review_id = request.POST.get("parent_review_id")
1✔
404
                reply_text = request.POST.get("reply_text", "").strip()
1✔
405
                parent_reply_id = request.POST.get("parent_reply_id")
1✔
406

407
                if parent_review_id and reply_text:
1✔
408
                    parent_review = get_object_or_404(Review, id=parent_review_id)
1✔
409

410
                    parent_reply = None
1✔
411
                    if parent_reply_id:
1✔
412
                        try:
1✔
413
                            parent_reply = Reply.objects.get(id=parent_reply_id)
1✔
414
                        except Reply.DoesNotExist:
1✔
415
                            parent_reply = None  # fallback: just attach to review
1✔
416

417
                    Reply.objects.create(
1✔
418
                        review=parent_review,
419
                        user=request.user,
420
                        text=reply_text,
421
                        parent_reply=parent_reply,
422
                    )
423

424
                    messages.success(request, "Reply submitted successfully!")
1✔
425
        return redirect(park.detail_page_url())
1✔
426

427
    park_json = json.dumps(model_to_dict(park))
1✔
428

429
    return render(
1✔
430
        request,
431
        "parks/park_detail.html",
432
        {
433
            "park": park,
434
            "images": images,
435
            "reviews": reviews,
436
            "park_json": park_json,
437
            "average_rating": average_rating,
438
            "current_count": current_count,
439
            "on_the_way_count": on_the_way_count,
440
        },
441
    )
442

443

444
def try_hard_delete_review_if_all_replies_deleted(review):
1✔
445
    if review.is_deleted and not review.replies.filter(is_deleted=False).exists():
1✔
446
        ParkImage.objects.filter(review=review).delete()
×
447
        review.delete()
×
448

449

450
@login_required
1✔
451
def delete_review(request, review_id):
1✔
452
    review = get_object_or_404(Review, id=review_id)
1✔
453

454
    # Ensure the current user owns the review
455
    if request.user != review.user:
1✔
456
        return HttpResponseForbidden("You are not allowed to delete this review.")
×
457

458
    # If there are any non-deleted replies, perform soft-delete
459
    if review.replies.filter(is_deleted=False).exists():
1✔
460
        review.is_deleted = True
×
461
        review.text = ""
×
462
        review.save()
×
463
    else:
464
        # Delete associated images (if any), then delete the review
465
        review.images.all().delete()
1✔
466
        review.delete()
1✔
467

468
    messages.success(request, "You have successfully deleted the review!")
1✔
469
    return redirect(review.park.detail_page_url())
1✔
470

471

472
@login_required
1✔
473
def delete_image(request, image_id):
1✔
474
    image = get_object_or_404(ParkImage, id=image_id)
1✔
475
    if image.user == request.user:
1✔
476
        image.delete()
1✔
477
        messages.success(request, "You have successfully deleted the image!")
1✔
478
        return redirect(image.park.detail_page_url())
1✔
479
    return HttpResponseForbidden("You are not allowed to delete this image.")
×
480

481

482
def contact_view(request):
1✔
483
    return render(request, "parks/contact.html")
×
484

485

486
@login_required
1✔
487
def report_image(request, image_id):
1✔
488
    image = get_object_or_404(ParkImage, id=image_id)
1✔
489

490
    if request.method == "POST":
1✔
491
        reason = request.POST.get("reason", "").strip()
1✔
492
        if reason:
1✔
493
            # Check if this user already reported this image
494
            already_reported = ImageReport.objects.filter(
1✔
495
                user=request.user, image=image
496
            ).exists()
497
            if already_reported:
1✔
498
                messages.error(request, "You have already reported this image before.")
1✔
499
            else:
500
                ImageReport.objects.create(
1✔
501
                    user=request.user, image=image, reason=reason
502
                )
503
                messages.success(request, "You have successfully reported the image!")
1✔
504
        return redirect(image.park.detail_page_url())
1✔
505

506
    return redirect(image.park.detail_page_url())
×
507

508

509
@login_required
1✔
510
def delete_reply(request, reply_id):
1✔
511
    reply = get_object_or_404(Reply, id=reply_id)
1✔
512

513
    if reply.user != request.user:
1✔
514
        messages.error(request, "You can only delete your own replies.")
1✔
515
        return redirect(request.META.get("HTTP_REFERER", "/"))
1✔
516

517
    if reply.children.filter(is_deleted=False).exists():
1✔
518
        # Soft-delete: mark deleted, clear text
519
        reply.is_deleted = True
×
520
        reply.text = ""
×
521
        reply.save()
×
522
    else:
523
        reply.delete()
1✔
524

525
    messages.success(request, "Reply deleted successfully.")
1✔
526
    # check & hard delete
527
    try_hard_delete_review_if_all_replies_deleted(reply.review)
1✔
528
    return redirect(request.META.get("HTTP_REFERER", "/"))
1✔
529

530

531
@login_required
1✔
532
def report_reply(request, reply_id):
1✔
533
    if request.method == "POST":
1✔
534
        reason = request.POST.get("reason", "").strip()
1✔
535
        reply = get_object_or_404(Reply, id=reply_id)
1✔
536
        if reply.user != request.user and reason:
1✔
537
            ReplyReport.objects.create(reply=reply, user=request.user, reason=reason)
1✔
538
            messages.success(request, "Reply reported successfully.")
1✔
539
        else:
540
            messages.error(request, "You cannot report your own reply.")
1✔
541
    return redirect(request.META.get("HTTP_REFERER", "/"))
1✔
542

543

544
def custom_500_view(request):
1✔
NEW
545
    return render(request, "500.html", status=500)
×
546

547

548
def trigger_500(request):
1✔
NEW
549
    raise Exception("Simulated 500 error")
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc