• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

kubeovn / kube-ovn / 14547474456

19 Apr 2025 08:37AM UTC coverage: 21.73% (-0.007%) from 21.737%
14547474456

push

github

web-flow
modernize: simplify code by using modern constructs (#5163)

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

87 of 376 new or added lines in 94 files covered. (23.14%)

1 existing line in 1 file now uncovered.

10251 of 47175 relevant lines covered (21.73%)

0.25 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/pkg/daemon/controller_linux.go
1
package daemon
2

3
import (
4
        "errors"
5
        "fmt"
6
        "net"
7
        "os"
8
        "os/exec"
9
        "path/filepath"
10
        "reflect"
11
        "slices"
12
        "strings"
13
        "syscall"
14

15
        ovsutil "github.com/digitalocean/go-openvswitch/ovs"
16
        nadutils "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/utils"
17
        "github.com/kubeovn/felix/ipsets"
18
        "github.com/kubeovn/go-iptables/iptables"
19
        "github.com/vishvananda/netlink"
20
        "golang.org/x/sys/unix"
21
        v1 "k8s.io/api/core/v1"
22
        k8serrors "k8s.io/apimachinery/pkg/api/errors"
23
        "k8s.io/apimachinery/pkg/labels"
24
        utilruntime "k8s.io/apimachinery/pkg/util/runtime"
25
        "k8s.io/client-go/tools/cache"
26
        "k8s.io/klog/v2"
27
        k8sipset "k8s.io/kubernetes/pkg/proxy/ipvs/ipset"
28
        k8siptables "k8s.io/kubernetes/pkg/util/iptables"
29

30
        kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
31
        "github.com/kubeovn/kube-ovn/pkg/ovs"
32
        "github.com/kubeovn/kube-ovn/pkg/util"
33
)
34

35
const (
36
        kernelModuleIPTables  = "ip_tables"
37
        kernelModuleIP6Tables = "ip6_tables"
38
)
39

40
// ControllerRuntime represents runtime specific controller members
41
type ControllerRuntime struct {
42
        iptables         map[string]*iptables.IPTables
43
        iptablesObsolete map[string]*iptables.IPTables
44
        k8siptables      map[string]k8siptables.Interface
45
        k8sipsets        k8sipset.Interface
46
        ipsets           map[string]*ipsets.IPSets
47
        gwCounters       map[string]*util.GwIPtableCounters
48

49
        nmSyncer  *networkManagerSyncer
50
        ovsClient *ovsutil.Client
51
}
52

53
type LbServiceRules struct {
54
        IP          string
55
        Port        uint16
56
        Protocol    string
57
        BridgeName  string
58
        DstMac      string
59
        UnderlayNic string
60
}
61

62
func evalCommandSymlinks(cmd string) (string, error) {
×
63
        path, err := exec.LookPath(cmd)
×
64
        if err != nil {
×
65
                return "", fmt.Errorf("failed to search for command %q: %w", cmd, err)
×
66
        }
×
67
        file, err := filepath.EvalSymlinks(path)
×
68
        if err != nil {
×
69
                return "", fmt.Errorf("failed to read evaluate symbolic links for file %q: %w", path, err)
×
70
        }
×
71

72
        return file, nil
×
73
}
74

75
func isLegacyIptablesMode() (bool, error) {
×
76
        path, err := evalCommandSymlinks("iptables")
×
77
        if err != nil {
×
78
                return false, err
×
79
        }
×
80
        pathLegacy, err := evalCommandSymlinks("iptables-legacy")
×
81
        if err != nil {
×
82
                return false, err
×
83
        }
×
84
        return path == pathLegacy, nil
×
85
}
86

87
func (c *Controller) initRuntime() error {
×
88
        ok, err := isLegacyIptablesMode()
×
89
        if err != nil {
×
90
                klog.Errorf("failed to check iptables mode: %v", err)
×
91
                return err
×
92
        }
×
93
        if !ok {
×
94
                // iptables works in nft mode, we should migrate iptables rules
×
95
                c.iptablesObsolete = make(map[string]*iptables.IPTables, 2)
×
96
        }
×
97

98
        c.iptables = make(map[string]*iptables.IPTables)
×
99
        c.ipsets = make(map[string]*ipsets.IPSets)
×
100
        c.gwCounters = make(map[string]*util.GwIPtableCounters)
×
101
        c.k8siptables = make(map[string]k8siptables.Interface)
×
102
        c.k8sipsets = k8sipset.New(c.k8sExec)
×
103
        c.ovsClient = ovsutil.New()
×
104

×
105
        if c.protocol == kubeovnv1.ProtocolIPv4 || c.protocol == kubeovnv1.ProtocolDual {
×
106
                ipt, err := iptables.NewWithProtocol(iptables.ProtocolIPv4)
×
107
                if err != nil {
×
108
                        klog.Error(err)
×
109
                        return err
×
110
                }
×
111
                c.iptables[kubeovnv1.ProtocolIPv4] = ipt
×
112
                if c.iptablesObsolete != nil {
×
113
                        ok, err := kernelModuleLoaded(kernelModuleIPTables)
×
114
                        if err != nil {
×
115
                                klog.Errorf("failed to check kernel module %s: %v", kernelModuleIPTables, err)
×
116
                        }
×
117
                        if ok {
×
118
                                if ipt, err = iptables.NewWithProtocolAndMode(iptables.ProtocolIPv4, "legacy"); err != nil {
×
119
                                        klog.Error(err)
×
120
                                        return err
×
121
                                }
×
122
                                c.iptablesObsolete[kubeovnv1.ProtocolIPv4] = ipt
×
123
                        }
124
                }
125
                c.ipsets[kubeovnv1.ProtocolIPv4] = ipsets.NewIPSets(ipsets.NewIPVersionConfig(ipsets.IPFamilyV4, IPSetPrefix, nil, nil))
×
126
                c.k8siptables[kubeovnv1.ProtocolIPv4] = k8siptables.New(c.k8sExec, k8siptables.ProtocolIPv4)
×
127
        }
128
        if c.protocol == kubeovnv1.ProtocolIPv6 || c.protocol == kubeovnv1.ProtocolDual {
×
129
                ipt, err := iptables.NewWithProtocol(iptables.ProtocolIPv6)
×
130
                if err != nil {
×
131
                        klog.Error(err)
×
132
                        return err
×
133
                }
×
134
                c.iptables[kubeovnv1.ProtocolIPv6] = ipt
×
135
                if c.iptablesObsolete != nil {
×
136
                        ok, err := kernelModuleLoaded(kernelModuleIP6Tables)
×
137
                        if err != nil {
×
138
                                klog.Errorf("failed to check kernel module %s: %v", kernelModuleIP6Tables, err)
×
139
                        }
×
140
                        if ok {
×
141
                                if ipt, err = iptables.NewWithProtocolAndMode(iptables.ProtocolIPv6, "legacy"); err != nil {
×
142
                                        klog.Error(err)
×
143
                                        return err
×
144
                                }
×
145
                                c.iptablesObsolete[kubeovnv1.ProtocolIPv6] = ipt
×
146
                        }
147
                }
148
                c.ipsets[kubeovnv1.ProtocolIPv6] = ipsets.NewIPSets(ipsets.NewIPVersionConfig(ipsets.IPFamilyV6, IPSetPrefix, nil, nil))
×
149
                c.k8siptables[kubeovnv1.ProtocolIPv6] = k8siptables.New(c.k8sExec, k8siptables.ProtocolIPv6)
×
150
        }
151

152
        c.nmSyncer = newNetworkManagerSyncer()
×
153
        c.nmSyncer.Run(c.transferAddrsAndRoutes)
×
154

×
155
        return nil
×
156
}
157

158
func (c *Controller) handleEnableExternalLBAddressChange(oldSubnet, newSubnet *kubeovnv1.Subnet) error {
×
159
        var subnetName string
×
160
        var action string
×
161

×
162
        switch {
×
163
        case oldSubnet != nil && newSubnet != nil:
×
164
                subnetName = oldSubnet.Name
×
165
                if oldSubnet.Spec.EnableExternalLBAddress != newSubnet.Spec.EnableExternalLBAddress {
×
166
                        klog.Infof("EnableExternalLBAddress changed for subnet %s", newSubnet.Name)
×
167
                        if newSubnet.Spec.EnableExternalLBAddress {
×
168
                                action = "add"
×
169
                        } else {
×
170
                                action = "remove"
×
171
                        }
×
172
                }
173
        case oldSubnet != nil:
×
174
                subnetName = oldSubnet.Name
×
175
                if oldSubnet.Spec.EnableExternalLBAddress {
×
176
                        klog.Infof("EnableExternalLBAddress removed for subnet %s", oldSubnet.Name)
×
177
                        action = "remove"
×
178
                }
×
179
        case newSubnet != nil:
×
180
                subnetName = newSubnet.Name
×
181
                if newSubnet.Spec.EnableExternalLBAddress {
×
182
                        klog.Infof("EnableExternalLBAddress added for subnet %s", newSubnet.Name)
×
183
                        action = "add"
×
184
                }
×
185
        }
186

187
        if action != "" {
×
188
                services, err := c.servicesLister.List(labels.Everything())
×
189
                if err != nil {
×
190
                        klog.Errorf("failed to list services: %v", err)
×
191
                        return err
×
192
                }
×
193

194
                for _, svc := range services {
×
195
                        if svc.Annotations[util.ServiceExternalIPFromSubnetAnnotation] == subnetName {
×
196
                                klog.Infof("Service %s/%s has external LB address pool annotation from subnet %s, action: %s", svc.Namespace, svc.Name, subnetName, action)
×
197
                                switch action {
×
198
                                case "add":
×
199
                                        c.serviceQueue.Add(&serviceEvent{newObj: svc})
×
200
                                case "remove":
×
201
                                        c.serviceQueue.Add(&serviceEvent{oldObj: svc})
×
202
                                }
203
                        }
204
                }
205
        }
206
        return nil
×
207
}
208

209
func (c *Controller) reconcileRouters(event *subnetEvent) error {
×
210
        subnets, err := c.subnetsLister.List(labels.Everything())
×
211
        if err != nil {
×
212
                klog.Errorf("failed to list subnets %v", err)
×
213
                return err
×
214
        }
×
215

216
        if event != nil {
×
217
                var ok bool
×
218
                var oldSubnet, newSubnet *kubeovnv1.Subnet
×
219
                if event.oldObj != nil {
×
220
                        if oldSubnet, ok = event.oldObj.(*kubeovnv1.Subnet); !ok {
×
221
                                klog.Errorf("expected old subnet in subnetEvent but got %#v", event.oldObj)
×
222
                                return nil
×
223
                        }
×
224
                }
225
                if event.newObj != nil {
×
226
                        if newSubnet, ok = event.newObj.(*kubeovnv1.Subnet); !ok {
×
227
                                klog.Errorf("expected new subnet in subnetEvent but got %#v", event.newObj)
×
228
                                return nil
×
229
                        }
×
230
                }
231

232
                if err = c.handleEnableExternalLBAddressChange(oldSubnet, newSubnet); err != nil {
×
233
                        klog.Errorf("failed to handle enable external lb address change: %v", err)
×
234
                        return err
×
235
                }
×
236
                // handle policy routing
237
                rulesToAdd, rulesToDel, routesToAdd, routesToDel, err := c.diffPolicyRouting(oldSubnet, newSubnet)
×
238
                if err != nil {
×
239
                        klog.Errorf("failed to get policy routing difference: %v", err)
×
240
                        return err
×
241
                }
×
242
                // add new routes first
243
                for _, r := range routesToAdd {
×
244
                        if err = netlink.RouteReplace(&r); err != nil && !errors.Is(err, syscall.EEXIST) {
×
245
                                klog.Errorf("failed to replace route for subnet %s: %v", newSubnet.Name, err)
×
246
                                return err
×
247
                        }
×
248
                }
249
                // next, add new rules
250
                for _, r := range rulesToAdd {
×
251
                        if err = netlink.RuleAdd(&r); err != nil && !errors.Is(err, syscall.EEXIST) {
×
252
                                klog.Errorf("failed to add network rule for subnet %s: %v", newSubnet.Name, err)
×
253
                                return err
×
254
                        }
×
255
                }
256
                // then delete old network rules
257
                for _, r := range rulesToDel {
×
258
                        // loop to delete all matched rules
×
259
                        for {
×
260
                                if err = netlink.RuleDel(&r); err != nil {
×
261
                                        if !errors.Is(err, syscall.ENOENT) {
×
262
                                                klog.Errorf("failed to delete network rule for subnet %s: %v", oldSubnet.Name, err)
×
263
                                                return err
×
264
                                        }
×
265
                                        break
×
266
                                }
267
                        }
268
                }
269
                // last, delete old network routes
270
                for _, r := range routesToDel {
×
271
                        if err = netlink.RouteDel(&r); err != nil && !errors.Is(err, syscall.ENOENT) {
×
272
                                klog.Errorf("failed to delete route for subnet %s: %v", oldSubnet.Name, err)
×
273
                                return err
×
274
                        }
×
275
                }
276
        }
277

278
        node, err := c.nodesLister.Get(c.config.NodeName)
×
279
        if err != nil {
×
280
                klog.Errorf("failed to get node %s %v", c.config.NodeName, err)
×
281
                return err
×
282
        }
×
283
        nodeIPv4, nodeIPv6 := util.GetNodeInternalIP(*node)
×
284
        var joinIPv4, joinIPv6 string
×
285
        if len(node.Annotations) != 0 {
×
286
                joinIPv4, joinIPv6 = util.SplitStringIP(node.Annotations[util.IPAddressAnnotation])
×
287
        }
×
288

289
        joinCIDR := make([]string, 0, 2)
×
290
        cidrs := make([]string, 0, len(subnets)*2)
×
291
        for _, subnet := range subnets {
×
292
                // The route for overlay subnet cidr via ovn0 should not be deleted even though subnet.Status has changed to not ready
×
293
                if subnet.Spec.Vpc != c.config.ClusterRouter ||
×
294
                        (subnet.Spec.Vlan != "" && !subnet.Spec.LogicalGateway && (!subnet.Spec.U2OInterconnection || (subnet.Spec.EnableLb != nil && *subnet.Spec.EnableLb))) ||
×
295
                        !subnet.Status.IsValidated() {
×
296
                        continue
×
297
                }
298

NEW
299
                for cidrBlock := range strings.SplitSeq(subnet.Spec.CIDRBlock, ",") {
×
300
                        if _, ipNet, err := net.ParseCIDR(cidrBlock); err != nil {
×
301
                                klog.Errorf("%s is not a valid cidr block", cidrBlock)
×
302
                        } else {
×
303
                                if nodeIPv4 != "" && util.CIDRContainIP(cidrBlock, nodeIPv4) {
×
304
                                        continue
×
305
                                }
306
                                if nodeIPv6 != "" && util.CIDRContainIP(cidrBlock, nodeIPv6) {
×
307
                                        continue
×
308
                                }
309
                                cidrs = append(cidrs, ipNet.String())
×
310
                                if subnet.Name == c.config.NodeSwitch {
×
311
                                        joinCIDR = append(joinCIDR, ipNet.String())
×
312
                                }
×
313
                        }
314
                }
315
        }
316

317
        gateway, ok := node.Annotations[util.GatewayAnnotation]
×
318
        if !ok {
×
319
                klog.Errorf("annotation for node %s ovn.kubernetes.io/gateway not exists", node.Name)
×
320
                return errors.New("annotation for node ovn.kubernetes.io/gateway not exists")
×
321
        }
×
322
        nic, err := netlink.LinkByName(util.NodeNic)
×
323
        if err != nil {
×
324
                klog.Errorf("failed to get nic %s", util.NodeNic)
×
325
                return fmt.Errorf("failed to get nic %s", util.NodeNic)
×
326
        }
×
327

328
        allRoutes, err := getNicExistRoutes(nil, gateway)
×
329
        if err != nil {
×
330
                klog.Error(err)
×
331
                return err
×
332
        }
×
333
        nodeNicRoutes, err := getNicExistRoutes(nic, gateway)
×
334
        if err != nil {
×
335
                klog.Error(err)
×
336
                return err
×
337
        }
×
338
        toAdd, toDel := routeDiff(nodeNicRoutes, allRoutes, cidrs, joinCIDR, joinIPv4, joinIPv6, gateway, net.ParseIP(nodeIPv4), net.ParseIP(nodeIPv6))
×
339
        for _, r := range toDel {
×
340
                if err = netlink.RouteDel(&netlink.Route{Dst: r.Dst}); err != nil {
×
341
                        klog.Errorf("failed to del route %v", err)
×
342
                }
×
343
        }
344

345
        for _, r := range toAdd {
×
346
                r.LinkIndex = nic.Attrs().Index
×
347
                if err = netlink.RouteReplace(&r); err != nil {
×
348
                        klog.Errorf("failed to replace route %v: %v", r, err)
×
349
                }
×
350
        }
351

352
        return nil
×
353
}
354

355
func genLBServiceRules(service *v1.Service, bridgeName, underlayNic string) []LbServiceRules {
×
356
        var lbServiceRules []LbServiceRules
×
357
        for _, ingress := range service.Status.LoadBalancer.Ingress {
×
358
                for _, port := range service.Spec.Ports {
×
359
                        lbServiceRules = append(lbServiceRules, LbServiceRules{
×
360
                                IP:          ingress.IP,
×
361
                                Port:        uint16(port.Port), // #nosec G115
×
362
                                Protocol:    string(port.Protocol),
×
363
                                DstMac:      util.MasqueradeExternalLBAccessMac,
×
364
                                UnderlayNic: underlayNic,
×
365
                                BridgeName:  bridgeName,
×
366
                        })
×
367
                }
×
368
        }
369
        return lbServiceRules
×
370
}
371

372
func (c *Controller) diffExternalLBServiceRules(oldService, newService *v1.Service, isSubnetExternalLBEnabled bool) (lbServiceRulesToAdd, lbServiceRulesToDel []LbServiceRules, err error) {
×
373
        var oldlbServiceRules, newlbServiceRules []LbServiceRules
×
374

×
375
        if oldService != nil && oldService.Annotations[util.ServiceExternalIPFromSubnetAnnotation] != "" {
×
376
                oldBridgeName, underlayNic, err := c.getExtInfoBySubnet(oldService.Annotations[util.ServiceExternalIPFromSubnetAnnotation])
×
377
                if err != nil {
×
378
                        klog.Errorf("failed to get provider network by subnet %s: %v", oldService.Annotations[util.ServiceExternalIPFromSubnetAnnotation], err)
×
379
                        return nil, nil, err
×
380
                }
×
381

382
                oldlbServiceRules = genLBServiceRules(oldService, oldBridgeName, underlayNic)
×
383
        }
384

385
        if isSubnetExternalLBEnabled && newService != nil && newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation] != "" {
×
386
                newBridgeName, underlayNic, err := c.getExtInfoBySubnet(newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation])
×
387
                if err != nil {
×
388
                        klog.Errorf("failed to get provider network by subnet %s: %v", newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation], err)
×
389
                        return nil, nil, err
×
390
                }
×
391
                newlbServiceRules = genLBServiceRules(newService, newBridgeName, underlayNic)
×
392
        }
393

394
        for _, oldRule := range oldlbServiceRules {
×
NEW
395
                found := slices.Contains(newlbServiceRules, oldRule)
×
396
                if !found {
×
397
                        lbServiceRulesToDel = append(lbServiceRulesToDel, oldRule)
×
398
                }
×
399
        }
400

401
        for _, newRule := range newlbServiceRules {
×
NEW
402
                found := slices.Contains(oldlbServiceRules, newRule)
×
403
                if !found {
×
404
                        lbServiceRulesToAdd = append(lbServiceRulesToAdd, newRule)
×
405
                }
×
406
        }
407

408
        return lbServiceRulesToAdd, lbServiceRulesToDel, nil
×
409
}
410

411
func (c *Controller) getExtInfoBySubnet(subnetName string) (string, string, error) {
×
412
        subnet, err := c.subnetsLister.Get(subnetName)
×
413
        if err != nil {
×
414
                klog.Errorf("failed to get subnet %s: %v", subnetName, err)
×
415
                return "", "", err
×
416
        }
×
417

418
        vlanName := subnet.Spec.Vlan
×
419
        if vlanName == "" {
×
420
                return "", "", errors.New("vlan not specified in subnet")
×
421
        }
×
422

423
        vlan, err := c.vlansLister.Get(vlanName)
×
424
        if err != nil {
×
425
                klog.Errorf("failed to get vlan %s: %v", vlanName, err)
×
426
                return "", "", err
×
427
        }
×
428

429
        providerNetworkName := vlan.Spec.Provider
×
430
        if providerNetworkName == "" {
×
431
                return "", "", errors.New("provider network not specified in vlan")
×
432
        }
×
433

434
        pn, err := c.providerNetworksLister.Get(providerNetworkName)
×
435
        if err != nil {
×
436
                klog.Errorf("failed to get provider network %s: %v", providerNetworkName, err)
×
437
                return "", "", err
×
438
        }
×
439

440
        underlayNic := pn.Spec.DefaultInterface
×
441
        for _, item := range pn.Spec.CustomInterfaces {
×
442
                if slices.Contains(item.Nodes, c.config.NodeName) {
×
443
                        underlayNic = item.Interface
×
444
                        break
×
445
                }
446
        }
447
        klog.Infof("Provider network: %s, Underlay NIC: %s", providerNetworkName, underlayNic)
×
448
        return util.ExternalBridgeName(providerNetworkName), underlayNic, nil
×
449
}
450

451
func (c *Controller) reconcileServices(event *serviceEvent) error {
×
452
        if event == nil {
×
453
                return nil
×
454
        }
×
455
        var ok bool
×
456
        var oldService, newService *v1.Service
×
457
        if event.oldObj != nil {
×
458
                if oldService, ok = event.oldObj.(*v1.Service); !ok {
×
459
                        klog.Errorf("expected old service in serviceEvent but got %#v", event.oldObj)
×
460
                        return nil
×
461
                }
×
462
        }
463

464
        if event.newObj != nil {
×
465
                if newService, ok = event.newObj.(*v1.Service); !ok {
×
466
                        klog.Errorf("expected new service in serviceEvent but got %#v", event.newObj)
×
467
                        return nil
×
468
                }
×
469
        }
470

471
        // check is the lb service IP related subnet's EnableExternalLBAddress
472
        isSubnetExternalLBEnabled := false
×
473
        if newService != nil && newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation] != "" {
×
474
                subnet, err := c.subnetsLister.Get(newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation])
×
475
                if err != nil {
×
476
                        klog.Errorf("failed to get subnet %s: %v", newService.Annotations[util.ServiceExternalIPFromSubnetAnnotation], err)
×
477
                        return err
×
478
                }
×
479
                isSubnetExternalLBEnabled = subnet.Spec.EnableExternalLBAddress
×
480
        }
481

482
        lbServiceRulesToAdd, lbServiceRulesToDel, err := c.diffExternalLBServiceRules(oldService, newService, isSubnetExternalLBEnabled)
×
483
        if err != nil {
×
484
                klog.Errorf("failed to get ip port difference: %v", err)
×
485
                return err
×
486
        }
×
487

488
        if len(lbServiceRulesToAdd) > 0 {
×
489
                for _, rule := range lbServiceRulesToAdd {
×
490
                        klog.Infof("Adding LB service rule: %+v", rule)
×
491
                        if err := ovs.AddOrUpdateUnderlaySubnetSvcLocalOpenFlow(c.ovsClient, rule.BridgeName, rule.IP, rule.Protocol, rule.DstMac, rule.UnderlayNic, rule.Port); err != nil {
×
492
                                klog.Errorf("failed to add or update underlay subnet svc local openflow: %v", err)
×
493
                        }
×
494
                }
495
        }
496

497
        if len(lbServiceRulesToDel) > 0 {
×
498
                for _, rule := range lbServiceRulesToDel {
×
499
                        klog.Infof("Delete LB service rule: %+v", rule)
×
500
                        if err := ovs.DeleteUnderlaySubnetSvcLocalOpenFlow(c.ovsClient, rule.BridgeName, rule.IP, rule.Protocol, rule.UnderlayNic, rule.Port); err != nil {
×
501
                                klog.Errorf("failed to delete underlay subnet svc local openflow: %v", err)
×
502
                        }
×
503
                }
504
        }
505

506
        return nil
×
507
}
508

509
func getNicExistRoutes(nic netlink.Link, gateway string) ([]netlink.Route, error) {
×
510
        var routes, existRoutes []netlink.Route
×
511
        var err error
×
NEW
512
        for gw := range strings.SplitSeq(gateway, ",") {
×
513
                if util.CheckProtocol(gw) == kubeovnv1.ProtocolIPv4 {
×
514
                        routes, err = netlink.RouteList(nic, netlink.FAMILY_V4)
×
515
                } else {
×
516
                        routes, err = netlink.RouteList(nic, netlink.FAMILY_V6)
×
517
                }
×
518
                if err != nil {
×
519
                        return nil, err
×
520
                }
×
521
                existRoutes = append(existRoutes, routes...)
×
522
        }
523
        return existRoutes, nil
×
524
}
525

526
func routeDiff(nodeNicRoutes, allRoutes []netlink.Route, cidrs, joinCIDR []string, joinIPv4, joinIPv6, gateway string, srcIPv4, srcIPv6 net.IP) (toAdd, toDel []netlink.Route) {
×
527
        // joinIPv6 is not used for now
×
528
        _ = joinIPv6
×
529

×
530
        for _, route := range nodeNicRoutes {
×
531
                if route.Scope == netlink.SCOPE_LINK || route.Dst == nil || route.Dst.IP.IsLinkLocalUnicast() {
×
532
                        continue
×
533
                }
534

NEW
535
                found := slices.Contains(cidrs, route.Dst.String())
×
536
                if !found {
×
537
                        toDel = append(toDel, route)
×
538
                }
×
539
                conflict := false
×
540
                for _, ar := range allRoutes {
×
541
                        if ar.Dst != nil && ar.Dst.String() == route.Dst.String() && ar.LinkIndex != route.LinkIndex {
×
542
                                // route conflict
×
543
                                conflict = true
×
544
                                break
×
545
                        }
546
                }
547
                if conflict {
×
548
                        toDel = append(toDel, route)
×
549
                }
×
550
        }
551
        if len(toDel) > 0 {
×
552
                klog.Infof("routes to delete: %v", toDel)
×
553
        }
×
554

555
        ipv4, ipv6 := util.SplitStringIP(gateway)
×
556
        gwV4, gwV6 := net.ParseIP(ipv4), net.ParseIP(ipv6)
×
557
        for _, c := range cidrs {
×
558
                var src, gw net.IP
×
559
                switch util.CheckProtocol(c) {
×
560
                case kubeovnv1.ProtocolIPv4:
×
561
                        src, gw = srcIPv4, gwV4
×
562
                case kubeovnv1.ProtocolIPv6:
×
563
                        src, gw = srcIPv6, gwV6
×
564
                }
565

566
                found := false
×
567
                for _, ar := range allRoutes {
×
568
                        if ar.Dst != nil && ar.Dst.String() == c {
×
569
                                // route already exist
×
570
                                found = true
×
571
                                break
×
572
                        }
573
                }
574
                if found {
×
575
                        continue
×
576
                }
577
                for _, r := range nodeNicRoutes {
×
578
                        if r.Dst == nil || r.Dst.String() != c {
×
579
                                continue
×
580
                        }
581
                        if src == nil {
×
582
                                if r.Src == nil {
×
583
                                        found = true
×
584
                                        break
×
585
                                }
586
                        } else if src.Equal(r.Src) {
×
587
                                found = true
×
588
                                break
×
589
                        }
590
                }
591
                if !found {
×
592
                        var priority int
×
593
                        scope := netlink.SCOPE_UNIVERSE
×
594
                        proto := netlink.RouteProtocol(syscall.RTPROT_STATIC)
×
595
                        if slices.Contains(joinCIDR, c) {
×
596
                                if util.CheckProtocol(c) == kubeovnv1.ProtocolIPv4 {
×
597
                                        src = net.ParseIP(joinIPv4)
×
598
                                } else {
×
599
                                        src, priority = nil, 256
×
600
                                }
×
601
                                gw, scope = nil, netlink.SCOPE_LINK
×
602
                                proto = netlink.RouteProtocol(unix.RTPROT_KERNEL)
×
603
                        }
604
                        _, cidr, _ := net.ParseCIDR(c)
×
605
                        toAdd = append(toAdd, netlink.Route{
×
606
                                Dst:      cidr,
×
607
                                Src:      src,
×
608
                                Gw:       gw,
×
609
                                Protocol: proto,
×
610
                                Scope:    scope,
×
611
                                Priority: priority,
×
612
                        })
×
613
                }
614
        }
615
        if len(toAdd) > 0 {
×
616
                klog.Infof("routes to add: %v", toAdd)
×
617
        }
×
618
        return
×
619
}
620

621
func getRulesToAdd(oldRules, newRules []netlink.Rule) []netlink.Rule {
×
622
        var toAdd []netlink.Rule
×
623

×
624
        for _, rule := range newRules {
×
625
                var found bool
×
626
                for _, r := range oldRules {
×
627
                        if r.Family == rule.Family && r.Priority == rule.Priority && r.Table == rule.Table && reflect.DeepEqual(r.Src, rule.Src) {
×
628
                                found = true
×
629
                                break
×
630
                        }
631
                }
632
                if !found {
×
633
                        toAdd = append(toAdd, rule)
×
634
                }
×
635
        }
636

637
        return toAdd
×
638
}
639

640
func getRoutesToAdd(oldRoutes, newRoutes []netlink.Route) []netlink.Route {
×
641
        var toAdd []netlink.Route
×
642

×
643
        for _, route := range newRoutes {
×
644
                var found bool
×
645
                for _, r := range oldRoutes {
×
646
                        if r.Equal(route) {
×
647
                                found = true
×
648
                                break
×
649
                        }
650
                }
651
                if !found {
×
652
                        toAdd = append(toAdd, route)
×
653
                }
×
654
        }
655

656
        return toAdd
×
657
}
658

659
func (c *Controller) diffPolicyRouting(oldSubnet, newSubnet *kubeovnv1.Subnet) (rulesToAdd, rulesToDel []netlink.Rule, routesToAdd, routesToDel []netlink.Route, err error) {
×
660
        oldRules, oldRoutes, err := c.getPolicyRouting(oldSubnet)
×
661
        if err != nil {
×
662
                klog.Error(err)
×
663
                return
×
664
        }
×
665
        newRules, newRoutes, err := c.getPolicyRouting(newSubnet)
×
666
        if err != nil {
×
667
                klog.Error(err)
×
668
                return
×
669
        }
×
670

671
        rulesToAdd = getRulesToAdd(oldRules, newRules)
×
672
        rulesToDel = getRulesToAdd(newRules, oldRules)
×
673
        routesToAdd = getRoutesToAdd(oldRoutes, newRoutes)
×
674
        routesToDel = getRoutesToAdd(newRoutes, oldRoutes)
×
675

×
676
        return
×
677
}
678

679
func (c *Controller) getPolicyRouting(subnet *kubeovnv1.Subnet) ([]netlink.Rule, []netlink.Route, error) {
×
680
        if subnet == nil || subnet.Spec.ExternalEgressGateway == "" || subnet.Spec.Vpc != c.config.ClusterRouter {
×
681
                return nil, nil, nil
×
682
        }
×
683
        if subnet.Spec.GatewayType == kubeovnv1.GWCentralizedType && !util.GatewayContains(subnet.Spec.GatewayNode, c.config.NodeName) {
×
684
                return nil, nil, nil
×
685
        }
×
686

687
        protocols := make([]string, 1, 2)
×
688
        if protocol := util.CheckProtocol(subnet.Spec.ExternalEgressGateway); protocol == kubeovnv1.ProtocolDual {
×
689
                protocols[0] = kubeovnv1.ProtocolIPv4
×
690
                protocols = append(protocols, kubeovnv1.ProtocolIPv6)
×
691
        } else {
×
692
                protocols[0] = protocol
×
693
        }
×
694

695
        cidr := strings.Split(subnet.Spec.CIDRBlock, ",")
×
696
        egw := strings.Split(subnet.Spec.ExternalEgressGateway, ",")
×
697

×
698
        // rules
×
699
        var rules []netlink.Rule
×
700
        rule := netlink.NewRule()
×
701
        rule.Table = int(subnet.Spec.PolicyRoutingTableID)
×
702
        rule.Priority = int(subnet.Spec.PolicyRoutingPriority)
×
703
        if subnet.Spec.GatewayType == kubeovnv1.GWDistributedType {
×
704
                pods, err := c.podsLister.List(labels.Everything())
×
705
                if err != nil {
×
706
                        klog.Errorf("list pods failed, %+v", err)
×
707
                        return nil, nil, err
×
708
                }
×
709

710
                hostname := os.Getenv(util.HostnameEnv)
×
711
                for _, pod := range pods {
×
712
                        if pod.Spec.HostNetwork ||
×
713
                                pod.Status.PodIP == "" ||
×
714
                                pod.Annotations[util.LogicalSwitchAnnotation] != subnet.Name ||
×
715
                                pod.Spec.NodeName != hostname {
×
716
                                continue
×
717
                        }
718

719
                        for i := range protocols {
×
720
                                rule.Family, _ = util.ProtocolToFamily(protocols[i])
×
721

×
722
                                var ip net.IP
×
723
                                var maskBits int
×
724
                                if len(pod.Status.PodIPs) == 2 && protocols[i] == kubeovnv1.ProtocolIPv6 {
×
725
                                        ip = net.ParseIP(pod.Status.PodIPs[1].IP)
×
726
                                        maskBits = 128
×
727
                                } else if util.CheckProtocol(pod.Status.PodIP) == protocols[i] {
×
728
                                        ip = net.ParseIP(pod.Status.PodIP)
×
729
                                        maskBits = 32
×
730
                                        if rule.Family == netlink.FAMILY_V6 {
×
731
                                                maskBits = 128
×
732
                                        }
×
733
                                }
734

735
                                rule.Src = &net.IPNet{IP: ip, Mask: net.CIDRMask(maskBits, maskBits)}
×
736
                                rules = append(rules, *rule)
×
737
                        }
738
                }
739
        } else {
×
740
                for i := range protocols {
×
741
                        rule.Family, _ = util.ProtocolToFamily(protocols[i])
×
742
                        if len(cidr) == len(protocols) {
×
743
                                _, rule.Src, _ = net.ParseCIDR(cidr[i])
×
744
                        }
×
745
                        rules = append(rules, *rule)
×
746
                }
747
        }
748

749
        // routes
750
        var routes []netlink.Route
×
751
        for i := range protocols {
×
752
                routes = append(routes, netlink.Route{
×
753
                        Protocol: netlink.RouteProtocol(syscall.RTPROT_STATIC),
×
754
                        Table:    int(subnet.Spec.PolicyRoutingTableID),
×
755
                        Gw:       net.ParseIP(egw[i]),
×
756
                })
×
757
        }
×
758

759
        return rules, routes, nil
×
760
}
761

762
func (c *Controller) handlePod(key string) error {
×
763
        namespace, name, err := cache.SplitMetaNamespaceKey(key)
×
764
        if err != nil {
×
765
                utilruntime.HandleError(fmt.Errorf("invalid resource key: %s", key))
×
766
                return nil
×
767
        }
×
768
        klog.Infof("handle qos update for pod %s/%s", namespace, name)
×
769

×
770
        pod, err := c.podsLister.Pods(namespace).Get(name)
×
771
        if err != nil {
×
772
                if k8serrors.IsNotFound(err) {
×
773
                        return nil
×
774
                }
×
775
                klog.Error(err)
×
776
                return err
×
777
        }
778

779
        if err := util.ValidatePodNetwork(pod.Annotations); err != nil {
×
780
                klog.Errorf("validate pod %s/%s failed, %v", namespace, name, err)
×
781
                c.recorder.Eventf(pod, v1.EventTypeWarning, "ValidatePodNetworkFailed", err.Error())
×
782
                return err
×
783
        }
×
784

785
        podName := pod.Name
×
786
        if pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, util.OvnProvider)] != "" {
×
787
                podName = pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, util.OvnProvider)]
×
788
        }
×
789

790
        // set default nic bandwidth
791
        //  ovsIngress and ovsEgress are derived from the pod's egress and ingress rate annotations respectively, their roles are reversed from the OVS interface perspective.
792
        ifaceID := ovs.PodNameToPortName(podName, pod.Namespace, util.OvnProvider)
×
793
        ovsIngress := pod.Annotations[util.EgressRateAnnotation]
×
794
        ovsEgress := pod.Annotations[util.IngressRateAnnotation]
×
795
        err = ovs.SetInterfaceBandwidth(podName, pod.Namespace, ifaceID, ovsIngress, ovsEgress)
×
796
        if err != nil {
×
797
                klog.Error(err)
×
798
                return err
×
799
        }
×
800
        err = ovs.ConfigInterfaceMirror(c.config.EnableMirror, pod.Annotations[util.MirrorControlAnnotation], ifaceID)
×
801
        if err != nil {
×
802
                klog.Error(err)
×
803
                return err
×
804
        }
×
805
        // set linux-netem qos
806
        err = ovs.SetNetemQos(podName, pod.Namespace, ifaceID, pod.Annotations[util.NetemQosLatencyAnnotation], pod.Annotations[util.NetemQosLimitAnnotation], pod.Annotations[util.NetemQosLossAnnotation], pod.Annotations[util.NetemQosJitterAnnotation])
×
807
        if err != nil {
×
808
                klog.Error(err)
×
809
                return err
×
810
        }
×
811

812
        // set multus-nic bandwidth
813
        attachNets, err := nadutils.ParsePodNetworkAnnotation(pod)
×
814
        if err != nil {
×
815
                klog.Error(err)
×
816
                return err
×
817
        }
×
818
        for _, multiNet := range attachNets {
×
819
                provider := fmt.Sprintf("%s.%s.%s", multiNet.Name, multiNet.Namespace, util.OvnProvider)
×
820
                if pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, provider)] != "" {
×
821
                        podName = pod.Annotations[fmt.Sprintf(util.VMAnnotationTemplate, provider)]
×
822
                }
×
823
                if pod.Annotations[fmt.Sprintf(util.AllocatedAnnotationTemplate, provider)] == "true" {
×
824
                        ifaceID = ovs.PodNameToPortName(podName, pod.Namespace, provider)
×
825

×
826
                        err = ovs.SetInterfaceBandwidth(podName, pod.Namespace, ifaceID, pod.Annotations[fmt.Sprintf(util.EgressRateAnnotationTemplate, provider)], pod.Annotations[fmt.Sprintf(util.IngressRateAnnotationTemplate, provider)])
×
827
                        if err != nil {
×
828
                                klog.Error(err)
×
829
                                return err
×
830
                        }
×
831
                        err = ovs.ConfigInterfaceMirror(c.config.EnableMirror, pod.Annotations[fmt.Sprintf(util.MirrorControlAnnotationTemplate, provider)], ifaceID)
×
832
                        if err != nil {
×
833
                                klog.Error(err)
×
834
                                return err
×
835
                        }
×
836
                        err = ovs.SetNetemQos(podName, pod.Namespace, ifaceID, pod.Annotations[fmt.Sprintf(util.NetemQosLatencyAnnotationTemplate, provider)], pod.Annotations[fmt.Sprintf(util.NetemQosLimitAnnotationTemplate, provider)], pod.Annotations[fmt.Sprintf(util.NetemQosLossAnnotationTemplate, provider)], pod.Annotations[fmt.Sprintf(util.NetemQosJitterAnnotationTemplate, provider)])
×
837
                        if err != nil {
×
838
                                klog.Error(err)
×
839
                                return err
×
840
                        }
×
841
                }
842
        }
843
        return nil
×
844
}
845

846
func (c *Controller) loopEncapIPCheck() {
×
847
        node, err := c.nodesLister.Get(c.config.NodeName)
×
848
        if err != nil {
×
849
                klog.Errorf("failed to get node %s %v", c.config.NodeName, err)
×
850
                return
×
851
        }
×
852

853
        if nodeTunnelName := node.GetAnnotations()[util.TunnelInterfaceAnnotation]; nodeTunnelName != "" {
×
854
                iface, err := findInterface(nodeTunnelName)
×
855
                if err != nil {
×
856
                        klog.Errorf("failed to find iface %s, %v", nodeTunnelName, err)
×
857
                        return
×
858
                }
×
859
                if iface.Flags&net.FlagUp == 0 {
×
860
                        klog.Errorf("iface %v is down", nodeTunnelName)
×
861
                        return
×
862
                }
×
863
                addrs, err := iface.Addrs()
×
864
                if err != nil {
×
865
                        klog.Errorf("failed to get iface addr. %v", err)
×
866
                        return
×
867
                }
×
868
                if len(addrs) == 0 {
×
869
                        klog.Errorf("iface %s has no ip address", nodeTunnelName)
×
870
                        return
×
871
                }
×
872
                if iface.Name != c.config.tunnelIface {
×
873
                        klog.Infof("use %s as tunnel interface", iface.Name)
×
874
                        c.config.tunnelIface = iface.Name
×
875
                }
×
876

877
                // if assigned iface in node annotation is down or with no ip, the error msg should be printed periodically
878
                if c.config.Iface == nodeTunnelName {
×
879
                        klog.V(3).Infof("node tunnel interface %s not changed", nodeTunnelName)
×
880
                        return
×
881
                }
×
882
                c.config.Iface = nodeTunnelName
×
883
                klog.Infof("Update node tunnel interface %v", nodeTunnelName)
×
884

×
885
                encapIP := strings.Split(addrs[0].String(), "/")[0]
×
886
                if err = setEncapIP(encapIP); err != nil {
×
887
                        klog.Errorf("failed to set encap ip %s for iface %s", encapIP, c.config.Iface)
×
888
                        return
×
889
                }
×
890
        }
891
}
892

893
func (c *Controller) ovnMetricsUpdate() {
×
894
        c.setOvnSubnetGatewayMetric()
×
895

×
896
        resetSysParaMetrics()
×
897
        c.setIPLocalPortRangeMetric()
×
898
        c.setCheckSumErrMetric()
×
899
        c.setDNSSearchMetric()
×
900
        c.setTCPTwRecycleMetric()
×
901
        c.setTCPMtuProbingMetric()
×
902
        c.setConntrackTCPLiberalMetric()
×
903
        c.setBridgeNfCallIptablesMetric()
×
904
        c.setIPv6RouteMaxsizeMetric()
×
905
        c.setTCPMemMetric()
×
906
}
×
907

908
func resetSysParaMetrics() {
×
909
        metricIPLocalPortRange.Reset()
×
910
        metricCheckSumErr.Reset()
×
911
        metricDNSSearch.Reset()
×
912
        metricTCPTwRecycle.Reset()
×
913
        metricTCPMtuProbing.Reset()
×
914
        metricConntrackTCPLiberal.Reset()
×
915
        metricBridgeNfCallIptables.Reset()
×
916
        metricTCPMem.Reset()
×
917
        metricIPv6RouteMaxsize.Reset()
×
918
}
×
919

920
func rotateLog() {
×
921
        output, err := exec.Command("logrotate", "/etc/logrotate.d/openvswitch").CombinedOutput()
×
922
        if err != nil {
×
923
                klog.Errorf("failed to rotate openvswitch log %q", output)
×
924
        }
×
925
        output, err = exec.Command("logrotate", "/etc/logrotate.d/ovn").CombinedOutput()
×
926
        if err != nil {
×
927
                klog.Errorf("failed to rotate ovn log %q", output)
×
928
        }
×
929
        output, err = exec.Command("logrotate", "/etc/logrotate.d/kubeovn").CombinedOutput()
×
930
        if err != nil {
×
931
                klog.Errorf("failed to rotate kube-ovn log %q", output)
×
932
        }
×
933
}
934

935
func kernelModuleLoaded(module string) (bool, error) {
×
936
        data, err := os.ReadFile("/proc/modules")
×
937
        if err != nil {
×
938
                klog.Errorf("failed to read /proc/modules: %v", err)
×
939
                return false, err
×
940
        }
×
941

NEW
942
        for line := range strings.SplitSeq(string(data), "\n") {
×
943
                if fields := strings.Fields(line); len(fields) != 0 && fields[0] == module {
×
944
                        return true, nil
×
945
                }
×
946
        }
947

948
        return false, nil
×
949
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc