14540577447

Committed 18 Apr 2025 07:23PM UTC coverage: 51.439% (-6.2%) from 57.611%

Build # 14540577447

Build Type

push

github

Committed by

ljacqu

Commit Message

Remove EvaluationResult type param from all Evaluator interfaces

Run Details

239 of 546 branches covered (43.77%)

16 of 17 new or added lines in 16 files covered. (94.12%)

193 existing lines in 17 files now uncovered.

679 of 1320 relevant lines covered (51.44%)

3.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

33.33

/src/main/java/ch/jalu/wordeval/evaluators/impl/DiacriticHomonyms.java

package ch.jalu.wordeval.evaluators.impl;

import ch.jalu.wordeval.dictionary.Word;
import ch.jalu.wordeval.evaluators.AllWordsEvaluator;
import ch.jalu.wordeval.evaluators.result.WordGroupWithKey;
import com.google.common.collect.ArrayListMultimap;
import com.google.common.collect.HashMultimap;
import com.google.common.collect.ListMultimap;
import com.google.common.collect.Multimaps;
import com.google.common.collect.SetMultimap;
import lombok.Getter;

import java.util.ArrayList;
import java.util.Collection;
import java.util.Comparator;
import java.util.HashSet;
import java.util.List;
import java.util.Set;

/**
 * Groups words which only differ in diacritics which are not considered
 * distinct letters in the language, such as {des, dés, dès} in French or
 * {schon, schön} in German.
 */
public class DiacriticHomonyms implements AllWordsEvaluator {

  @Getter
  private final List<WordGroupWithKey> results = new ArrayList<>();

  @Override
  public void evaluate(Collection<Word> words) {
    SetMultimap<String, Word> wordsByNoAccentRep = words.stream()
      .collect(Multimaps.toMultimap(
        Word::getWithoutAccents,
        word -> word,
        HashMultimap::create));

    Multimaps.asMap(wordsByNoAccentRep).forEach((wordRep, wordsInGroup) -> {
      if (wordsInGroup.size() > 1) {
        results.add(new WordGroupWithKey(wordsInGroup, wordRep));
      }
    });
  }

  @Override
  public ListMultimap<Object, Object> getTopResults(int topScores, int maxLimit) {
    Comparator<WordGroupWithKey> comparator = Comparator.comparingInt((WordGroupWithKey group) -> group.getWords().size())
        .thenComparing(group -> group.getKey().length())
        .reversed(); // todo: unit test

    List<WordGroupWithKey> sortedResult = results.stream()
        .sorted(comparator)
        .toList();

    Set<Integer> uniqueValues = new HashSet<>();
    ListMultimap<Object, Object> filteredResults = ArrayListMultimap.create();
    for (WordGroupWithKey wordGroup : sortedResult) {
      int score = wordGroup.getWords().size();
      if (uniqueValues.add(score) && uniqueValues.size() > topScores) {
        break;
      }
      List<String> wordList = wordGroup.getWords().stream()
          .map(Word::getRaw)
          .toList();
      filteredResults.put(score, wordList);
      if (filteredResults.size() >= maxLimit) {
        break;
      }
    }

    return filteredResults;
  }
}

1	package ch.jalu.wordeval.evaluators.impl;
2
3	import ch.jalu.wordeval.dictionary.Word;
4	import ch.jalu.wordeval.evaluators.AllWordsEvaluator;
5	import ch.jalu.wordeval.evaluators.result.WordGroupWithKey;
6	import com.google.common.collect.ArrayListMultimap;
7	import com.google.common.collect.HashMultimap;
8	import com.google.common.collect.ListMultimap;
9	import com.google.common.collect.Multimaps;
10	import com.google.common.collect.SetMultimap;
11	import lombok.Getter;
12
13	import java.util.ArrayList;
14	import java.util.Collection;
15	import java.util.Comparator;
16	import java.util.HashSet;
17	import java.util.List;
18	import java.util.Set;
19
20	/**
21	* Groups words which only differ in diacritics which are not considered
22	* distinct letters in the language, such as {des, dés, dès} in French or
23	* {schon, schön} in German.
24	*/
25	public class DiacriticHomonyms implements AllWordsEvaluator {	2✔
26
27	@Getter	6✔
28	private final List<WordGroupWithKey> results = new ArrayList<>();
29
30	@Override
31	public void evaluate(Collection<Word> words) {
32	SetMultimap<String, Word> wordsByNoAccentRep = words.stream()	5✔
33	.collect(Multimaps.toMultimap(	4✔
34	Word::getWithoutAccents,
35	word -> word,	2✔
36	HashMultimap::create));
37
38	Multimaps.asMap(wordsByNoAccentRep).forEach((wordRep, wordsInGroup) -> {	5✔
39	if (wordsInGroup.size() > 1) {	4✔
40	results.add(new WordGroupWithKey(wordsInGroup, wordRep));	9✔
41	}
42	});	1✔
43	}	1✔
44
45	@Override
46	public ListMultimap<Object, Object> getTopResults(int topScores, int maxLimit) {
UNCOV 47	Comparator<WordGroupWithKey> comparator = Comparator.comparingInt((WordGroupWithKey group) -> group.getWords().size())	×
UNCOV 48	.thenComparing(group -> group.getKey().length())	×
UNCOV 49	.reversed(); // todo: unit test	×
50
UNCOV 51	List<WordGroupWithKey> sortedResult = results.stream()	×
UNCOV 52	.sorted(comparator)	×
UNCOV 53	.toList();	×
54
UNCOV 55	Set<Integer> uniqueValues = new HashSet<>();	×
UNCOV 56	ListMultimap<Object, Object> filteredResults = ArrayListMultimap.create();	×
UNCOV 57	for (WordGroupWithKey wordGroup : sortedResult) {	×
UNCOV 58	int score = wordGroup.getWords().size();	×
UNCOV 59	if (uniqueValues.add(score) && uniqueValues.size() > topScores) {	×
UNCOV 60	break;	×
61	}
UNCOV 62	List<String> wordList = wordGroup.getWords().stream()	×
UNCOV 63	.map(Word::getRaw)	×
UNCOV 64	.toList();	×
UNCOV 65	filteredResults.put(score, wordList);	×
UNCOV 66	if (filteredResults.size() >= maxLimit) {	×
UNCOV 67	break;	×
68	}
UNCOV 69	}	×
70
UNCOV 71	return filteredResults;	×
72	}
73	}

ljacqu / wordeval / 14540577447

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous