9e29adcd-8fa5-4a20-b4ec-b83dae9467cd

Committed 18 Apr 2025 09:43AM UTC coverage: 46.945%. Remained the same

Build # 9e29adcd-8fa5-4a20-b4ec-b83dae9467cd

Build Type

push

circleci

Committed by

mpasternak

Commit Message

Looking for failing test on GA

Run Details

17332 of 36920 relevant lines covered (46.94%)

1.2 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.0

src/crossref_bpp/forms.py

import logging

from django import forms
from django.core.exceptions import ValidationError
from sentry_sdk import capture_exception

from crossref_bpp.models import CrossrefAPICache
from import_common.normalization import normalize_doi


class PobierzZCrossrefAPIForm(forms.Form):
    identyfikator_doi = forms.CharField(
        label="Identyfikator DOI",
        help_text="... może być również adres URL http://dx.doi.org/... lub http://doi.org/...",
        required=True,
        widget=forms.TextInput(attrs={"style": "width: 512px"}),
    )

    def clean_identyfikator_doi(self):
        v = self.cleaned_data["identyfikator_doi"]
        return normalize_doi(v)

    def clean(self):
        doi = self.cleaned_data.get("identyfikator_doi")
        if doi is None:
            raise ValidationError("Podaj identyfikator DOI")
        try:
            data = CrossrefAPICache.objects.get_by_doi(doi)
        except Exception as e:
            capture_exception(e)
            logging.exception(e)
            raise ValidationError(f"Podczas pobierania danych wystąpił błąd {e}")

        if data is None:
            raise ValidationError(
                f'Dla podanego DOI "{doi}" nie znaleziono nic po stronie CrossRef API'
            )

        self.cleaned_data["json_data"] = data

1	import logging	3✔
2
3	from django import forms	3✔
4	from django.core.exceptions import ValidationError	3✔
5	from sentry_sdk import capture_exception	3✔
6
7	from crossref_bpp.models import CrossrefAPICache	3✔
8	from import_common.normalization import normalize_doi	3✔
9
10
11	class PobierzZCrossrefAPIForm(forms.Form):	3✔
12	identyfikator_doi = forms.CharField(	3✔
13	label="Identyfikator DOI",
14	help_text="... może być również adres URL http://dx.doi.org/... lub http://doi.org/...",
15	required=True,
16	widget=forms.TextInput(attrs={"style": "width: 512px"}),
17	)
18
19	def clean_identyfikator_doi(self):	3✔
20	v = self.cleaned_data["identyfikator_doi"]	1✔
21	return normalize_doi(v)	1✔
22
23	def clean(self):	3✔
24	doi = self.cleaned_data.get("identyfikator_doi")	1✔
25	if doi is None:	1✔
26	raise ValidationError("Podaj identyfikator DOI")	×
27	try:	1✔
28	data = CrossrefAPICache.objects.get_by_doi(doi)	1✔
29	except Exception as e:	×
30	capture_exception(e)	×
31	logging.exception(e)	×
32	raise ValidationError(f"Podczas pobierania danych wystąpił błąd {e}")	×
33
34	if data is None:	1✔
35	raise ValidationError(	×
36	f'Dla podanego DOI "{doi}" nie znaleziono nic po stronie CrossRef API'
37	)
38
39	self.cleaned_data["json_data"] = data	1✔

iplweb / bpp / 9e29adcd-8fa5-4a20-b4ec-b83dae9467cd

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous