• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

gcivil-nyu-org / team4-wed-spring25 / 486

16 Apr 2025 08:22PM UTC coverage: 95.171% (-2.6%) from 97.744%
486

push

travis-pro

web-flow
Merge pull request #256 from gcivil-nyu-org/marvin_dev

Marvin dev

121 of 154 new or added lines in 5 files covered. (78.57%)

1 existing line in 1 file now uncovered.

1084 of 1139 relevant lines covered (95.17%)

0.95 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.94
/parks/views.py
1
from django.shortcuts import render
1✔
2
from django.shortcuts import get_object_or_404
1✔
3
from django.shortcuts import redirect
1✔
4
from django.http import (  # noqa: F401  # Ignore "imported but unused"
1✔
5
    HttpResponseForbidden,
6
    HttpResponse,
7
    JsonResponse,
8
    HttpResponsePermanentRedirect,
9
)
10
from django.urls import reverse  # noqa: F401  # Ignore "imported but unused"
1✔
11
from django.db.models import OuterRef, Subquery, CharField, Q, Avg, Count, Prefetch
1✔
12
from django.db.models.functions import Cast
1✔
13
from .models import (
1✔
14
    DogRunNew,
15
    Review,
16
    ParkImage,
17
    ReviewReport,
18
    ImageReport,
19
    ParkPresence,
20
)
21
from django.forms.models import model_to_dict
1✔
22
from django.contrib.auth import login
1✔
23
from django.contrib.auth.decorators import login_required
1✔
24
from .forms import RegisterForm
1✔
25

26
import json
1✔
27
import datetime
1✔
28
from django.contrib import messages
1✔
29
from django.utils import timezone
1✔
30
from django.utils.timezone import now, localtime
1✔
31
from django.views.decorators.http import require_POST
1✔
32
from django.views.decorators.cache import never_cache
1✔
33
from datetime import timedelta
1✔
34

35

36
@login_required
1✔
37
@require_POST
1✔
38
def checkin_view(request):
1✔
NEW
39
    data = json.loads(request.body)
×
NEW
40
    park_id = data.get("park_id")
×
NEW
41
    park = get_object_or_404(DogRunNew, id=park_id)
×
42

43
    # Remove existing 'current' check-ins from other parks
NEW
44
    ParkPresence.objects.filter(user=request.user, status="current").exclude(
×
45
        park=park
46
    ).delete()
47

48
    # Check in to this park
NEW
49
    presence, created = ParkPresence.objects.update_or_create(
×
50
        user=request.user,
51
        park=park,
52
        defaults={"status": "current", "time": timezone.now()},
53
    )
54

NEW
55
    return JsonResponse({"status": "checked in", "new": created})
×
56

57

58
@login_required
1✔
59
@require_POST
1✔
60
def bethere_view(request):
1✔
NEW
61
    try:
×
NEW
62
        data = json.loads(request.body)
×
NEW
63
        park_id = data.get("park_id")
×
NEW
64
        time_str = data.get("time")  # e.g. "17:30"
×
65

NEW
66
        if not park_id or not time_str:
×
NEW
67
            return JsonResponse({"error": "Missing park_id or time"}, status=400)
×
68

69
        # Parse and validate time
NEW
70
        try:
×
NEW
71
            arrival_time = datetime.datetime.strptime(time_str, "%H:%M").time()
×
NEW
72
        except ValueError:
×
NEW
73
            return JsonResponse({"error": "Invalid time format"}, status=400)
×
74

NEW
75
        current_datetime = now()
×
NEW
76
        today = current_datetime.date()
×
NEW
77
        arrival_datetime = timezone.make_aware(
×
78
            datetime.datetime.combine(today, arrival_time)
79
        )
80

NEW
81
        if arrival_datetime < current_datetime:
×
NEW
82
            return JsonResponse({"error": "Cannot select a past time"}, status=400)
×
83

NEW
84
        park = get_object_or_404(DogRunNew, id=park_id)
×
85

86
        # ✅ Save the full datetime, not just the time
NEW
87
        presence, created = ParkPresence.objects.update_or_create(
×
88
            user=request.user,
89
            park=park,
90
            defaults={"status": "On their way", "time": arrival_datetime},
91
        )
92

NEW
93
        formatted_time = arrival_datetime.strftime("%I:%M %p")
×
NEW
94
        return JsonResponse({"status": "on their way", "time": formatted_time})
×
95

96
    except Exception as e:
97
        import traceback
98

99
        print(traceback.format_exc())
100
        return JsonResponse({"error": str(e)}, status=500)
101

102

103
def expire_old_checkins():
1✔
104
    expiration_time = timezone.now() - timedelta(hours=1)
1✔
105
    ParkPresence.objects.filter(status="current", time__lt=expiration_time).delete()
1✔
106

107

108
def register_view(request):
1✔
109
    if request.method == "POST":
1✔
110
        form = RegisterForm(request.POST)
1✔
111
        if form.is_valid():
1✔
112
            # Save but don't commit yet
113
            user = form.save(commit=False)
1✔
114
            # If they chose Admin, mark them as staff
115
            if form.cleaned_data["role"] == "admin":
1✔
116
                user.is_staff = True
1✔
117
            user.save()
1✔
118

119
            # Log the user in immediately
120
            login(request, user)
1✔
121
            request.session.save()
1✔
122
            return redirect("home")
1✔
123
    else:
124
        form = RegisterForm()
1✔
125

126
    return render(request, "parks/register.html", {"form": form})
1✔
127

128

129
def home_view(request):
1✔
130
    return render(request, "parks/home.html")
×
131

132

133
@never_cache
1✔
134
def park_and_map(request):
1✔
135
    # Get filter values from GET request
136
    query = request.GET.get("query", "").strip()
1✔
137
    filter_value = request.GET.get("filter", "").strip()
1✔
138
    accessible_value = request.GET.get("accessible", "").strip()
1✔
139
    borough_value = request.GET.get("borough", "").strip().upper()
1✔
140

141
    thumbnail = ParkImage.objects.filter(
1✔
142
        park_id=OuterRef("pk"), is_removed=False, review__is_removed=False
143
    ).values("image")[:1]
144

145
    # Fetch all dog runs from the database
146
    parks = (
1✔
147
        DogRunNew.objects.all()
148
        .order_by("id")
149
        .prefetch_related("images")
150
        .annotate(
151
            thumbnail_url=Cast(Subquery(thumbnail), output_field=CharField()),
152
            average_rating=Avg("reviews__rating", filter=Q(reviews__is_removed=False)),
153
            review_count=Count("reviews", filter=Q(reviews__is_removed=False)),
154
        )
155
    )
156

157
    # Search by ZIP, name, or Google name
158
    if query:
1✔
159
        parks = parks.filter(
×
160
            Q(name__icontains=query)
161
            | Q(google_name__icontains=query)
162
            | Q(zip_code__icontains=query)
163
        )
164

165
    # Filter by park type (e.g., "Off-Leash")
166
    if filter_value:
1✔
167
        parks = parks.filter(dogruns_type__iexact=filter_value)
×
168

169
    # Filter by accessibility only if explicitly set to "True" or "False"
170
    if accessible_value == "True":
1✔
171
        parks = parks.filter(accessible=True)
×
172
    elif accessible_value == "False":
1✔
173
        parks = parks.filter(accessible=False)
×
174

175
    if borough_value:
1✔
176
        parks = parks.filter(borough=borough_value)
1✔
177

178
    # Convert parks to JSON (for JS use)
179
    # parks_json = json.dumps(list(parks.values()))
180

181
    parks_json = json.dumps(
1✔
182
        [
183
            {
184
                **model_to_dict(park),
185
                "thumbnail_url": park.thumbnail_url,
186
                "average_rating": park.average_rating,
187
                "review_count": park.review_count,
188
                "url": park.detail_page_url(),
189
            }
190
            for park in parks
191
        ]
192
    )
193

194
    # Render the template
195
    return render(
1✔
196
        request,
197
        "parks/combined_view.html",
198
        {
199
            "parks": parks,
200
            "parks_json": parks_json,
201
            "query": query,
202
            "selected_type": filter_value,
203
            "selected_accessible": accessible_value,
204
            "selected_borough": borough_value,
205
        },
206
    )
207

208

209
@never_cache
1✔
210
def park_detail(request, slug, id):
1✔
211
    park = get_object_or_404(DogRunNew, id=id)
1✔
212

213
    # Check slug, if incorrect, redirect to correct one
214
    if slug != park.slug:
1✔
215
        return HttpResponsePermanentRedirect(park.detail_page_url())
1✔
216

217
    images = ParkImage.objects.filter(
1✔
218
        park=park, is_removed=False, review__is_removed=False
219
    )
220

221
    # Prefetch only non-removed images for each review
222
    visible_images = Prefetch(
1✔
223
        "images",
224
        queryset=ParkImage.objects.filter(is_removed=False),
225
        to_attr="visible_images",
226
    )
227
    reviews = park.reviews.filter(is_removed=False).prefetch_related(visible_images)
1✔
228

229
    average_rating = reviews.aggregate(Avg("rating"))["rating__avg"]
1✔
230

231
    # Clean up expired "On their way" entries
232
    now = localtime()
1✔
233
    # Call the function to expire old check-ins
234
    expire_old_checkins()
1✔
235

236
    ParkPresence.objects.filter(park=park, status="On their way", time__lt=now).delete()
1✔
237

238
    # Updated counts after cleanup
239
    current_count = ParkPresence.objects.filter(park=park, status="current").count()
1✔
240
    on_the_way_count = ParkPresence.objects.filter(
1✔
241
        park=park, status="On their way", time__isnull=False, time__gte=now
242
    ).count()
243

244
    if request.user.is_authenticated and request.method == "POST":
1✔
245
        form_type = request.POST.get("form_type")
1✔
246

247
        if form_type == "submit_review":
1✔
248
            review_text = request.POST.get("text", "").strip()
1✔
249
            rating_value = request.POST.get("rating", "").strip()
1✔
250

251
            if not rating_value.isdigit():
1✔
252
                messages.error(request, "Please select a rating before submitting.")
×
253
                return redirect(park.detail_page_url())
×
254

255
            rating = int(rating_value)
1✔
256
            if rating < 1 or rating > 5:
1✔
257
                return render(
×
258
                    request,
259
                    "parks/park_detail.html",
260
                    {
261
                        "park": park,
262
                        "images": images,
263
                        "reviews": reviews,
264
                        "error_message": "Rating must be between 1 and 5 stars!",
265
                        "average_rating": average_rating,
266
                        "current_count": current_count,
267
                        "on_the_way_count": on_the_way_count,
268
                    },
269
                )
270

271
            review = Review.objects.create(
1✔
272
                park=park,
273
                text=review_text if review_text else "",
274
                rating=rating,
275
                user=request.user,
276
            )
277
            images = request.FILES.getlist("images")
1✔
278
            ALLOWED_IMAGE_TYPES = ["image/jpeg", "image/png", "image/webp"]
1✔
279

280
            invalid_type = any(
1✔
281
                img.content_type not in ALLOWED_IMAGE_TYPES for img in images
282
            )
283

284
            if invalid_type:
1✔
NEW
285
                messages.error(request, "Only JPEG, PNG, or WebP images are allowed.")
×
NEW
286
                review.delete()
×
NEW
287
                return redirect("park_detail", slug=park.slug, id=park.id)
×
288

289
            MAX_IMAGE_SIZE = 5 * 1024 * 1024  # 5 MB
1✔
290

291
            invalid_images = [img for img in images if img.size > MAX_IMAGE_SIZE]
1✔
292

293
            if invalid_images:
1✔
NEW
294
                messages.error(request, "Each image must be under 5 MB.")
×
NEW
295
                review.delete()
×
NEW
296
                return redirect("park_detail", slug=park.slug, id=park.id)
×
297

298
            # Save valid images
299
            for image in images:
1✔
300
                ParkImage.objects.create(
1✔
301
                    park=park, image=image, review=review, user=request.user
302
                )
303

304
            messages.success(request, "Your review was submitted successfully!")
1✔
305

306
        elif form_type == "check_in":
1✔
307
            ParkPresence.objects.create(
1✔
308
                user=request.user,
309
                park=park,
310
                status="current",
311
                time=now,
312
            )
313

314
        elif form_type == "be_there_at":
1✔
315
            time_str = request.POST.get("time")
1✔
316
            try:
1✔
317
                arrival_time = timezone.datetime.combine(
1✔
318
                    now.date(), timezone.datetime.strptime(time_str, "%H:%M").time()
319
                )
320
                arrival_time = timezone.make_aware(
1✔
321
                    arrival_time
322
                )  # Make it timezone aware
NEW
323
            except (ValueError, TypeError):
×
NEW
324
                arrival_time = None
×
325

326
            if arrival_time and arrival_time >= now:
1✔
327
                ParkPresence.objects.create(
1✔
328
                    user=request.user,
329
                    park=park,
330
                    status="on_the_way",
331
                    time=arrival_time,
332
                )
333
        # report reviews
334
        elif form_type == "report_review":
1✔
335
            if request.user.is_authenticated:
1✔
336
                review_id = request.POST.get("review_id")
1✔
337
                reason = request.POST.get("reason", "").strip()
1✔
338
                if review_id and reason:
1✔
339
                    review = get_object_or_404(Review, id=review_id)
1✔
340

341
                    # prevent duplicate reports by the same user
342
                    exists = ReviewReport.objects.filter(
1✔
343
                        review=review, reported_by=request.user
344
                    ).exists()
345
                    if exists:
1✔
346
                        messages.error(
1✔
347
                            request, "You have already reported this review before."
348
                        )
349
                    else:
350
                        ReviewReport.objects.create(
1✔
351
                            review=review, reported_by=request.user, reason=reason
352
                        )
353
                        messages.success(
1✔
354
                            request, "Your review report was submitted successfully."
355
                        )
356
        return redirect(park.detail_page_url())
1✔
357
    park_json = json.dumps(model_to_dict(park))
1✔
358

359
    return render(
1✔
360
        request,
361
        "parks/park_detail.html",
362
        {
363
            "park": park,
364
            "images": images,
365
            "reviews": reviews,
366
            "park_json": park_json,
367
            "average_rating": average_rating,
368
            "current_count": current_count,
369
            "on_the_way_count": on_the_way_count,
370
        },
371
    )
372

373

374
@login_required
1✔
375
def delete_review(request, review_id):
1✔
376
    review = get_object_or_404(Review, id=review_id)
1✔
377
    if request.user == review.user:
1✔
378
        review.delete()
1✔
379
        messages.success(request, "You have successfully deleted the review!")
1✔
380
        return redirect(review.park.detail_page_url())
1✔
381
    else:
382
        return HttpResponseForbidden("You are not allowed to delete this review.")
×
383

384

385
@login_required
1✔
386
def delete_image(request, image_id):
1✔
387
    image = get_object_or_404(ParkImage, id=image_id)
1✔
388
    if image.user == request.user:
1✔
389
        image.delete()
1✔
390
        messages.success(request, "You have successfully deleted the image!")
1✔
391
        return redirect(image.park.detail_page_url())
1✔
392
    return HttpResponseForbidden("You are not allowed to delete this image.")
×
393

394

395
def contact_view(request):
1✔
UNCOV
396
    return render(request, "parks/contact.html")
×
397

398

399
@login_required
1✔
400
def report_image(request, image_id):
1✔
401
    image = get_object_or_404(ParkImage, id=image_id)
1✔
402

403
    if request.method == "POST":
1✔
404
        reason = request.POST.get("reason", "").strip()
1✔
405
        if reason:
1✔
406
            # Check if this user already reported this image
407
            already_reported = ImageReport.objects.filter(
1✔
408
                user=request.user, image=image
409
            ).exists()
410
            if already_reported:
1✔
411
                messages.error(request, "You have already reported this image before.")
1✔
412
            else:
413
                ImageReport.objects.create(
1✔
414
                    user=request.user, image=image, reason=reason
415
                )
416
                messages.success(request, "You have successfully reported the image!")
1✔
417
        return redirect(image.park.detail_page_url())
1✔
418

419
    return redirect(image.park.detail_page_url())
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc