#357

Committed 16 Apr 2025 04:19PM UTC coverage: 86.147%. First build

Build # #357

Build Type

Pull #233

github

Committed by

Pfeil

Commit Message

fix: replace get() with path() for safer JSON node access in CustomPreview

Pull Request Pull Request #233: Version 2.1.0

Run Details

532 of 690 new or added lines in 19 files covered. (77.1%)

1878 of 2180 relevant lines covered (86.15%)

0.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/src/main/java/edu/kit/datamanager/ro_crate/writer/FolderWriter.java

package edu.kit.datamanager.ro_crate.writer;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;

import edu.kit.datamanager.ro_crate.Crate;
import edu.kit.datamanager.ro_crate.entities.data.DataEntity;
import edu.kit.datamanager.ro_crate.objectmapper.MyObjectMapper;

import java.io.ByteArrayInputStream;
import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.nio.charset.StandardCharsets;
import org.apache.commons.io.FileUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
 * A class for writing a crate to a folder.
 *
 * @author Nikola Tzotchev on 9.2.2022 г.
 * @version 1
 */
public class FolderWriter implements WriterStrategy {

    private static Logger logger = LoggerFactory.getLogger(FolderWriter.class);

    @Override
    public void save(Crate crate, String destination) {
        File file = new File(destination);
        try {
            FileUtils.forceMkdir(file);
            ObjectMapper objectMapper = MyObjectMapper.getMapper();
            JsonNode node = objectMapper.readTree(crate.getJsonMetadata());
            String str = objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(node);
            InputStream inputStream = new ByteArrayInputStream(str.getBytes(StandardCharsets.UTF_8));

            File json = new File(destination, "ro-crate-metadata.json");
            FileUtils.copyInputStreamToFile(inputStream, json);
            inputStream.close();            
            // save also the preview files to the crate destination
            if (crate.getPreview() != null) {
                crate.getPreview().saveAllToFolder(file);
            }
            for (var e : crate.getUntrackedFiles()) {
                if (e.isDirectory()) {
                    FileUtils.copyDirectoryToDirectory(e, file);
                } else {
                    FileUtils.copyFileToDirectory(e, file);
                }
            }
        } catch (IOException e) {
            logger.error("Error creating destination directory!", e);
        }
        for (DataEntity dataEntity : crate.getAllDataEntities()) {
            try {
                dataEntity.savetoFile(file);
            } catch (IOException e) {
                logger.error("Cannot save " + dataEntity.getId() + " to destination folder!", e);
            }
        }
    }
}

1	package edu.kit.datamanager.ro_crate.writer;
2
3	import com.fasterxml.jackson.databind.JsonNode;
4	import com.fasterxml.jackson.databind.ObjectMapper;
5
6	import edu.kit.datamanager.ro_crate.Crate;
7	import edu.kit.datamanager.ro_crate.entities.data.DataEntity;
8	import edu.kit.datamanager.ro_crate.objectmapper.MyObjectMapper;
9
10	import java.io.ByteArrayInputStream;
11	import java.io.File;
12	import java.io.IOException;
13	import java.io.InputStream;
14	import java.nio.charset.StandardCharsets;
15	import org.apache.commons.io.FileUtils;
16	import org.slf4j.Logger;
17	import org.slf4j.LoggerFactory;
18
19	/**
20	* A class for writing a crate to a folder.
21	*
22	* @author Nikola Tzotchev on 9.2.2022 г.
23	* @version 1
24	*/
25	public class FolderWriter implements WriterStrategy {	1✔
26
27	private static Logger logger = LoggerFactory.getLogger(FolderWriter.class);	1✔
28
29	@Override
30	public void save(Crate crate, String destination) {
31	File file = new File(destination);	1✔
32	try {
33	FileUtils.forceMkdir(file);	1✔
34	ObjectMapper objectMapper = MyObjectMapper.getMapper();	1✔
35	JsonNode node = objectMapper.readTree(crate.getJsonMetadata());	1✔
36	String str = objectMapper.writerWithDefaultPrettyPrinter().writeValueAsString(node);	1✔
37	InputStream inputStream = new ByteArrayInputStream(str.getBytes(StandardCharsets.UTF_8));	1✔
38
39	File json = new File(destination, "ro-crate-metadata.json");	1✔
40	FileUtils.copyInputStreamToFile(inputStream, json);	1✔
41	inputStream.close();	1✔
42	// save also the preview files to the crate destination
43	if (crate.getPreview() != null) {	1✔
44	crate.getPreview().saveAllToFolder(file);	1✔
45	}
46	for (var e : crate.getUntrackedFiles()) {	1✔
47	if (e.isDirectory()) {	1✔
48	FileUtils.copyDirectoryToDirectory(e, file);	1✔
49	} else {
50	FileUtils.copyFileToDirectory(e, file);	1✔
51	}
52	}	1✔
NEW 53	} catch (IOException e) {	×
NEW 54	logger.error("Error creating destination directory!", e);	×
55	}	1✔
56	for (DataEntity dataEntity : crate.getAllDataEntities()) {	1✔
57	try {
58	dataEntity.savetoFile(file);	1✔
NEW 59	} catch (IOException e) {	×
NEW 60	logger.error("Cannot save " + dataEntity.getId() + " to destination folder!", e);	×
61	}	1✔
62	}	1✔
63	}	1✔
64	}

kit-data-manager / ro-crate-java / #357

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous