#357

Committed 16 Apr 2025 04:19PM UTC coverage: 86.147%. First build

Build # #357

Build Type

Pull #233

github

Committed by

Pfeil

Commit Message

fix: replace get() with path() for safer JSON node access in CustomPreview

Pull Request Pull Request #233: Version 2.1.0

Run Details

532 of 690 new or added lines in 19 files covered. (77.1%)

1878 of 2180 relevant lines covered (86.15%)

0.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

7.69

/src/main/java/edu/kit/datamanager/ro_crate/reader/StreamReaderStrategy.java

package edu.kit.datamanager.ro_crate.reader;

import com.fasterxml.jackson.databind.node.ObjectNode;
import edu.kit.datamanager.ro_crate.writer.StreamWriterStrategy;
import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.InputStream;
import org.slf4j.LoggerFactory;

/**
 * Interface for reading RO-Crate metadata and content from input streams.
 *
 * @author jejkal
 */
public interface StreamReaderStrategy extends ReaderStrategy {

    org.slf4j.Logger logger = LoggerFactory.getLogger(StreamReaderStrategy.class);

    /**
     * Default override of readMetadataJson interface from ReaderStrategy. The
     * override assumes, that location is a file, which is used as input stream.
     * If this assumption is not true, this call will fail.
     *
     * @param location The source, which is supposed to be a file.
     *
     * @return the RO-Crate metadata as ObjectNode
     */
    @Override
    default ObjectNode readMetadataJson(String location) {
        ObjectNode result = null;
        try {
            result = readMetadataJson(new FileInputStream(new File(location)));
        } catch (FileNotFoundException ex) {
            logger.error("Failed read crate from source " + location, ex);
        }
        return result;
    }

    /**
     * Default override of readContent interface from ReaderStrategy. The
     * override assumes, that location is a file, which is used as input stream.
     * If this assumption is not true, this call will fail.
     *
     * @param location The source, which is supposed to be a file.
     *
     * @return the RO-Crate content as file, i.e., a folder
     */
    @Override
    default File readContent(String location) {
        File result = null;
        try {
            result = readContent(new FileInputStream(new File(location)));
        } catch (FileNotFoundException ex) {
            logger.error("Failed read crate from source " + location, ex);
        }
        return result;
    }

    ObjectNode readMetadataJson(InputStream source);

    File readContent(InputStream source);

}

1	package edu.kit.datamanager.ro_crate.reader;
2
3	import com.fasterxml.jackson.databind.node.ObjectNode;
4	import edu.kit.datamanager.ro_crate.writer.StreamWriterStrategy;
5	import java.io.File;
6	import java.io.FileInputStream;
7	import java.io.FileNotFoundException;
8	import java.io.InputStream;
9	import org.slf4j.LoggerFactory;
10
11	/**
12	* Interface for reading RO-Crate metadata and content from input streams.
13	*
14	* @author jejkal
15	*/
16	public interface StreamReaderStrategy extends ReaderStrategy {
17
18	org.slf4j.Logger logger = LoggerFactory.getLogger(StreamReaderStrategy.class);	1✔
19
20	/**
21	* Default override of readMetadataJson interface from ReaderStrategy. The
22	* override assumes, that location is a file, which is used as input stream.
23	* If this assumption is not true, this call will fail.
24	*
25	* @param location The source, which is supposed to be a file.
26	*
27	* @return the RO-Crate metadata as ObjectNode
28	*/
29	@Override
30	default ObjectNode readMetadataJson(String location) {
NEW 31	ObjectNode result = null;	×
32	try {
NEW 33	result = readMetadataJson(new FileInputStream(new File(location)));	×
NEW 34	} catch (FileNotFoundException ex) {	×
NEW 35	logger.error("Failed read crate from source " + location, ex);	×
NEW 36	}	×
NEW 37	return result;	×
38	}
39
40	/**
41	* Default override of readContent interface from ReaderStrategy. The
42	* override assumes, that location is a file, which is used as input stream.
43	* If this assumption is not true, this call will fail.
44	*
45	* @param location The source, which is supposed to be a file.
46	*
47	* @return the RO-Crate content as file, i.e., a folder
48	*/
49	@Override
50	default File readContent(String location) {
NEW 51	File result = null;	×
52	try {
NEW 53	result = readContent(new FileInputStream(new File(location)));	×
NEW 54	} catch (FileNotFoundException ex) {	×
NEW 55	logger.error("Failed read crate from source " + location, ex);	×
NEW 56	}	×
NEW 57	return result;	×
58	}
59
60	ObjectNode readMetadataJson(InputStream source);
61
62	File readContent(InputStream source);
63
64	}

kit-data-manager / ro-crate-java / #357

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous