gcivil-nyu-org / team4-wed-spring25 / 466

Committed 16 Apr 2025 06:11AM UTC coverage: 94.475% (-0.07%) from 94.547%

Build # 466

Build Type

push

travis-pro

Committed by

mr2447

Commit Message

fixed bugs

Run Details

5 of 7 new or added lines in 1 file covered. (71.43%)

1 existing line in 1 file now uncovered.

872 of 923 relevant lines covered (94.47%)

0.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

75.42

/parks/views.py

from django.shortcuts import render
from django.shortcuts import get_object_or_404
from django.shortcuts import redirect
from django.http import (  # noqa: F401  # Ignore "imported but unused"
    HttpResponseForbidden,
    HttpResponse,
    JsonResponse,
)
from django.db.models import OuterRef, Subquery, CharField, Q, Avg, Count
from django.db.models.functions import Cast
from .models import (
    DogRunNew,
    Review,
    ParkImage,
    ReviewReport,
    ImageReport,
    ParkPresence,
)
from django.forms.models import model_to_dict
from django.contrib.auth import login
from django.contrib.auth.decorators import login_required
from .forms import RegisterForm

import json
import datetime
from django.contrib import messages
from django.utils import timezone
from django.utils.timezone import now, localtime
from django.views.decorators.http import require_POST
from django.views.decorators.cache import never_cache
from datetime import timedelta


@login_required
@require_POST
def checkin_view(request):
    data = json.loads(request.body)
    park_id = data.get("park_id")
    park = get_object_or_404(DogRunNew, id=park_id)

    # Remove existing 'current' check-ins from other parks
    ParkPresence.objects.filter(user=request.user, status="current").exclude(
        park=park
    ).delete()

    # Check in to this park
    presence, created = ParkPresence.objects.update_or_create(
        user=request.user,
        park=park,
        defaults={"status": "current", "time": timezone.now()},
    )

    return JsonResponse({"status": "checked in", "new": created})


@login_required
@require_POST
def bethere_view(request):
    try:
        data = json.loads(request.body)
        park_id = data.get("park_id")
        time_str = data.get("time")  # e.g. "17:30"

        if not park_id or not time_str:
            return JsonResponse({"error": "Missing park_id or time"}, status=400)

        # Parse and validate time
        try:
            arrival_time = datetime.datetime.strptime(time_str, "%H:%M").time()
        except ValueError:
            return JsonResponse({"error": "Invalid time format"}, status=400)

        current_datetime = now()
        today = current_datetime.date()
        arrival_datetime = timezone.make_aware(
            datetime.datetime.combine(today, arrival_time)
        )

        if arrival_datetime < current_datetime:
            return JsonResponse({"error": "Cannot select a past time"}, status=400)

        park = get_object_or_404(DogRunNew, id=park_id)

        # ✅ Save the full datetime, not just the time
        presence, created = ParkPresence.objects.update_or_create(
            user=request.user,
            park=park,
            defaults={"status": "On their way", "time": arrival_datetime},
        )

        formatted_time = arrival_datetime.strftime("%I:%M %p")
        return JsonResponse({"status": "on their way", "time": formatted_time})

    except Exception as e:
        import traceback

        print(traceback.format_exc())
        return JsonResponse({"error": str(e)}, status=500)


def expire_old_checkins():
    expiration_time = timezone.now() - timedelta(hours=1)
    ParkPresence.objects.filter(status="current", time__lt=expiration_time).delete()


def register_view(request):
    if request.method == "POST":
        form = RegisterForm(request.POST)
        if form.is_valid():
            # Save but don't commit yet
            user = form.save(commit=False)
            # If they chose Admin, mark them as staff
            if form.cleaned_data["role"] == "admin":
                user.is_staff = True
            user.save()

            # Log the user in immediately
            login(request, user)
            request.session.save()
            return redirect("home")
    else:
        form = RegisterForm()

    return render(request, "parks/register.html", {"form": form})


def home_view(request):
    return render(request, "parks/home.html")


@never_cache
def park_and_map(request):
    # Get filter values from GET request
    query = request.GET.get("query", "").strip()
    filter_value = request.GET.get("filter", "").strip()
    accessible_value = request.GET.get("accessible", "").strip()
    borough_value = request.GET.get("borough", "").strip().upper()

    thumbnail = ParkImage.objects.filter(park_id=OuterRef("pk")).values("image")[:1]

    # Fetch all dog runs from the database
    parks = (
        DogRunNew.objects.all()
        .order_by("id")
        .prefetch_related("images")
        .annotate(
            thumbnail_url=Cast(Subquery(thumbnail), output_field=CharField()),
            average_rating=Avg("reviews__rating"),
            review_count=Count("reviews"),
        )
    )

    # Search by ZIP, name, or Google name
    if query:
        parks = parks.filter(
            Q(name__icontains=query)
            | Q(google_name__icontains=query)
            | Q(zip_code__icontains=query)
        )

    # Filter by park type (e.g., "Off-Leash")
    if filter_value:
        parks = parks.filter(dogruns_type__iexact=filter_value)

    # Filter by accessibility only if explicitly set to "True" or "False"
    if accessible_value == "True":
        parks = parks.filter(accessible=True)
    elif accessible_value == "False":
        parks = parks.filter(accessible=False)

    if borough_value:
        parks = parks.filter(borough=borough_value)

    # Convert parks to JSON (for JS use)
    parks_json = json.dumps(list(parks.values()))

    # Render the template
    return render(
        request,
        "parks/combined_view.html",
        {
            "parks": parks,
            "parks_json": parks_json,
            "query": query,
            "selected_type": filter_value,
            "selected_accessible": accessible_value,
            "selected_borough": borough_value,
        },
    )


@never_cache
def park_detail(request, slug, id):
    park = get_object_or_404(DogRunNew, id=id)
    images = ParkImage.objects.filter(park=park)
    reviews = park.reviews.all()
    average_rating = reviews.aggregate(Avg("rating"))["rating__avg"]

    # Clean up expired "On their way" entries
    now = localtime()
    # Call the function to expire old check-ins
    expire_old_checkins()

    ParkPresence.objects.filter(park=park, status="On their way", time__lt=now).delete()

    # Updated counts after cleanup
    current_count = ParkPresence.objects.filter(park=park, status="current").count()
    on_the_way_count = ParkPresence.objects.filter(
        park=park, status="On their way", time__isnull=False, time__gte=now
    ).count()

    if request.user.is_authenticated and request.method == "POST":
        form_type = request.POST.get("form_type")

        if form_type == "submit_review":
            review_text = request.POST.get("text", "").strip()
            rating_value = request.POST.get("rating", "").strip()

            if not rating_value.isdigit():
                messages.error(request, "Please select a rating before submitting.")
                return redirect("park_detail", slug=park.slug, id=park.id)

            rating = int(rating_value)
            if rating < 1 or rating > 5:
                return render(
                    request,
                    "parks/park_detail.html",
                    {
                        "park": park,
                        "images": images,
                        "reviews": reviews,
                        "error_message": "Rating must be between 1 and 5 stars!",
                        "average_rating": average_rating,
                        "current_count": current_count,
                        "on_the_way_count": on_the_way_count,
                    },
                )

            review = Review.objects.create(
                park=park,
                text=review_text if review_text else "",
                rating=rating,
                user=request.user,
            )
            images = request.FILES.getlist("images")
            ALLOWED_IMAGE_TYPES = ["image/jpeg", "image/png", "image/webp"]

            invalid_type = any(
                img.content_type not in ALLOWED_IMAGE_TYPES for img in images
            )

            if invalid_type:
                messages.error(request, "Only JPEG, PNG, or WebP images are allowed.")
                review.delete()
                return redirect("park_detail", slug=park.slug, id=park.id)

            MAX_IMAGE_SIZE = 5 * 1024 * 1024  # 5 MB

            invalid_images = [img for img in images if img.size > MAX_IMAGE_SIZE]

            if invalid_images:
                messages.error(request, "Each image must be under 5 MB.")
                review.delete()
                return redirect("park_detail", slug=park.slug, id=park.id)

            # Save valid images
            for image in images:
                ParkImage.objects.create(
                    park=park, image=image, review=review, user=request.user
                )

            messages.success(request, "Your review was submitted successfully!")
            return redirect("park_detail", slug=park.slug, id=park.id)

        elif form_type == "check_in":
            ParkPresence.objects.create(
                user=request.user,
                park=park,
                status="current",
                time=now,
            )

        elif form_type == "be_there_at":
            time_str = request.POST.get("time")
            try:
                arrival_time = timezone.datetime.combine(
                    now.date(), timezone.datetime.strptime(time_str, "%H:%M").time()
                )
                arrival_time = timezone.make_aware(
                    arrival_time
                )  # Make it timezone aware
            except (ValueError, TypeError):
                arrival_time = None

            if arrival_time and arrival_time >= now:
                ParkPresence.objects.create(
                    user=request.user,
                    park=park,
                    status="on_the_way",
                    time=arrival_time,
                )

        elif form_type == "report_review":
            if request.user.is_authenticated:
                review_id = request.POST.get("review_id")
                reason = request.POST.get("reason", "").strip()
                if review_id and reason:
                    review = get_object_or_404(Review, id=review_id)
                    ReviewReport.objects.create(
                        review=review, reported_by=request.user, reason=reason
                    )
                    messages.success(
                        request, "Your review report was submitted successfully."
                    )
                    return redirect("park_detail", slug=park.slug, id=park.id)

    park_json = json.dumps(model_to_dict(park))

    return render(
        request,
        "parks/park_detail.html",
        {
            "park": park,
            "images": images,
            "reviews": reviews,
            "park_json": park_json,
            "average_rating": average_rating,
            "current_count": current_count,
            "on_the_way_count": on_the_way_count,
        },
    )


@login_required
def delete_review(request, review_id):
    review = get_object_or_404(Review, id=review_id)
    if request.user == review.user:
        review.delete()
        messages.success(request, "You have successfully deleted the review!")
        return redirect("park_detail", slug=review.park.slug, id=review.park.id)
    else:
        return HttpResponseForbidden("You are not allowed to delete this review.")


@login_required
def delete_image(request, image_id):
    image = get_object_or_404(ParkImage, id=image_id)
    if image.user == request.user:
        park_id = image.park.id
        image.delete()
        messages.success(request, "You have successfully deleted the image!")
        return redirect("park_detail", slug=image.park.slug, id=park_id)
    return HttpResponseForbidden("You are not allowed to delete this image.")


def contact_view(request):
    return render(request, "parks/contact.html")


@login_required
def report_image(request, image_id):
    image = get_object_or_404(ParkImage, id=image_id)
    if request.method == "POST":
        reason = request.POST.get("reason", "").strip()
        if reason:
            ImageReport.objects.create(user=request.user, image=image, reason=reason)
            messages.success(request, "You have successfully reported the image!")
            return redirect("park_detail", slug=image.park.slug, id=image.park.id)
    return redirect("park_detail", slug=image.park.slug, id=image.park.id)

1	from django.shortcuts import render	1✔
2	from django.shortcuts import get_object_or_404	1✔
3	from django.shortcuts import redirect	1✔
4	from django.http import ( # noqa: F401 # Ignore "imported but unused"	1✔
5	HttpResponseForbidden,
6	HttpResponse,
7	JsonResponse,
8	)
9	from django.db.models import OuterRef, Subquery, CharField, Q, Avg, Count	1✔
10	from django.db.models.functions import Cast	1✔
11	from .models import (	1✔
12	DogRunNew,
13	Review,
14	ParkImage,
15	ReviewReport,
16	ImageReport,
17	ParkPresence,
18	)
19	from django.forms.models import model_to_dict	1✔
20	from django.contrib.auth import login	1✔
21	from django.contrib.auth.decorators import login_required	1✔
22	from .forms import RegisterForm	1✔
23
24	import json	1✔
25	import datetime	1✔
26	from django.contrib import messages	1✔
27	from django.utils import timezone	1✔
28	from django.utils.timezone import now, localtime	1✔
29	from django.views.decorators.http import require_POST	1✔
30	from django.views.decorators.cache import never_cache	1✔
31	from datetime import timedelta	1✔
32
33
34	@login_required	1✔
35	@require_POST	1✔
36	def checkin_view(request):	1✔
37	data = json.loads(request.body)	×
38	park_id = data.get("park_id")	×
39	park = get_object_or_404(DogRunNew, id=park_id)	×
40
41	# Remove existing 'current' check-ins from other parks
NEW 42	ParkPresence.objects.filter(user=request.user, status="current").exclude(	×
43	park=park
44	).delete()
45
46	# Check in to this park
UNCOV 47	presence, created = ParkPresence.objects.update_or_create(	×
48	user=request.user,
49	park=park,
50	defaults={"status": "current", "time": timezone.now()},
51	)
52
NEW 53	return JsonResponse({"status": "checked in", "new": created})	×
54
55
56	@login_required	1✔
57	@require_POST	1✔
58	def bethere_view(request):	1✔
59	try:	×
60	data = json.loads(request.body)	×
61	park_id = data.get("park_id")	×
62	time_str = data.get("time") # e.g. "17:30"	×
63
64	if not park_id or not time_str:	×
65	return JsonResponse({"error": "Missing park_id or time"}, status=400)	×
66
67	# Parse and validate time
68	try:	×
69	arrival_time = datetime.datetime.strptime(time_str, "%H:%M").time()	×
70	except ValueError:	×
71	return JsonResponse({"error": "Invalid time format"}, status=400)	×
72
73	current_datetime = now()	×
74	today = current_datetime.date()	×
75	arrival_datetime = timezone.make_aware(	×
76	datetime.datetime.combine(today, arrival_time)
77	)
78
79	if arrival_datetime < current_datetime:	×
80	return JsonResponse({"error": "Cannot select a past time"}, status=400)	×
81
82	park = get_object_or_404(DogRunNew, id=park_id)	×
83
84	# ✅ Save the full datetime, not just the time
85	presence, created = ParkPresence.objects.update_or_create(	×
86	user=request.user,
87	park=park,
88	defaults={"status": "On their way", "time": arrival_datetime},
89	)
90
91	formatted_time = arrival_datetime.strftime("%I:%M %p")	×
92	return JsonResponse({"status": "on their way", "time": formatted_time})	×
93
94	except Exception as e:
95	import traceback
96
97	print(traceback.format_exc())
98	return JsonResponse({"error": str(e)}, status=500)
99
100
101	def expire_old_checkins():	1✔
102	expiration_time = timezone.now() - timedelta(hours=1)	1✔
103	ParkPresence.objects.filter(status="current", time__lt=expiration_time).delete()	1✔
104
105
106	def register_view(request):	1✔
107	if request.method == "POST":	1✔
108	form = RegisterForm(request.POST)	1✔
109	if form.is_valid():	1✔
110	# Save but don't commit yet
111	user = form.save(commit=False)	1✔
112	# If they chose Admin, mark them as staff
113	if form.cleaned_data["role"] == "admin":	1✔
114	user.is_staff = True	1✔
115	user.save()	1✔
116
117	# Log the user in immediately
118	login(request, user)	1✔
119	request.session.save()	1✔
120	return redirect("home")	1✔
121	else:
122	form = RegisterForm()	1✔
123
124	return render(request, "parks/register.html", {"form": form})	1✔
125
126
127	def home_view(request):	1✔
128	return render(request, "parks/home.html")	×
129
130
131	@never_cache	1✔
132	def park_and_map(request):	1✔
133	# Get filter values from GET request
134	query = request.GET.get("query", "").strip()	1✔
135	filter_value = request.GET.get("filter", "").strip()	1✔
136	accessible_value = request.GET.get("accessible", "").strip()	1✔
137	borough_value = request.GET.get("borough", "").strip().upper()	1✔
138
139	thumbnail = ParkImage.objects.filter(park_id=OuterRef("pk")).values("image")[:1]	1✔
140
141	# Fetch all dog runs from the database
142	parks = (	1✔
143	DogRunNew.objects.all()
144	.order_by("id")
145	.prefetch_related("images")
146	.annotate(
147	thumbnail_url=Cast(Subquery(thumbnail), output_field=CharField()),
148	average_rating=Avg("reviews__rating"),
149	review_count=Count("reviews"),
150	)
151	)
152
153	# Search by ZIP, name, or Google name
154	if query:	1✔
155	parks = parks.filter(	×
156	Q(name__icontains=query)
157	\| Q(google_name__icontains=query)
158	\| Q(zip_code__icontains=query)
159	)
160
161	# Filter by park type (e.g., "Off-Leash")
162	if filter_value:	1✔
163	parks = parks.filter(dogruns_type__iexact=filter_value)	×
164
165	# Filter by accessibility only if explicitly set to "True" or "False"
166	if accessible_value == "True":	1✔
167	parks = parks.filter(accessible=True)	×
168	elif accessible_value == "False":	1✔
169	parks = parks.filter(accessible=False)	×
170
171	if borough_value:	1✔
172	parks = parks.filter(borough=borough_value)	1✔
173
174	# Convert parks to JSON (for JS use)
175	parks_json = json.dumps(list(parks.values()))	1✔
176
177	# Render the template
178	return render(	1✔
179	request,
180	"parks/combined_view.html",
181	{
182	"parks": parks,
183	"parks_json": parks_json,
184	"query": query,
185	"selected_type": filter_value,
186	"selected_accessible": accessible_value,
187	"selected_borough": borough_value,
188	},
189	)
190
191
192	@never_cache	1✔
193	def park_detail(request, slug, id):	1✔
194	park = get_object_or_404(DogRunNew, id=id)	1✔
195	images = ParkImage.objects.filter(park=park)	1✔
196	reviews = park.reviews.all()	1✔
197	average_rating = reviews.aggregate(Avg("rating"))["rating__avg"]	1✔
198
199	# Clean up expired "On their way" entries
200	now = localtime()	1✔
201	# Call the function to expire old check-ins
202	expire_old_checkins()	1✔
203
204	ParkPresence.objects.filter(park=park, status="On their way", time__lt=now).delete()	1✔
205
206	# Updated counts after cleanup
207	current_count = ParkPresence.objects.filter(park=park, status="current").count()	1✔
208	on_the_way_count = ParkPresence.objects.filter(	1✔
209	park=park, status="On their way", time__isnull=False, time__gte=now
210	).count()
211
212	if request.user.is_authenticated and request.method == "POST":	1✔
213	form_type = request.POST.get("form_type")	1✔
214
215	if form_type == "submit_review":	1✔
216	review_text = request.POST.get("text", "").strip()	1✔
217	rating_value = request.POST.get("rating", "").strip()	1✔
218
219	if not rating_value.isdigit():	1✔
220	messages.error(request, "Please select a rating before submitting.")	×
221	return redirect("park_detail", slug=park.slug, id=park.id)	×
222
223	rating = int(rating_value)	1✔
224	if rating < 1 or rating > 5:	1✔
225	return render(	×
226	request,
227	"parks/park_detail.html",
228	{
229	"park": park,
230	"images": images,
231	"reviews": reviews,
232	"error_message": "Rating must be between 1 and 5 stars!",
233	"average_rating": average_rating,
234	"current_count": current_count,
235	"on_the_way_count": on_the_way_count,
236	},
237	)
238
239	review = Review.objects.create(	1✔
240	park=park,
241	text=review_text if review_text else "",
242	rating=rating,
243	user=request.user,
244	)
245	images = request.FILES.getlist("images")	1✔
246	ALLOWED_IMAGE_TYPES = ["image/jpeg", "image/png", "image/webp"]	1✔
247
248	invalid_type = any(	1✔
249	img.content_type not in ALLOWED_IMAGE_TYPES for img in images
250	)
251
252	if invalid_type:	1✔
253	messages.error(request, "Only JPEG, PNG, or WebP images are allowed.")	×
254	review.delete()	×
255	return redirect("park_detail", slug=park.slug, id=park.id)	×
256
257	MAX_IMAGE_SIZE = 5 * 1024 * 1024 # 5 MB	1✔
258
259	invalid_images = [img for img in images if img.size > MAX_IMAGE_SIZE]	1✔
260
261	if invalid_images:	1✔
262	messages.error(request, "Each image must be under 5 MB.")	×
263	review.delete()	×
264	return redirect("park_detail", slug=park.slug, id=park.id)	×
265
266	# Save valid images
267	for image in images:	1✔
268	ParkImage.objects.create(	1✔
269	park=park, image=image, review=review, user=request.user
270	)
271
272	messages.success(request, "Your review was submitted successfully!")	1✔
273	return redirect("park_detail", slug=park.slug, id=park.id)	1✔
274
275	elif form_type == "check_in":	1✔
276	ParkPresence.objects.create(	1✔
277	user=request.user,
278	park=park,
279	status="current",
280	time=now,
281	)
282
283	elif form_type == "be_there_at":	1✔
284	time_str = request.POST.get("time")	1✔
285	try:	1✔
286	arrival_time = timezone.datetime.combine(	1✔
287	now.date(), timezone.datetime.strptime(time_str, "%H:%M").time()
288	)
289	arrival_time = timezone.make_aware(	1✔
290	arrival_time
291	) # Make it timezone aware
292	except (ValueError, TypeError):	×
293	arrival_time = None	×
294
295	if arrival_time and arrival_time >= now:	1✔
296	ParkPresence.objects.create(	1✔
297	user=request.user,
298	park=park,
299	status="on_the_way",
300	time=arrival_time,
301	)
302
303	elif form_type == "report_review":	1✔
304	if request.user.is_authenticated:	1✔
305	review_id = request.POST.get("review_id")	1✔
306	reason = request.POST.get("reason", "").strip()	1✔
307	if review_id and reason:	1✔
308	review = get_object_or_404(Review, id=review_id)	1✔
309	ReviewReport.objects.create(	1✔
310	review=review, reported_by=request.user, reason=reason
311	)
312	messages.success(	1✔
313	request, "Your review report was submitted successfully."
314	)
315	return redirect("park_detail", slug=park.slug, id=park.id)	1✔
316
317	park_json = json.dumps(model_to_dict(park))	1✔
318
319	return render(	1✔
320	request,
321	"parks/park_detail.html",
322	{
323	"park": park,
324	"images": images,
325	"reviews": reviews,
326	"park_json": park_json,
327	"average_rating": average_rating,
328	"current_count": current_count,
329	"on_the_way_count": on_the_way_count,
330	},
331	)
332
333
334	@login_required	1✔
335	def delete_review(request, review_id):	1✔
336	review = get_object_or_404(Review, id=review_id)	1✔
337	if request.user == review.user:	1✔
338	review.delete()	1✔
339	messages.success(request, "You have successfully deleted the review!")	1✔
340	return redirect("park_detail", slug=review.park.slug, id=review.park.id)	1✔
341	else:
342	return HttpResponseForbidden("You are not allowed to delete this review.")	×
343
344
345	@login_required	1✔
346	def delete_image(request, image_id):	1✔
347	image = get_object_or_404(ParkImage, id=image_id)	1✔
348	if image.user == request.user:	1✔
349	park_id = image.park.id	1✔
350	image.delete()	1✔
351	messages.success(request, "You have successfully deleted the image!")	1✔
352	return redirect("park_detail", slug=image.park.slug, id=park_id)	1✔
353	return HttpResponseForbidden("You are not allowed to delete this image.")	×
354
355
356	def contact_view(request):	1✔
357	return render(request, "parks/contact.html")	×
358
359
360	@login_required	1✔
361	def report_image(request, image_id):	1✔
362	image = get_object_or_404(ParkImage, id=image_id)	1✔
363	if request.method == "POST":	1✔
364	reason = request.POST.get("reason", "").strip()	1✔
365	if reason:	1✔
366	ImageReport.objects.create(user=request.user, image=image, reason=reason)	1✔
367	messages.success(request, "You have successfully reported the image!")	1✔
368	return redirect("park_detail", slug=image.park.slug, id=image.park.id)	1✔
369	return redirect("park_detail", slug=image.park.slug, id=image.park.id)	1✔

gcivil-nyu-org / team4-wed-spring25 / 466

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous