14471580514

Committed 11 Jul 2024 02:47PM UTC coverage: 57.068% (-20.2%) from 77.316%

Build # 14471580514

Build Type

push

github

Committed by

web-flow

Commit Message

fix: properly remove activities in workflow remove if catalog is corrupt (#3729)

Run Details

0 of 1 new or added line in 1 file covered. (0.0%)

6141 existing lines in 213 files now uncovered.

17395 of 30481 relevant lines covered (57.07%)

1.77 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

69.86

/renku/command/command_builder/database.py

# Copyright Swiss Data Science Center (SDSC). A partnership between
# École Polytechnique Fédérale de Lausanne (EPFL) and
# Eidgenössische Technische Hochschule Zürich (ETHZ).
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
"""Command builder for local object database."""


import json
import os
from typing import Optional

from packaging.version import Version

from renku.command.command_builder.command import Command, CommandResult, check_finalized
from renku.core import errors
from renku.core.interface.activity_gateway import IActivityGateway
from renku.core.interface.database_gateway import IDatabaseGateway
from renku.core.interface.dataset_gateway import IDatasetGateway
from renku.core.interface.plan_gateway import IPlanGateway
from renku.core.interface.project_gateway import IProjectGateway
from renku.core.interface.storage import IStorageFactory
from renku.domain_model.project_context import project_context
from renku.infrastructure.gateway.activity_gateway import ActivityGateway
from renku.infrastructure.gateway.database_gateway import DatabaseGateway
from renku.infrastructure.gateway.dataset_gateway import DatasetGateway
from renku.infrastructure.gateway.plan_gateway import PlanGateway
from renku.infrastructure.gateway.project_gateway import ProjectGateway
from renku.infrastructure.storage.factory import StorageFactory


class DatabaseCommand(Command):
    """Builder to get a database connection."""

    PRE_ORDER = 4
    POST_ORDER = 5

    def __init__(self, builder: Command, write: bool = False, path: Optional[str] = None, create: bool = False) -> None:
        self._builder = builder
        self._write = write
        self._path = path
        self._create = create
        self.project_found: bool = False

    def _injection_pre_hook(self, builder: Command, context: dict, *args, **kwargs) -> None:
        """Create a Database singleton."""
        from renku.version import __version__

        if not project_context.has_context():
            raise ValueError("Database builder needs a ProjectContext to be set.")

        project_context.push_path(path=self._path or project_context.path, save_changes=self._write)

        project_gateway = ProjectGateway()

        context["constructor_bindings"][IPlanGateway] = lambda: PlanGateway()
        context["constructor_bindings"][IActivityGateway] = lambda: ActivityGateway()
        context["constructor_bindings"][IDatabaseGateway] = lambda: DatabaseGateway()
        context["constructor_bindings"][IDatasetGateway] = lambda: DatasetGateway()
        context["constructor_bindings"][IProjectGateway] = lambda: project_gateway
        context["constructor_bindings"][IStorageFactory] = lambda: StorageFactory

        if int(os.environ.get("RENKU_SKIP_MIN_VERSION_CHECK", "0")) == 1:
            # NOTE: Used for unit tests
            return

        try:
            project = project_gateway.get_project()
            minimum_renku_version = Version(project.minimum_renku_version)
            self.project_found = True
        except (KeyError, ImportError, ValueError):
            try:
                with open(project_context.database_path / "project") as f:
                    project = json.load(f)
                    min_version = project.get("minimum_renku_version")
                    if min_version is None:
                        return
                    minimum_renku_version = Version(min_version)
            except (KeyError, OSError, json.JSONDecodeError):
                # NOTE: We don't check minimum version if there's no project metadata available
                return

        current_version = Version(__version__)

        if Version(current_version.base_version) < minimum_renku_version:
            raise errors.MinimumVersionError(current_version, minimum_renku_version)

    def _post_hook(self, builder: Command, context: dict, result: CommandResult, *args, **kwargs) -> None:
        from renku.domain_model.project import Project

        if self._write and self.project_found:
            # NOTE: Fetch project again in case it was updated (the current reference would be put of date)
            project_gateway = ProjectGateway()
            project = project_gateway.get_project()

            if Version(project.minimum_renku_version) < Version(Project.minimum_renku_version):
                # NOTE: update minimum renku version on write as migrations might happen on the fly
                project.minimum_renku_version = Project.minimum_renku_version

        project_context.pop_context()

    @check_finalized
    def build(self) -> Command:
        """Build the command."""
        self._builder.add_injection_pre_hook(self.PRE_ORDER, self._injection_pre_hook)
        self._builder.add_post_hook(self.POST_ORDER, self._post_hook)

        return self._builder.build()

1	# Copyright Swiss Data Science Center (SDSC). A partnership between
2	# École Polytechnique Fédérale de Lausanne (EPFL) and
3	# Eidgenössische Technische Hochschule Zürich (ETHZ).
4	#
5	# Licensed under the Apache License, Version 2.0 (the "License");
6	# you may not use this file except in compliance with the License.
7	# You may obtain a copy of the License at
8	#
9	# http://www.apache.org/licenses/LICENSE-2.0
10	#
11	# Unless required by applicable law or agreed to in writing, software
12	# distributed under the License is distributed on an "AS IS" BASIS,
13	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14	# See the License for the specific language governing permissions and
15	# limitations under the License.
16	"""Command builder for local object database."""	4✔
17
18
19	import json	4✔
20	import os	4✔
21	from typing import Optional	4✔
22
23	from packaging.version import Version	4✔
24
25	from renku.command.command_builder.command import Command, CommandResult, check_finalized	4✔
26	from renku.core import errors	4✔
27	from renku.core.interface.activity_gateway import IActivityGateway	4✔
28	from renku.core.interface.database_gateway import IDatabaseGateway	4✔
29	from renku.core.interface.dataset_gateway import IDatasetGateway	4✔
30	from renku.core.interface.plan_gateway import IPlanGateway	4✔
31	from renku.core.interface.project_gateway import IProjectGateway	4✔
32	from renku.core.interface.storage import IStorageFactory	4✔
33	from renku.domain_model.project_context import project_context	4✔
34	from renku.infrastructure.gateway.activity_gateway import ActivityGateway	4✔
35	from renku.infrastructure.gateway.database_gateway import DatabaseGateway	4✔
36	from renku.infrastructure.gateway.dataset_gateway import DatasetGateway	4✔
37	from renku.infrastructure.gateway.plan_gateway import PlanGateway	4✔
38	from renku.infrastructure.gateway.project_gateway import ProjectGateway	4✔
39	from renku.infrastructure.storage.factory import StorageFactory	4✔
40
41
42	class DatabaseCommand(Command):	4✔
43	"""Builder to get a database connection."""
44
45	PRE_ORDER = 4	4✔
46	POST_ORDER = 5	4✔
47
48	def __init__(self, builder: Command, write: bool = False, path: Optional[str] = None, create: bool = False) -> None:	4✔
49	self._builder = builder	4✔
50	self._write = write	4✔
51	self._path = path	4✔
52	self._create = create	4✔
53	self.project_found: bool = False	4✔
54
55	def _injection_pre_hook(self, builder: Command, context: dict, args, *kwargs) -> None:	4✔
56	"""Create a Database singleton."""
57	from renku.version import __version__	4✔
58
59	if not project_context.has_context():	4✔
60	raise ValueError("Database builder needs a ProjectContext to be set.")	×
61
62	project_context.push_path(path=self._path or project_context.path, save_changes=self._write)	4✔
63
64	project_gateway = ProjectGateway()	4✔
65
66	context["constructor_bindings"][IPlanGateway] = lambda: PlanGateway()	4✔
67	context["constructor_bindings"][IActivityGateway] = lambda: ActivityGateway()	4✔
68	context["constructor_bindings"][IDatabaseGateway] = lambda: DatabaseGateway()	4✔
69	context["constructor_bindings"][IDatasetGateway] = lambda: DatasetGateway()	4✔
70	context["constructor_bindings"][IProjectGateway] = lambda: project_gateway	4✔
71	context["constructor_bindings"][IStorageFactory] = lambda: StorageFactory	4✔
72
73	if int(os.environ.get("RENKU_SKIP_MIN_VERSION_CHECK", "0")) == 1:	4✔
74	# NOTE: Used for unit tests
75	return	4✔
76
UNCOV 77	try:	×
UNCOV 78	project = project_gateway.get_project()	×
UNCOV 79	minimum_renku_version = Version(project.minimum_renku_version)	×
UNCOV 80	self.project_found = True	×
81	except (KeyError, ImportError, ValueError):	×
82	try:	×
83	with open(project_context.database_path / "project") as f:	×
84	project = json.load(f)	×
85	min_version = project.get("minimum_renku_version")	×
86	if min_version is None:	×
87	return	×
88	minimum_renku_version = Version(min_version)	×
89	except (KeyError, OSError, json.JSONDecodeError):	×
90	# NOTE: We don't check minimum version if there's no project metadata available
91	return	×
92
UNCOV 93	current_version = Version(__version__)	×
94
UNCOV 95	if Version(current_version.base_version) < minimum_renku_version:	×
UNCOV 96	raise errors.MinimumVersionError(current_version, minimum_renku_version)	×
97
98	def _post_hook(self, builder: Command, context: dict, result: CommandResult, args, *kwargs) -> None:	4✔
99	from renku.domain_model.project import Project	4✔
100
101	if self._write and self.project_found:	4✔
102	# NOTE: Fetch project again in case it was updated (the current reference would be put of date)
UNCOV 103	project_gateway = ProjectGateway()	×
UNCOV 104	project = project_gateway.get_project()	×
105
UNCOV 106	if Version(project.minimum_renku_version) < Version(Project.minimum_renku_version):	×
107	# NOTE: update minimum renku version on write as migrations might happen on the fly
UNCOV 108	project.minimum_renku_version = Project.minimum_renku_version	×
109
110	project_context.pop_context()	4✔
111
112	@check_finalized	4✔
113	def build(self) -> Command:	4✔
114	"""Build the command."""
115	self._builder.add_injection_pre_hook(self.PRE_ORDER, self._injection_pre_hook)	4✔
116	self._builder.add_post_hook(self.POST_ORDER, self._post_hook)	4✔
117
118	return self._builder.build()	4✔

SwissDataScienceCenter / renku-python / 14471580514

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous