• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3844

10 Apr 2025 08:48AM UTC coverage: 43.852% (-19.2%) from 63.077%
#3844

push

travis-ci

web-flow
fix: the REPLICA parameter supports plural forms when used to create and alter a database (#30732)

104394 of 310659 branches covered (33.6%)

Branch coverage included in aggregate %.

167442 of 309240 relevant lines covered (54.15%)

3866624.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.24
/source/dnode/mnode/sdb/src/sdbHash.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17
#include "sdb.h"
18

19
static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);
20

21
const char *sdbTableName(ESdbType type) {
15,824✔
22
  switch (type) {
15,824!
23
    case SDB_TRANS:
5,406✔
24
      return "trans";
5,406✔
25
    case SDB_CLUSTER:
512✔
26
      return "cluster";
512✔
27
    case SDB_MNODE:
542✔
28
      return "mnode";
542✔
29
    case SDB_QNODE:
94✔
30
      return "qnode";
94✔
31
    case SDB_SNODE:
94✔
32
      return "snode";
94✔
33
    case SDB_DNODE:
1,334✔
34
      return "dnode";
1,334✔
35
    case SDB_USER:
926✔
36
      return "user";
926✔
37
    case SDB_AUTH:
×
38
      return "auth";
×
39
    case SDB_ACCT:
330✔
40
      return "acct";
330✔
41
    case SDB_STREAM_CK:
×
42
      return "stream_ck";
×
43
    case SDB_STREAM:
144✔
44
      return "stream";
144✔
45
    case SDB_OFFSET:
×
46
      return "offset";
×
47
    case SDB_SUBSCRIBE:
80✔
48
      return "subscribe";
80✔
49
    case SDB_CONSUMER:
170✔
50
      return "consumer";
170✔
51
    case SDB_TOPIC:
80✔
52
      return "topic";
80✔
53
    case SDB_VGROUP:
1,658✔
54
      return "vgroup";
1,658✔
55
    case SDB_SMA:
80✔
56
      return "sma";
80✔
57
    case SDB_STB:
786✔
58
      return "stb";
786✔
59
    case SDB_DB:
1,060✔
60
      return "db";
1,060✔
61
    case SDB_FUNC:
254✔
62
      return "func";
254✔
63
    case SDB_IDX:
366✔
64
      return "idx";
366✔
65
    case SDB_VIEW:
80✔
66
      return "view";
80✔
67
    case SDB_STREAM_SEQ:
80✔
68
      return "stream_seq";
80✔
69
    case SDB_COMPACT:
80✔
70
      return "compact";
80✔
71
    case SDB_COMPACT_DETAIL:
80✔
72
      return "compact_detail";
80✔
73
    case SDB_GRANT:
258✔
74
      return "grant";
258✔
75
    case SDB_ARBGROUP:
80✔
76
      return "arb_group";
80✔
77
    case SDB_ANODE:
80✔
78
      return "anode";
80✔
79
    case SDB_CFG:
1,166✔
80
      return "config";
1,166✔
81
    default:
4✔
82
      return "undefine";
4✔
83
  }
84
}
85

86
const char *sdbStatusName(ESdbStatus status) {
9,358✔
87
  switch (status) {
9,358!
88
    case SDB_STATUS_CREATING:
224✔
89
      return "creating";
224✔
90
    case SDB_STATUS_DROPPING:
92✔
91
      return "dropping";
92✔
92
    case SDB_STATUS_READY:
6,758✔
93
      return "ready";
6,758✔
94
    case SDB_STATUS_DROPPED:
1,614✔
95
      return "dropped";
1,614✔
96
    case SDB_STATUS_INIT:
668✔
97
      return "init";
668✔
98
    case SDB_STATUS_UPDATE:
×
99
      return "update";
×
100
    default:
2✔
101
      return "undefine";
2✔
102
  }
103
}
104

105
void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
27,978✔
106
#if 1
107
  EKeyType keyType = pSdb->keyTypes[pRow->type];
27,978✔
108

109
  if (keyType == SDB_KEY_BINARY) {
27,978✔
110
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
8,014✔
111
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
112
  } else if (keyType == SDB_KEY_INT32) {
19,964✔
113
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
18,770✔
114
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
115
  } else if (keyType == SDB_KEY_INT64) {
1,194!
116
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
1,198✔
117
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
118
  } else {
119
  }
120
#endif
121
}
27,978✔
122

123
static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
23,142✔
124
  if (type >= SDB_MAX || type < 0) {
23,142!
125
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
2✔
126
    return NULL;
2✔
127
  }
128

129
  SHashObj *hash = pSdb->hashObjs[type];
23,140✔
130
  if (hash == NULL) {
23,140✔
131
    terrno = TSDB_CODE_APP_ERROR;
8✔
132
    return NULL;
8✔
133
  }
134

135
  return hash;
23,132✔
136
}
137

138
static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
8,942✔
139
  int32_t  keySize = 0;
8,942✔
140
  EKeyType keyType = pSdb->keyTypes[type];
8,942✔
141

142
  if (keyType == SDB_KEY_INT32) {
8,942✔
143
    keySize = sizeof(int32_t);
5,722✔
144
  } else if (keyType == SDB_KEY_BINARY) {
3,220✔
145
    keySize = strlen(pKey) + 1;
3,178✔
146
  } else {
147
    keySize = sizeof(int64_t);
42✔
148
  }
149

150
  return keySize;
8,942✔
151
}
152

153
static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
942✔
154
  int32_t type = pRow->type;
942✔
155
  sdbWriteLock(pSdb, type);
942✔
156

157
  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
942✔
158
  if (pOldRow != NULL) {
942!
159
    sdbUnLock(pSdb, type);
×
160
    sdbFreeRow(pSdb, pRow, false);
×
161
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
×
162
    return terrno;
×
163
  }
164

165
  pRow->refCount = 0;
942✔
166
  pRow->status = pRaw->status;
942✔
167
  sdbPrintOper(pSdb, pRow, "insert");
942✔
168

169
  int32_t code = 0;
942✔
170
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
942!
171
    sdbUnLock(pSdb, type);
×
172
    sdbFreeRow(pSdb, pRow, false);
×
173
    return code;
×
174
  }
175

176
  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
942✔
177
  if (insertFp != NULL) {
942!
178
    code = (*insertFp)(pSdb, pRow->pObj);
942✔
179
    if (code != 0) {
942!
180
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
×
181
        mError("failed to remove row from hash");
×
182
      }
183
      sdbFreeRow(pSdb, pRow, false);
×
184
      sdbUnLock(pSdb, type);
×
185
      terrno = code;
×
186
      return terrno;
×
187
    }
188
  }
189

190
  sdbUnLock(pSdb, type);
942✔
191

192
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
942✔
193
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
380✔
194
  }
195
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
942✔
196
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
28✔
197
  }
198
  pSdb->tableVer[pRow->type]++;
942✔
199

200
  return 0;
942✔
201
}
202

203
static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
1,372✔
204
  int32_t type = pNewRow->type;
1,372✔
205
  sdbWriteLock(pSdb, type);
1,372✔
206

207
  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
1,372✔
208
  if (ppOldRow == NULL || *ppOldRow == NULL) {
1,372!
209
    sdbUnLock(pSdb, type);
858✔
210
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
858✔
211
  }
212

213
  SSdbRow *pOldRow = *ppOldRow;
514✔
214
  pOldRow->status = pRaw->status;
514✔
215
  sdbPrintOper(pSdb, pOldRow, "update");
514✔
216

217
  int32_t     code = 0;
514✔
218
  SdbUpdateFp updateFp = pSdb->updateFps[type];
514✔
219
  if (updateFp != NULL) {
514!
220
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
514✔
221
  }
222
  sdbUnLock(pSdb, type);
514✔
223

224
  // sdbUnLock(pSdb, type);
225
  sdbFreeRow(pSdb, pNewRow, false);
514✔
226

227
  pSdb->tableVer[pOldRow->type]++;
514✔
228
  return code;
514✔
229
}
230

231
static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
366✔
232
  int32_t type = pRow->type;
366✔
233
  sdbWriteLock(pSdb, type);
366✔
234

235
  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
366✔
236
  if (ppOldRow == NULL || *ppOldRow == NULL) {
366!
237
    sdbUnLock(pSdb, type);
×
238
    sdbFreeRow(pSdb, pRow, false);
×
239
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
×
240
    return terrno;
×
241
  }
242
  SSdbRow *pOldRow = *ppOldRow;
366✔
243
  pOldRow->status = pRaw->status;
366✔
244

245
  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
366✔
246
  sdbPrintOper(pSdb, pOldRow, "delete");
366✔
247

248
  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
366!
249
    sdbUnLock(pSdb, type);
×
250
    sdbFreeRow(pSdb, pRow, false);
×
251
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
×
252
    return terrno;
×
253
  }
254
  pSdb->tableVer[pOldRow->type]++;
366✔
255
  sdbUnLock(pSdb, type);
366✔
256

257
  sdbFreeRow(pSdb, pRow, false);
366✔
258

259
  sdbCheckRow(pSdb, pOldRow);
366✔
260
  return 0;
366✔
261
}
262

263
int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
1,826✔
264
  if (pRaw->type == SDB_CFG) {
1,826✔
265
    mTrace("sdb write cfg");
376✔
266
  }
267
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
1,826✔
268
  if (hash == NULL) return terrno;
1,826✔
269

270
  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
1,822✔
271
  SSdbRow    *pRow = (*decodeFp)(pRaw);
1,822✔
272
  if (pRow == NULL) return terrno;
1,822!
273

274
  pRow->type = pRaw->type;
1,822✔
275

276
  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
1,822✔
277
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;
1,822✔
278

279
  switch (pRaw->status) {
1,822!
280
    case SDB_STATUS_CREATING:
84✔
281
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
84✔
282
      break;
84✔
283
    case SDB_STATUS_READY:
1,372✔
284
    case SDB_STATUS_UPDATE:
285
    case SDB_STATUS_DROPPING:
286
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
1,372✔
287
      break;
1,372✔
288
    case SDB_STATUS_DROPPED:
366✔
289
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
366✔
290
      break;
366✔
291
  }
292

293
  return code;
1,822✔
294
}
295

296
int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
296✔
297
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
296✔
298
  sdbFreeRaw(pRaw);
296✔
299
  return code;
296✔
300
}
301

302
void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
7,122✔
303
  terrno = 0;
7,122✔
304

305
  SHashObj *hash = sdbGetHash(pSdb, type);
7,122✔
306
  if (hash == NULL) return NULL;
7,122✔
307

308
  void   *pRet = NULL;
7,120✔
309
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);
7,120✔
310

311
  sdbReadLock(pSdb, type);
7,120✔
312

313
  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
7,120✔
314
  if (ppRow == NULL || *ppRow == NULL) {
7,120!
315
    sdbUnLock(pSdb, type);
614✔
316
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
614✔
317
    return NULL;
614✔
318
  }
319

320
  SSdbRow *pRow = *ppRow;
6,506✔
321
  switch (pRow->status) {
6,506!
322
    case SDB_STATUS_READY:
6,492✔
323
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
6,492✔
324
      pRet = pRow->pObj;
6,492✔
325
      sdbPrintOper(pSdb, pRow, "acquire");
6,492✔
326
      break;
6,492✔
327
    case SDB_STATUS_CREATING:
2✔
328
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
2✔
329
      break;
2✔
330
    case SDB_STATUS_DROPPING:
12✔
331
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
12✔
332
      break;
12✔
333
    default:
×
334
      terrno = TSDB_CODE_APP_ERROR;
×
335
      break;
×
336
  }
337

338
  if (pRet == NULL) {
6,506✔
339
    if (!onlyReady) {
14!
340
      terrno = 0;
×
341
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
×
342
      pRet = pRow->pObj;
×
343
      sdbPrintOper(pSdb, pRow, "acquire");
×
344
    }
345
  }
346

347
  sdbUnLock(pSdb, type);
6,506✔
348
  return pRet;
6,506✔
349
}
350

351
void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
7,102✔
352
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
20✔
353
  return sdbAcquireAll(pSdb, type, pKey, false);
20✔
354
}
355

356
static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
366✔
357
  int32_t type = pRow->type;
366✔
358
  sdbWriteLock(pSdb, type);
366✔
359

360
  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
366✔
361
  sdbPrintOper(pSdb, pRow, "check");
366✔
362
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
366!
363
    sdbFreeRow(pSdb, pRow, true);
96✔
364
  }
365

366
  sdbUnLock(pSdb, type);
366✔
367
}
366✔
368

369
void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
12,090✔
370
  if (pObj == NULL) return;
12,090✔
371

372
  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
11,564✔
373
  if (pRow->type >= SDB_MAX) return;
11,564✔
374

375
  int32_t type = pRow->type;
11,562✔
376
  if (lock) {
11,562✔
377
    sdbWriteLock(pSdb, type);
11,542✔
378
  }
379

380
  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
11,562✔
381
  sdbPrintOper(pSdb, pRow, "release");
11,562✔
382
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
11,562✔
383
    sdbFreeRow(pSdb, pRow, true);
270✔
384
  }
385
  if (ref < 0) {
11,562✔
386
    mError("row:%p, ref:%d, type:%s", pRow, ref, sdbTableName(type));
100!
387
  }
388

389
  if (lock) {
11,562✔
390
    sdbUnLock(pSdb, type);
11,542✔
391
  }
392
}
393

394
void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }
12,070✔
395

396
void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
8,438✔
397
  *ppObj = NULL;
8,438✔
398

399
  SHashObj *hash = sdbGetHash(pSdb, type);
8,438✔
400
  if (hash == NULL) return NULL;
8,436✔
401

402
  sdbReadLock(pSdb, type);
8,434✔
403

404
  SSdbRow **ppRow = taosHashIterate(hash, pIter);
8,434✔
405
  while (ppRow != NULL) {
8,442✔
406
    SSdbRow *pRow = *ppRow;
4,532✔
407
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
4,532!
408
      ppRow = taosHashIterate(hash, ppRow);
6✔
409
      continue;
6✔
410
    }
411

412
    (void)atomic_add_fetch_32(&pRow->refCount, 1);
4,526✔
413
    sdbPrintOper(pSdb, pRow, "fetch");
4,526✔
414
    *ppObj = pRow->pObj;
4,526✔
415
    break;
4,526✔
416
  }
417
  sdbUnLock(pSdb, type);
8,436✔
418

419
  return ppRow;
8,436✔
420
}
421

422
void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
906✔
423
  *ppObj = NULL;
906✔
424

425
  SHashObj *hash = sdbGetHash(pSdb, type);
906✔
426
  if (hash == NULL) return NULL;
906!
427

428
  if (lock) {
906✔
429
    sdbReadLock(pSdb, type);
866✔
430
  }
431

432
  SSdbRow **ppRow = taosHashIterate(hash, pIter);
906✔
433
  while (ppRow != NULL) {
906✔
434
    SSdbRow *pRow = *ppRow;
546✔
435
    if (pRow == NULL) {
546!
436
      ppRow = taosHashIterate(hash, ppRow);
×
437
      continue;
×
438
    }
439

440
    (void)atomic_add_fetch_32(&pRow->refCount, 1);
546✔
441
    sdbPrintOper(pSdb, pRow, "fetch");
546✔
442
    *ppObj = pRow->pObj;
546✔
443
    *status = pRow->status;
546✔
444
    break;
546✔
445
  }
446
  if (lock) {
906✔
447
    sdbUnLock(pSdb, type);
866✔
448
  }
449

450
  return ppRow;
906✔
451
}
452

453
void sdbCancelFetch(SSdb *pSdb, void *pIter) {
794✔
454
  if (pIter == NULL) return;
794✔
455
  SSdbRow *pRow = *(SSdbRow **)pIter;
790✔
456
  mTrace("cancel fetch row:%p", pRow);
790✔
457
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
790✔
458
  if (hash == NULL) return;
790!
459

460
  int32_t type = pRow->type;
790✔
461
  sdbReadLock(pSdb, type);
790✔
462
  taosHashCancelIterate(hash, pIter);
790✔
463
  sdbUnLock(pSdb, type);
790✔
464
}
465

466
void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
×
467
  if (pIter == NULL) return;
×
468
  if (type >= SDB_MAX || type < 0) return;
×
469
  SHashObj *hash = sdbGetHash(pSdb, type);
×
470
  if (hash == NULL) return;
×
471

472
  sdbReadLock(pSdb, type);
×
473
  taosHashCancelIterate(hash, pIter);
×
474
  sdbUnLock(pSdb, type);
×
475
}
476

477
void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
124✔
478
  SHashObj *hash = sdbGetHash(pSdb, type);
124✔
479
  if (hash == NULL) return;
124!
480

481
  sdbReadLock(pSdb, type);
124✔
482

483
  SSdbRow **ppRow = taosHashIterate(hash, NULL);
124✔
484
  while (ppRow != NULL) {
212✔
485
    SSdbRow *pRow = *ppRow;
92✔
486
    if (pRow->status == SDB_STATUS_READY) {
92!
487
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
92✔
488
      if (!isContinue) {
92✔
489
        taosHashCancelIterate(hash, ppRow);
4✔
490
        break;
4✔
491
      }
492
    }
493

494
    ppRow = taosHashIterate(hash, ppRow);
88✔
495
  }
496

497
  sdbUnLock(pSdb, type);
124✔
498
}
499

500
int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
3,576✔
501
  SHashObj *hash = sdbGetHash(pSdb, type);
3,576✔
502
  if (hash == NULL) return 0;
3,576!
503

504
  sdbReadLock(pSdb, type);
3,576✔
505
  int32_t size = taosHashGetSize(hash);
3,576✔
506
  sdbUnLock(pSdb, type);
3,576✔
507

508
  return size;
3,576✔
509
}
510

511
int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
364✔
512
  SHashObj *hash = sdbGetHash(pSdb, type);
364✔
513
  if (hash == NULL) return -1;
364✔
514

515
  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;
362✔
516

517
  int32_t maxId = 0;
350✔
518
  sdbReadLock(pSdb, type);
350✔
519

520
  SSdbRow **ppRow = taosHashIterate(hash, NULL);
350✔
521
  while (ppRow != NULL) {
362✔
522
    SSdbRow *pRow = *ppRow;
12✔
523
    int32_t  id = *(int32_t *)pRow->pObj;
12✔
524
    maxId = TMAX(id, maxId);
12✔
525
    ppRow = taosHashIterate(hash, ppRow);
12✔
526
  }
527

528
  sdbUnLock(pSdb, type);
350✔
529
  maxId = TMAX(maxId, pSdb->maxId[type]);
350✔
530
  return maxId + 1;
350✔
531
}
532

533
int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
1,366✔
534
  if (type >= SDB_MAX || type < 0) {
1,366✔
535
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
2✔
536
    return -1;
2✔
537
  }
538

539
  return pSdb->tableVer[type];
1,364✔
540
}
541

542
bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
×
543
  int32_t *pInt = p1;
×
544
  (*pInt) += 1;
×
545
  return true;
×
546
}
547

548
int32_t sdbGetValidSize(SSdb *pSdb, ESdbType type) {
×
549
  int32_t num = 0;
×
550
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
×
551
  return num;
×
552
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc